@tiledesk/tiledesk-tybot-connector 0.2.0 → 0.2.2

package/CHANGELOG.md

@@ -5,7 +5,11 @@
 available on:
  ▶️ https://www.npmjs.com/package/@tiledesk/tiledesk-tybot-connector
 
-### 0.2.00
+### 0.2.1 - online
+- bug fix:  /ext/parameters/requests/:requestid replies with res.send([]);
+- bug fix: allParameterStatic() => check for attributes not null before iterating Object.entries()
+
+### 0.2.0 - online, unused
 - bug fix
 
 ### 0.1.99

package/index.js

@@ -486,43 +486,42 @@ router.get('/message/context/:messageid', async (req, res) => {
 });
 
 router.get('/ext/parameters/requests/:requestid', async (req, res) => {
-  const requestId = req.params.requestid;
-  const parameters = await TiledeskChatbot.allParametersStatic(tdcache, requestId);
-  if (req.query.all != null) {
-    res.send(parameters);
-  }
-  else {
-    const RESERVED = [
-      TiledeskChatbotConst.REQ_CHATBOT_NAME_KEY,
-      TiledeskChatbotConst.REQ_CHAT_URL,
-      TiledeskChatbotConst.REQ_CITY_KEY,
-      TiledeskChatbotConst.REQ_COUNTRY_KEY,
-      TiledeskChatbotConst.REQ_DEPARTMENT_ID_KEY,
-      TiledeskChatbotConst.REQ_DEPARTMENT_NAME_KEY,
-      TiledeskChatbotConst.REQ_END_USER_ID_KEY,
-      TiledeskChatbotConst.REQ_END_USER_IP_ADDRESS_KEY,
-      TiledeskChatbotConst.REQ_LAST_MESSAGE_ID_KEY,
-      TiledeskChatbotConst.REQ_LAST_USER_TEXT_KEY,
-      TiledeskChatbotConst.REQ_PROJECT_ID_KEY,
-      TiledeskChatbotConst.REQ_REQUEST_ID_KEY,
-      TiledeskChatbotConst.REQ_USER_AGENT_KEY,
-      TiledeskChatbotConst.REQ_USER_LANGUAGE_KEY,
-      TiledeskChatbotConst.REQ_USER_SOURCE_PAGE_KEY
-    ]
-    let userParams = {};
-    if (parameters) {
-      for (const [key, value] of Object.entries(parameters)) {
-        // console.log(key, value);
-        // There is a bug that moves the requestId as a key in request attributes, so: && !key.startsWith("support-group-")
-        if (!key.startsWith("_") && !RESERVED.some(e => e === key) && !key.startsWith("support-group-")) {
-          userParams[key] = value;
-        }
-      }
-    }
-    res.send(userParams);
-  }
-  
-  
+  res.send([]);
+  // const requestId = req.params.requestid;
+  // const parameters = await TiledeskChatbot.allParametersStatic(tdcache, requestId);
+  // if (req.query.all != null) {
+  //   res.send(parameters);
+  // }
+  // else {
+  //   const RESERVED = [
+  //     TiledeskChatbotConst.REQ_CHATBOT_NAME_KEY,
+  //     TiledeskChatbotConst.REQ_CHAT_URL,
+  //     TiledeskChatbotConst.REQ_CITY_KEY,
+  //     TiledeskChatbotConst.REQ_COUNTRY_KEY,
+  //     TiledeskChatbotConst.REQ_DEPARTMENT_ID_KEY,
+  //     TiledeskChatbotConst.REQ_DEPARTMENT_NAME_KEY,
+  //     TiledeskChatbotConst.REQ_END_USER_ID_KEY,
+  //     TiledeskChatbotConst.REQ_END_USER_IP_ADDRESS_KEY,
+  //     TiledeskChatbotConst.REQ_LAST_MESSAGE_ID_KEY,
+  //     TiledeskChatbotConst.REQ_LAST_USER_TEXT_KEY,
+  //     TiledeskChatbotConst.REQ_PROJECT_ID_KEY,
+  //     TiledeskChatbotConst.REQ_REQUEST_ID_KEY,
+  //     TiledeskChatbotConst.REQ_USER_AGENT_KEY,
+  //     TiledeskChatbotConst.REQ_USER_LANGUAGE_KEY,
+  //     TiledeskChatbotConst.REQ_USER_SOURCE_PAGE_KEY
+  //   ]
+  //   let userParams = {};
+  //   if (parameters) {
+  //     for (const [key, value] of Object.entries(parameters)) {
+  //       // console.log(key, value);
+  //       // There is a bug that moves the requestId as a key in request attributes, so: && !key.startsWith("support-group-")
+  //       if (!key.startsWith("_") && !RESERVED.some(e => e === key) && !key.startsWith("support-group-")) {
+  //         userParams[key] = value;
+  //       }
+  //     }
+  //   }
+  //   res.send(userParams);
+  // }
 });
 
 router.get('/', (req, res) => {

package/models/TiledeskChatbot.js

@@ -585,12 +585,18 @@ class TiledeskChatbot {
   }
 
   static async allParametersStatic(_tdcache, requestId) {
-    // const parameters_key = "tilebot:requests:" + requestId + ":parameters";
-    const attributes__as_string_map = await _tdcache.hgetall(
-      TiledeskChatbot.requestCacheKey(requestId) + ":parameters");
+    const parameters_key = TiledeskChatbot.requestCacheKey(requestId) + ":parameters";
+    const attributes__as_string_map = await _tdcache.hgetall(parameters_key);
+    console.log("** getting parameters for requestId:", requestId);
+    console.log("** for key:", parameters_key, "parameters:", JSON.stringify(attributes__as_string_map));
     let attributes_native_values = {};
-    for (const [key, value] of Object.entries(attributes__as_string_map)) {
-      attributes_native_values[key] = JSON.parse(value);
+    if (attributes__as_string_map !== null) {
+      for (const [key, value] of Object.entries(attributes__as_string_map)) {
+        attributes_native_values[key] = JSON.parse(value);
+      }
+    }
+    else {
+      console.error("An error occurred. 'attributes__as_string_map' is null!");
     }
     return attributes_native_values;
   }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@tiledesk/tiledesk-tybot-connector",
-  "version": "0.2.00",
+  "version": "0.2.2",
   "description": "Tiledesk Tybot connector",
   "main": "index.js",
   "scripts": {