@tiledesk/tiledesk-server 2.19.14 → 2.19.16

package/CHANGELOG.md

@@ -5,6 +5,13 @@
 🚀        IN PRODUCTION                        🚀
 (https://www.npmjs.com/package/@tiledesk/tiledesk-server/v/2.3.77) 
 
+# 2.19.16
+- Queued /kb/scrape/single via scheduleScrape instead of sync startScrape
+- Improved guest closure event handling in activity monitoring
+
+# 2.19.15
+- Fixed bug on updating cells in a table row
+
 # 2.19.14
 - Improved Activities management
 

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@tiledesk/tiledesk-server",
   "description": "The Tiledesk server module",
-  "version": "2.19.14",
+  "version": "2.19.16",
   "scripts": {
     "start": "node ./bin/www",
     "pretest": "mongodb-runner start",

package/pubmodules/activities/models/activity.js

@@ -103,6 +103,49 @@ function userIdFromEntity(entity) {
   return null;
 }
 
+// Human agents assigned to a request target (e.g. REQUEST_CLOSE when a guest closes).
+// Without this, involvedUserIds would only contain closed_by / actor and miss the assignee,
+// so ?agent_id= filters would not return the activity for the assigned operator.
+function agentIdsFromRequestTarget(target) {
+  if (!target || !target.object) {
+    return [];
+  }
+  var ids = [];
+  var seen = {};
+  function addId(raw) {
+    if (raw == null) {
+      return;
+    }
+    var id = String(raw);
+    if (!id || id.indexOf('bot_') === 0 || seen[id]) {
+      return;
+    }
+    seen[id] = true;
+    ids.push(id);
+  }
+
+  var participantsAgents = target.object.participantsAgents;
+  if (Array.isArray(participantsAgents)) {
+    for (var i = 0; i < participantsAgents.length; i++) {
+      addId(participantsAgents[i]);
+    }
+  }
+
+  // Fallback when only the populated virtual is present on the serialized request
+  var participatingAgents = target.object.participatingAgents;
+  if (Array.isArray(participatingAgents)) {
+    for (var j = 0; j < participatingAgents.length; j++) {
+      var agent = participatingAgents[j];
+      if (!agent) {
+        continue;
+      }
+      addId(agent._id || agent.id || agent);
+    }
+  }
+
+  return ids;
+}
+
 function computeInvolvedUserIds(doc) {
   var ids = new Set();
   if (doc.actor && doc.actor.type === 'user' && doc.actor.id) {
@@ -116,6 +159,9 @@ function computeInvolvedUserIds(doc) {
   if (relatedUserId) {
     ids.add(relatedUserId);
   }
+  agentIdsFromRequestTarget(doc.target).forEach(function (id) {
+    ids.add(id);
+  });
   return Array.from(ids);
 }
 
@@ -147,7 +193,8 @@ var ActivitySchema = new Schema({
     type: RelatedActivitySchema,
     required: false
   },
-  // Denormalized list of user ids involved in the activity (actor, target user, related user).
+  // Denormalized list of user ids involved in the activity
+  // (actor, target user, related user, and request participantsAgents when target is a request).
   // Auto-filled by the pre-save hook below. Indexed for efficient "activities of a user" queries.
   involvedUserIds: {
     type: [String],

package/pubmodules/activities/routes/activity.js

@@ -86,7 +86,7 @@ router.get('/', async (req, res) => {
   }
 
   if (req.query.agent_id) {
-    // involvedUserIds covers actor, target user and related user for new records.
+    // involvedUserIds covers actor, target user, related user and request participantsAgents.
     // The other two clauses keep backward compatibility with legacy records.
     query["$or"] = [
       { "involvedUserIds": req.query.agent_id },

package/routes/kb.js

@@ -270,18 +270,14 @@ router.post('/scrape/single', async (req, res) => {
       winston.verbose("/scrape/single json: ", json);
 
       json.id_project = project_id;
+      json.webhook = apiUrl + '/webhook/kb/status?token=' + KB_WEBHOOK_TOKEN;
 
       if (process.env.NODE_ENV === "test") {
-        res.status(200).send({ success: true, message: "Skip indexing in test environment", data: json })
+        return res.status(200).send({ success: true, message: "Skip indexing in test environment", data: json })
       }
 
-      aiManager.startScrape(json).then((response) => {
-        winston.verbose("startScrape response: ", response);
-        res.status(200).send(response);
-      }).catch((err) => {
-        winston.error("startScrape err: ", err);
-        res.status(500).send({ success: false, error: err });
-      })
+      aiManager.scheduleScrape([json], namespace.hybrid);
+      return res.status(200).send({ success: true, message: "Content queued for reindexing" });
 
     }
   })

package/utils/dataTableUtils.js

@@ -224,7 +224,7 @@ function validateRowData(data, schema) {
     const col = schema[j];
     if (!Object.prototype.hasOwnProperty.call(data, col.name)) continue;
     const raw = data[col.name];
-    if (raw === null || raw === undefined) continue;
+    if (raw === undefined) continue;
     result[col.name] = coerceValue(raw, col);
   }
   return result;