@tiledesk/tiledesk-server 2.14.1 → 2.14.3

package/CHANGELOG.md

@@ -5,6 +5,12 @@
 🚀        IN PRODUCTION                        🚀
 (https://www.npmjs.com/package/@tiledesk/tiledesk-server/v/2.3.77) 
 
+# 2.14.3
+- Fixed bug: first message not sent from default chatbot. Refactored availableAgentsCount handling in requestService to ensure accurate snapshot updates during request creation.
+
+# 2.14.2
+- Updated updateRequestSnapshotQueued.js to update the snapshot only
+
 # 2.14.1
 - Fixed missing snapshot parameter in event request
 - Updated twilio-connector to 0.1.28

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@tiledesk/tiledesk-server",
   "description": "The Tiledesk server module",
-  "version": "2.14.1",
+  "version": "2.14.3",
   "scripts": {
     "start": "node ./bin/www",
     "pretest": "mongodb-runner start",

package/pubmodules/rules/conciergeBot.js

@@ -80,7 +80,10 @@ devi mandare un messaggio welcome tu altrimenti il bot inserito successivamente
                                     //apply only if the status is temp and no bot is available. with agent you must reroute to assign temp request to an agent 
                                     winston.debug("rerouting");
                                     // reroute(request_id, id_project, nobot)
-                                    requestService.reroute(message.request.request_id, message.request.id_project, false ).catch((err) => {
+                                    let t1 = Date.now();    
+                                    requestService.reroute(message.request.request_id, message.request.id_project, false ).then(function() {
+                                        console.log("[Performance] (ConciergeBot) reroute time: " + (Date.now() - t1));
+                                    }).catch((err) => {
                                         winston.error("ConciergeBot error reroute: " + err);
                                     });     
                                 }

package/pubmodules/trigger/rulesTrigger.js

@@ -1164,8 +1164,9 @@ class RulesTrigger {
                       lead: createdLead, requester: puser
                     };
       
+                    let t1 = Date.now();
                     return requestService.create(new_request).then(function (savedRequest) {                   
-
+                      console.log("[Performance] (rulesTrigger) requestService.create time: " + (Date.now() - t1));
                       // performance console log
                       // console.log("************* request created trigger: "+new Date().toISOString());
 
@@ -1176,8 +1177,11 @@ class RulesTrigger {
                         var senderFullname = fullname || 'Guest'; // guest_here
 
                         // create(sender, senderFullname, recipient, text, id_project, createdBy, status, attributes, type, metadata, language) {
-                        return messageService.create( id_user, senderFullname , savedRequest.request_id, text,
-                          id_project, id_user,  MessageConstants.CHAT_MESSAGE_STATUS.SENDING, attributes, type, eventTrigger.event.metadata, language);
+                        let t2 = Date.now();
+                        return messageService.create( id_user, senderFullname , savedRequest.request_id, text, id_project, id_user,  MessageConstants.CHAT_MESSAGE_STATUS.SENDING, attributes, type, eventTrigger.event.metadata, language).then(function(savedMessage) {
+                          console.log("[Performance] (rulesTrigger) messageService.create time: " + (Date.now() - t2));
+                          return savedMessage;
+                        });
                       }).catch(function (err) {
                         winston.error("Error trigger requestService.create", err);
                       });

package/services/requestService.js

@@ -221,6 +221,8 @@ class RequestService {
         request.assigned_at = assigned_at;
         request.waiting_time = undefined //reset waiting_time on reroute
 
+        console.log("request.snapshot for ", request.request_id ," exists: ", request.snapshot ? "yes" : "no\n", new Date());
+        console.log("request.snapshot.agents for ", request.request_id ," exists: ", request.snapshot?.agents ? "yes" : "no\n", new Date());
         if (!request.snapshot) { //if used other methods than .create
           request.snapshot = {}
         }
@@ -606,8 +608,9 @@ class RequestService {
     if (dep_id) {
       snapshot.department = result.department;
     }
-    snapshot.agents = agents;
-
+    
+    snapshot.availableAgentsCount = this.getAvailableAgentsCount(agents);
+    
     if (request.requester) {
       snapshot.requester = request.requester;
     }
@@ -644,7 +647,8 @@ class RequestService {
       priority,
       auto_close,
       followers,
-      createdAt
+      createdAt,
+      snapshot
     })
 
     if (isTestConversation) {
@@ -669,6 +673,7 @@ class RequestService {
       }
       await q.exec();
 
+      snapshot.agents = agents; 
       requestEvent.emit("request.create.simple", savedRequest, snapshot);
 
       if (isStandardConversation) {

package/services/updateRequestSnapshotQueued.js

@@ -16,7 +16,7 @@ class UpdateRequestSnapshotQueued {
   }
 
   updateRequestSnapshot() {
-    var snapshotUpdateKey = 'request.snapshot.update';
+    let snapshotUpdateKey = 'request.snapshot.update';
     if (requestEvent.queueEnabled) {
       snapshotUpdateKey = 'request.snapshot.update.queue';
     }
@@ -25,35 +25,40 @@ class UpdateRequestSnapshotQueued {
     requestEvent.on(snapshotUpdateKey, function (data) {
       setImmediate(() => {
         winston.debug("updateRequestSnapshot on request.snapshot.update ", data);
+        console.log("updateRequestSnapshot on request.snapshot.update ", data);
 
-        var request = data.request;
-        var snapshot = data.snapshot;
+        const request = data.request;
+        const snapshot = data.snapshot;
+        const agentsArray = snapshot?.agents || [];
+        console.log("(queue) updateRequestSnapshot snapshot agents length: ", agentsArray.length);
 
         if (!request || !request.request_id || !request.id_project) {
           winston.error("updateRequestSnapshot: Invalid request data", data);
           return;
         }
 
-        if (!snapshot || Object.keys(snapshot).length === 0) {
-          winston.debug("updateRequestSnapshot: Empty snapshot, skipping update");
+        // If there is no agents array in snapshot or it's not actually an array, skip the update
+        if (!Array.isArray(agentsArray)) {
+          winston.error("updateRequestSnapshot: snapshot.agents is not an array.", snapshot);
           return;
         }
 
-        var query = { request_id: request.request_id, id_project: request.id_project };
+        const query = { request_id: request.request_id, id_project: request.id_project };
         winston.debug("updateRequestSnapshot query ", query);
 
+        // Update ONLY the snapshot.agents field, presupposing 'snapshot' document already exists
         Request.findOneAndUpdate(
           query, 
-          { "$set": { "snapshot": snapshot } }, 
+          { "$set": { "snapshot.agents": agentsArray } }, 
           { new: true },
           function (err, updatedRequest) {
             if (err) {
-              winston.error("Error updating request snapshot updateRequestSnapshot", err);
+              winston.error("Error updating request snapshot.agents in updateRequestSnapshot", err);
               return;
             }
             if (updatedRequest) {
-              winston.debug("updateRequestSnapshot updated request " + updatedRequest.request_id);
-              requestEvent.emit('request.update.snapshot', { request: updatedRequest, snapshot: snapshot });
+              console.log("updateRequestSnapshot updated snapshot.agents for request " + updatedRequest.request_id, new Date());
+              winston.debug("updateRequestSnapshot updated snapshot.agents for request " + updatedRequest.request_id);
             } else {
               winston.warn("updateRequestSnapshot: Request not found for " + request.request_id);
             }