@tiledesk/tiledesk-server 2.10.6 → 2.10.8

package/CHANGELOG.md

@@ -5,6 +5,14 @@
 🚀        IN PRODUCTION                        🚀
 (https://www.npmjs.com/package/@tiledesk/tiledesk-server/v/2.3.77) 
 
+# 2.10.8
+- Fix bug closing conversation by chatbot
+- Fix bug typo error on import chatbot as json
+
+# 2.10.7
+- Update: removed regex in signup and changepsw (temp)
+- Update: fire request.close event even if the request is already closed
+
 # 2.10.6
 - Update: return more chatbot info with restricted_mode
 

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@tiledesk/tiledesk-server",
   "description": "The Tiledesk server module",
-  "version": "2.10.6",
+  "version": "2.10.8",
   "scripts": {
     "start": "node ./bin/www",
     "pretest": "mongodb-runner start",

package/routes/auth.js

@@ -80,10 +80,10 @@ router.post('/signup',
 
     // TODO: move the regex control inside signup method of UserService.
     // Warning: the pwd used in every test must be changed!
-    const regex = new RegExp(/^(?=.*[a-z])(?=.*[A-Z])(?=.*\d)(?=.*[!@#$%^&*])[A-Za-z\d!@#$%^&*]{8,}$/);
-    if (!regex.test(req.body.password)) {
-      return res.status(403).send({ success: false, message: "The password does not meet the minimum vulnerability requirements"})
-    }
+    // const regex = new RegExp(/^(?=.*[a-z])(?=.*[A-Z])(?=.*\d)(?=.*[!@#$%^&*])[A-Za-z\d!@#$%^&*]{8,}$/);
+    // if (!regex.test(req.body.password)) {
+    //   return res.status(403).send({ success: false, message: "The password does not meet the minimum vulnerability requirements"})
+    // }
 
     return userService.signup(req.body.email, req.body.password, req.body.firstname, req.body.lastname, false)
       .then( async function (savedUser) {

package/routes/faq_kb.js

@@ -719,7 +719,7 @@ router.post('/importjson/:id_faq_kb', roleChecker.hasRole('admin'), upload.singl
 
         if (faq) {
           winston.debug("new intent created")
-          faqBotEvent.emit('faq.create', savedFaq);
+          faqBotEvent.emit('faq.create', faq);
         }
       })
     }

package/routes/request.js

@@ -306,12 +306,20 @@ router.patch('/:requestid', function (req, res) {
 router.put('/:requestid/close', async function (req, res) {
   winston.debug(req.body);
   let request_id = req.params.requestid;
-  let user_role = req.projectuser.role;
+  
+  /**
+   * Check on projectuser existence.
+   * If req.projectuser is null then the request was made by a chatbot.
+   */
+  let project_user = req.projectuser;
+  let user_role;
+  if (project_user) {
+    user_role = project_user.role;
+  }
 
-  // closeRequestByRequestId(request_id, id_project, skipStatsUpdate, notify, closed_by)
   const closed_by = req.user.id;
 
-  if (user_role !== RoleConstants.OWNER && user_role !== RoleConstants.ADMIN) {
+  if (user_role && (user_role !== RoleConstants.OWNER && user_role !== RoleConstants.ADMIN)) {
     let request = await Request.findOne({ id_project: req.projectid, request_id: request_id }).catch((err) => {
       winston.error("Error finding request: ", err);
       return res.status(500).send({ success: false, error: "Error finding request with request_id " + request_id })
@@ -327,7 +335,6 @@ router.put('/:requestid/close', async function (req, res) {
       return res.status(403).send({ success: false, error: "You must be among the participants to close a conversation."})
     }
   }
-  
 
   return requestService.closeRequestByRequestId(req.params.requestid, req.projectid, false, true, closed_by, req.body.force).then(function (closedRequest) {
     winston.verbose("request closed", closedRequest);

package/routes/users.js

@@ -137,10 +137,10 @@ router.put('/changepsw', function (req, res) {
               return res.status(403).send({ success: false, message: "The new password must be different from the previous one."})
             }
 
-            const regex = new RegExp(/^(?=.*[a-z])(?=.*[A-Z])(?=.*\d)(?=.*[!@#$%^&*])[A-Za-z\d!@#$%^&*]{8,}$/);
-            if (!regex.test(req.body.newpsw)) {
-              return res.status(403).send({ success: false, message: "The password does not meet the minimum vulnerability requirements"})
-            }
+            // const regex = new RegExp(/^(?=.*[a-z])(?=.*[A-Z])(?=.*\d)(?=.*[!@#$%^&*])[A-Za-z\d!@#$%^&*]{8,}$/);
+            // if (!regex.test(req.body.newpsw)) {
+            //   return res.status(403).send({ success: false, message: "The password does not meet the minimum vulnerability requirements"})
+            // }
             
             user.password = req.body.newpsw
 

package/services/requestService.js

@@ -1749,6 +1749,7 @@ class RequestService {
           if (force == false && request.status == RequestConstants.CLOSED) {
             // qui1000
             //  if (request.statusObj.closed) {
+            requestEvent.emit('request.close', request);
             winston.debug("Request already closed for request_id " + request_id + " and id_project " + id_project);
             return resolve(request);
           }