@tikoci/rosetta 0.8.0 → 0.8.1

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@tikoci/rosetta",
-  "version": "0.8.0",
+  "version": "0.8.1",
   "description": "RouterOS documentation as SQLite FTS5 — RAG search + command glossary via MCP",
   "type": "module",
   "license": "MIT",

package/src/mcp.ts

@@ -66,10 +66,13 @@ async function ensureDbReady(log: (msg: string) => void): Promise<void> {
   const dbPath = resolveDbPath(import.meta.dirname);
   const runningVersion = resolveVersion(import.meta.dirname);
 
-  /** Probe an existing DB. Returns null if the file is missing or unreadable. */
+  /** Probe an existing DB. Returns null if the file is missing or unreadable.
+   *  Do NOT pass { readonly: true } — freshly written SQLite WAL-mode files fail
+   *  to open readonly on macOS until a read-write connection initialises the WAL
+   *  shared-memory file. Same gotcha as setup.ts::probeDb. */
   function probe(): { pages: number; schemaVersion: number; releaseTag: string | null } | null {
     try {
-      const check = new sqlite(dbPath, { readonly: true });
+      const check = new sqlite(dbPath);
       const pages = (check.prepare("SELECT COUNT(*) AS c FROM pages").get() as { c: number }).c;
       const ver = (check.prepare("PRAGMA user_version").get() as { user_version: number }).user_version;
       let releaseTag: string | null = null;

package/src/release.test.ts

@@ -202,6 +202,22 @@ describe("setup.ts", () => {
     expect(src).toContain("Still incompatible after re-download");
     expect(src).toMatch(/Still incompatible[\s\S]{0,400}process\.exit\(1\)/);
   });
+
+  test("no DB open uses { readonly: true } (WAL-shm init trap on macOS)", () => {
+    // Freshly-renamed WAL-mode DBs fail to open readonly on macOS until a
+    // read-write connection initialises the .shm file. downloadDb explicitly
+    // deletes .wal/.shm before the rename, so every subsequent open must be
+    // read-write. Regressing this ships a bunx path that can't open its own
+    // validated download (see v0.8.0 "DB=unreadable" bug).
+    for (const file of ["src/mcp.ts", "src/setup.ts", "src/db.ts"]) {
+      // Strip line + block comments before scanning, so the "do NOT pass
+      // { readonly: true }" warnings themselves don't trip the check.
+      const src = readText(file)
+        .replace(/\/\*[\s\S]*?\*\//g, "")
+        .replace(/\/\/.*$/gm, "");
+      expect(src).not.toMatch(/readonly\s*:\s*true/);
+    }
+  });
 });
 
 // ---------------------------------------------------------------------------

package/src/setup.test.ts

@@ -8,7 +8,7 @@
 
 import sqlite from "bun:sqlite";
 import { afterAll, describe, expect, test } from "bun:test";
-import { mkdtempSync, rmSync, writeFileSync } from "node:fs";
+import { existsSync, mkdtempSync, rmSync, unlinkSync, writeFileSync } from "node:fs";
 import { tmpdir } from "node:os";
 import path from "node:path";
 
@@ -91,6 +91,36 @@ describe("probeDb", () => {
     expect(probe?.releaseTag).toBe("v0.0.0-test");
   });
 
+  test("opens a freshly-renamed WAL-mode DB with no .shm sibling", () => {
+    // Reproduces the exact state downloadDb leaves the DB in: journal_mode=WAL
+    // on disk, but the .wal/.shm siblings are deleted just before the rename.
+    // On macOS, opening such a file with { readonly: true } fails with
+    // "unable to open database file" because SQLite cannot create the shm
+    // from a read-only handle. probeDb intentionally opens read-write.
+    const dbFile = path.join(tmp, "wal-no-shm.db");
+    const seed = new sqlite(dbFile);
+    seed.exec("PRAGMA journal_mode = WAL");
+    seed.run(`PRAGMA user_version = ${SCHEMA_VERSION};`);
+    seed.run("CREATE TABLE pages (id INTEGER PRIMARY KEY);");
+    seed.run("CREATE TABLE commands (id INTEGER PRIMARY KEY);");
+    seed.run("INSERT INTO pages (id) VALUES (1), (2), (3);");
+    seed.run("INSERT INTO commands (id) VALUES (1), (2);");
+    seed.close();
+
+    // Simulate downloadDb's post-rename cleanup — WAL file on disk marks WAL
+    // mode in the header, but the transient .wal/.shm are gone.
+    for (const suffix of ["-wal", "-shm"]) {
+      const p = dbFile + suffix;
+      if (existsSync(p)) unlinkSync(p);
+    }
+
+    const probe = probeDb(dbFile);
+    expect(probe).not.toBeNull();
+    expect(probe?.schemaVersion).toBe(SCHEMA_VERSION);
+    expect(probe?.pages).toBe(3);
+    expect(probe?.commands).toBe(2);
+  });
+
   test("releaseTag is null when db_meta is absent (pre-v5 schema)", () => {
     const dbFile = path.join(tmp, "no-meta.db");
     const db = new sqlite(dbFile);

package/src/setup.ts

@@ -26,12 +26,14 @@ const MIN_COMMANDS = 1000;
 const MIN_DECOMPRESSED_BYTES = 50 * 1024 * 1024; // 50 MB
 const SQLITE_MAGIC = "SQLite format 3\0";
 
-/** Check if a DB file exists and has actual page data */
+/** Check if a DB file exists and has actual page data.
+ *  Opens read-write — see probeDb's note: freshly written WAL-mode files can
+ *  fail to open readonly on macOS when the .shm file is missing. */
 function dbHasData(dbPath: string): boolean {
   if (!existsSync(dbPath)) return false;
   try {
     const { default: sqlite } = require("bun:sqlite");
-    const check = new sqlite(dbPath, { readonly: true });
+    const check = new sqlite(dbPath);
     const row = check.prepare("SELECT COUNT(*) AS c FROM pages").get() as { c: number };
     check.close();
     return row.c > 0;