@tikoci/centrs 0.1.4 → 0.1.7

package/src/execute-fanout.ts

@@ -15,7 +15,7 @@
  *   - A `--default` / `__default__` member is guarded from being dialed as the
  *     literal hostname `"__default__"` — it fails that one target deterministically
  *     with `target/unresolved`.
- *   - A **write-shaped** command (add/set/remove) is confirmed ONCE up front
+ *   - A **write-shaped** command is confirmed ONCE up front
  *     (`--yes`), never per target; without `--yes` the error names the blast radius
  *     (how many routers). Write-ness is target-independent (`canonicalizeExecuteCommand`).
  */
@@ -26,6 +26,7 @@ import type {
 	CommonSettingsMeta,
 	FanoutData,
 	FanoutSummary,
+	ValidationTrace,
 } from "./core/envelope.ts";
 import {
 	buildFanoutEnvelope,
@@ -36,6 +37,7 @@ import {
 	runFanout,
 	summarizeFanout,
 } from "./core/fanout.ts";
+import { toYaml } from "./core/yaml.ts";
 import { CentrsError, serializeCentrsError } from "./errors.ts";
 import {
 	buildExecuteErrorEnvelopeFromResolved,
@@ -60,7 +62,6 @@ import {
 	type SelectionResolveInput,
 	type TargetSelection,
 } from "./resolver/index.ts";
-import { toYaml } from "./retrieve.ts";
 
 /** Compact description of the selector that produced the fan-out. */
 export interface ExecuteSelectionSummary {
@@ -233,6 +234,11 @@ export async function executeFanout(
 	await assertFanoutWriteConfirmed(request, global.summary, expansion);
 
 	const execute = internals.execute ?? runResolvedExecute;
+	// Per-target validation trace. `execute` and `onExecuteError` are separate
+	// callbacks that share only the resolved request, so the request object is
+	// the key: without it a per-target error envelope would reconstruct
+	// `meta.validation` instead of reporting the gate that actually ran (GH#354).
+	const traces = new WeakMap<ResolvedExecuteRequest, ValidationTrace>();
 	const sleep = internals.sleep ?? defaultFanoutSleep;
 
 	const targets = await runFanout<
@@ -282,11 +288,19 @@ export async function executeFanout(
 				warnings: member.kind === "cdb" ? [...member.resolution.warnings] : [],
 				summary: "Failed to resolve a fanout target.",
 			}),
-		execute: async (resolved, member) =>
-			relabelAdhocMember(await execute(resolved), member),
+		execute: async (resolved, member) => {
+			const trace: ValidationTrace = {};
+			traces.set(resolved, trace);
+			return relabelAdhocMember(await execute(resolved, trace), member);
+		},
 		onExecuteError: (resolved, member, error) =>
 			relabelAdhocMember(
-				buildExecuteErrorEnvelopeFromResolved(resolved, error),
+				buildExecuteErrorEnvelopeFromResolved(
+					resolved,
+					error,
+					undefined,
+					traces.get(resolved),
+				),
 				member,
 			),
 		sleep,