@tikoci/centrs 0.1.1 → 0.1.3

package/src/btest.ts

@@ -138,6 +138,8 @@ export interface BtestClientData {
 	stopReason: BtestStopReason;
 	serverUdpPort?: number;
 	clientUdpPort?: number;
+	/** TCP data connections actually driven (1 + joined secondaries). */
+	activeConnections: number;
 }
 
 export interface BtestClientOperationMeta {
@@ -215,9 +217,37 @@ export async function btestClient(
 		controlPort,
 	};
 
+	const warnings: {
+		code: string;
+		message: string;
+		context?: Record<string, unknown>;
+	}[] = [];
+
 	try {
 		validateClientOptions(request);
 
+		// The btest wire command carries a single tx-size field; --remote-udp-tx-size
+		// and --local-udp-tx-size map to it separately only for receive (remote wins)
+		// and transmit (local wins). For both, localUdpTxSize wins and
+		// remoteUdpTxSize is silently discarded — warn when they differ so the user
+		// knows which size the server will actually use.
+		if (
+			protocol === "udp" &&
+			direction === "both" &&
+			request.remoteUdpTxSize !== undefined &&
+			request.localUdpTxSize !== undefined &&
+			request.remoteUdpTxSize !== request.localUdpTxSize
+		) {
+			warnings.push({
+				code: "routeros/btest-udp-tx-size-ignored",
+				message: `--remote-udp-tx-size (${request.remoteUdpTxSize}) is ignored for --direction both; the btest wire protocol carries a single tx-size and --local-udp-tx-size (${request.localUdpTxSize}) is used for both directions.`,
+				context: {
+					ignored: request.remoteUdpTxSize,
+					used: request.localUdpTxSize,
+				},
+			});
+		}
+
 		const cdbResolution = await resolveCdb(
 			{
 				targetInput: request.targetInput,
@@ -273,6 +303,9 @@ export async function btestClient(
 				? { statusIntervalMs: request.intervalMs }
 				: {}),
 			...(txSize !== undefined ? { txSize } : {}),
+			...(request.connectionCount !== undefined
+				? { tcpConnectionCount: request.connectionCount }
+				: {}),
 			...(request.localTxSpeed !== undefined
 				? { localTxSpeed: request.localTxSpeed }
 				: {}),
@@ -301,6 +334,7 @@ export async function btestClient(
 			txTotalAvgBps: secs > 0 ? (summary.totalTxBytes * 8) / secs : 0,
 			rxTotalAvgBps: secs > 0 ? (summary.totalRxBytes * 8) / secs : 0,
 			stopReason: summary.stopReason,
+			activeConnections: summary.activeConnections,
 		};
 		if (summary.username !== undefined) data.user = summary.username;
 		if (summary.serverUdpPort !== undefined)
@@ -308,10 +342,36 @@ export async function btestClient(
 		if (summary.clientUdpPort !== undefined)
 			data.clientUdpPort = summary.clientUdpPort;
 
+		// TCP multi-connection: centrs now opens the negotiated extra data
+		// connections (fan-out). It still degrades to a single stream when the server
+		// negotiates no session token — notably authenticated (EC-SRP5) sessions,
+		// whose post-auth token centrs does not yet capture. Warn only when the
+		// realized fan-out fell short of the request, with the actual count.
+		if (
+			protocol === "tcp" &&
+			request.connectionCount !== undefined &&
+			request.connectionCount > 1 &&
+			summary.activeConnections < request.connectionCount
+		) {
+			const single = summary.activeConnections === 1;
+			warnings.push({
+				code: "routeros/btest-connection-count-single-stream",
+				message: `--connection-count (${request.connectionCount}) requested, but ${summary.activeConnections} TCP data connection(s) are active${
+					single && summary.authKind !== "none"
+						? " — authenticated multi-connection is not yet supported"
+						: ""
+				}; throughput will not scale to the full count.`,
+				context: {
+					requested: request.connectionCount,
+					active: summary.activeConnections,
+				},
+			});
+		}
+
 		return {
 			ok: true,
 			data,
-			warnings: [],
+			warnings: warnings.map((w) => ({ ...w })),
 			tips: [],
 			meta: clientMeta(target.host, controlPort, operation, auth.username),
 		};