@tiens.nguyen/gu-cli 1.0.830 → 1.0.831

package/gonext_agent_chat.py

@@ -7999,6 +7999,111 @@ _HEREDOC_HINT = ("\n\nSHELL QUOTING broke this line. For text with quotes or lin
                  "run_command(\"\"\"git commit -F - <<'EOF'\n<message>\nEOF\"\"\") — nothing in the "
                  "message needs escaping.")
 
+# A PIPE HIDES THE EXIT CODE OF EVERYTHING BEFORE IT (#360 review, turn 3c06654e). The model ran
+# `python3 -m pytest … | tail -5 && git add … && git commit …`; pytest was not installed, `tail`
+# exited 0, and the commit went in untested. Global `set -o pipefail` would fix that and break
+# `git log | head -5` (SIGPIPE → 141) everywhere, so the line runs as written and gu READS the
+# output instead: a pipe line that exited 0 while printing an unmistakable failure is reported
+# as one. Markers are line-anchored and specific, so ordinary output containing "error" passes.
+_PIPE_FAIL_RE = re.compile(
+    r"^.*(?:No module named \S+|ModuleNotFoundError: .*|: command not found|: not found$"
+    r"|^Traceback \(most recent call last\):|^fatal: .*|^error: .*|^npm ERR! .*"
+    r"|^E: Unable to locate package .*|: No such file or directory$)",
+    re.M)
+
+
+def _pipe_hidden_failure(scan, out: str) -> str:
+    """The failure line a pipe hid, or "" — only for a line that has a `|`."""
+    if not scan or not any(t[0] == "op" and t[1] == "|" for t in scan.get("tokens") or []):
+        return ""
+    m = _PIPE_FAIL_RE.search(out or "")
+    return m.group(0).strip()[:200] if m else ""
+
+
+def _pipe_hidden_failure_note(line: str) -> str:
+    return ("\n\nWARNING — A FAILURE WAS HIDDEN BY A PIPE: the output shows "
+            f"'{line}', but a pipeline reports only its LAST command's exit code, so this "
+            "line counted as success and every part after `&&` RAN ANYWAY. Check what those "
+            "parts did before relying on them. To chain on a check, run it without a pipe, or "
+            "start the line with `set -o pipefail;`.")
+
+
+# THE PROJECT'S OWN TEST COMMANDS (#360 review). The model guessed `python3 -m pytest` in a repo
+# whose package.json says `python3 -m unittest discover tests -v && node --test` — pytest was not
+# even installed. The manifests already say how each part of the project is tested; reading them
+# costs no tool call. Depth ≤ 3 (a monorepo's packages), at most 8, nearest first.
+_TEST_SKIP_DIRS = {"node_modules", "dist", "build", "out", "target", "vendor", "venv", ".venv",
+                   "__pycache__", "server-bundle", "coverage"}
+
+
+def _project_test_commands(root: str, max_depth: int = 3, limit: int = 8) -> list:
+    """[(relative folder, command)] from package.json scripts.test, a Makefile `test:` target,
+    pytest config, Cargo.toml and go.mod. Never raises."""
+    import json as _json
+    found = []
+    try:
+        root = os.path.abspath(root)
+    except Exception:  # noqa: BLE001
+        return []
+    queue = [(root, 0)]
+    while queue and len(found) < limit:
+        d, depth = queue.pop(0)
+        try:
+            names = set(os.listdir(d))
+        except OSError:
+            continue
+        rel = os.path.relpath(d, root)
+        rel = "." if rel == "." else rel.replace(os.sep, "/")
+        cmd = ""
+        if "package.json" in names:
+            try:
+                with open(os.path.join(d, "package.json"), encoding="utf-8") as fh:
+                    t = ((_json.load(fh) or {}).get("scripts") or {}).get("test") or ""
+                if t and "no test specified" not in t:
+                    cmd = f"npm test  ({_clip(t, 110)})"
+            except Exception:  # noqa: BLE001
+                pass
+        if not cmd and "Makefile" in names:
+            try:
+                with open(os.path.join(d, "Makefile"), encoding="utf-8", errors="replace") as fh:
+                    if re.search(r"(?m)^test\s*:", fh.read(200_000)):
+                        cmd = "make test"
+            except OSError:
+                pass
+        if not cmd and ("pytest.ini" in names or "conftest.py" in names):
+            cmd = "python3 -m pytest"
+        if not cmd and "pyproject.toml" in names:
+            try:
+                with open(os.path.join(d, "pyproject.toml"), encoding="utf-8", errors="replace") as fh:
+                    if "[tool.pytest" in fh.read(200_000):
+                        cmd = "python3 -m pytest"
+            except OSError:
+                pass
+        if not cmd and "Cargo.toml" in names:
+            cmd = "cargo test"
+        if not cmd and "go.mod" in names:
+            cmd = "go test ./..."
+        if cmd:
+            found.append((rel, cmd))
+        if depth < max_depth:
+            for n in sorted(names):
+                if n.startswith(".") or n in _TEST_SKIP_DIRS:
+                    continue
+                p = os.path.join(d, n)
+                if os.path.isdir(p) and not os.path.islink(p):
+                    queue.append((p, depth + 1))
+    return found
+
+
+def _test_commands_line(root: str) -> str:
+    cmds = _project_test_commands(root) if root else []
+    if not cmds:
+        return ""
+    return ("  TEST COMMANDS, from this project's own manifests — use these, never guess a runner "
+            "(a missing pytest fails silently behind a pipe): "
+            + "; ".join(f"{d} → {c}" for d, c in cmds) + "\n")
+
+
 # bash's words for a line whose quotes do not pair up.
 _SHELL_QUOTE_ERR_RE = re.compile(
     r"unexpected EOF while looking for matching|syntax error near unexpected token|"
@@ -10418,9 +10523,16 @@ def run_agent_chat(cfg):
             _ws_servers_line += _shells_context_line(_shells_load())
         except Exception as _e:  # noqa: BLE001
             _log(f"shell context skip: {_e}")
+    _ws_tests_line = ""
+    if _WS_AVAILABLE and _WS_ACTIVE:
+        try:
+            _ws_tests_line = _test_commands_line(_WS_ACTIVE)
+        except Exception as _e:  # noqa: BLE001
+            _log(f"test command scan skip: {_e}")
     _ws_context_block = (
         _ws_current_line
         + f"  Other registered workspaces (use only if the user names them): {_ws_names}\n"
+        + _ws_tests_line
         + _ws_servers_line
         + f"  Current folder contents:\n"
         + "\n".join(f"    {line}" for line in _ws_overview.splitlines()) + "\n"
@@ -14754,6 +14866,11 @@ def run_agent_chat(cfg):
                         # `git commit -m '…turn'\''s…'` lost its backslash to Python and bash
                         # stopped on the quote; the next step was spent guessing. A heredoc in a
                         # triple-quoted string has no quoting to get wrong.
+                        _hidden = _pipe_hidden_failure(_scan, out) if (rc == 0 and _use_shell) else ""
+                        if _hidden:
+                            result += _pipe_hidden_failure_note(_hidden)
+                            _emit({"type": "step", "text":
+                                   f"Command failed behind a pipe → {_trim_words(_hidden)}"})
                         if rc != 0 and _use_shell and _SHELL_QUOTE_ERR_RE.search(out or ""):
                             result += _HEREDOC_HINT
                         if rc != 0 and _WS_PERM_ERR_RE.search(out or ""):

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@tiens.nguyen/gu-cli",
-  "version": "1.0.830",
+  "version": "1.0.831",
   "description": "Gu CLI — the gu terminal plus the local worker that runs agent / OCR / PDF / embedding jobs on your Mac (Ollama / MLX / OpenAI-compatible).",
   "type": "module",
   "license": "MIT",