@tiens.nguyen/gu-cli 1.0.823 → 1.0.824

package/gonext_agent_chat.py

@@ -2026,7 +2026,11 @@ def _is_greeting_smalltalk(text: str) -> bool:
 # self-labels as "Thought"/"Thinking Process" up front (a real answer doesn't open by
 # naming itself as the model's own reasoning), or it's dense with self-correction
 # language a finished answer wouldn't contain.
-_SCRATCHPAD_START_RE = re.compile(r"^\s*thought\b\s*[:\n]", re.I)
+# The label may come dressed as markdown — "## Thought" or "**Thought:**" — and is still the
+# model naming its own reasoning (#139: Kimi K3 wrote "## Thought\n\n… Let me check git status"
+# and it was delivered as the ANSWER to "commit", so nothing ran).
+_SCRATCHPAD_START_RE = re.compile(
+    r"^\s*(?:#{1,6}\s*|\*\*|__)?thought(?:\s*:|\s*(?:\*\*|__)\s*:?|\s*\n)", re.I)
 _DELIBERATION_RE = re.compile(
     r"\b(wait,|actually,|let'?s (try|just|use|list|see|go)|"
     r"i (?:need to|should) (?:check|verify|confirm))\b",
@@ -5224,6 +5228,37 @@ def _has_runnable_block(text) -> bool:
         return False
 
 
+# Chat-template control tokens a served model sometimes prints instead of acting on (#139,
+# Kimi K3 on ollama.com: "Thought: …<|close|>think<|sep|><|open|>response<|sep|>"). They mark
+# where the model's own reasoning ended and its reply began.
+_TEMPLATE_TOKEN_RE = re.compile(r"<\|[a-z_]{2,24}\|>(?:\s*[a-z_]{2,24}\s*<\|[a-z_]{2,24}\|>)*", re.I)
+
+
+def _strip_leaked_template(content):
+    """Cut leaked chat-template tokens out of a reply; keep what came after the last one.
+
+    Text before the last token is the model's reasoning written into the visible channel; text
+    after it is the reply. An EMPTY reply stays empty, so the empty-content nudge asks the model
+    to act instead of the step failing on a plan that ran nothing (seen live: three steps of
+    "Thought: … now final answer.<|close|>think…" before a final_answer). Tokens inside a
+    <code> block are file content, never ours to touch."""
+    if not isinstance(content, str) or "<|" not in content:
+        return content
+    spans = [m.span() for m in re.finditer(_CODE_PAIR_RE, content, re.I)]
+    last = None
+    for m in _TEMPLATE_TOKEN_RE.finditer(content):
+        if not any(a <= m.start() < b for a, b in spans):
+            last = m
+    if last is None:
+        return content
+    reply = content[last.end():].strip()
+    if reply:
+        return reply
+    head = _TEMPLATE_TOKEN_RE.sub("", content[:last.start()]).strip()
+    # A runnable block before the tokens is still the action — keep it.
+    return head if _has_runnable_block(head) else ""
+
+
 def _code_nudge_reason(content, openai_backend: bool):
     """Why (if at all) this streamed turn should be re-prompted once with the CODE-NOW
     directive — or None to accept it as-is. Pure decision so the three triggers can be
@@ -5234,14 +5269,16 @@ def _code_nudge_reason(content, openai_backend: bool):
          merely TRUNCATED at the `</code>` stop sequence is not that (task #119): it is
          closed first and accepted as-is, so a step that already called a tool no longer
          pays for a second model call to be told to do what it just did.
-      3. prose-only plan — narration of what it is ABOUT to do, no tag at all. This one
-         is openai-only and additionally requires _looks_like_scratchpad, so a FINISHED
-         prose answer is never nudged into inventing another tool call. It exists because
-         the "</code>" visible in a smolagents trace is appended by smolagents AFTER the
-         model returns, so trigger 2 cannot see this shape.
-
-    Triggers 1 and 2 keep their existing backend-agnostic behavior — the Ollama path is
-    unchanged, since trigger 3 is the only new one and it is gated off there."""
+      3. prose-only plan — narration of what it is ABOUT to do, no tag at all. It
+         requires _looks_like_scratchpad, so a FINISHED prose answer is never nudged into
+         inventing another tool call. It exists because the "</code>" visible in a
+         smolagents trace is appended by smolagents AFTER the model returns, so trigger 2
+         cannot see this shape.
+
+    All three apply on every backend. Trigger 3 was openai-only (kept off small local
+    Ollama models); #139 showed the cost: Kimi K3 served by ollama.com is an "ollama"
+    backend, so each plan-only reply burned a whole failed step instead of one retry.
+    `openai_backend` is kept for callers and no longer changes the decision."""
     text = (content or "").strip()
     if not text:
         return "empty-content"
@@ -5249,7 +5286,7 @@ def _code_nudge_reason(content, openai_backend: bool):
         return None  # a real block (closing a stop-truncated one first) — nothing to nudge
     if re.search(r"</?code[\s>/]", content, re.I):
         return "dangling code tag, no valid block"
-    if openai_backend and _looks_like_scratchpad(text):
+    if _looks_like_scratchpad(text):
         return "prose-only plan, no code block"
     return None
 
@@ -11730,6 +11767,12 @@ def run_agent_chat(cfg):
             # anything downstream asks "did this turn produce a code block?" — otherwise a
             # step that called a tool correctly reads as broken. Gated on the code actually
             # compiling, so a genuinely dangling tag still falls through to the nudge below.
+            # Leaked chat-template tokens first (#139): what came before them is reasoning.
+            _unleaked = _strip_leaked_template(content)
+            if _unleaked != content:
+                _log(f"leaked chat-template tokens → kept the reply after them "
+                     f"({len(content)} → {len(_unleaked)} chars)")
+                content = _unleaked
             content = _close_dangling_code_block(content)
             # TAGS FIRST, judgement second. The tag repair used to run much later, so every
             # decision in between — is this a code block? does it need a nudge? — was made on

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@tiens.nguyen/gu-cli",
-  "version": "1.0.823",
+  "version": "1.0.824",
   "description": "Gu CLI — the gu terminal plus the local worker that runs agent / OCR / PDF / embedding jobs on your Mac (Ollama / MLX / OpenAI-compatible).",
   "type": "module",
   "license": "MIT",