@tiens.nguyen/gu-cli 1.0.686

package/version-check.mjs

@@ -0,0 +1,72 @@
+/**
+ * Is something newer available, and which installed version should actually be used?
+ *
+ * TWO THINGS GO STALE INDEPENDENTLY (task #181) and neither was ever checked:
+ *   · the CLI  — @tiens.nguyen/gu-cli on npm
+ *   · the API  — the Client Expert package on S3, per ~/.gonext/api/<version>/
+ *
+ * They share nothing but the question. The CLI's answer means "restart gu"; the API's means
+ * "restart the local API, dropping whatever it was serving". So only the COMPARISON lives here,
+ * pure and testable without a network, a bucket or a registry — the fetches belong to the
+ * callers, which is also what lets a failed probe degrade to "no update" instead of an error.
+ */
+
+/**
+ * Compare two dotted versions numerically. → negative if a < b, 0 if equal, positive if a > b.
+ *
+ * NOT a string compare, which is the bug this exists to avoid: "1.0.9" > "1.0.10" lexically,
+ * and the version numbers here are already past that boundary. Non-numeric junk sorts as 0
+ * rather than NaN, so a malformed manifest can never make a comparison silently reverse.
+ */
+export function compareVersions(a, b) {
+  const parts = (v) => String(v ?? "").split(".").map((n) => Number.parseInt(n, 10) || 0);
+  const A = parts(a);
+  const B = parts(b);
+  for (let i = 0; i < Math.max(A.length, B.length); i++) {
+    const d = (A[i] ?? 0) - (B[i] ?? 0);
+    if (d) return d;
+  }
+  return 0;
+}
+
+/** Is `available` strictly newer than `running`? Missing either side ⇒ no. */
+export function isNewer(available, running) {
+  if (!available || !running) return false;
+  return compareVersions(available, running) > 0;
+}
+
+/**
+ * The version to actually START, from what is installed on disk. → the version, or "".
+ *
+ * NEWEST USABLE, NOT NEWEST. This is the outage fix. `api start` used to sort the directory
+ * names and take the last one, with no check that it could run — so an interrupted upgrade
+ * (source unpacked, dependencies not yet installed) sorted highest, was chosen, and failed with
+ * `Cannot find package 'dotenv'` while a perfectly good older version sat beside it. Observed
+ * on a live machine, which was down until the deps were installed by hand.
+ *
+ * `usable` is injected rather than read here so the rule is testable without a filesystem, and
+ * so the caller decides what "usable" means (today: node_modules present).
+ */
+export function pickUsableVersion(versions, usable = () => true) {
+  const sorted = [...(versions ?? [])]
+    .filter(Boolean)
+    .sort((a, b) => compareVersions(a, b));
+  for (let i = sorted.length - 1; i >= 0; i--) {
+    if (usable(sorted[i])) return sorted[i];
+  }
+  return "";
+}
+
+/**
+ * What the user should be told is available. → { cli, api, any }
+ *
+ * Each side is either "" (nothing newer, or we could not find out) or the newer version. The
+ * two are kept SEPARATE all the way to the UI because acting on them differs: one restarts the
+ * API, the other requires restarting gu itself. Collapsing them into a boolean here is what
+ * would make a single ambiguous "update available" button, which is the thing to avoid.
+ */
+export function updatesAvailable({ cliRunning, cliLatest, apiRunning, apiLatest } = {}) {
+  const cli = isNewer(cliLatest, cliRunning) ? String(cliLatest) : "";
+  const api = isNewer(apiLatest, apiRunning) ? String(apiLatest) : "";
+  return { cli, api, any: Boolean(cli || api) };
+}