@ticketboothapp/booking 1.2.95 → 1.2.96

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@ticketboothapp/booking",
-  "version": "1.2.95",
+  "version": "1.2.96",
   "private": false,
   "sideEffects": [
     "**/*.css",

package/src/components/booking/AdminChangeBookingFlow.tsx

@@ -4153,47 +4153,9 @@ export function AdminChangeBookingFlow({
     });
   }, [adminCustomReceiptLines]);
 
-  /**
-   * Provider `/change` applies from booking item billable rows plus `pricingAdjustment`.
-   * For admin FE-authoritative receipts, the quote/receipt total can include an explicit tax row while the provider
-   * billable-row builder does not add that row on a date-only change. Send it as an automatic adjustment so
-   * `newTotalAmount` and the billable line sum stay in lockstep.
-   */
-  const providerReceiptTaxAdjustment = useMemo((): Array<{ label: string; amount: number }> => {
-    if (!isProviderDashboardChange || !useAdminFeAuthoritativeQuote) return [];
-    const tax = roundMoney(adminFeAuthoritativeReceipt.tax);
-    if (Math.abs(tax) < 0.005) return [];
-    const providerAlreadyHasTaxLine = providerQuotedLines.some((line) => {
-      const type = String(line.type ?? '').trim().toUpperCase();
-      const label = String(line.label ?? '').trim().toLowerCase();
-      return type === 'TAX' || label.includes('tax');
-    });
-    if (providerAlreadyHasTaxLine) return [];
-    const taxLine = adminFeAuthoritativeReceipt.lineItems.find(
-      (line) => String(line.type ?? '').trim().toUpperCase() === 'TAX'
-    );
-    return [
-      {
-        label: taxLine?.label?.trim() || (t('booking.tax') !== 'booking.tax' ? t('booking.tax') : 'Taxes and fees'),
-        amount: tax,
-      },
-    ];
-  }, [
-    isProviderDashboardChange,
-    useAdminFeAuthoritativeQuote,
-    adminFeAuthoritativeReceipt.tax,
-    adminFeAuthoritativeReceipt.lineItems,
-    providerQuotedLines,
-    t,
-  ]);
-
   const mergedProviderAdditionalAdjustments = useMemo(
-    () => [
-      ...providerAdditionalAdjustments,
-      ...adminCustomLinesAsAdditionalAdjustments,
-      ...providerReceiptTaxAdjustment,
-    ],
-    [providerAdditionalAdjustments, adminCustomLinesAsAdditionalAdjustments, providerReceiptTaxAdjustment]
+    () => [...providerAdditionalAdjustments, ...adminCustomLinesAsAdditionalAdjustments],
+    [providerAdditionalAdjustments, adminCustomLinesAsAdditionalAdjustments]
   );
 
   const changeFlowSelectionPreview = useMemo((): ChangeFlowSelectionPreview | null => {

package/src/components/booking/ChangeBookingFlow.tsx

@@ -61,17 +61,11 @@ import {
   roundMoney,
 } from '../../lib/booking/change-flow-pricing';
 import {
-  mergePriceSummaryLinesForDrift,
-  mergeLineComparisonsWithFullDrift,
   normalizePricingDriftDetailFromQuote,
   normalizeTicketPricingTraceFromQuote,
-  sumPriceSummaryLinesMajorUnits,
-  computePricingDriftDelta,
 } from '../../lib/booking/change-booking-pricing-drift';
-import { ChangeBookingPricingDriftPanel } from './ChangeBookingPricingDriftPanel';
 import {
   buildChangeBookingServerPreview,
-  mapQuoteLineItemsToPriceSummaryLines,
 } from '../../lib/booking/change-booking-server-preview';
 import { buildCheckoutBreakdown } from '../../lib/booking/checkout-breakdown';
 import type { PricingConfig, PrecomputedPricesByCategory, ItineraryDisplayStep } from '../../lib/booking-api';
@@ -3171,190 +3165,6 @@ export function ChangeBookingFlow({
     originalReceiptTotal: originalReceipt?.total,
   });
 
-  /** When quote blocks checkout, compare FE vs server lines for debugging (prefers `pricingDriftDetail` from API when sent). */
-  const quoteBlockedPricingDrift = useMemo(() => {
-    if (!suppressSelfServeCurrencyUi || latestChangeQuote?.canProceed !== false) return null;
-    if (!selectedAvailability || totalQuantity <= 0) return null;
-
-    const api = latestChangeQuote.pricingDriftDetail;
-    const currencyForFmt = (latestChangeQuote.currency ?? currency) as Currency;
-
-    const clientMappedFromApi = mapQuoteLineItemsToPriceSummaryLines(api?.clientLineItems);
-    const useBeClientLines = clientMappedFromApi.length > 0;
-    /**
-     * Checkout passes tax/discount via PriceSummary props, not always as `priceSummaryLines`. Include them here so
-     * drift rows and their sums align with `changeFlowNewBookingTotal` (subtotal + tax − promo).
-     */
-    const clientLinesForMerge: PriceSummaryLine[] = (() => {
-      if (useBeClientLines) return clientMappedFromApi;
-      const lines: PriceSummaryLine[] = [...checkoutPriceSummaryLines];
-      const hasTaxLine = lines.some(
-        (l) => l.kind === 'line' && String(l.type ?? '').toUpperCase() === 'TAX',
-      );
-      if (!hasTaxLine && !isTaxIncludedInPrice && Math.abs(effectiveTax) >= 0.005) {
-        lines.push({
-          kind: 'line',
-          label: t('booking.tax') !== 'booking.tax' ? t('booking.tax') : 'Taxes and fees',
-          amount: effectiveTax,
-          type: 'TAX',
-        });
-      }
-      const hasPromoSummaryLine = lines.some(
-        (l) =>
-          l.kind === 'line' &&
-          (/PROMO|DISCOUNT|VOUCHER|GIFT/i.test(String(l.type ?? '')) ||
-            (l.amount < -0.005 && /promo|discount/i.test(l.label))),
-      );
-      if (!hasPromoSummaryLine && Math.abs(effectivePromoDiscountAmount) >= 0.005) {
-        const trimmedPromoCode = appliedPromoCode?.trim() ?? '';
-        const promoLabel =
-          trimmedPromoCode.length > 0
-            ? `Promo: ${trimmedPromoCode}`
-            : originalReceipt?.promoLabel?.trim() || 'Discount';
-        lines.push({
-          kind: 'line',
-          label: promoLabel,
-          amount: -effectivePromoDiscountAmount,
-          type: 'PROMO_CODE',
-        });
-      }
-      return lines;
-    })();
-
-    const serverMappedFromApi = mapQuoteLineItemsToPriceSummaryLines(api?.serverLineItems);
-    const useBeServerLines = serverMappedFromApi.length > 0;
-    const serverLinesForMerge = useBeServerLines
-      ? serverMappedFromApi
-      : (latestChangeQuote.serverPreview?.priceSummaryLines ?? []);
-
-    const clientTotalForDrift =
-      api?.clientTotalMajorUnits != null && Number.isFinite(api.clientTotalMajorUnits)
-        ? api.clientTotalMajorUnits
-        : useBeClientLines
-          ? sumPriceSummaryLinesMajorUnits(clientMappedFromApi)
-          : changeFlowNewBookingTotal;
-
-    let totalDelta: number | null = null;
-    if (api?.deltaMajorUnits != null && Number.isFinite(api.deltaMajorUnits)) {
-      totalDelta = roundMoney(api.deltaMajorUnits);
-    }
-
-    /**
-     * Server “price check” total: explicit API fields → sum of BE server lines → derive from delta → receipt preview totals.
-     */
-    let serverTotalFromQuote: number | undefined =
-      api?.serverTotalMajorUnits != null && Number.isFinite(api.serverTotalMajorUnits)
-        ? api.serverTotalMajorUnits
-        : undefined;
-    if (serverTotalFromQuote == null && useBeServerLines) {
-      serverTotalFromQuote = sumPriceSummaryLinesMajorUnits(serverMappedFromApi);
-    }
-    if (serverTotalFromQuote == null && totalDelta != null) {
-      serverTotalFromQuote = roundMoney(clientTotalForDrift - totalDelta);
-    }
-    if (serverTotalFromQuote == null) {
-      serverTotalFromQuote =
-        latestChangeQuote.serverDisplay?.total ??
-        latestChangeQuote.serverPreview?.totalNewBooking ??
-        undefined;
-    }
-    if (totalDelta == null && serverTotalFromQuote != null && Number.isFinite(serverTotalFromQuote)) {
-      totalDelta = roundMoney(clientTotalForDrift - serverTotalFromQuote);
-    }
-
-    const mergedForDrift = mergePriceSummaryLinesForDrift(clientLinesForMerge, serverLinesForMerge);
-    const rows =
-      api?.lineComparisons && api.lineComparisons.length > 0
-        ? mergeLineComparisonsWithFullDrift(api.lineComparisons, mergedForDrift)
-        : mergedForDrift;
-
-    const receiptAnchoring = api?.receiptAnchoring;
-    let driftRows = rows;
-    if (receiptAnchoring) {
-      const adj = roundMoney(
-        receiptAnchoring.reconciledTotalMajorUnits -
-          receiptAnchoring.requestedCatalogLineSumMajorUnits,
-      );
-      if (Math.abs(adj) >= 0.005) {
-        driftRows = [
-          ...rows,
-          {
-            key: 'meta:receipt-anchoring',
-            label: 'Receipt anchoring adjustment (BE only — not included in app total)',
-            clientAmount: null,
-            serverAmount: adj,
-            delta: computePricingDriftDelta(null, adj),
-          },
-        ];
-      }
-    }
-
-    const hasTotalDelta = totalDelta != null && Math.abs(totalDelta) >= 0.005;
-
-    if (driftRows.length === 0 && !hasTotalDelta) {
-      return null;
-    }
-
-    const usesBeLinePayload = useBeClientLines || useBeServerLines;
-
-    const ticketCartDetail = ticketLineItemsForChangeFlowDisplay
-      .filter((l) => (l.qty ?? 0) > 0)
-      .map((line) => {
-        const cat = line.category?.trim().toUpperCase() ?? '';
-        const rate = pricingForTicketSelector.find((r) => r.category.toUpperCase() === cat);
-        const rawList = rate?.baseInDisplayCurrency ?? rate?.priceCAD;
-        const listUnit =
-          rawList != null && Number.isFinite(Number(rawList))
-            ? Number(rawList)
-            : line.qty > 0
-              ? line.itemTotal / line.qty
-              : 0;
-        return {
-          category: cat,
-          qty: line.qty,
-          listUnitMajor: roundMoney(listUnit),
-          effectiveUnitMajor: roundMoney(line.qty > 0 ? line.itemTotal / line.qty : 0),
-          lineTotalMajor: line.itemTotal,
-        };
-      });
-
-    return (
-      <ChangeBookingPricingDriftPanel
-        rows={driftRows}
-        clientTotal={clientTotalForDrift}
-        serverTotal={serverTotalFromQuote}
-        totalDelta={totalDelta}
-        currency={currencyForFmt}
-        locale={locale}
-        ticketCartDetail={ticketCartDetail.length > 0 ? ticketCartDetail : undefined}
-        serverTicketPricingTrace={latestChangeQuote.ticketPricingTrace ?? undefined}
-        receiptAnchoring={receiptAnchoring}
-        footnote={
-          usesBeLinePayload
-            ? 'Lines use pricingDriftDetail.clientLineItems / serverLineItems when the quote includes them; totals prefer explicit major-unit fields, then sums of those lines, then the live cart / receipt preview.'
-            : undefined
-        }
-      />
-    );
-  }, [
-    suppressSelfServeCurrencyUi,
-    latestChangeQuote,
-    selectedAvailability,
-    totalQuantity,
-    checkoutPriceSummaryLines,
-    changeFlowNewBookingTotal,
-    currency,
-    locale,
-    ticketLineItemsForChangeFlowDisplay,
-    pricingForTicketSelector,
-    isTaxIncludedInPrice,
-    effectiveTax,
-    effectivePromoDiscountAmount,
-    appliedPromoCode,
-    originalReceipt?.promoLabel,
-    t,
-  ]);
-
   /** Replaces PriceSummary with non-numeric status until quote returns authoritative totals (no FE dollar amounts). */
   const selfServeCheckoutPlaceholder = useMemo(() => {
     if (!suppressSelfServeCurrencyUi || !selectedAvailability || totalQuantity <= 0) return undefined;
@@ -3377,7 +3187,6 @@ export function ChangeBookingFlow({
       return (
         <div className="rounded-lg border border-amber-200 bg-amber-50 px-4 py-3 text-sm text-amber-950">
           <div>{latestChangeQuote.reasonIfBlocked ?? 'This booking change is not available.'}</div>
-          {quoteBlockedPricingDrift}
         </div>
       );
     }
@@ -3394,7 +3203,6 @@ export function ChangeBookingFlow({
     changeQuoteLoading,
     changeQuoteFetchError,
     latestChangeQuote,
-    quoteBlockedPricingDrift,
     t,
   ]);
 
@@ -5058,4 +4866,3 @@ export function ChangeBookingFlow({
     </div>
   );
 }
-