@ticketboothapp/booking 1.2.172 → 1.2.174

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@ticketboothapp/booking",
-  "version": "1.2.172",
+  "version": "1.2.174",
   "private": false,
   "sideEffects": [
     "**/*.css",

package/src/components/booking/AdminChangeBookingFlow.tsx

@@ -833,12 +833,6 @@ export function AdminChangeBookingFlow({
     latestChangeQuote?.allowedRefundDispositionsByOperationId,
     latestChangeQuote?.removedValueByOperationId,
   ]);
-  useEffect(() => {
-    if (!isProviderDashboardChange || responseRefundDecisionOperations.length === 0) return;
-    setRefundDispositionsByOperationId((current) =>
-      defaultPendingRefundDispositions(responseRefundDecisionOperations, current),
-    );
-  }, [isProviderDashboardChange, responseRefundDecisionOperations]);
   const activeRefundDecisionContext = useMemo(() => mergeAdminRefundDecisionContext({
     current: refundDecisionContext,
     selectionKey: refundDecisionSelectionKey,
@@ -857,9 +851,19 @@ export function AdminChangeBookingFlow({
       ? responseReturnPriceTreatmentOperations
       : [];
   const activeRefundDispositionsByOperationId = useMemo(() => {
+    // Provider changes default discovered refund operations to pending at
+    // settlement time. Do not write those response-derived defaults into the
+    // explicit input state: doing so changes the request key after the first
+    // quote and immediately triggers an identical second quote.
+    const dispositionsWithPendingRefundDefaults = isProviderDashboardChange
+      ? defaultPendingRefundDispositions(
+          activeRefundDecisionContext?.operations ?? [],
+          refundDispositionsByOperationId,
+        )
+      : refundDispositionsByOperationId;
     const dispositionsWithReturnPriceDefaults = defaultKeepOriginalReturnPriceDispositions(
       activeReturnPriceTreatmentOperations,
-      refundDispositionsByOperationId,
+      dispositionsWithPendingRefundDefaults,
     );
     return selectRefundDispositionsForOperations(
       activeRefundDecisionContext,
@@ -869,6 +873,7 @@ export function AdminChangeBookingFlow({
   }, [
     activeRefundDecisionContext?.operations,
     activeReturnPriceTreatmentOperations,
+    isProviderDashboardChange,
     refundDispositionsByOperationId,
   ]);
   const handleRefundDispositionChange = useCallback((
@@ -910,7 +915,9 @@ export function AdminChangeBookingFlow({
     adminReverseAdjustmentIds,
     needsAdjustmentDiscovery:
       isProviderDashboardChange && !hasHydratedExistingAdjustments,
-    refundDispositionsByOperationId: activeRefundDispositionsByOperationId,
+    // Only explicit user inputs belong to quote identity. Automatic provider
+    // defaults are derived separately for settlement/submission below.
+    refundDispositionsByOperationId,
     useAdminFeAuthoritativeQuote,
     latestChangeQuote,
     setLatestChangeQuote,

package/src/components/booking/useAdminChangeQuotePreview.ts

@@ -190,37 +190,15 @@ export function useAdminChangeQuotePreview({
   const refundDecisionRequired = (latestChangeQuote?.refundDecisionOperations?.length ?? 0) > 0;
   const hasPublishedChangeQuoteRef = useRef(latestChangeQuote !== null);
   hasPublishedChangeQuoteRef.current = latestChangeQuote !== null;
-  /**
-   * Existing admin adjustments must be discoverable before the operator makes a change.
-   * Initial selection hydration can briefly leave the live availability/return unset, so use
-   * the persisted booking identities for this read-only discovery quote instead of waiting for
-   * the editable target controls to become complete.
-   */
-  const quoteAvailability = useMemo<Availability | null>(() => {
-    if (selectedAvailability) return selectedAvailability;
-    if (!needsAdjustmentDiscovery || !initialValues?.dateTime?.trim()) return null;
-    const optionId = initialValues.productOptionId?.trim() || initialValues.productId?.trim();
-    if (!optionId) return null;
-    return {
-      dateTime: initialValues.dateTime.trim(),
-      availabilityId: initialValues.availabilityId?.trim() || undefined,
-      productOptionId: optionId,
-      vacancies: Math.max(totalQuantity, 1),
-      currency,
-    };
-  }, [
-    selectedAvailability,
-    needsAdjustmentDiscovery,
-    initialValues?.dateTime,
-    initialValues?.availabilityId,
-    initialValues?.productOptionId,
-    initialValues?.productId,
-    totalQuantity,
-    currency,
-  ]);
+  // Quote only against a live availability. Existing-adjustment discovery is
+  // bundled into the first real change quote; it must not issue a quote merely
+  // because the modal is hydrating.
+  const quoteAvailability = selectedAvailability;
   const quoteReturnAvailabilityId =
     selectedReturnOption?.returnAvailabilityId ??
-    (needsAdjustmentDiscovery ? initialValues?.returnAvailabilityId?.trim() || null : null);
+    (quoteAvailability && needsAdjustmentDiscovery
+      ? initialValues?.returnAvailabilityId?.trim() || null
+      : null);
   const changeQuoteInputsKey = useMemo(() => buildAdminChangeQuoteRequestKey({
     bookingReference: initialValues?.bookingReference,
     lastName,
@@ -258,11 +236,13 @@ export function useAdminChangeQuotePreview({
   ]);
   const destinationRequiresReturnSelection = Boolean(selectedAvailability?.returnOptions?.length);
   const missingRequiredReturnSelection = destinationRequiresReturnSelection && !selectedReturnOption;
-  const quoteMissingRequiredReturnSelection =
-    missingRequiredReturnSelection && !needsAdjustmentDiscovery;
+  const quoteMissingRequiredReturnSelection = missingRequiredReturnSelection;
   const canRequestChangeQuote = canRequestAdminChangeQuote({
     isCustomerSelfServeChange,
-    hasEffectiveChangeSelection: hasEffectiveChangeSelection || needsAdjustmentDiscovery,
+    // Opening the change flow is not itself a change. Existing adjustment
+    // discovery can be included with the first real quote instead of issuing a
+    // quote during modal hydration.
+    hasEffectiveChangeSelection,
     hasSelectedAvailability: quoteAvailability != null,
     bookingReference: initialValues?.bookingReference,
     lastName,

package/test/change-booking-helpers.test.ts

@@ -612,7 +612,7 @@ test('admin quote dedupe refetches unchanged inputs after the published quote is
   assert.equal(canReuseCompletedAdminChangeQuote(inputKey, 'different-inputs', true), false);
 });
 
-test('admin quote gate allows adjustment-only changes', () => {
+test('admin quote gate requires a real change while allowing adjustment-only changes', () => {
   assert.equal(canRequestAdminChangeQuote({
     isCustomerSelfServeChange: true,
     hasEffectiveChangeSelection: true,
@@ -624,6 +624,7 @@ test('admin quote gate allows adjustment-only changes', () => {
 
   assert.equal(canRequestAdminChangeQuote({
     isCustomerSelfServeChange: true,
+    // A fully hydrated modal is still not quoteable until something changes.
     hasEffectiveChangeSelection: false,
     hasSelectedAvailability: true,
     bookingReference: 'DIFG66OF',