@ticketboothapp/booking 1.2.144 → 1.2.146

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@ticketboothapp/booking",
-  "version": "1.2.144",
+  "version": "1.2.146",
   "private": false,
   "sideEffects": [
     "**/*.css",

package/src/components/booking/AdminChangeBookingFlow.tsx

@@ -687,8 +687,6 @@ export function AdminChangeBookingFlow({
     quantities,
     addOnSelections,
     adminCustomReceiptLines,
-    editableSummaryLineAmountInputs,
-    editableSummaryLineLabelInputs,
     useAdminFeAuthoritativeQuote,
     latestChangeQuote,
     setLatestChangeQuote,

package/src/components/booking/admin-change-quote-request-key.ts

@@ -0,0 +1,37 @@
+import type { Availability } from '../../lib/booking-api';
+import { getAvailabilityOptionId } from './change-booking-flow-helpers';
+
+interface AdminChangeQuoteRequestKeyInput {
+  bookingReference?: string | null;
+  lastName: string;
+  productId: string;
+  selectedAvailability: Availability | null;
+  pickupLocationId: string | null;
+  returnAvailabilityId: string | null;
+  quantities: Record<string, number>;
+  addOnSelections: Array<{ addOnId: string; variantId?: string; quantity?: number }>;
+  adminCustomReceiptLines: Array<{ label: string; amountInput: string; amountSign?: number }>;
+  useAdminFeAuthoritativeQuote: boolean;
+}
+
+/**
+ * Identity of a price request. This must contain user-controlled quote inputs only.
+ * Server/display-derived receipt state must never invalidate the response that produced it.
+ */
+export function buildAdminChangeQuoteRequestKey(input: AdminChangeQuoteRequestKeyInput): string {
+  const availability = input.selectedAvailability;
+  return JSON.stringify({
+    bookingReference: input.bookingReference?.trim() ?? '',
+    lastName: input.lastName.trim().toLowerCase(),
+    parentProductId: input.productId,
+    optionId: availability ? getAvailabilityOptionId(availability) : '',
+    dateTime: availability?.dateTime ?? '',
+    availabilityId: availability?.availabilityId ?? null,
+    pickupLocationId: input.pickupLocationId,
+    returnAvailabilityId: input.returnAvailabilityId,
+    quantities: input.quantities,
+    addOnSelections: input.addOnSelections,
+    adminCustomReceiptLines: input.adminCustomReceiptLines,
+    useAdminFeAuthoritativeQuote: input.useAdminFeAuthoritativeQuote,
+  });
+}

package/src/components/booking/useAdminChangeQuotePreview.ts

@@ -26,6 +26,7 @@ import {
 } from './change-booking-flow-helpers';
 import type { Currency } from './CurrencySwitcher';
 import type { AdminChangeLatestQuote } from './useAdminChangeCheckoutController';
+import { buildAdminChangeQuoteRequestKey } from './admin-change-quote-request-key';
 
 type AddOnSelection = { addOnId: string; variantId?: string; quantity?: number };
 type AdminCustomReceiptLine = { label: string; amountInput: string; amountSign?: number };
@@ -50,8 +51,6 @@ export interface UseAdminChangeQuotePreviewParams {
   quantities: Record<string, number>;
   addOnSelections: AddOnSelection[];
   adminCustomReceiptLines: AdminCustomReceiptLine[];
-  editableSummaryLineAmountInputs: Record<string, string>;
-  editableSummaryLineLabelInputs: Record<string, string>;
   useAdminFeAuthoritativeQuote: boolean;
   latestChangeQuote: AdminChangeLatestQuote | null;
   setLatestChangeQuote: Dispatch<SetStateAction<AdminChangeLatestQuote | null>>;
@@ -109,8 +108,6 @@ export function useAdminChangeQuotePreview({
   quantities,
   addOnSelections,
   adminCustomReceiptLines,
-  editableSummaryLineAmountInputs,
-  editableSummaryLineLabelInputs,
   useAdminFeAuthoritativeQuote,
   latestChangeQuote,
   setLatestChangeQuote,
@@ -154,20 +151,16 @@ export function useAdminChangeQuotePreview({
     !!lastName.trim();
 
   const isChangeQuoteBlocked = isCustomerSelfServeChange && latestChangeQuote?.canProceed === false;
-  const changeQuoteInputsKey = useMemo(() => JSON.stringify({
-    bookingReference: initialValues?.bookingReference?.trim() ?? '',
-    lastName: lastName.trim().toLowerCase(),
-    parentProductId: product.productId,
-    optionId: selectedAvailability ? getAvailabilityOptionId(selectedAvailability) : '',
-    dateTime: selectedAvailability?.dateTime ?? '',
-    availabilityId: selectedAvailability?.availabilityId ?? null,
-    pickupLocationId: pickupLocationId ?? null,
+  const changeQuoteInputsKey = useMemo(() => buildAdminChangeQuoteRequestKey({
+    bookingReference: initialValues?.bookingReference,
+    lastName,
+    productId: product.productId,
+    selectedAvailability,
+    pickupLocationId,
     returnAvailabilityId: selectedReturnOption?.returnAvailabilityId ?? null,
     quantities,
     addOnSelections,
     adminCustomReceiptLines,
-    editableSummaryLineAmountInputs,
-    editableSummaryLineLabelInputs,
     useAdminFeAuthoritativeQuote,
   }), [
     initialValues?.bookingReference,
@@ -179,8 +172,6 @@ export function useAdminChangeQuotePreview({
     quantities,
     addOnSelections,
     adminCustomReceiptLines,
-    editableSummaryLineAmountInputs,
-    editableSummaryLineLabelInputs,
     useAdminFeAuthoritativeQuote,
   ]);
   const destinationRequiresReturnSelection = Boolean(selectedAvailability?.returnOptions?.length);
@@ -432,14 +423,15 @@ export function useAdminChangeQuotePreview({
               })
             : await quoteChangeBooking(quoteRequestBase);
           if (seq !== changeQuoteRequestSeq.current) return;
-          setLatestChangeQuote(
-            sliceAndMergeChangeQuoteForUi(quote, {
+          const mergedQuote = sliceAndMergeChangeQuoteForUi(quote, {
               total: changeFlowNewBookingTotal,
               subtotal: effectiveSubtotalForCheckout,
               tax: effectiveTax,
-            }, currency).mergedQuote,
-          );
+            }, currency).mergedQuote;
+          // Commit the completed identity before publishing its result. This keeps a
+          // render caused by setLatestChangeQuote from being interpreted as a new request.
           lastCompletedQuoteInputsKeyRef.current = changeQuoteInputsKey;
+          setLatestChangeQuote(mergedQuote);
         } catch (e) {
           if (seq !== changeQuoteRequestSeq.current) return;
           setLatestChangeQuote(null);
@@ -460,34 +452,12 @@ export function useAdminChangeQuotePreview({
       window.clearTimeout(timer);
     };
   }, [
+    // Fetching is controlled by the canonical user-input identity. Do not add quote-derived
+    // totals, receipt objects, or display lines here: a response must not trigger another quote.
     isCustomerSelfServeChange,
     hasChangeSelection,
-    selectedAvailability,
-    initialValues,
-    lastName,
     missingRequiredReturnSelection,
-    pickupLocationId,
-    selectedReturnOption?.returnAvailabilityId,
-    quantities,
-    addOnSelections,
-    changeFlowInitialTicketCount,
-    changeFlowNewBookingTotal,
-    changeFlowClientEstimateDue,
-    effectiveSubtotalForCheckout,
-    effectiveTax,
-    currency,
-    adminCustomLinesAsAdditionalAdjustments,
-    adminFeAuthoritativeReceipt,
-    useAdminFeAuthoritativeQuote,
     changeQuoteInputsKey,
-    originalReceipt,
-    product.productId,
-    setChangeQuoteLoading,
-    setChangeQuoteFetchError,
-    setLatestChangeQuote,
-    lastCompletedQuoteInputsKeyRef,
-    inFlightQuoteInputsKeyRef,
-    changeQuoteRequestSeq,
   ]);
 
   return {

package/test/change-booking-helpers.test.ts

@@ -7,6 +7,7 @@ import { evaluateChangeBookingQuoteForCheckout } from '../src/components/booking
 import { buildCheckoutModalSummaryFromPricingV2Quote } from '../src/components/booking/pricing-v2-checkout-summary';
 import type { ChangeQuoteUiSlice } from '../src/lib/booking/change-flow-pricing';
 import type { ChangeBookingQuoteResponse } from '../src/lib/booking-api';
+import { buildAdminChangeQuoteRequestKey } from '../src/components/booking/admin-change-quote-request-key';
 
 function quote(overrides: Partial<ChangeBookingQuoteResponse>): ChangeBookingQuoteResponse {
   return {
@@ -35,6 +36,39 @@ function test(name: string, fn: () => void): void {
   }
 }
 
+test('admin quote response display state cannot invalidate its request identity', () => {
+  const selectedAvailability = {
+    availabilityId: 'a_1',
+    productId: 'po_1',
+    dateTime: '2026-07-22T09:35:00-06:00',
+    vacancies: 10,
+  } as Parameters<typeof buildAdminChangeQuoteRequestKey>[0]['selectedAvailability'];
+  const userInputs = {
+    bookingReference: 'BIHAYXQS',
+    lastName: 'Tauro',
+    productId: 'p_1',
+    selectedAvailability,
+    pickupLocationId: 'pickup_1',
+    returnAvailabilityId: 'return_1',
+    quantities: { ADULT: 3 },
+    addOnSelections: [],
+    adminCustomReceiptLines: [],
+    useAdminFeAuthoritativeQuote: true,
+  };
+
+  const keyBeforeResponse = buildAdminChangeQuoteRequestKey(userInputs);
+  // These are populated from the successful server quote. They are deliberately
+  // not accepted by the request-key builder and therefore cannot trigger a re-quote.
+  const serverDisplayState = {
+    editableSummaryLineAmountInputs: { adult: '173.24', tax: '16.09' },
+    editableSummaryLineLabelInputs: { adult: 'ADULT' },
+  };
+  assert.ok(serverDisplayState.editableSummaryLineAmountInputs.adult);
+  const keyAfterResponse = buildAdminChangeQuoteRequestKey(userInputs);
+
+  assert.equal(keyAfterResponse, keyBeforeResponse);
+});
+
 test('routes customer change quote to paid checkout when amount is due', () => {
   const decision = evaluateChangeBookingQuoteForCheckout({
     quote: quote({