@ticketboothapp/booking 1.2.129 → 1.2.130

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@ticketboothapp/booking",
-  "version": "1.2.129",
+  "version": "1.2.130",
   "private": false,
   "sideEffects": [
     "**/*.css",

package/src/components/booking/pricing-v2-checkout-summary.ts

@@ -48,27 +48,37 @@ function isPaymentCreditType(type?: string | null): boolean {
   return normalized === "GIFT_CARD" || normalized === "PAYMENT_CREDIT";
 }
 
-function isPaymentCreditSummaryLine(line: PriceSummaryLine): boolean {
-  return line.kind === "line" && isPaymentCreditType(line.type);
+function isPaymentCreditQuoteLine(line: PricingV2QuoteLineSnapshot): boolean {
+  return isPaymentCreditType(line.type);
 }
 
-function movePaymentCreditLinesAfterTax(lines: PriceSummaryLine[]): PriceSummaryLine[] {
-  const paymentCreditLines = lines.filter(isPaymentCreditSummaryLine);
-  if (paymentCreditLines.length === 0) return lines;
+function isPostTaxDiscountQuoteLine(line: PricingV2QuoteLineSnapshot): boolean {
+  const discountBehavior = String(line.discountBehavior ?? "").trim().toUpperCase();
+  const source = String(line.source ?? "").trim().toUpperCase();
+  return discountBehavior === "POST_TAX_DISCOUNT" || source === "VOUCHER";
+}
 
-  const nonPaymentCreditLines = lines.filter((line) => !isPaymentCreditSummaryLine(line));
-  const taxIndex = nonPaymentCreditLines.findIndex(
-    (line) => line.kind === "line" && normalizedLineType(line.type) === "TAX",
+function moveSettlementLinesAfterTax(
+  lines: PricingV2QuoteLineSnapshot[],
+): PricingV2QuoteLineSnapshot[] {
+  const settlementLines = lines.filter(
+    (line) => isPaymentCreditQuoteLine(line) || isPostTaxDiscountQuoteLine(line),
+  );
+  if (settlementLines.length === 0) return lines;
+
+  const nonSettlementLines = lines.filter(
+    (line) => !isPaymentCreditQuoteLine(line) && !isPostTaxDiscountQuoteLine(line),
   );
+  const taxIndex = nonSettlementLines.findIndex((line) => normalizedLineType(line.type) === "TAX");
 
   if (taxIndex < 0) {
-    return [...nonPaymentCreditLines, ...paymentCreditLines];
+    return [...nonSettlementLines, ...settlementLines];
   }
 
   return [
-    ...nonPaymentCreditLines.slice(0, taxIndex + 1),
-    ...paymentCreditLines,
-    ...nonPaymentCreditLines.slice(taxIndex + 1),
+    ...nonSettlementLines.slice(0, taxIndex + 1),
+    ...settlementLines,
+    ...nonSettlementLines.slice(taxIndex + 1),
   ];
 }
 
@@ -112,11 +122,10 @@ export function buildCheckoutModalSummaryFromPricingV2Quote(
   const total = pricingV2QuoteTotal(quote);
   if (total == null) return undefined;
 
-  const mappedLines =
-    quote?.lines
-      ?.map((line, index) => priceSummaryLineFromQuoteLine(line, index))
-      .filter((line): line is PriceSummaryLine => line != null) ?? [];
-  const lines = movePaymentCreditLinesAfterTax(mappedLines);
+  const quoteLines = quote?.lines ?? [];
+  const lines = moveSettlementLinesAfterTax(quoteLines)
+    .map((line, index) => priceSummaryLineFromQuoteLine(line, index))
+    .filter((line): line is PriceSummaryLine => line != null);
 
   if (lines.length === 0) return undefined;
 
@@ -156,8 +165,9 @@ export function buildCheckoutModalSummaryFromPricingV2Quote(
     0,
     finiteNumber(quote?.paymentCreditTotal) ?? 0,
   );
+  const hasPostTaxDiscount = quoteLines.some(isPostTaxDiscountQuoteLine);
   const subtotal = finiteNumber(
-    paymentCreditTotal > 0
+    paymentCreditTotal > 0 || hasPostTaxDiscount
       ? quote?.taxableSubtotal ??
           quote?.grossSubtotal ??
           quote?.netSubtotalBeforeTax ??

package/test/change-booking-helpers.test.ts

@@ -218,6 +218,59 @@ test('maps Pricing V2 gift cards as payment credits after tax', () => {
   );
 });
 
+test('maps Pricing V2 post-tax vouchers after tax with full taxable subtotal', () => {
+  const summary = buildCheckoutModalSummaryFromPricingV2Quote(
+    {
+      currency: 'CAD',
+      grossSubtotal: 629.18,
+      discountTotal: -455.11,
+      paymentCreditTotal: 0,
+      netSubtotalBeforeTax: 174.07,
+      taxableSubtotal: 629.18,
+      taxAmount: 53.48,
+      payableTotal: 227.55,
+      amountToCharge: 227.55,
+      lines: [
+        {
+          lineId: 'ticket_1',
+          type: 'TICKET',
+          label: 'ADULT',
+          amount: 581.21,
+          quantity: 3,
+        },
+        {
+          lineId: 'fee_1',
+          type: 'FEE',
+          label: 'Moraine Lake Road Access Fee',
+          amount: 47.97,
+        },
+        {
+          lineId: 'voucher_1',
+          type: 'DISCOUNT',
+          label: "Les Clefs d'Or",
+          amount: -455.11,
+          discountBehavior: 'POST_TAX_DISCOUNT',
+          source: 'VOUCHER',
+        },
+        {
+          lineId: 'tax_1',
+          type: 'TAX',
+          label: 'Taxes and fees',
+          amount: 53.48,
+        },
+      ],
+    },
+    'Rounding',
+  );
+
+  assert.equal(summary?.subtotal, 629.18);
+  assert.equal(summary?.fullTotalAmount, 227.55);
+  assert.deepEqual(
+    summary?.lines.map((line) => (line.kind === 'line' ? line.type : 'TICKET')),
+    ['TICKET', 'FEE', 'TAX', 'DISCOUNT'],
+  );
+});
+
 test('builds paid checkout modal data with trimmed customer and change totals', () => {
   const modalData = buildChangeBookingPaidCheckoutModalData({
     bookingReference: 'bookRef_ABC-123',