@tiba-spark/client-shared-lib 26.3.0-206 → 26.3.0-219

package/fesm2022/tiba-spark-client-shared-lib.mjs

@@ -123416,7 +123416,12 @@ let FacilityState = class FacilityState {
     }
     onZoneChangedAction(ctx, { zone, parkId }) {
         const selected = ctx.getState().selected;
-        const zoneIndex = selected.zones?.findIndex(item => item.id === zone.id && item.parkID === parkId);
+        // SPRK3-14984: ZoneChangedAction is a SignalR push, so it arrives regardless of
+        // whether a park is selected or its zones are loaded yet.
+        if (!selected?.zones) {
+            return;
+        }
+        const zoneIndex = selected.zones.findIndex(item => item.id === zone.id && item.parkID === parkId);
         zone.occupancy = zone.monthliesOccupancy + zone.transientsOccupancy;
         zone.vacancy = zone.capacity - zone.occupancy;
         switch (zone.rulesMode) {
@@ -123441,7 +123446,13 @@ let FacilityState = class FacilityState {
         selected.zones = clone(selected.zones);
         const facilityDictionary = ctx.getState().dictionary;
         const guid = ctx.getState().guid;
-        facilityDictionary[guid][selected.id].zones = selected.zones;
+        // SPRK3-14984 (Sentry JAVASCRIPT-ANGULAR-35): dictionary defaults to {} and is
+        // always truthy, but dictionary[guid] is undefined until the tenant is hydrated
+        // and the park may not be under it. The selected/zones slices are still correct.
+        const storedFacility = facilityDictionary[guid]?.[selected.id];
+        if (storedFacility) {
+            storedFacility.zones = selected.zones;
+        }
         ctx.patchState({
             dictionary: facilityDictionary,
             selected,
@@ -123492,9 +123503,17 @@ let FacilityState = class FacilityState {
         servicesRunningStatusDictionary[guid] = servicesRunningStatus;
         ctx.patchState({ servicesRunningStatusDictionary });
         // Updating ParkConnectionStatus for parks
-        if (facilityDictionary) {
+        // SPRK3-14836 (Sentry JAVASCRIPT-ANGULAR-1R): the old `if (facilityDictionary)`
+        // guarded the outer object, which defaults to {} and always passes, while
+        // Object.values(facilityDictionary[guid]) threw for an unhydrated tenant. The
+        // connectionStatusDictionary slice needs its own per-guid bucket for the same reason.
+        const parksForGuid = facilityDictionary?.[guid];
+        if (parksForGuid) {
             const connectionStatusDictionary = cloneDeep(ctx.getState().connectionStatusDictionary);
-            const facilities = Object.values(facilityDictionary[guid]);
+            if (!connectionStatusDictionary[guid]) {
+                connectionStatusDictionary[guid] = {};
+            }
+            const facilities = Object.values(parksForGuid);
             for (const facility of facilities) {
                 connectionStatusDictionary[guid][facility.id] = this.globalErrorService.getParkConnectionStatus(guid, facility, servicesRunningStatus, facilityDictionary);
             }
@@ -123518,6 +123537,9 @@ let FacilityState = class FacilityState {
         }
         // Updating ParkConnectionStatus for parks
         const connectionStatusDictionary = cloneDeep(ctx.getState().connectionStatusDictionary);
+        if (!connectionStatusDictionary[guid]) {
+            connectionStatusDictionary[guid] = {};
+        }
         const servicesRunningStatusDictionary = ctx.getState().servicesRunningStatusDictionary;
         const facilities = Object.values(facilityDictionary[guid]);
         for (const facility of facilities) {
@@ -123623,7 +123645,11 @@ let FacilityState = class FacilityState {
         }
     }
     onFacilityRemoteCommandExecutedAction(ctx, { facilityRemoteCommandEvent }) {
-        const facility = ctx.getState().dictionary[facilityRemoteCommandEvent.guid][facilityRemoteCommandEvent.parkId];
+        // The command-executed push can name a tenant/park this client has not loaded.
+        const facility = ctx.getState().dictionary[facilityRemoteCommandEvent.guid]?.[facilityRemoteCommandEvent.parkId];
+        if (!facility) {
+            return;
+        }
         const operationTypeKey = FacilityRemoteCommandsLocalizationKey[FacilityRemoteCommandTypes$2[facilityRemoteCommandEvent.type]];
         const config = {
             messages: [{ value: facility.name, class: NotificationClass.body }],
@@ -123654,19 +123680,36 @@ let FacilityState = class FacilityState {
         const facilityDictionary = ctx.getState().dictionary;
         const nowMoment = moment();
         if (facilitiesMap) {
-            facilitiesMap[guid].forEach(f => {
-                f.cloudId = f.cloudId = facilityDictionary[guid][f.id].cloudId;
-                f.featurePermissions = facilityDictionary[guid][f.id].featurePermissions;
-                f.permissions = facilityDictionary[guid][f.id].permissions;
-                facilityDictionary[guid][f.id] = this.updateFacilityConnectivityFlags(facilityDictionary[guid][f.id], f);
-                return facilityDictionary[guid][f.id];
+            // Same class as the SPRK3-15108 guard in the else-branch below: neither the
+            // incoming map nor the stored dictionary is guaranteed to hold this guid, and a
+            // super-park map can name a child park the dictionary has not loaded.
+            const storedParks = facilityDictionary[guid];
+            facilitiesMap[guid]?.forEach(f => {
+                const storedFacility = storedParks?.[f.id];
+                if (!storedFacility) {
+                    return;
+                }
+                f.cloudId = storedFacility.cloudId;
+                f.featurePermissions = storedFacility.featurePermissions;
+                f.permissions = storedFacility.permissions;
+                storedParks[f.id] = this.updateFacilityConnectivityFlags(storedFacility, f);
             });
         }
         else {
-            facility.cloudId = facilityDictionary[guid][facility.id].cloudId;
-            facility.featurePermissions = facilityDictionary[guid][facility.id].featurePermissions;
-            facility.permissions = facilityDictionary[guid][facility.id].permissions;
-            facilityDictionary[guid][parkId] = this.updateFacilityConnectivityFlags(facilityDictionary[guid][parkId], facility);
+            // SPRK3-15108: getFacility can resolve with an empty payload, and the dictionary may hold
+            // no entry for this guid/facility yet. Either way there is nothing to merge, and the three
+            // reads below used to throw (Sentry JAVASCRIPT-ANGULAR-3F) — the `if (facility)` guard
+            // further down was added for the same class of crash but sits after the dereference.
+            const storedFacility = facility ? facilityDictionary[guid]?.[facility.id] : null;
+            if (!storedFacility) {
+                return;
+            }
+            facility.cloudId = storedFacility.cloudId;
+            facility.featurePermissions = storedFacility.featurePermissions;
+            facility.permissions = storedFacility.permissions;
+            // The guard above validated [facility.id]; parkId can differ for a super-park
+            // child, in which case [parkId] holds nothing to merge from.
+            facilityDictionary[guid][parkId] = this.updateFacilityConnectivityFlags(facilityDictionary[guid][parkId] ?? storedFacility, facility);
         }
         // Guard: a super-park facilities map may not contain the requested parkId
         // (or the response may be empty). Skip the time-diff calc rather than
@@ -123675,7 +123718,7 @@ let FacilityState = class FacilityState {
             clientServerDiffDictionary[guid] = this.getClientServerTimeDiff(facility, nowMoment);
             this.patchDiffDictinaryToStore(ctx, clientServerDiffDictionary);
         }
-        this.patchFacilitiesToStore(ctx, facilityDictionary, facilityDictionary[guid][parkId], appModule);
+        this.patchFacilitiesToStore(ctx, facilityDictionary, facilityDictionary[guid]?.[parkId], appModule);
     }
     updateFacilityConnectivityFlags(storedFacility, incomingFacility) {
         const cloudDateTimeUtc = this.getCloudDateTimeUtc();
@@ -123688,7 +123731,7 @@ let FacilityState = class FacilityState {
         ctx.patchState({
             dictionary,
         });
-        if (appModule === AppModule$2.Cc) {
+        if (appModule === AppModule$2.Cc && facility) {
             const allowedActions = convertFeaturePermissionsToDictionary(facility.featurePermissions);
             ctx.patchState({
                 selected: facility,
@@ -123716,10 +123759,12 @@ let FacilityState = class FacilityState {
     }
     updateServiceRunningStatusFlags(currentServicesRunningStatus, newServicesRunningStatus) {
         const cloudDateTimeUtc = this.getCloudDateTimeUtc();
-        newServicesRunningStatus.smartParkDisconnectedTimestamp = newServicesRunningStatus.isSmartParkConnected ? null : currentServicesRunningStatus.smartParkDisconnectedTimestamp ?? cloudDateTimeUtc;
-        newServicesRunningStatus.smartParkCoreDisconnectedTimestamp = newServicesRunningStatus.isSmartParkCoreConnected ? null : currentServicesRunningStatus.smartParkCoreDisconnectedTimestamp ?? cloudDateTimeUtc;
-        newServicesRunningStatus.sparkCloudDisconnectedTimestamp = newServicesRunningStatus.isSparkCloudConnected ? null : currentServicesRunningStatus.sparkCloudDisconnectedTimestamp ?? cloudDateTimeUtc;
-        newServicesRunningStatus.sparkCoreDisconnectedTimestamp = newServicesRunningStatus.isSparkCoreConnected ? null : currentServicesRunningStatus.sparkCoreDisconnectedTimestamp ?? cloudDateTimeUtc;
+        // The caller passes servicesRunningStatusDictionary[guid], which is absent on the
+        // first status push for a tenant -- fall back to "disconnected as of now".
+        newServicesRunningStatus.smartParkDisconnectedTimestamp = newServicesRunningStatus.isSmartParkConnected ? null : currentServicesRunningStatus?.smartParkDisconnectedTimestamp ?? cloudDateTimeUtc;
+        newServicesRunningStatus.smartParkCoreDisconnectedTimestamp = newServicesRunningStatus.isSmartParkCoreConnected ? null : currentServicesRunningStatus?.smartParkCoreDisconnectedTimestamp ?? cloudDateTimeUtc;
+        newServicesRunningStatus.sparkCloudDisconnectedTimestamp = newServicesRunningStatus.isSparkCloudConnected ? null : currentServicesRunningStatus?.sparkCloudDisconnectedTimestamp ?? cloudDateTimeUtc;
+        newServicesRunningStatus.sparkCoreDisconnectedTimestamp = newServicesRunningStatus.isSparkCoreConnected ? null : currentServicesRunningStatus?.sparkCoreDisconnectedTimestamp ?? cloudDateTimeUtc;
         return newServicesRunningStatus;
     }
     assignFacility(storedFacility, incomingFacility) {
@@ -124699,7 +124744,14 @@ let ParkManagerState = class ParkManagerState {
                 const clonedDto = DeviceStatusDto$1.fromJS(action.deviceStatus);
                 clonedDto.type = devicesById[deviceId].type;
                 devicesById[deviceId].deviceStatus = clonedDto;
-                devicesbyCommId[commID].deviceStatus = clonedDto;
+                // SPRK3-14987 (Sentry JAVASCRIPT-ANGULAR-3A): the guard above tests byId, but
+                // this writes byCommId -- a different map, keyed by a different, optional field.
+                // byId is the primary index and both maps are rebuilt together in patchDevices,
+                // so a missing secondary entry must not cost byId its fresh status.
+                const deviceByCommId = devicesbyCommId[commID];
+                if (deviceByCommId) {
+                    deviceByCommId.deviceStatus = clonedDto;
+                }
                 ctx.patchState({
                     byId: cloneDeep(devicesById),
                     byCommId: cloneDeep(devicesbyCommId),
@@ -128370,6 +128422,11 @@ class CompanyService {
             includeSubCompanies: includeSubCompanies,
         });
         const accountsFetchMethod = this.getAccountsFetchMethod(permissionType);
+        if (!accountsFetchMethod) {
+            return of(null).pipe(tap(_ => {
+                this.loadingCompanySubject$.next(false);
+            }));
+        }
         const getCompanies$ = accountsFetchMethod(guid, parkId, searchParamsDto.maxResults, searchParamsDto.searchTerm, searchParamsDto.orderBy.column, searchParamsDto.orderBy.orderDirection, companiesFilterDto);
         return getCompanies$.pipe(tap(_ => {
             this.loadingCompanySubject$.next(false);
@@ -128389,6 +128446,11 @@ class CompanyService {
             subCompanyIds: subCompanyIds,
         });
         const subAccountsFetchMethod = this.getSubAccountsFetchMethod(permissionType);
+        if (!subAccountsFetchMethod) {
+            return of(null).pipe(tap(_ => {
+                this.loadingSubCompanySubject$.next(false);
+            }));
+        }
         getSubCompanies$ = subAccountsFetchMethod(guid, parkId, null, null, null, OrderDirection$2.None, subCompaniesWithPermissions);
         return getSubCompanies$.pipe(tap(_ => {
             this.loadingSubCompanySubject$.next(false);
@@ -128403,6 +128465,11 @@ class CompanyService {
         this.loadingSubCompanySubject$.next(true);
         let getSubCompanies$;
         const subAccountsFetchMethod = this.getSubAccountsFetchMethod(permissionType);
+        if (!subAccountsFetchMethod) {
+            return of(null).pipe(tap(_ => {
+                this.loadingSubCompanySubject$.next(false);
+            }));
+        }
         const subCompaniesFilterDto = new SubCompaniesFilterDto({
             parkId,
             companyIds,
@@ -128464,11 +128531,16 @@ class CompanyService {
             this.messageBarService.clearMessagebar('credentialWarningMessage');
         }
     }
+    // Both mappings below are partial lookups over PermissionType, so a miss is a
+    // reachable state rather than a programming error: the Reports Center binds its
+    // company dropdowns to the selected category's permission type, and the "All
+    // reports" category legitimately has none. Return undefined on a miss and let
+    // the callers degrade — see SPRK3-15029.
     getAccountsFetchMethod(permissionType) {
-        return (this.accountsFetchMethodsMapping[permissionType]).bind(this.accountRpcServiceProxy);
+        return this.accountsFetchMethodsMapping[permissionType]?.bind(this.accountRpcServiceProxy);
     }
     getSubAccountsFetchMethod(permissionType) {
-        return (this.subAccountsFetchMethodsMapping[permissionType]).bind(this.accountRpcServiceProxy);
+        return this.subAccountsFetchMethodsMapping[permissionType]?.bind(this.accountRpcServiceProxy);
     }
     static { this.ɵfac = i0.ɵɵngDeclareFactory({ minVersion: "12.0.0", version: "18.2.14", ngImport: i0, type: CompanyService, deps: [{ token: i1$2.Store }, { token: MessageBarService }, { token: i1$5.TranslateService }, { token: SmartparkService }, { token: AccountRpcServiceProxy }], target: i0.ɵɵFactoryTarget.Injectable }); }
     static { this.ɵprov = i0.ɵɵngDeclareInjectable({ minVersion: "12.0.0", version: "18.2.14", ngImport: i0, type: CompanyService }); }
@@ -134289,7 +134361,9 @@ class FacilityService {
         };
         this.hasPermissionTypesByPark = (permissionTypes, guid, parkId) => {
             const facilityDictionary = this.store.selectSnapshot(FacilityState.facilityDictionary);
-            const featurePermissions = facilityDictionary[guid][parkId].featurePermissions;
+            // SPRK3-14812: the dictionary is not hydrated for every guid/park at every point
+            // in the change-detection cycle. An unknown park grants nothing (fail closed).
+            const featurePermissions = facilityDictionary?.[guid]?.[parkId]?.featurePermissions;
             const sparkVersion = this.store.selectSnapshot(({ smartpark: { versions } }) => versions[guid]);
             return permissionTypes.reduce((acc, permissionType) => {
                 const permissionSupportVersion = PermissionTypeSupportedVersionDictionary[permissionType];
@@ -134297,7 +134371,10 @@ class FacilityService {
                     console.warn(`Permission ${permissionType} version support is missing in PermissionTypeSupportedVersionDictionary file`);
                 }
                 const isVersionSupported = isVersionGreaterThanEqual(sparkVersion, permissionSupportVersion);
-                acc[permissionType] = isVersionSupported && featurePermissions.includes(permissionType);
+                // isVersionGreaterThanEqual returns undefined (not false) for an unknown version
+                // despite its declared boolean return, which leaked undefined into a dictionary
+                // typed { [key: string]: boolean }. Coerce so the declared type holds.
+                acc[permissionType] = !!(isVersionSupported && featurePermissions?.includes(permissionType));
                 return acc;
             }, {});
         };
@@ -134306,8 +134383,11 @@ class FacilityService {
             let isVersionSupported = this.isVersionSupported(permissionType, guid);
             if (isVersionSupported) {
                 const facilityDictionary = this.store.selectSnapshot(FacilityState.facilityDictionary);
-                const featurePermissions = facilityDictionary[guid][parkId].featurePermissions;
-                hasPermission = featurePermissions?.includes(permissionType);
+                // SPRK3-14812 (Sentry JAVASCRIPT-ANGULAR-K): the optional chain sat one level too
+                // deep -- [guid] and [parkId] were both indexed unguarded. Fail closed, which is
+                // what the `hasPermission = false` initialiser above already promises callers.
+                const featurePermissions = facilityDictionary?.[guid]?.[parkId]?.featurePermissions;
+                hasPermission = !!featurePermissions?.includes(permissionType);
             }
             return hasPermission;
         };