@tianhai/pi-workflow-kit 0.8.4 → 0.10.0

package/skills/finalizing/SKILL.md

@@ -7,13 +7,29 @@ description: "Use this after all tasks are complete to clean up, document, and s
 
 Ship the completed work.
 
+## Pre-finalization checks
+
+### Check for skipped tasks
+
+Before archiving, if a progress file exists (`docs/plans/*-progress.md`), read it and check for any `⏭ skipped` tasks. If found, warn:
+
+```
+⚠️ Tasks 4 and 7 were skipped. Continue with finalizing, or go back?
+```
+
+Wait for the user to confirm before proceeding.
+
 ## Process
 
-1. **Move planning docs** — archive the design and implementation docs, then commit:
+1. **Move planning docs** — archive the design, implementation, progress docs, and ADRs (if any), then commit:
    ```
    mkdir -p docs/plans/completed
+   mkdir -p docs/plans/completed/adr
    mv docs/plans/*-design.md docs/plans/completed/
    mv docs/plans/*-implementation.md docs/plans/completed/
+   mv docs/plans/*-progress.md docs/plans/completed/
+   mv docs/plans/adr/*.md docs/plans/completed/adr/ 2>/dev/null || true
+   rmdir docs/plans/adr 2>/dev/null || true
    git add docs/plans/ && git commit -m "chore: archive planning docs"
    ```
 
@@ -30,6 +46,14 @@ Ship the completed work.
       gh pr create --title "feat: <summary>" --body "<task summary>"
       ```
 
+      Use the progress file to generate the summary. Convert the task table to a bulleted list:
+      ```
+      - ✅ Create User model
+      - ✅ Write User model tests
+      - ⏭ Add auth middleware (skipped)
+      - ✅ Add login endpoint
+      ```
+
    2. **Rebase & merge** *(recommended)* — rebase onto parent, fast-forward merge, push parent, delete branch:
       ```
       parent=$(git show-branch -a 2>/dev/null | grep '\*' | grep -v "$(git branch --show-current)" | head -1 | sed 's/.*\[\(.*\)\].*/\1/' | sed 's/[\^~].*//')
@@ -54,7 +78,7 @@ Ship the completed work.
       ```
       parent=$(git show-branch -a 2>/dev/null | grep '\*' | grep -v "$(git branch --show-current)" | head -1 | sed 's/.*\[\(.*\)\].*/\1/' | sed 's/[\^~].*//')
       git checkout "$parent" && git pull
-      git merge --no-ff -m "Merge branch '<branch>'" -
+      git checkout - && git merge --no-ff -m "Merge branch '<branch>'" -
       git push origin "$parent"
       git branch -d - && git push origin --delete -
       ```

package/skills/writing-plans/SKILL.md

@@ -22,6 +22,47 @@ Each task should be 2-5 minutes of work:
 - `git commit` after each task
 - Optional `checkpoint: test` or `checkpoint: done` label
 
+Each task must use a numbered heading:
+
+```markdown
+## Task N: <description>
+
+<!-- tdd: new-feature -->
+<!-- checkpoint: none -->
+```
+
+...where N starts at 1 and incrementally numbers each task in the plan.
+
+The metadata comments (placed right after the heading) are optional but recommended. If present, they help the executing-tasks skill parse the plan correctly.
+
+Valid TDD values: `new-feature`, `modifying-tested-code`, `trivial`
+
+Valid checkpoint values: `none`, `test`, `done`
+
+These comments are optional — if omitted, the agent infers TDD scenario and checkpoint from context.
+
+Also use the `<!-- tdd: ... -->` and `<!-- checkpoint: ... -->` metadata comments to specify options explicitly. The inline `checkpoint: test` / `checkpoint: done` label format (e.g. in a task list) is also supported as a fallback, but the metadata comment is the canonical source.
+
+
+## Vertical slices
+
+Each task should be a **vertical slice** — a thin path through ALL relevant layers end-to-end, delivering one complete piece of observable behavior.
+
+```
+WRONG (horizontal):
+  Task 1: Create database schema for users
+  Task 2: Write user API endpoints
+  Task 3: Build user UI components
+  Task 4: Wire everything together
+
+RIGHT (vertical):
+  Task 1: User can sign up (model + endpoint + validation + test)
+  Task 2: User can log in (auth check + token + test)
+  Task 3: User can view profile (query + endpoint + test)
+```
+
+Vertical slices ensure every committed task leaves the codebase in a testable state and reduces the blast radius of a bad task.
+
 ## TDD in the plan
 
 Label each task with its TDD scenario: