@tianhai/pi-workflow-kit 0.4.1 → 0.5.1

package/extensions/workflow-monitor.ts

@@ -8,14 +8,12 @@
  * - Register workflow_reference tool for on-demand reference content
  */
 
-import * as fs from "node:fs";
 import * as path from "node:path";
 import { StringEnum } from "@mariozechner/pi-ai";
 import type { ExtensionAPI, ExtensionContext } from "@mariozechner/pi-coding-agent";
 import { Text } from "@mariozechner/pi-tui";
 import { Type } from "@sinclair/typebox";
-import { PLAN_TRACKER_TOOL_NAME } from "./constants.js";
-import { log } from "./lib/logging.js";
+import { PLAN_TRACKER_CLEARED_TYPE, PLAN_TRACKER_TOOL_NAME } from "./constants.js";
 import type { PlanTrackerDetails } from "./plan-tracker.js";
 import { getCurrentGitRef } from "./workflow-monitor/git";
 import { loadReference, REFERENCE_TOPICS } from "./workflow-monitor/reference-tool";
@@ -27,7 +25,16 @@ import {
   getTddViolationWarning,
   getVerificationViolationWarning,
 } from "./workflow-monitor/warnings";
-import { createWorkflowHandler, type Violation, type WorkflowHandler } from "./workflow-monitor/workflow-handler";
+import {
+  createWorkflowHandler,
+  DEBUG_DEFAULTS,
+  TDD_DEFAULTS,
+  VERIFICATION_DEFAULTS,
+  type Violation,
+  type WorkflowHandler,
+} from "./workflow-monitor/workflow-handler";
+import { getWorkflowNextCompletions } from "./workflow-monitor/workflow-next-completions";
+import { deriveWorkflowHandoffState, validateNextWorkflowPhase } from "./workflow-monitor/workflow-next-state";
 import {
   computeBoundaryToPrompt,
   type Phase,
@@ -55,64 +62,32 @@ async function selectValue<T extends string>(
 
 const SUPERPOWERS_STATE_ENTRY_TYPE = "superpowers_state";
 
-export function getStateFilePath(): string {
-  return path.join(process.cwd(), ".pi", "superpowers-state.json");
-}
-
-export function reconstructState(ctx: ExtensionContext, handler: WorkflowHandler, stateFilePath?: string | false) {
+export function reconstructState(ctx: ExtensionContext, handler: WorkflowHandler) {
   handler.resetState();
 
-  // Read both file-based and session-based state, then pick the newer one.
-  let fileData: (Record<string, unknown> & { savedAt?: number }) | null = null;
-  let sessionData: (Record<string, unknown> & { savedAt?: number }) | null = null;
-
-  if (stateFilePath !== false) {
-    try {
-      const statePath = stateFilePath ?? getStateFilePath();
-      if (fs.existsSync(statePath)) {
-        const raw = fs.readFileSync(statePath, "utf-8");
-        fileData = JSON.parse(raw);
-      }
-    } catch (err) {
-      log.warn(
-        `Failed to read state file, falling back to session entries: ${err instanceof Error ? err.message : err}`,
-      );
-    }
-  }
-
-  // Scan session branch for most recent superpowers state entry
+  // Scan session branch for most recent superpowers state entry.
+  // The session branch IS the single source of truth — no file-based
+  // persistence needed since pi's journal survives restarts and reloads.
   const entries = ctx.sessionManager.getBranch();
   for (let i = entries.length - 1; i >= 0; i--) {
     const entry = entries[i];
     // biome-ignore lint/suspicious/noExplicitAny: pi SDK session entry type
     if (entry.type === "custom" && (entry as any).customType === SUPERPOWERS_STATE_ENTRY_TYPE) {
       // biome-ignore lint/suspicious/noExplicitAny: pi SDK session entry type
-      sessionData = (entry as any).data;
-      break;
+      handler.setFullState((entry as any).data);
+      return;
     }
     // Migration fallback: old-format workflow-only entries
     // biome-ignore lint/suspicious/noExplicitAny: pi SDK session entry type
     if (entry.type === "custom" && (entry as any).customType === WORKFLOW_TRACKER_ENTRY_TYPE) {
       // biome-ignore lint/suspicious/noExplicitAny: pi SDK session entry type
-      sessionData = { workflow: (entry as any).data };
-      break;
+      handler.setFullState({ workflow: (entry as any).data });
+      return;
     }
   }
 
-  // Pick the newer source when both are available; otherwise use whichever exists.
-  if (fileData && sessionData) {
-    const fileSavedAt = fileData.savedAt ?? 0;
-    const sessionSavedAt = sessionData.savedAt ?? 0;
-    const winner = fileSavedAt >= sessionSavedAt ? fileData : sessionData;
-    handler.setFullState(winner);
-  } else if (fileData) {
-    handler.setFullState(fileData);
-  } else if (sessionData) {
-    handler.setFullState(sessionData);
-  } else {
-    // No entries found — reset to fresh defaults
-    handler.setFullState({});
-  }
+  // No entries found — reset to fresh defaults
+  handler.setFullState({});
 }
 
 export default function (pi: ExtensionAPI) {
@@ -123,10 +98,9 @@ export default function (pi: ExtensionAPI) {
   const pendingViolations = new Map<string, Violation>();
   const pendingVerificationViolations = new Map<string, VerificationViolation>();
   const pendingBranchGates = new Map<string, string>();
-  const pendingProcessWarnings = new Map<string, string>();
 
-  type ViolationBucket = "process" | "practice";
-  const strikes: Record<ViolationBucket, number> = { process: 0, practice: 0 };
+  type ViolationBucket = "practice";
+  const strikes: Record<ViolationBucket, number> = { practice: 0 };
   const sessionAllowed: Partial<Record<ViolationBucket, boolean>> = {};
 
   async function maybeEscalate(bucket: ViolationBucket, ctx: ExtensionContext): Promise<"allow" | "block"> {
@@ -160,14 +134,6 @@ export default function (pi: ExtensionAPI) {
   const persistState = () => {
     const stateWithTimestamp = { ...handler.getFullState(), savedAt: Date.now() };
     pi.appendEntry(SUPERPOWERS_STATE_ENTRY_TYPE, stateWithTimestamp);
-    // Also persist to file for cross-session survival
-    try {
-      const statePath = getStateFilePath();
-      fs.mkdirSync(path.dirname(statePath), { recursive: true });
-      fs.writeFileSync(statePath, JSON.stringify(stateWithTimestamp, null, 2));
-    } catch (err) {
-      log.warn(`Failed to persist state file: ${err instanceof Error ? err.message : err}`);
-    }
   };
 
   const phaseToSkill: Record<string, string> = {
@@ -210,10 +176,7 @@ export default function (pi: ExtensionAPI) {
     pendingViolations.clear();
     pendingVerificationViolations.clear();
     pendingBranchGates.clear();
-    pendingProcessWarnings.clear();
-    strikes.process = 0;
     strikes.practice = 0;
-    delete sessionAllowed.process;
     delete sessionAllowed.practice;
     branchNoticeShown = false;
     branchConfirmed = false;
@@ -494,16 +457,13 @@ export default function (pi: ExtensionAPI) {
         const isPlansWrite = resolved.startsWith(plansRoot);
 
         if (isThinkingPhase && !isPlansWrite) {
-          const escalation = await maybeEscalate("process", ctx);
-          if (escalation === "block") {
-            return { blocked: true };
-          }
-
-          pendingProcessWarnings.set(
-            toolCallId,
-            `⚠️ PROCESS VIOLATION: Wrote ${filePath} during ${phase} phase.\n` +
-              "During brainstorming/planning you may only write to docs/plans/. Stop and return to docs/plans/ or advance workflow phases intentionally.",
-          );
+          return {
+            blocked: true,
+            reason:
+              `⚠️ PROCESS VIOLATION: Wrote ${filePath} during ${phase} phase.\n` +
+              "During brainstorming/planning you may only write to docs/plans/. " +
+              "Read code and docs to understand the problem, then discuss the design before implementing.",
+          };
         }
 
         changed = handler.handleFileWritten(filePath) || changed;
@@ -595,12 +555,6 @@ export default function (pi: ExtensionAPI) {
         }
       }
       pendingViolations.delete(toolCallId);
-
-      const processWarning = pendingProcessWarnings.get(toolCallId);
-      if (processWarning) {
-        injected.push(processWarning);
-      }
-      pendingProcessWarnings.delete(toolCallId);
     }
 
     // Handle bash results (test runs, commits, investigation)
@@ -802,6 +756,8 @@ export default function (pi: ExtensionAPI) {
     description: "Reset workflow tracker to fresh state for a new task",
     async handler(_args, ctx) {
       handler.resetState();
+      // Emit a clear signal so plan-tracker also reconstructs to empty.
+      pi.appendEntry(PLAN_TRACKER_CLEARED_TYPE, { clearedAt: Date.now() });
       persistState();
       updateWidget(ctx);
       if (ctx.hasUI) {
@@ -812,6 +768,7 @@ export default function (pi: ExtensionAPI) {
 
   pi.registerCommand("workflow-next", {
     description: "Start a fresh session for the next workflow phase (optionally referencing an artifact path)",
+    getArgumentCompletions: getWorkflowNextCompletions,
     async handler(args, ctx) {
       if (!ctx.hasUI) {
         ctx.ui.notify("workflow-next requires interactive mode", "error");
@@ -828,8 +785,38 @@ export default function (pi: ExtensionAPI) {
         return;
       }
 
+      // Validate handoff against current workflow state
+      const currentWorkflowState = handler.getWorkflowState();
+      if (currentWorkflowState?.currentPhase) {
+        const validationError = validateNextWorkflowPhase(currentWorkflowState, phase as Phase);
+        if (validationError) {
+          ctx.ui.notify(validationError, "error");
+          return;
+        }
+      }
+
+      // Derive handoff state for session seeding
+      const derivedWorkflow = currentWorkflowState
+        ? deriveWorkflowHandoffState(currentWorkflowState, phase as Phase)
+        : undefined;
+
       const parentSession = ctx.sessionManager.getSessionFile();
-      const res = await ctx.newSession({ parentSession });
+      const res = await ctx.newSession({
+        parentSession,
+        setup: derivedWorkflow
+          ? async (sm) => {
+              const fullState = handler.getFullState();
+              sm.appendCustomEntry(SUPERPOWERS_STATE_ENTRY_TYPE, {
+                ...fullState,
+                workflow: derivedWorkflow,
+                tdd: { ...TDD_DEFAULTS, testFiles: [], sourceFiles: [] },
+                debug: { ...DEBUG_DEFAULTS },
+                verification: { ...VERIFICATION_DEFAULTS },
+                savedAt: Date.now(),
+              });
+            }
+          : undefined,
+      });
       if (res.cancelled) return;
 
       const lines: string[] = [];

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@tianhai/pi-workflow-kit",
-  "version": "0.4.1",
+  "version": "0.5.1",
   "description": "Workflow skills and enforcement extensions for pi",
   "keywords": [
     "pi-package"