@tiagojct/subsub 0.12.1 → 0.13.1

package/CHANGELOG.md

@@ -1,8 +1,14 @@
 # Changes
 
-Sub-Sub follows the version numbers of npm: a change in the second number (0.12) can change how you use it; a change in the third (0.12.1) only fixes. Until the pilot results are in, new versions are fixes only, apart from changes that the pilot asks for.
+Sub-Sub follows the version numbers of npm: a change in the second number (0.13) adds features or changes how you use it; a change in the third (0.13.1) only fixes.
 
-## 0.12.1 (2026-10-07)
+## 0.13.1 (2026-10-07)
+
+- A change that would change nothing (for example, citekeys for items that already have one) is no longer offered for approval. Sub-Sub says why instead.
+
+## 0.13.0 (2026-10-07)
+
+The same changes were published first as 0.12.1.
 
 Files and notes without a parent item (Zotero server 0.5.5):
 

package/dist/preview.js

@@ -196,6 +196,23 @@ export function formatPreview(tool, preview, lang = "en") {
         lines.push(s(p, 1500));
     return lines.join("\n");
 }
+/**
+ * True when a preview has nothing to apply: every count it gives is zero and it creates,
+ * writes or undoes nothing. Such a change is not offered for approval.
+ */
+export function isEmptyPreview(preview) {
+    if (!preview || typeof preview !== "object")
+        return false;
+    const p = preview;
+    const counts = ["would_import", "would_attach", "would_set_parent"].filter((k) => Array.isArray(p[k]));
+    if (typeof p.would_change !== "number" && !counts.length)
+        return false;
+    if (typeof p.would_change === "number" && p.would_change > 0)
+        return false;
+    if (counts.some((k) => p[k].length > 0))
+        return false;
+    return !["would_create", "undoing", "summary", "note_preview"].some((k) => p[k]);
+}
 export function describeArgs(input) {
     return Object.entries(input)
         .map(([k, v]) => `${k}: ${s(v, 120)}`)

package/dist/subsub.js

@@ -24,7 +24,7 @@ import { profileList, profileSpec, promptBlocked } from "./profiles.js";
 import { coerceArgs, loosenArrays, resolvePathArgs } from "./args.js";
 import { applyEdits, checkLiteratureNote } from "./notes.js";
 import { buildPolicy, isSecret, judgePath, normalizeToolPath, realish, within } from "./paths.js";
-import { describeArgs, formatPreview } from "./preview.js";
+import { describeArgs, formatPreview, isEmptyPreview } from "./preview.js";
 import { perMinuteWait, providerTrouble, TROUBLE_TEXT, TROUBLE_TEXT_PT } from "./keys.js";
 import { headerLines, paintPreview, QUOTES, schemeFromAnsi, themeName } from "./look.js";
 import { systemAddition } from "./prompt.js";
@@ -442,6 +442,12 @@ export async function createSubsub(pi, deps = {}) {
         }
         if (preview.isError)
             return { block: true, reason: preview.text };
+        if (isEmptyPreview(preview.data)) {
+            return {
+                block: true,
+                reason: `Nothing to apply: the preview changes no item, so ${user} was not asked. Tell ${user} why in plain words; do not call ${name} again with the same input. Preview: ${JSON.stringify(preview.data).slice(0, 2000)}`,
+            };
+        }
         const title = L(`Sub-Sub: apply ${name.replace(/^(zotero|scholar)_/, "")}?`, `Sub-Sub: aplicar ${name.replace(/^(zotero|scholar)_/, "")}?`);
         let shown = formatPreview(name, preview.data ?? preview.text, lang);
         // The dialog may stay open for minutes. Before applying, compute the preview again: if the

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@tiagojct/subsub",
-  "version": "0.12.1",
+  "version": "0.13.1",
   "description": "Sub-Sub: a research assistant that works from your own Zotero library, in the browser or the terminal, built on pi",
   "type": "module",
   "license": "MIT",

package/src/preview.ts

@@ -207,6 +207,20 @@ export function formatPreview(tool: string, preview: unknown, lang: Lang = "en")
 	return lines.join("\n");
 }
 
+/**
+ * True when a preview has nothing to apply: every count it gives is zero and it creates,
+ * writes or undoes nothing. Such a change is not offered for approval.
+ */
+export function isEmptyPreview(preview: unknown): boolean {
+	if (!preview || typeof preview !== "object") return false;
+	const p = preview as Obj;
+	const counts = ["would_import", "would_attach", "would_set_parent"].filter((k) => Array.isArray(p[k]));
+	if (typeof p.would_change !== "number" && !counts.length) return false;
+	if (typeof p.would_change === "number" && p.would_change > 0) return false;
+	if (counts.some((k) => (p[k] as unknown[]).length > 0)) return false;
+	return !["would_create", "undoing", "summary", "note_preview"].some((k) => p[k]);
+}
+
 export function describeArgs(input: Record<string, unknown>): string {
 	return Object.entries(input)
 		.map(([k, v]) => `${k}: ${s(v, 120)}`)

package/src/subsub.ts

@@ -41,7 +41,7 @@ import { profileList, profileSpec, promptBlocked } from "./profiles.ts";
 import { coerceArgs, loosenArrays, resolvePathArgs } from "./args.ts";
 import { applyEdits, checkLiteratureNote } from "./notes.ts";
 import { buildPolicy, isSecret, judgePath, normalizeToolPath, realish, within } from "./paths.ts";
-import { describeArgs, formatPreview } from "./preview.ts";
+import { describeArgs, formatPreview, isEmptyPreview } from "./preview.ts";
 import { perMinuteWait, providerTrouble, TROUBLE_TEXT, TROUBLE_TEXT_PT } from "./keys.ts";
 import { headerLines, type LibraryState, paintPreview, QUOTES, type Scheme, schemeFromAnsi, themeName } from "./look.ts";
 import { systemAddition } from "./prompt.ts";
@@ -459,6 +459,12 @@ export async function createSubsub(pi: ExtensionAPI, deps: SubsubDeps = {}): Pro
 			return { block: true, reason: `Preview failed: ${(err as Error).message}` };
 		}
 		if (preview.isError) return { block: true, reason: preview.text };
+		if (isEmptyPreview(preview.data)) {
+			return {
+				block: true,
+				reason: `Nothing to apply: the preview changes no item, so ${user} was not asked. Tell ${user} why in plain words; do not call ${name} again with the same input. Preview: ${JSON.stringify(preview.data).slice(0, 2000)}`,
+			};
+		}
 		const title = L(`Sub-Sub: apply ${name.replace(/^(zotero|scholar)_/, "")}?`, `Sub-Sub: aplicar ${name.replace(/^(zotero|scholar)_/, "")}?`);
 		let shown = formatPreview(name, preview.data ?? preview.text, lang);
 		// The dialog may stay open for minutes. Before applying, compute the preview again: if the