@thzero/library_server 0.13.32 → 0.14.1

package/middleware/authentication.js

@@ -37,7 +37,7 @@ const authentication = (required) => {
 				const service = injector.getService(LibraryConstants.InjectorKeys.SERVICE_AUTH);
 				const results = await service.verifyToken(ctx.correlationId, token);
 				logger.debug('middleware', 'authentication', 'results', results, ctx.correlationId);
-				if (!results || !results.success) {
+				if (this._hasFailed(results)) {
 					logger.warn('middleware', 'authentication', 'Unauthenticated... invalid token', null, ctx.correlationId);
 					ctx.throw(401);
 					return;

package/package.json

@@ -1,10 +1,10 @@
 {
   "name": "@thzero/library_server",
-  "version": "0.13.32",
+  "version": "0.14.1",
   "version_major": 0,
-  "version_minor": 13,
-  "version_patch": 32,
-  "version_date": "09/01/2021",
+  "version_minor": 14,
+  "version_patch": 1,
+  "version_date": "10/02/2021",
   "description": "An opinionated library of common functionality to bootstrap a Koa based API application using MongoDb and Firebase.",
   "author": "thZero",
   "license": "MIT",
@@ -30,30 +30,30 @@
     "@koa/router": "^10.1.1",
     "async-mutex": "^0.3.2",
     "config": "^3.3.6",
-    "dayjs": "^1.10.6",
+    "dayjs": "^1.10.7",
     "dayjs-plugin-utc": "^0.1.2",
     "easy-rbac": "^3.1.1",
     "esm": "^3.2.25",
     "internal-ip": "^6.2.0",
-    "koa": "^2.13.1",
+    "koa": "^2.13.3",
     "koa-body": "^4.2.0",
     "koa-helmet": "^6.1.0",
     "koa-static": "^5.0.0"
   },
   "devDependencies": {
-    "@thzero/library_cli": "^0.13.17"
+    "@thzero/library_cli": "^0.13.19"
   },
   "peerDependencies": {
-    "@thzero/library_common": "^0.13",
-    "@thzero/library_common_service": "^0.13",
-    "@babel/core": "^7.15.0",
+    "@thzero/library_common": "^0.14",
+    "@thzero/library_common_service": "^0.14",
+    "@babel/core": "^7.15.5",
     "@babel/plugin-proposal-class-properties": "^7.14.5",
-    "@babel/preset-env": "^7.15.0",
+    "@babel/preset-env": "^7.15.6",
     "babel-loader": "^8.2.2",
     "eslint": "^7.32.0",
     "eslint-plugin-node": "^11.1.0",
-    "pino-pretty": "^6.0.0",
-    "webpack": "^5.51.1",
+    "pino-pretty": "^7.0.1",
+    "webpack": "^5.56.0",
     "webpack-cli": "^4.8.0"
   }
 }

package/repository/index.js

@@ -124,9 +124,7 @@ class Repository {
 	}
 
 	_successResponse(value, correlationId) {
-		const response = Response.success(correlationId);
-		response.results = value;
-		return response;
+		return Response.success(correlationId, value);
 	}
 
 	_warn(clazz, method, message, err, code, errors, correlationId) {

package/service/admin/index.js

@@ -10,12 +10,12 @@ class BaseAdminService extends Service {
 			return this._error('BaseAdminService', 'create', null, null, null, null, correlationId);
 
 		const validationResponse = this._validateUser(correlationId, user);
-		if (!validationResponse.success)
+		if (this._hasFailed(validationResponse))
 			return validationResponse;
 
 		this._logger.debug('BaseAdminService', 'create', 'requestedValue', requestedValue, correlationId);
 		const validationCheckValueResponse = this._validateCreate(correlationId, requestedValue);
-		if (!validationCheckValueResponse.success)
+		if (this._hasFailed(validationCheckValueResponse))
 			return validationCheckValueResponse;
 
 		const respositoryResponse = await this._repository.create(correlationId, user.id, requestedValue);
@@ -27,7 +27,7 @@ class BaseAdminService extends Service {
 			return this._error('BaseAdminService', 'delete', null, null, null, null, correlationId);
 
 		const validationCheckIdResponse = this._serviceValidation.check(correlationId, this._serviceValidation.idSchema, id, null, this._validationCheckKey);
-		if (!validationCheckIdResponse.success)
+		if (this._hasFailed(validationCheckIdResponse))
 			return validationCheckIdResponse;
 
 		const respositoryResponse = await this._repository.delete(correlationId, id);
@@ -36,7 +36,7 @@ class BaseAdminService extends Service {
 
 	async search(correlationId, user, params) {
 		const validationCheckParamsResponse = this._validateSearch(correlationId, params);
-		if (!validationCheckParamsResponse.success)
+		if (this._hasFailed(validationCheckParamsResponse))
 			return validationCheckParamsResponse;
 
 		const respositoryResponse = await this._repository.search(correlationId, params);
@@ -48,25 +48,25 @@ class BaseAdminService extends Service {
 			return this._error('BaseAdminService', 'update', 'requestedValue', null, null, null, correlationId);
 
 		const validationResponse = this._validateUser(correlationId, user);
-		if (!validationResponse.success)
+		if (this._hasFailed(validationResponse))
 			return validationResponse;
 
 		const validationIdResponse = this._validateId(correlationId, id, this._validationCheckKey);
-		if (!validationIdResponse.success)
+		if (this._hasFailed(validationIdResponse))
 			return validationIdResponse;
 
 		this._logger.debug('BaseAdminService', 'update', 'requestedValue', requestedValue, correlationId);
 		const validationCheckValueUpdateResponse = this._validateUpdate(correlationId, requestedValue);
-		if (!validationCheckValueUpdateResponse.success)
+		if (this._hasFailed(validationCheckValueUpdateResponse))
 			return validationCheckValueUpdateResponse;
 
 		let value = this._initializeData();
 		const fetchRespositoryResponse = await this._repository.fetch(correlationId, id);
-		if (fetchRespositoryResponse.success && fetchRespositoryResponse.results)
+		if (this._hasSucceeded(fetchRespositoryResponse) && fetchRespositoryResponse.results)
 			value = Utility.map(this._initializeData(), fetchRespositoryResponse.results, true);
 
 		const validResponse = this._checkUpdatedTimestamp(correlationId, value, requestedValue, 'value');
-		if (!validResponse.success)
+		if (this._hasFailed(validResponse))
 			return validResponse;
 
 		value.map(requestedValue);

package/service/admin/users.js

@@ -28,15 +28,15 @@ class BaseUsersAdminService extends BaseAdminService {
 			return this._error('BaseUsersAdminService', 'delete', null, null, null, null, correlationId);
 
 		const validationCheckIdResponse = this._serviceValidation.check(correlationId, this._serviceValidation.idSchema, id, null, this._validationCheckKey);
-		if (!validationCheckIdResponse.success)
+		if (this._hasFailed(validationCheckIdResponse))
 			return validationCheckIdResponse;
 
 		const fetchResponse = await this._serviceUser.fetch(correlationId, id);
-		if (!fetchResponse.success)
+		if (this._hasFailed(fetchResponse))
 			return fetchResponse;
 
 		const response = await this._serviceAuth.deleteUser(correlationId, id);
-		if (!response.success)
+		if (this._hasFailed(response))
 			return response;
 
 		const respositoryResponse = await this._repository.delete(correlationId, id);
@@ -45,31 +45,31 @@ class BaseUsersAdminService extends BaseAdminService {
 
 	async update(correlationId, user, id, requestedUser) {
 		const validationResponse = this._validateUser(correlationId, user);
-		if (!validationResponse.success)
+		if (this._hasFailed(validationResponse))
 			return validationResponse;
 
 		const validationIdResponse = this._validateId(correlationId, id, 'adminUsers');
-		if (!validationIdResponse.success)
+		if (this._hasFailed(validationIdResponse))
 			return validationIdResponse;
 
 		this._logger.debug('BaseUsersAdminService', 'update', 'requestedUser', requestedUser, correlationId);
 		const validationCheckUsersUpdateResponse = this._serviceValidation.check(correlationId, this._serviceValidation.userUpdateSchema, requestedUser, null, this._validationCheckKey);
-		if (!validationCheckUsersUpdateResponse.success)
+		if (this._hasFailed(validationCheckUsersUpdateResponse))
 			return validationCheckUsersUpdateResponse;
 
 		let userExisting = this._initializeData();
 		const fetchRespositoryResponse = await this._repository.fetch(correlationId, id);
-		if (fetchRespositoryResponse.success && fetchRespositoryResponse.results)
+		if (this._hasSuceeded(fetchRespositoryResponse) && fetchRespositoryResponse.results)
 			userExisting = Utility.map(this._initializeData(), fetchRespositoryResponse.results, true);
 
 		const validResponse = this._checkUpdatedTimestamp(correlationId, userExisting, requestedUser, 'users');
-		if (!validResponse.success)
+		if (this._hasFailed(validResponse))
 			return validResponse;
 
 		userExisting.map(requestedUser);
 
 		const respositoryResponse = await this._repository.update(correlationId, user.id, userExisting);
-		if (!respositoryResponse.success)
+		if (this._hasFailed(respositoryResponse))
 			return respositoryResponse;
 
 		if (!user.external && !user.external.id)

package/service/baseUser.js

@@ -5,7 +5,7 @@ import NotImplementedError from '@thzero/library_common/errors/notImplemented';
 class BaseUserService extends Service {
 	async fetch(correlationId, userId) {
 		const validationCheckExternalIdResponse = this._serviceValidation.check(correlationId, this._serviceValidation.externalIdSchema, userId);
-		if (!validationCheckExternalIdResponse.success)
+		if (this._hasFailed(validationCheckExternalIdResponse))
 			return validationCheckExternalIdResponse;
 
 		const respositoryResponse = await this._repositoryUser.fetch(correlationId, userId);
@@ -14,7 +14,7 @@ class BaseUserService extends Service {
 
 	async fetchByExternalId(correlationId, externalUserId) {
 		const validationCheckExternalIdResponse = this._serviceValidation.check(correlationId, this._serviceValidation.externalIdSchema, externalUserId);
-		if (!validationCheckExternalIdResponse.success)
+		if (this._hasFailed(validationCheckExternalIdResponse))
 			return validationCheckExternalIdResponse;
 
 		const respositoryResponse = await this._repositoryUser.fetchByExternalId(correlationId, externalUserId);
@@ -23,7 +23,7 @@ class BaseUserService extends Service {
 
 	async fetchByGamerId(correlationId, requestedGamerId) {
 		const validationRequestedGamerIdResponse = this._serviceValidation.check(correlationId, this._serviceValidation.gamerIdSchema, requestedGamerId);
-		if (!validationRequestedGamerIdResponse.success)
+		if (this._hasFailed(validationRequestedGamerIdResponse))
 			return validationRequestedGamerIdResponse;
 
 		const respositoryResponse = await this._repositoryUser.fetchByGamerId(correlationId, requestedGamerId);
@@ -32,7 +32,7 @@ class BaseUserService extends Service {
 
 	async fetchByGamerTag(correlationId, requestedUserGamerTag) {
 		const validationRequestedGamerTagResponse = this._serviceValidation.check(correlationId, this._serviceValidation.gamerTagSchema, requestedUserGamerTag);
-		if (!validationRequestedGamerTagResponse.success)
+		if (this._hasFailed(validationRequestedGamerTagResponse))
 			return validationRequestedGamerTagResponse;
 
 		const respositoryResponse = await this._repositoryUser.fetchByGamerTag(correlationId, requestedUserGamerTag);
@@ -41,7 +41,7 @@ class BaseUserService extends Service {
 
 	async refreshSettings(correlationId, params) {
 		const validationCheckExternalIdResponse = this._serviceValidation.check(correlationId, this._serviceValidation.settingsRefreshSchema, params);
-		if (!validationCheckExternalIdResponse.success)
+		if (this._hasFailed(validationCheckExternalIdResponse))
 			return validationCheckExternalIdResponse;
 
 		const respositoryResponse = await this._repositoryUser.refreshSettings(correlationId, params.userId);
@@ -50,11 +50,11 @@ class BaseUserService extends Service {
 
 	async update(correlationId, externalUser) {
 		const validationCheckExternalUserResponse = this._serviceValidation.check(correlationId, this._serviceValidation.externalUserSchema, externalUser);
-		if (!validationCheckExternalUserResponse.success)
+		if (this._hasFailed(validationCheckExternalUserResponse))
 			return validationCheckExternalUserResponse;
 
 		const respositoryResponse = await this._repositoryUser.fetchByExternalId(correlationId, externalUser.id, true);
-		if (!respositoryResponse)
+		if (this._hasFailed(respositoryResponse))
 			return respositoryResponse;
 
 		let user = respositoryResponse.results;
@@ -80,15 +80,15 @@ class BaseUserService extends Service {
 
 	async updateSettings(correlationId, requestedSettings) {
 		const validationCheckSettingsResponse = this._serviceValidation.check(correlationId, this._serviceValidation.settingRequestSchema(), requestedSettings);
-		if (!validationCheckSettingsResponse.success)
+		if (this._hasFailed(validationCheckSettingsResponse))
 			return validationCheckSettingsResponse;
 
 		const validationSettingsResponse = await this._updateSettingsValidation(correlationId, requestedSettings);
-		if (!validationSettingsResponse.success)
+		if (this._hasFailed(validationSettingsResponse))
 			return validationSettingsResponse;
 
 		const updateSettingsResponse = await this._updateSettings(correlationId, requestedSettings);
-		if (!updateSettingsResponse.success)
+		if (this._hasFailed(updateSettingsResponse))
 			return updateSettingsResponse;
 
 		const respositoryResponse = await this._repositoryUser.updateSettings(correlationId, requestedSettings.userId, requestedSettings.settings);

package/service/news/base.js

@@ -29,7 +29,7 @@ class BaseNewsService extends Service {
 			return validationCheckNewsTiemstampResponse;
 
 		const respositoryResponse = await this._repositoryNews.latest(correlationId, timestamp);
-		if (!respositoryResponse.success)
+		if (this._hasFailed(respositoryResponse))
 			return respositoryResponse;
 
 		let data = respositoryResponse.results.data;