@threlte/xr 1.5.0 → 1.5.2

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
@@ -11,6 +11,17 @@ export const injectPointerControlsPlugin = () => {
11
11
  if (!hasEventHandlers)
12
12
  return;
13
13
  const { addInteractiveObject, removeInteractiveObject } = usePointerControls();
14
+ $effect.pre(() => {
15
+ const ref = args.ref;
16
+ const props = args.props;
17
+ const hasEventHandlers = events.some((eventName) => typeof props[eventName] === 'function');
18
+ if (!hasEventHandlers)
19
+ return;
20
+ addInteractiveObject(ref, props);
21
+ return () => {
22
+ removeInteractiveObject(ref);
23
+ };
24
+ });
14
25
  observe.pre(() => [args.ref], ([ref]) => {
15
26
  addInteractiveObject(ref, args.props);
16
27
  return () => removeInteractiveObject(ref);
@@ -6,7 +6,7 @@ import { useHand } from '../../hooks/useHand.svelte.js';
6
6
  import { useFixed } from '../../internal/useFixed.js';
7
7
  import { isPresenting, pointerIntersection } from '../../internal/state.svelte.js';
8
8
  const getIntersectionId = (intersection) => {
9
- return `${(intersection.eventObject || intersection.object).uuid}/${intersection.index}${intersection.instanceId ?? ''}`;
9
+ return `${(intersection.eventObject || intersection.object).uuid}|${intersection.index}|${intersection.instanceId}`;
10
10
  };
11
11
  const EPSILON = 0.0001;
12
12
  export const setupPointerControls = (context, handContext, fixedStep = 1 / 40) => {
@@ -37,31 +37,56 @@ export const setupPointerControls = (context, handContext, fixedStep = 1 / 40) =
37
37
  handleEvent('onclick', event);
38
38
  };
39
39
  function cancelPointer(intersections) {
40
- for (const [, hoveredObj] of handContext.hovered) {
41
- // When no objects were hit or the the hovered object wasn't found underneath the cursor
40
+ if (handContext.hovered.size === 0)
41
+ return;
42
+ const toRemove = [];
43
+ for (const [id, hoveredObj] of handContext.hovered) {
44
+ // When no objects were hit or the hovered object wasn't found underneath the cursor
42
45
  // we call pointerout and delete the object from the hovered elements map
43
46
  if (intersections.length === 0 ||
44
47
  !intersections.some((hit) => hit.object === hoveredObj.object &&
45
48
  hit.index === hoveredObj.index &&
46
49
  hit.instanceId === hoveredObj.instanceId)) {
47
- const { eventObject } = hoveredObj;
48
- handContext.hovered.delete(getIntersectionId(hoveredObj));
49
- const events = dispatchers.get(eventObject);
50
- if (events !== undefined) {
51
- // Clear out intersects, they are outdated by now
52
- const data = { ...hoveredObj, intersections };
53
- events.onpointerout?.(data);
54
- events.onpointerleave?.(data);
55
- // Deal with cancelation
56
- handContext.pointerOverTarget.set(false);
57
- cancelPointer([]);
58
- }
50
+ toRemove.push([id, hoveredObj]);
59
51
  }
60
52
  }
53
+ for (const [id, hoveredObj] of toRemove) {
54
+ const { eventObject } = hoveredObj;
55
+ handContext.hovered.delete(id);
56
+ const events = dispatchers.get(eventObject);
57
+ if (events !== undefined) {
58
+ // Clear out intersects, they are outdated by now
59
+ const data = { ...hoveredObj, intersections };
60
+ events.onpointerout?.(data);
61
+ events.onpointerleave?.(data);
62
+ }
63
+ }
64
+ if (handContext.hovered.size === 0) {
65
+ handContext.pointerOverTarget.set(false);
66
+ }
61
67
  }
62
68
  const getHits = () => {
63
69
  const intersections = [];
64
- const hits = context.raycaster.intersectObjects(context.interactiveObjects, true);
70
+ const rawHits = context.raycaster.intersectObjects(context.interactiveObjects, true);
71
+ const seen = new Set();
72
+ // Deduplicate hits by object. When recursive=true, intersectObjects searches
73
+ // each registered object's full subtree, so a child that is itself registered
74
+ // appears once per registered ancestor — causing duplicate events. The key is
75
+ // context-sensitive so that legitimate multi-hit objects are preserved:
76
+ // InstancedMesh — each instance is a distinct target, key by instanceId
77
+ // Points — each point is a distinct target, key by point index
78
+ // Mesh / other — uuid only; multiple face hits are the same surface
79
+ const hits = rawHits.filter((hit) => {
80
+ const key = hit.instanceId !== undefined
81
+ ? `${hit.object.uuid}|${hit.instanceId}`
82
+ : hit.object.isPoints
83
+ ? `${hit.object.uuid}|${hit.index}`
84
+ : hit.object.uuid;
85
+ if (seen.has(key))
86
+ return false;
87
+ seen.add(key);
88
+ return true;
89
+ });
65
90
  const filtered = context.filter === undefined ? hits : context.filter(hits, context, handContext);
66
91
  pointerIntersection[handedness] = filtered[0];
67
92
  // Bubble up the events, find the event source (eventObject)
package/package.json CHANGED
@@ -1,6 +1,6 @@
1
1
  {
2
2
  "name": "@threlte/xr",
3
- "version": "1.5.0",
3
+ "version": "1.5.2",
4
4
  "author": "Micheal Parks <michealparks1989@gmail.com> (https://parks.lol)",
5
5
  "license": "MIT",
6
6
  "description": "Tools to more easily create VR and AR experiences with Threlte",
@@ -28,7 +28,7 @@
28
28
  "typescript-eslint": "^8.32.0",
29
29
  "vite": "^7.1.4",
30
30
  "vite-plugin-mkcert": "^1.17.5",
31
- "@threlte/core": "8.5.2"
31
+ "@threlte/core": "8.5.4"
32
32
  },
33
33
  "peerDependencies": {
34
34
  "svelte": ">=5",