@threenative/core 0.3.9 → 0.3.11

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
package/src/warmup.ts CHANGED
@@ -236,6 +236,7 @@ export interface IWarmUpReport {
236
236
  /** The narrow slice of the renderer this needs. Structural so a test needs no renderer. */
237
237
  export interface IWarmUpRenderer {
238
238
  compileAsync?: (scene: Object3D, camera: Camera, targetScene?: Object3D) => Promise<void>;
239
+ compileComputeAsync?: (node: unknown) => Promise<void>;
239
240
  computeAsync?: (node: unknown) => Promise<void>;
240
241
  pipelineCensus?: () => IPipelineCensus;
241
242
  /**
@@ -447,18 +448,36 @@ export interface IComputeWarmUpReport {
447
448
  readonly timedOut: boolean;
448
449
  }
449
450
 
450
- function computeAsyncOf(renderer: IWarmUpRenderer): ((node: unknown) => Promise<void>) | undefined {
451
- const receiver = typeof renderer.computeAsync === "function" ? renderer : renderer.raw;
451
+ /** Compiles kernels without running them. */
452
+ interface IComputeWarmUpSeam {
453
+ warm(node: unknown): Promise<void>;
454
+ }
455
+
456
+ function computeAsyncOf(renderer: IWarmUpRenderer): IComputeWarmUpSeam | undefined {
457
+ const receiver =
458
+ typeof renderer.compileComputeAsync === "function" ||
459
+ typeof renderer.computeAsync === "function"
460
+ ? renderer
461
+ : renderer.raw;
452
462
  if (typeof receiver !== "object" || receiver === null) return undefined;
453
- const { backend, computeAsync } = receiver as {
463
+ const { backend, compileComputeAsync, computeAsync } = receiver as {
454
464
  backend?: { isWebGPUBackend?: boolean };
455
- computeAsync?: (node: unknown, dispatchSize?: number) => Promise<void>;
465
+ compileComputeAsync?: (node: unknown) => Promise<void>;
466
+ computeAsync?: (node: unknown, dispatchSize?: number | readonly number[]) => Promise<void>;
456
467
  };
468
+ if (backend?.isWebGPUBackend === true) {
469
+ // Three 0.187 compiles a compute pipeline and its bindings without dispatching it
470
+ // (src/renderers/common/Renderer.js:1359, `compileComputeAsync`), so warm-up builds the pipeline
471
+ // the real dispatch uses and nothing runs against the live storage buffers. Dispatching the same
472
+ // kernel with a zeroed count instead made Chrome report `DispatchWorkgroups with a workgroup
473
+ // count of 0 is unusual` once per kernel per warm-up. A renderer without that path reports its
474
+ // kernels as uncompiled rather than silently running them.
475
+ if (typeof compileComputeAsync !== "function") return undefined;
476
+ return { warm: (node) => compileComputeAsync.call(receiver, node) };
477
+ }
457
478
  if (typeof computeAsync !== "function") return undefined;
458
- // WebGPU compiles zero workgroups without running a solver against its live storage buffers.
459
- return backend?.isWebGPUBackend === true
460
- ? (node) => computeAsync.call(receiver, node, 0)
461
- : computeAsync.bind(receiver);
479
+ const plain = computeAsync.bind(receiver);
480
+ return { warm: (node) => plain(node) };
462
481
  }
463
482
 
464
483
  /**
@@ -547,8 +566,8 @@ async function runComputeWarmUp(
547
566
  now: () => number,
548
567
  yieldFrame: () => Promise<void>,
549
568
  ): Promise<IComputeWarmUpReport> {
550
- const computeAsync = computeAsyncOf(renderer);
551
- if (computeAsync === undefined) {
569
+ const seam = computeAsyncOf(renderer);
570
+ if (seam === undefined) {
552
571
  return { compiled: 0, abandoned: 0, unsupported: true, timedOut: false };
553
572
  }
554
573
 
@@ -564,7 +583,7 @@ async function runComputeWarmUp(
564
583
  }
565
584
  const finished = await withinDeadline(
566
585
  Math.min(deadline, now() + compileTimeoutMs),
567
- Promise.resolve().then(() => computeAsync(nodes[index])),
586
+ Promise.resolve().then(() => seam.warm(nodes[index])),
568
587
  yieldFrame,
569
588
  now,
570
589
  );
@@ -6066,7 +6066,7 @@ export class WorldCells extends Group implements IComputeDriven {
6066
6066
  };
6067
6067
  }
6068
6068
 
6069
- dispose(): void {
6069
+ override dispose(): void {
6070
6070
  if (this.#released) return;
6071
6071
  this.#released = true;
6072
6072
  for (const [mesh, entry] of [...this.#awaited]) {
@@ -6107,6 +6107,9 @@ export class WorldCells extends Group implements IComputeDriven {
6107
6107
  drainMeshPool();
6108
6108
  this.#terrain?.dispose();
6109
6109
  this.removeFromParent();
6110
+ // r186's Object3D.dispose() dispatches the dispose event the renderer frees this object's
6111
+ // render objects on, so an override must reach it.
6112
+ super.dispose();
6110
6113
  }
6111
6114
 
6112
6115
  #updateResidency(followCell: { x: number; z: number }, x: number, z: number): void {
@@ -2678,7 +2678,7 @@ export class TerrainTiles extends Object3D implements IComputeDriven {
2678
2678
  this.dispose();
2679
2679
  }
2680
2680
 
2681
- dispose(): void {
2681
+ override dispose(): void {
2682
2682
  if (this.#released) return;
2683
2683
  this.#released = true;
2684
2684
  this.#renderer = undefined;
@@ -2690,6 +2690,9 @@ export class TerrainTiles extends Object3D implements IComputeDriven {
2690
2690
  for (const tile of [...this.#resident.values()]) this.#evict(tile);
2691
2691
  this.#resident.clear();
2692
2692
  this.removeFromParent();
2693
+ // r186's Object3D.dispose() dispatches the dispose event the renderer frees this object's
2694
+ // render objects on, so an override must reach it.
2695
+ super.dispose();
2693
2696
  }
2694
2697
 
2695
2698
  *#createField(origin: IHeightfieldOrigin, chunked: boolean): Generator<void, Heightfield> {