@thoughtspot/visual-embed-sdk 1.52.1 → 1.52.2-beta.0

package/cjs/src/utils/filterConverter.spec.js

@@ -0,0 +1,709 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+const types_1 = require("../types");
+const utils_1 = require("../embed/hostEventClient/utils");
+const filterConverter_1 = require("./filterConverter");
+describe('convertFilterChangedToUpdateFiltersPayload', () => {
+    test('returns an empty filters array for an empty payload', () => {
+        expect((0, filterConverter_1.convertFilterChangedToUpdateFiltersPayload)({})).toEqual({ filters: [] });
+    });
+    test('returns an empty filters array for null/undefined input', () => {
+        expect((0, filterConverter_1.convertFilterChangedToUpdateFiltersPayload)(null)).toEqual({ filters: [] });
+        expect((0, filterConverter_1.convertFilterChangedToUpdateFiltersPayload)(undefined)).toEqual({ filters: [] });
+    });
+    test('converts runtime filters as-is', () => {
+        const payload = {
+            runtimeFilters: [
+                { columnName: 'state', operator: types_1.RuntimeFilterOp.EQ, values: ['california'] },
+            ],
+        };
+        expect((0, filterConverter_1.convertFilterChangedToUpdateFiltersPayload)(payload)).toEqual({
+            filters: [
+                { columnName: 'state', operator: types_1.RuntimeFilterOp.EQ, values: ['california'] },
+            ],
+        });
+    });
+    test('converts a simple attribute filter (filterContent)', () => {
+        const payload = {
+            liveboardFilters: [
+                {
+                    columnInfo: { name: 'item type' },
+                    filters: [
+                        {
+                            filterContent: [
+                                {
+                                    filterType: 'IN',
+                                    value: [{ key: 'bags' }, { key: 'shirts' }],
+                                },
+                            ],
+                        },
+                    ],
+                },
+            ],
+        };
+        expect((0, filterConverter_1.convertFilterChangedToUpdateFiltersPayload)(payload)).toEqual({
+            filters: [
+                { columnName: 'item type', operator: 'IN', values: ['bags', 'shirts'] },
+            ],
+        });
+    });
+    test('includes negate when set on a filterContent filter', () => {
+        const payload = {
+            liveboardFilters: [
+                {
+                    columnInfo: { name: 'region' },
+                    filters: [
+                        {
+                            filterContent: [
+                                {
+                                    filterType: 'EQ',
+                                    negate: true,
+                                    value: [{ key: 'west' }],
+                                },
+                            ],
+                        },
+                    ],
+                },
+            ],
+        };
+        expect((0, filterConverter_1.convertFilterChangedToUpdateFiltersPayload)(payload)).toEqual({
+            filters: [
+                { columnName: 'region', operator: 'EQ', values: ['west'], negate: true },
+            ],
+        });
+    });
+    test('skips a filter group with no columnInfo.name', () => {
+        const payload = {
+            liveboardFilters: [
+                {
+                    filters: [
+                        { filterContent: [{ filterType: 'EQ', value: [{ key: 'x' }] }] },
+                    ],
+                },
+            ],
+        };
+        expect((0, filterConverter_1.convertFilterChangedToUpdateFiltersPayload)(payload)).toEqual({ filters: [] });
+    });
+    test('skips a filter with neither filterContent nor dateFilterContent', () => {
+        const payload = {
+            liveboardFilters: [
+                {
+                    columnInfo: { name: 'region' },
+                    filters: [{}],
+                },
+            ],
+        };
+        expect((0, filterConverter_1.convertFilterChangedToUpdateFiltersPayload)(payload)).toEqual({ filters: [] });
+    });
+    test('converts an EXACT_DATE filter using epoch', () => {
+        const payload = {
+            liveboardFilters: [
+                {
+                    columnInfo: { name: 'date' },
+                    filters: [
+                        {
+                            dateFilterContent: [
+                                {
+                                    dateFilter: { type: 'EXACT_DATE', op: 'EQ', epoch: '1690847400' },
+                                },
+                            ],
+                        },
+                    ],
+                },
+            ],
+        };
+        expect((0, filterConverter_1.convertFilterChangedToUpdateFiltersPayload)(payload)).toEqual({
+            filters: [
+                {
+                    columnName: 'date', operator: 'EQ', values: [1690847400], type: 'EXACT_DATE',
+                },
+            ],
+        });
+    });
+    test('converts an EXACT_DATE_RANGE filter using dateRange epochs', () => {
+        const payload = {
+            liveboardFilters: [
+                {
+                    columnInfo: { name: 'date' },
+                    filters: [
+                        {
+                            dateFilterContent: [
+                                {
+                                    dateFilter: {
+                                        type: 'EXACT_DATE_RANGE',
+                                        op: 'BW_INC',
+                                        dateRange: { lowEpoch: '100', highEpoch: '200' },
+                                    },
+                                },
+                            ],
+                        },
+                    ],
+                },
+            ],
+        };
+        expect((0, filterConverter_1.convertFilterChangedToUpdateFiltersPayload)(payload)).toEqual({
+            filters: [
+                {
+                    columnName: 'date', operator: 'BW_INC', values: [100, 200], type: 'EXACT_DATE_RANGE',
+                },
+            ],
+        });
+    });
+    test('converts a MONTH_YEAR filter', () => {
+        const payload = {
+            liveboardFilters: [
+                {
+                    columnInfo: { name: 'date' },
+                    filters: [
+                        {
+                            dateFilterContent: [
+                                {
+                                    dateFilter: {
+                                        type: 'MONTH_YEAR', op: 'EQ', monthName: 'JULY', yearName: '2023',
+                                    },
+                                },
+                            ],
+                        },
+                    ],
+                },
+            ],
+        };
+        expect((0, filterConverter_1.convertFilterChangedToUpdateFiltersPayload)(payload)).toEqual({
+            filters: [
+                {
+                    columnName: 'date', operator: 'EQ', values: ['JULY', '2023'], type: 'MONTH_YEAR',
+                },
+            ],
+        });
+    });
+    test('converts a QUARTER_YEAR filter', () => {
+        const payload = {
+            liveboardFilters: [
+                {
+                    columnInfo: { name: 'date' },
+                    filters: [
+                        {
+                            dateFilterContent: [
+                                {
+                                    dateFilter: {
+                                        type: 'QUARTER_YEAR', op: 'EQ', quarterName: 'Q1', yearName: '2023',
+                                    },
+                                },
+                            ],
+                        },
+                    ],
+                },
+            ],
+        };
+        expect((0, filterConverter_1.convertFilterChangedToUpdateFiltersPayload)(payload)).toEqual({
+            filters: [
+                {
+                    columnName: 'date', operator: 'EQ', values: ['Q1', '2023'], type: 'QUARTER_YEAR',
+                },
+            ],
+        });
+    });
+    test('converts a YEAR_ONLY filter', () => {
+        const payload = {
+            liveboardFilters: [
+                {
+                    columnInfo: { name: 'date' },
+                    filters: [
+                        {
+                            dateFilterContent: [
+                                { dateFilter: { type: 'YEAR_ONLY', op: 'EQ', yearName: '2023' } },
+                            ],
+                        },
+                    ],
+                },
+            ],
+        };
+        expect((0, filterConverter_1.convertFilterChangedToUpdateFiltersPayload)(payload)).toEqual({
+            filters: [
+                { columnName: 'date', operator: 'EQ', values: ['2023'], type: 'YEAR_ONLY' },
+            ],
+        });
+    });
+    test('converts a LAST_N_PERIOD filter with datePeriod and includeCurrentPeriod', () => {
+        const payload = {
+            liveboardFilters: [
+                {
+                    columnInfo: { name: 'date' },
+                    filters: [
+                        {
+                            dateFilterContent: [
+                                {
+                                    negate: true,
+                                    dateFilter: {
+                                        type: 'LAST_N_PERIOD',
+                                        op: 'EQ',
+                                        number: 3,
+                                        datePeriod: 'MONTH',
+                                        includeCurrentPeriod: true,
+                                    },
+                                },
+                            ],
+                        },
+                    ],
+                },
+            ],
+        };
+        expect((0, filterConverter_1.convertFilterChangedToUpdateFiltersPayload)(payload)).toEqual({
+            filters: [
+                {
+                    columnName: 'date',
+                    operator: 'EQ',
+                    values: [3],
+                    type: 'LAST_N_PERIOD',
+                    datePeriod: 'MONTH',
+                    includeCurrentPeriod: true,
+                    negate: true,
+                },
+            ],
+        });
+    });
+    test('converts a period-only date filter (e.g. TODAY) with empty values', () => {
+        const payload = {
+            liveboardFilters: [
+                {
+                    columnInfo: { name: 'date' },
+                    filters: [
+                        {
+                            dateFilterContent: [
+                                { dateFilter: { type: 'TODAY', op: 'EQ' } },
+                            ],
+                        },
+                    ],
+                },
+            ],
+        };
+        expect((0, filterConverter_1.convertFilterChangedToUpdateFiltersPayload)(payload)).toEqual({
+            filters: [
+                { columnName: 'date', operator: 'EQ', values: [], type: 'TODAY' },
+            ],
+        });
+    });
+    test('skips a dateFilterContent entry with no type', () => {
+        const payload = {
+            liveboardFilters: [
+                {
+                    columnInfo: { name: 'date' },
+                    filters: [
+                        { dateFilterContent: [{ dateFilter: {} }] },
+                    ],
+                },
+            ],
+        };
+        expect((0, filterConverter_1.convertFilterChangedToUpdateFiltersPayload)(payload)).toEqual({ filters: [] });
+    });
+    test('defaults operator to EQ when dateFilter.op is missing', () => {
+        const payload = {
+            liveboardFilters: [
+                {
+                    columnInfo: { name: 'date' },
+                    filters: [
+                        { dateFilterContent: [{ dateFilter: { type: 'TODAY' } }] },
+                    ],
+                },
+            ],
+        };
+        expect((0, filterConverter_1.convertFilterChangedToUpdateFiltersPayload)(payload)).toEqual({
+            filters: [
+                { columnName: 'date', operator: types_1.RuntimeFilterOp.EQ, values: [], type: 'TODAY' },
+            ],
+        });
+    });
+    test('converts every filterContent entry on a filter, not just the first', () => {
+        const payload = {
+            liveboardFilters: [
+                {
+                    columnInfo: { name: 'quantity' },
+                    filters: [
+                        {
+                            filterContent: [
+                                { filterType: 'GE', value: [{ key: 5 }] },
+                                { filterType: 'LE', value: [{ key: 10 }] },
+                            ],
+                        },
+                    ],
+                },
+            ],
+        };
+        expect((0, filterConverter_1.convertFilterChangedToUpdateFiltersPayload)(payload)).toEqual({
+            filters: [
+                { columnName: 'quantity', operator: 'GE', values: [5] },
+                { columnName: 'quantity', operator: 'LE', values: [10] },
+            ],
+        });
+    });
+    test('converts every Filter entry in a filter group, not just the first', () => {
+        const payload = {
+            liveboardFilters: [
+                {
+                    columnInfo: { name: 'region' },
+                    filters: [
+                        { filterContent: [{ filterType: 'EQ', value: [{ key: 'west' }] }] },
+                        { filterContent: [{ filterType: 'EQ', value: [{ key: 'east' }] }] },
+                    ],
+                },
+            ],
+        };
+        expect((0, filterConverter_1.convertFilterChangedToUpdateFiltersPayload)(payload)).toEqual({
+            filters: [
+                { columnName: 'region', operator: 'EQ', values: ['west'] },
+                { columnName: 'region', operator: 'EQ', values: ['east'] },
+            ],
+        });
+    });
+    test('keeps falsy-but-defined filter values such as 0 and false', () => {
+        const payload = {
+            liveboardFilters: [
+                {
+                    columnInfo: { name: 'flag' },
+                    filters: [
+                        {
+                            filterContent: [
+                                { filterType: 'IN', value: [{ key: 0 }, { key: false }] },
+                            ],
+                        },
+                    ],
+                },
+            ],
+        };
+        expect((0, filterConverter_1.convertFilterChangedToUpdateFiltersPayload)(payload)).toEqual({
+            filters: [
+                { columnName: 'flag', operator: 'IN', values: [0, false] },
+            ],
+        });
+    });
+    test('skips an EXACT_DATE filter missing its epoch instead of emitting empty values', () => {
+        const payload = {
+            liveboardFilters: [
+                {
+                    columnInfo: { name: 'date' },
+                    filters: [
+                        { dateFilterContent: [{ dateFilter: { type: 'EXACT_DATE', op: 'EQ' } }] },
+                    ],
+                },
+            ],
+        };
+        expect((0, filterConverter_1.convertFilterChangedToUpdateFiltersPayload)(payload)).toEqual({ filters: [] });
+    });
+    test('skips a MONTH_YEAR filter missing yearName instead of emitting empty values', () => {
+        const payload = {
+            liveboardFilters: [
+                {
+                    columnInfo: { name: 'date' },
+                    filters: [
+                        {
+                            dateFilterContent: [
+                                { dateFilter: { type: 'MONTH_YEAR', op: 'EQ', monthName: 'JULY' } },
+                            ],
+                        },
+                    ],
+                },
+            ],
+        };
+        expect((0, filterConverter_1.convertFilterChangedToUpdateFiltersPayload)(payload)).toEqual({ filters: [] });
+    });
+    test('skips an unrecognized date filter type rather than guessing', () => {
+        const payload = {
+            liveboardFilters: [
+                {
+                    columnInfo: { name: 'date' },
+                    filters: [
+                        { dateFilterContent: [{ dateFilter: { type: 'SOME_FUTURE_TYPE', op: 'EQ' } }] },
+                    ],
+                },
+            ],
+        };
+        expect((0, filterConverter_1.convertFilterChangedToUpdateFiltersPayload)(payload)).toEqual({ filters: [] });
+    });
+    test('output satisfies isValidUpdateFiltersPayload', () => {
+        const payload = {
+            liveboardFilters: [
+                {
+                    columnInfo: { name: 'item type' },
+                    filters: [
+                        { filterContent: [{ filterType: 'IN', value: [{ key: 'bags' }] }] },
+                    ],
+                },
+            ],
+            runtimeFilters: [
+                { columnName: 'region', operator: types_1.RuntimeFilterOp.EQ, values: ['west'] },
+            ],
+        };
+        const converted = (0, filterConverter_1.convertFilterChangedToUpdateFiltersPayload)(payload);
+        expect((0, utils_1.isValidUpdateFiltersPayload)(converted)).toBe(true);
+    });
+    test('combines multiple liveboard filters and runtime filters', () => {
+        const payload = {
+            liveboardFilters: [
+                {
+                    columnInfo: { name: 'item type' },
+                    filters: [
+                        { filterContent: [{ filterType: 'IN', value: [{ key: 'bags' }] }] },
+                    ],
+                },
+            ],
+            runtimeFilters: [
+                { columnName: 'region', operator: types_1.RuntimeFilterOp.EQ, values: ['west'] },
+            ],
+        };
+        expect((0, filterConverter_1.convertFilterChangedToUpdateFiltersPayload)(payload)).toEqual({
+            filters: [
+                { columnName: 'item type', operator: 'IN', values: ['bags'] },
+                { columnName: 'region', operator: types_1.RuntimeFilterOp.EQ, values: ['west'] },
+            ],
+        });
+    });
+    // The payload arrives as JSON from the embedded app, so an absent field can
+    // be `null` rather than omitted. `Number(null)` is 0, so a naive coercion
+    // would turn a missing epoch into 1970 and a missing period count into 0.
+    describe('null and non-numeric values in the payload', () => {
+        const dateFilterPayload = (dateFilter) => ({
+            liveboardFilters: [
+                {
+                    columnInfo: { name: 'date' },
+                    filters: [{ dateFilterContent: [{ dateFilter: dateFilter }] }],
+                },
+            ],
+        });
+        test.each([null, '', 'not-a-date'])('skips an EXACT_DATE filter whose epoch is %p instead of emitting epoch 0', (epoch) => {
+            const payload = dateFilterPayload({ type: 'EXACT_DATE', op: 'EQ', epoch });
+            expect((0, filterConverter_1.convertFilterChangedToUpdateFiltersPayload)(payload)).toEqual({ filters: [] });
+        });
+        test('skips an EXACT_DATE_RANGE filter when either bound is null', () => {
+            const missingHigh = dateFilterPayload({
+                type: 'EXACT_DATE_RANGE', op: 'BW', dateRange: { lowEpoch: 1000, highEpoch: null },
+            });
+            const missingLow = dateFilterPayload({
+                type: 'EXACT_DATE_RANGE', op: 'BW', dateRange: { lowEpoch: null, highEpoch: 2000 },
+            });
+            expect((0, filterConverter_1.convertFilterChangedToUpdateFiltersPayload)(missingHigh)).toEqual({ filters: [] });
+            expect((0, filterConverter_1.convertFilterChangedToUpdateFiltersPayload)(missingLow)).toEqual({ filters: [] });
+        });
+        test.each(['LAST_N_PERIOD', 'NEXT_N_PERIOD'])('skips a %s filter whose number is null instead of emitting a 0-length period', (type) => {
+            const payload = dateFilterPayload({ type, op: 'EQ', number: null, datePeriod: 'MONTH' });
+            expect((0, filterConverter_1.convertFilterChangedToUpdateFiltersPayload)(payload)).toEqual({ filters: [] });
+        });
+        test('accepts an epoch of 0 as a real value', () => {
+            const payload = dateFilterPayload({ type: 'EXACT_DATE', op: 'EQ', epoch: 0 });
+            expect((0, filterConverter_1.convertFilterChangedToUpdateFiltersPayload)(payload)).toEqual({
+                filters: [{
+                        columnName: 'date', operator: 'EQ', values: [0], type: 'EXACT_DATE',
+                    }],
+            });
+        });
+        test('accepts a numeric epoch sent as a string', () => {
+            const payload = dateFilterPayload({ type: 'EXACT_DATE', op: 'EQ', epoch: '1700000000' });
+            expect((0, filterConverter_1.convertFilterChangedToUpdateFiltersPayload)(payload)).toEqual({
+                filters: [{
+                        columnName: 'date', operator: 'EQ', values: [1700000000], type: 'EXACT_DATE',
+                    }],
+            });
+        });
+        test('omits includeCurrentPeriod when it is null', () => {
+            const payload = dateFilterPayload({
+                type: 'LAST_N_PERIOD', op: 'EQ', number: 3, datePeriod: 'MONTH', includeCurrentPeriod: null,
+            });
+            const [filter] = (0, filterConverter_1.convertFilterChangedToUpdateFiltersPayload)(payload).filters;
+            expect(filter).not.toHaveProperty('includeCurrentPeriod');
+        });
+        test('keeps includeCurrentPeriod when it is explicitly false', () => {
+            const payload = dateFilterPayload({
+                type: 'LAST_N_PERIOD', op: 'EQ', number: 3, datePeriod: 'MONTH', includeCurrentPeriod: false,
+            });
+            const [filter] = (0, filterConverter_1.convertFilterChangedToUpdateFiltersPayload)(payload).filters;
+            expect(filter.includeCurrentPeriod).toBe(false);
+        });
+        test('drops null keys from an attribute filter but keeps the rest', () => {
+            const payload = {
+                liveboardFilters: [
+                    {
+                        columnInfo: { name: 'item type' },
+                        filters: [
+                            {
+                                filterContent: [
+                                    {
+                                        filterType: 'IN',
+                                        value: [{ key: 'bags' }, { key: null }, { key: 'shirts' }],
+                                    },
+                                ],
+                            },
+                        ],
+                    },
+                ],
+            };
+            expect((0, filterConverter_1.convertFilterChangedToUpdateFiltersPayload)(payload)).toEqual({
+                filters: [{ columnName: 'item type', operator: 'IN', values: ['bags', 'shirts'] }],
+            });
+        });
+        test('keeps a falsy-but-real key such as 0 or false', () => {
+            const payload = {
+                liveboardFilters: [
+                    {
+                        columnInfo: { name: 'quantity' },
+                        filters: [
+                            { filterContent: [{ filterType: 'IN', value: [{ key: 0 }, { key: false }] }] },
+                        ],
+                    },
+                ],
+            };
+            expect((0, filterConverter_1.convertFilterChangedToUpdateFiltersPayload)(payload)).toEqual({
+                filters: [{ columnName: 'quantity', operator: 'IN', values: [0, false] }],
+            });
+        });
+    });
+    // A runtime filter needs no reshaping, but it still arrives as JSON. One
+    // malformed entry fails isValidUpdateFiltersPayload for the WHOLE filters
+    // array, which would take every other converted filter down with it.
+    describe('malformed runtime filters', () => {
+        const malformed = [
+            { columnName: null, operator: types_1.RuntimeFilterOp.EQ, values: ['west'] },
+            { columnName: '', operator: types_1.RuntimeFilterOp.EQ, values: ['west'] },
+            { operator: types_1.RuntimeFilterOp.EQ, values: ['west'] },
+            { columnName: 'region', operator: null, values: ['west'] },
+            { columnName: 'region', values: ['west'] },
+            { columnName: 'region', operator: types_1.RuntimeFilterOp.EQ, values: null },
+            { columnName: 'region', operator: types_1.RuntimeFilterOp.EQ },
+        ];
+        test.each(malformed)('skips the malformed runtime filter %p', (runtimeFilter) => {
+            const payload = { runtimeFilters: [runtimeFilter] };
+            expect((0, filterConverter_1.convertFilterChangedToUpdateFiltersPayload)(payload)).toEqual({ filters: [] });
+        });
+        test('a bad runtime filter does not discard the good filters alongside it', () => {
+            const payload = {
+                liveboardFilters: [
+                    {
+                        columnInfo: { name: 'item type' },
+                        filters: [{ filterContent: [{ filterType: 'IN', value: [{ key: 'bags' }] }] }],
+                    },
+                ],
+                runtimeFilters: [
+                    { columnName: null, operator: types_1.RuntimeFilterOp.EQ, values: ['west'] },
+                    { columnName: 'region', operator: types_1.RuntimeFilterOp.EQ, values: ['west'] },
+                ],
+            };
+            const converted = (0, filterConverter_1.convertFilterChangedToUpdateFiltersPayload)(payload);
+            expect(converted).toEqual({
+                filters: [
+                    { columnName: 'item type', operator: 'IN', values: ['bags'] },
+                    { columnName: 'region', operator: types_1.RuntimeFilterOp.EQ, values: ['west'] },
+                ],
+            });
+            // The whole point: the surviving payload is still triggerable.
+            expect((0, utils_1.isValidUpdateFiltersPayload)(converted)).toBe(true);
+        });
+        test('keeps a runtime filter with an empty values array', () => {
+            const payload = {
+                runtimeFilters: [{ columnName: 'region', operator: types_1.RuntimeFilterOp.EQ, values: [] }],
+            };
+            expect((0, filterConverter_1.convertFilterChangedToUpdateFiltersPayload)(payload)).toEqual({
+                filters: [{ columnName: 'region', operator: types_1.RuntimeFilterOp.EQ, values: [] }],
+            });
+        });
+    });
+    // liveboardFilters entries carry an optional `applicability`
+    // ({level, targetId}) from SDK 1.53.0 / 26.10.0.cl, and UpdateFilters
+    // accepts it per filter. Dropping it would replay a tab-scoped filter
+    // across the whole Liveboard.
+    describe('applicability (filter scope)', () => {
+        const TAB_ID = 'e0836cad-4fdf-42d4-bd97-567a6b2a6058';
+        const groupWith = (applicability) => ({
+            liveboardFilters: [
+                {
+                    columnInfo: { name: 'item type' },
+                    applicability,
+                    filters: [{ filterContent: [{ filterType: 'IN', value: [{ key: 'bags' }] }] }],
+                },
+            ],
+        });
+        test('carries TAB scope through to the converted filter', () => {
+            const converted = (0, filterConverter_1.convertFilterChangedToUpdateFiltersPayload)(groupWith({ level: 'TAB', targetId: TAB_ID }));
+            expect(converted).toEqual({
+                filters: [{
+                        columnName: 'item type',
+                        operator: 'IN',
+                        values: ['bags'],
+                        applicability: { level: 'TAB', targetId: TAB_ID },
+                    }],
+            });
+            expect((0, utils_1.isValidUpdateFiltersPayload)(converted)).toBe(true);
+        });
+        test('carries GROUP scope through to the converted filter', () => {
+            const converted = (0, filterConverter_1.convertFilterChangedToUpdateFiltersPayload)(groupWith({ level: 'GROUP', targetId: TAB_ID }));
+            expect(converted.filters[0].applicability).toEqual({ level: 'GROUP', targetId: TAB_ID });
+            expect((0, utils_1.isValidUpdateFiltersPayload)(converted)).toBe(true);
+        });
+        test('carries LIVEBOARD scope, which needs no targetId', () => {
+            const converted = (0, filterConverter_1.convertFilterChangedToUpdateFiltersPayload)(groupWith({ level: 'LIVEBOARD' }));
+            expect(converted.filters[0].applicability).toEqual({ level: 'LIVEBOARD' });
+            expect((0, utils_1.isValidUpdateFiltersPayload)(converted)).toBe(true);
+        });
+        test('omits applicability entirely when the payload has none', () => {
+            const converted = (0, filterConverter_1.convertFilterChangedToUpdateFiltersPayload)(groupWith(undefined));
+            expect(converted.filters[0]).not.toHaveProperty('applicability');
+            expect((0, utils_1.isValidUpdateFiltersPayload)(converted)).toBe(true);
+        });
+        test('applies the group scope to every filter the group produces', () => {
+            const payload = {
+                liveboardFilters: [
+                    {
+                        columnInfo: { name: 'quantity' },
+                        applicability: { level: 'TAB', targetId: TAB_ID },
+                        filters: [
+                            {
+                                filterContent: [
+                                    { filterType: 'GE', value: [{ key: 5 }] },
+                                    { filterType: 'LE', value: [{ key: 10 }] },
+                                ],
+                            },
+                        ],
+                    },
+                ],
+            };
+            const converted = (0, filterConverter_1.convertFilterChangedToUpdateFiltersPayload)(payload);
+            expect(converted.filters).toHaveLength(2);
+            converted.filters.forEach((filter) => {
+                expect(filter.applicability).toEqual({ level: 'TAB', targetId: TAB_ID });
+            });
+        });
+        test.each([
+            [{ level: 'TAB' }, 'TAB with no targetId'],
+            [{ level: 'GROUP', targetId: '   ' }, 'GROUP with a blank targetId'],
+            [{ level: 'SOMETHING_ELSE', targetId: TAB_ID }, 'an unknown level'],
+            [{ targetId: TAB_ID }, 'no level at all'],
+        ])('skips a filter scoped with %p (%s) rather than widening it', (applicability, _label) => {
+            expect((0, filterConverter_1.convertFilterChangedToUpdateFiltersPayload)(groupWith(applicability)))
+                .toEqual({ filters: [] });
+        });
+        test('a malformed scope on one column does not invalidate the others', () => {
+            const payload = {
+                liveboardFilters: [
+                    {
+                        columnInfo: { name: 'item type' },
+                        applicability: { level: 'TAB' },
+                        filters: [{ filterContent: [{ filterType: 'IN', value: [{ key: 'bags' }] }] }],
+                    },
+                    {
+                        columnInfo: { name: 'region' },
+                        applicability: { level: 'TAB', targetId: TAB_ID },
+                        filters: [{ filterContent: [{ filterType: 'IN', value: [{ key: 'west' }] }] }],
+                    },
+                ],
+            };
+            const converted = (0, filterConverter_1.convertFilterChangedToUpdateFiltersPayload)(payload);
+            expect(converted).toEqual({
+                filters: [{
+                        columnName: 'region',
+                        operator: 'IN',
+                        values: ['west'],
+                        applicability: { level: 'TAB', targetId: TAB_ID },
+                    }],
+            });
+            expect((0, utils_1.isValidUpdateFiltersPayload)(converted)).toBe(true);
+        });
+    });
+});
+//# sourceMappingURL=filterConverter.spec.js.map