@thoughtspot/visual-embed-sdk 1.48.0 → 1.49.1

package/lib/src/embed/ts-embed.spec.js

@@ -81,7 +81,7 @@ const getMockAppInitPayload = (data) => {
         interceptUrls: [],
         shouldBypassPayloadValidation: undefined,
         useHostEventsV2: undefined,
-        embedExpiryInAuthToken: true
+        embedExpiryInAuthToken: true,
     };
     return {
         type: EmbedEvent.APP_INIT,
@@ -370,7 +370,10 @@ describe('Unit test case for ts embed', () => {
             });
             await executeAfterWait(() => {
                 expect(mockPort.postMessage).toHaveBeenCalledWith(getMockAppInitPayload({
-                    reorderedHomepageModules: [HomepageModule.MyLibrary, HomepageModule.Watchlist],
+                    reorderedHomepageModules: [
+                        HomepageModule.MyLibrary,
+                        HomepageModule.Watchlist,
+                    ],
                 }));
             });
         });
@@ -516,7 +519,10 @@ describe('Unit test case for ts embed', () => {
             });
             await executeAfterWait(() => {
                 expect(mockPort.postMessage).toHaveBeenCalledWith(getMockAppInitPayload({
-                    hiddenHomeLeftNavItems: [HomeLeftNavItem.Home, HomeLeftNavItem.MonitorSubscription],
+                    hiddenHomeLeftNavItems: [
+                        HomeLeftNavItem.Home,
+                        HomeLeftNavItem.MonitorSubscription,
+                    ],
                 }));
             });
         });
@@ -744,10 +750,8 @@ describe('Unit test case for ts embed', () => {
                     customVariablesForThirdPartyTools: {},
                 }));
                 const customisationContent = mockPort.postMessage.mock.calls[0][0].data.customisations.content;
-                expect(customisationContent.stringIDsUrl)
-                    .toBe('https://sample-string-ids-url.com');
-                expect(customisationContent.stringIDs)
-                    .toEqual({
+                expect(customisationContent.stringIDsUrl).toBe('https://sample-string-ids-url.com');
+                expect(customisationContent.stringIDs).toEqual({
                     'liveboard.header.title': 'Dashboard name',
                 });
             });
@@ -757,7 +761,10 @@ describe('Unit test case for ts embed', () => {
                 type: EmbedEvent.APP_INIT,
                 data: {},
             };
-            const searchEmbed = new SearchEmbed(getRootEl(), { ...defaultViewConfig, exposeTranslationIDs: true });
+            const searchEmbed = new SearchEmbed(getRootEl(), {
+                ...defaultViewConfig,
+                exposeTranslationIDs: true,
+            });
             searchEmbed.render();
             const mockPort = {
                 postMessage: jest.fn(),
@@ -798,16 +805,16 @@ describe('Unit test case for ts embed', () => {
                         name: 'Valid Action',
                         target: CustomActionTarget.LIVEBOARD,
                         position: CustomActionsPosition.PRIMARY,
-                        metadataIds: { liveboardIds: ['lb123'] }
+                        metadataIds: { liveboardIds: ['lb123'] },
                     },
                     {
                         id: 'action2',
                         name: 'Another Valid Action',
                         target: CustomActionTarget.VIZ,
                         position: CustomActionsPosition.MENU,
-                        metadataIds: { vizIds: ['viz456'] }
-                    }
-                ]
+                        metadataIds: { vizIds: ['viz456'] },
+                    },
+                ],
             });
             searchEmbed.render();
             const mockPort = {
@@ -833,15 +840,15 @@ describe('Unit test case for ts embed', () => {
                             name: 'Another Valid Action',
                             target: CustomActionTarget.VIZ,
                             position: CustomActionsPosition.MENU,
-                            metadataIds: { vizIds: ['viz456'] }
+                            metadataIds: { vizIds: ['viz456'] },
                         },
                         {
                             id: 'action1',
                             name: 'Valid Action',
                             target: CustomActionTarget.LIVEBOARD,
                             position: CustomActionsPosition.PRIMARY,
-                            metadataIds: { liveboardIds: ['lb123'] }
-                        }
+                            metadataIds: { liveboardIds: ['lb123'] },
+                        },
                     ],
                     customVariablesForThirdPartyTools: {},
                 }));
@@ -854,14 +861,14 @@ describe('Unit test case for ts embed', () => {
                         id: 'action1',
                         name: 'Valid Action',
                         target: CustomActionTarget.LIVEBOARD,
-                        position: CustomActionsPosition.PRIMARY
+                        position: CustomActionsPosition.PRIMARY,
                     }),
                     expect.objectContaining({
                         id: 'action2',
                         name: 'Another Valid Action',
                         target: CustomActionTarget.VIZ,
-                        position: CustomActionsPosition.MENU
-                    })
+                        position: CustomActionsPosition.MENU,
+                    }),
                 ]));
                 // Verify actions are sorted by name (alphabetically)
                 expect(appInitData.customActions[0].name).toBe('Another Valid Action');
@@ -915,7 +922,10 @@ describe('Unit test case for ts embed', () => {
                 type: EmbedEvent.APP_INIT,
                 data: {},
             };
-            const searchEmbed = new SearchEmbed(getRootEl(), { ...defaultViewConfig, preRenderId: 'test' });
+            const searchEmbed = new SearchEmbed(getRootEl(), {
+                ...defaultViewConfig,
+                preRenderId: 'test',
+            });
             searchEmbed.preRender();
             const mockPort = {
                 postMessage: jest.fn(),
@@ -966,7 +976,10 @@ describe('Unit test case for ts embed', () => {
                 type: EmbedEvent.AuthExpire,
                 data: {},
             };
-            const searchEmbed = new SearchEmbed(getRootEl(), { ...defaultViewConfig, preRenderId: 'test' });
+            const searchEmbed = new SearchEmbed(getRootEl(), {
+                ...defaultViewConfig,
+                preRenderId: 'test',
+            });
             jest.spyOn(baseInstance, 'notifyAuthFailure');
             searchEmbed.preRender();
             const loggerSpy = jest.spyOn(logger, 'error').mockImplementation(() => { });
@@ -1106,9 +1119,13 @@ describe('Unit test case for ts embed', () => {
             // resetCachedPreauthInfo();
             let mockGetPreauthInfo = null;
             if (overrideOrgId) {
-                mockGetPreauthInfo = jest.spyOn(sessionInfoService, 'getPreauthInfo').mockImplementation(jest.fn());
+                mockGetPreauthInfo = jest
+                    .spyOn(sessionInfoService, 'getPreauthInfo')
+                    .mockImplementation(jest.fn());
             }
-            const mockPreauthInfoFetch = jest.spyOn(authService, 'fetchPreauthInfoService').mockResolvedValueOnce({
+            const mockPreauthInfoFetch = jest
+                .spyOn(authService, 'fetchPreauthInfoService')
+                .mockResolvedValueOnce({
                 ok: true,
                 headers: new Headers({ 'content-type': 'application/json' }),
                 json: async () => ({
@@ -1143,14 +1160,14 @@ describe('Unit test case for ts embed', () => {
             };
         };
         test('should call InfoSuccess Event on preauth call success', async () => {
-            const { mockPreauthInfoFetch, iFrame, } = await setup(true);
+            const { mockPreauthInfoFetch, iFrame } = await setup(true);
             expect(mockPreauthInfoFetch).toHaveBeenCalledTimes(1);
             await executeAfterWait(() => {
                 expect(mockProcessTrigger).toHaveBeenCalledWith(iFrame, HostEvent.InfoSuccess, 'http://tshost', expect.objectContaining({ info: expect.any(Object) }), undefined);
             });
         });
         test('should not call InfoSuccess Event if overrideOrgId is true', async () => {
-            const { mockGetPreauthInfo, } = await setup(true, 123);
+            const { mockGetPreauthInfo } = await setup(true, 123);
             expect(mockGetPreauthInfo).toHaveBeenCalledTimes(0);
         });
     });
@@ -1183,14 +1200,17 @@ describe('Unit test case for ts embed', () => {
             const isAppEmbedWithPrimaryNavbar = embedType === 'AppEmbed' && showPrimaryNavbar === true;
             const shouldDisableCache = overrideOrgId || disablePreauthCache || isAppEmbedWithPrimaryNavbar;
             if (shouldDisableCache) {
-                mockGetPreauthInfo = jest.spyOn(sessionInfoService, 'getPreauthInfo')
+                mockGetPreauthInfo = jest
+                    .spyOn(sessionInfoService, 'getPreauthInfo')
                     .mockImplementation(jest.fn());
             }
             else {
-                mockGetPreauthInfo = jest.spyOn(sessionInfoService, 'getPreauthInfo')
+                mockGetPreauthInfo = jest
+                    .spyOn(sessionInfoService, 'getPreauthInfo')
                     .mockResolvedValue({ info: { test: 'data' } });
             }
-            const mockPreauthInfoFetch = jest.spyOn(authService, 'fetchPreauthInfoService')
+            const mockPreauthInfoFetch = jest
+                .spyOn(authService, 'fetchPreauthInfoService')
                 .mockResolvedValueOnce({
                 ok: true,
                 headers: new Headers({ 'content-type': 'application/json' }),
@@ -1662,8 +1682,8 @@ describe('Unit test case for ts embed', () => {
                 },
             });
             await appEmbed.render();
-            expectUrlMatchesWithParams(getIFrameSrc(), `http://${thoughtSpotHost}/?embedApp=true&primaryNavHidden=true&profileAndHelpInNavBarHidden=false&${defaultParamsForPinboardEmbed}`
-                + `&foo=bar&baz=1&bool=true${defaultParamsPost}#/home`);
+            expectUrlMatchesWithParams(getIFrameSrc(), `http://${thoughtSpotHost}/?embedApp=true&primaryNavHidden=true&profileAndHelpInNavBarHidden=false&${defaultParamsForPinboardEmbed}` +
+                `&foo=bar&baz=1&bool=true${defaultParamsPost}#/home`);
         });
         it('should set the additional flags correctly on the iframe src from init and view config', async () => {
             init({
@@ -1687,8 +1707,8 @@ describe('Unit test case for ts embed', () => {
                 },
             });
             await appEmbed.render();
-            expectUrlMatchesWithParams(getIFrameSrc(), `http://${thoughtSpotHost}/?embedApp=true&primaryNavHidden=true&profileAndHelpInNavBarHidden=false&${defaultParamsForPinboardEmbed}`
-                + `&foo=bar&foo2=bar2&foo3=false&baz=1&bool=true${defaultParamsPost}#/home`);
+            expectUrlMatchesWithParams(getIFrameSrc(), `http://${thoughtSpotHost}/?embedApp=true&primaryNavHidden=true&profileAndHelpInNavBarHidden=false&${defaultParamsForPinboardEmbed}` +
+                `&foo=bar&foo2=bar2&foo3=false&baz=1&bool=true${defaultParamsPost}#/home`);
         });
         it('Sets the showAlerts param', async () => {
             const appEmbed = new AppEmbed(getRootEl(), {
@@ -1699,8 +1719,8 @@ describe('Unit test case for ts embed', () => {
                 showAlerts: true,
             });
             await appEmbed.render();
-            expectUrlMatchesWithParams(getIFrameSrc(), `http://${thoughtSpotHost}/?embedApp=true&primaryNavHidden=true&profileAndHelpInNavBarHidden=false&${defaultParamsForPinboardEmbed}`
-                + `&showAlerts=true${defaultParamsPost}#/home`);
+            expectUrlMatchesWithParams(getIFrameSrc(), `http://${thoughtSpotHost}/?embedApp=true&primaryNavHidden=true&profileAndHelpInNavBarHidden=false&${defaultParamsForPinboardEmbed}` +
+                `&showAlerts=true${defaultParamsPost}#/home`);
         });
         it('Sets the locale param', async () => {
             const appEmbed = new AppEmbed(getRootEl(), {
@@ -1711,8 +1731,8 @@ describe('Unit test case for ts embed', () => {
                 locale: 'ja-JP',
             });
             await appEmbed.render();
-            expectUrlMatchesWithParams(getIFrameSrc(), `http://${thoughtSpotHost}/?embedApp=true&primaryNavHidden=true&profileAndHelpInNavBarHidden=false&${defaultParamsForPinboardEmbed}`
-                + `&locale=ja-JP${defaultParamsPost}#/home`);
+            expectUrlMatchesWithParams(getIFrameSrc(), `http://${thoughtSpotHost}/?embedApp=true&primaryNavHidden=true&profileAndHelpInNavBarHidden=false&${defaultParamsForPinboardEmbed}` +
+                `&locale=ja-JP${defaultParamsPost}#/home`);
         });
         it('Sets both params when enableLinkOverridesV2 is set', async () => {
             const liveboardEmbed = new LiveboardEmbed(getRootEl(), {
@@ -1726,7 +1746,7 @@ describe('Unit test case for ts embed', () => {
             await liveboardEmbed.render();
             expectUrlMatchesWithParams(getIFrameSrc(), `http://${thoughtSpotHost}/?embedApp=true&${defaultParamsForPinboardEmbed}&enableLinkOverridesV2=true&linkOverride=true${defaultParamsPost}#/embed/viz/test-lb`);
         });
-        it('Sets only linkOverride when enableLinkOverridesV2 is not set', async () => {
+        it('Auto-upgrades V1 linkOverride to V2 (sends both flags)', async () => {
             const liveboardEmbed = new LiveboardEmbed(getRootEl(), {
                 frameParams: {
                     width: '100%',
@@ -1736,7 +1756,40 @@ describe('Unit test case for ts embed', () => {
                 linkOverride: true,
             });
             await liveboardEmbed.render();
-            expectUrlMatchesWithParams(getIFrameSrc(), `http://${thoughtSpotHost}/?embedApp=true&${defaultParamsForPinboardEmbed}&linkOverride=true${defaultParamsPost}#/embed/viz/test-lb`);
+            const src = getIFrameSrc();
+            expect(src).toContain('linkOverride=true');
+            expect(src).toContain('enableLinkOverridesV2=true');
+        });
+        it('Auto-disables V2 link overrides when disableRedirectionLinksInNewTab is true', async () => {
+            const liveboardEmbed = new LiveboardEmbed(getRootEl(), {
+                frameParams: {
+                    width: '100%',
+                    height: '100%',
+                },
+                liveboardId: 'test-lb',
+                enableLinkOverridesV2: true,
+                disableRedirectionLinksInNewTab: true,
+            });
+            await liveboardEmbed.render();
+            const src = getIFrameSrc();
+            expect(src).not.toContain('enableLinkOverridesV2=true');
+            expect(src).not.toContain('linkOverride=true');
+            expect(src).toContain('disableRedirectionLinksInNewTab=true');
+        });
+        it('Auto-disables V1 link override when disableRedirectionLinksInNewTab is true', async () => {
+            const liveboardEmbed = new LiveboardEmbed(getRootEl(), {
+                frameParams: {
+                    width: '100%',
+                    height: '100%',
+                },
+                liveboardId: 'test-lb',
+                linkOverride: true,
+                disableRedirectionLinksInNewTab: true,
+            });
+            await liveboardEmbed.render();
+            const src = getIFrameSrc();
+            expect(src).not.toContain('linkOverride=true');
+            expect(src).toContain('disableRedirectionLinksInNewTab=true');
         });
         it('Sets the iconSprite url', async () => {
             const appEmbed = new AppEmbed(getRootEl(), {
@@ -1749,8 +1802,8 @@ describe('Unit test case for ts embed', () => {
                 },
             });
             await appEmbed.render();
-            expectUrlMatchesWithParams(getIFrameSrc(), `http://${thoughtSpotHost}/?embedApp=true&primaryNavHidden=true&profileAndHelpInNavBarHidden=false&${defaultParamsForPinboardEmbed}`
-                + `&iconSprite=iconSprite.com${defaultParamsPost}#/home`);
+            expectUrlMatchesWithParams(getIFrameSrc(), `http://${thoughtSpotHost}/?embedApp=true&primaryNavHidden=true&profileAndHelpInNavBarHidden=false&${defaultParamsForPinboardEmbed}` +
+                `&iconSprite=iconSprite.com${defaultParamsPost}#/home`);
         });
         it('inserts as sibling of root node if configured', async () => {
             const appEmbed = new AppEmbed(getRootEl(), {
@@ -1983,22 +2036,26 @@ describe('Unit test case for ts embed', () => {
             tsEmbedDiv.style.width = '100px';
             tsEmbedDiv.style.height = '100px';
             let resizeObserverCb;
-            window.ResizeObserver = window.ResizeObserver
-                || jest.fn().mockImplementation((resizeObserverCbParam) => {
-                    resizeObserverCb = resizeObserverCbParam;
-                    return {
-                        disconnect: jest.fn(),
-                        observe: jest.fn(),
-                        unobserve: jest.fn(),
-                    };
-                });
+            window.ResizeObserver =
+                window.ResizeObserver ||
+                    jest.fn().mockImplementation((resizeObserverCbParam) => {
+                        resizeObserverCb = resizeObserverCbParam;
+                        return {
+                            disconnect: jest.fn(),
+                            observe: jest.fn(),
+                            unobserve: jest.fn(),
+                        };
+                    });
             // show preRender
             const warnSpy = jest.spyOn(logger, 'warn');
             libEmbed.showPreRender();
             expect(warnSpy).toHaveBeenCalledTimes(1);
+            // The ResizeObserver now tracks the placeholder inside this.el,
+            // not this.el itself, so pass it as the target.
+            const preRenderPlaceholder = tsEmbedDiv.firstElementChild;
             resizeObserverCb([
                 {
-                    target: tsEmbedDiv,
+                    target: preRenderPlaceholder,
                     contentRect: { height: 297, width: 987 },
                 },
             ]);
@@ -2049,12 +2106,13 @@ describe('Unit test case for ts embed', () => {
         });
         it('should set overflow:hidden when hidePreRender and remove when showPreRender', async () => {
             createRootEleForEmbed();
-            window.ResizeObserver = window.ResizeObserver
-                || jest.fn().mockImplementation(() => ({
-                    disconnect: jest.fn(),
-                    observe: jest.fn(),
-                    unobserve: jest.fn(),
-                }));
+            window.ResizeObserver =
+                window.ResizeObserver ||
+                    jest.fn().mockImplementation(() => ({
+                        disconnect: jest.fn(),
+                        observe: jest.fn(),
+                        unobserve: jest.fn(),
+                    }));
             const libEmbed = new LiveboardEmbed('#tsEmbedDiv', {
                 preRenderId: 'overflow-test',
                 liveboardId: 'myLiveboardId',
@@ -2080,27 +2138,28 @@ describe('Unit test case for ts embed', () => {
         it('it should connect with another object', async () => {
             createRootEleForEmbed();
             mockMessageChannel();
-            window.ResizeObserver = window.ResizeObserver
-                || jest.fn().mockImplementation(() => ({
-                    disconnect: jest.fn(),
-                    observe: jest.fn(),
-                    unobserve: jest.fn(),
-                }));
+            window.ResizeObserver =
+                window.ResizeObserver ||
+                    jest.fn().mockImplementation(() => ({
+                        disconnect: jest.fn(),
+                        observe: jest.fn(),
+                        unobserve: jest.fn(),
+                    }));
             const libEmbed = new LiveboardEmbed('#tsEmbedDiv', {
                 preRenderId: 'i-am-preRendered',
                 liveboardId: 'myLiveboardId',
             });
             libEmbed.preRender();
             await waitFor(() => !!getIFrameEl());
-            const warnSpy = jest.spyOn(logger, 'warn');
             const newEmbed = new LiveboardEmbed('#tsEmbedDiv', {
                 preRenderId: 'i-am-preRendered',
                 liveboardId: 'awdawda',
                 hiddenActions: [Action.AddFilter],
                 frameParams: { height: 90 },
             });
-            newEmbed.showPreRender();
-            expect(warnSpy).toHaveBeenCalledTimes(2);
+            await newEmbed.showPreRender();
+            // Verify newEmbed successfully connected to the existing preRender
+            expect(newEmbed.isPreRenderConnected()).toBe(true);
         });
         it('showPreRender should not preRender if not available', async () => {
             createRootEleForEmbed();
@@ -2251,7 +2310,10 @@ describe('Unit test case for ts embed', () => {
             document.body.innerHTML = getDocumentBody();
         });
         test('Pre-render should wait for init to complete', async () => {
-            const lib = new LiveboardEmbed(getRootEl(), { preRenderId: 'test', liveboardId: 'test' });
+            const lib = new LiveboardEmbed(getRootEl(), {
+                preRenderId: 'test',
+                liveboardId: 'test',
+            });
             lib.preRender();
             await executeAfterWait(() => {
                 expect(errorSpy).toHaveBeenCalledWith(ERROR_MESSAGE.RENDER_CALLED_BEFORE_INIT);
@@ -2481,7 +2543,11 @@ describe('Unit test case for ts embed', () => {
                 expect(authToken.getAuthenticationToken).toHaveBeenCalledWith(expect.any(Object), true);
                 // Check that logger.error was called with the token refresh
                 // error
-                const errorCalls = logger.error.mock.calls.filter((call) => { var _a, _b; return ((_a = call[0]) === null || _a === void 0 ? void 0 : _a.includes(ERROR_MESSAGE.INVALID_TOKEN_ERROR)) && ((_b = call[0]) === null || _b === void 0 ? void 0 : _b.includes('Token fetch failed')); });
+                const errorCalls = logger.error.mock.calls.filter((call) => {
+                    var _a, _b;
+                    return ((_a = call[0]) === null || _a === void 0 ? void 0 : _a.includes(ERROR_MESSAGE.INVALID_TOKEN_ERROR)) &&
+                        ((_b = call[0]) === null || _b === void 0 ? void 0 : _b.includes('Token fetch failed'));
+                });
                 expect(errorCalls.length).toBeGreaterThan(0);
                 expect(processData.processAuthFailure).toHaveBeenCalledWith(error, expect.any(Element));
                 expect(mockPort.postMessage).not.toHaveBeenCalled();
@@ -2643,8 +2709,8 @@ describe('Unit test case for ts embed', () => {
         test('should return getPreRenderObj and log if same object', () => {
             const searchEmbed = new SearchEmbed(getRootEl(), defaultViewConfig);
             const loggerSpy = jest.spyOn(logger, 'info');
-            // Mock insertedDomEl to have the embed object
-            searchEmbed.insertedDomEl = {
+            // getPreRenderObj reads the embed reference from preRenderWrapper
+            searchEmbed.preRenderWrapper = {
                 [searchEmbed['embedNodeKey']]: searchEmbed,
             };
             const result = searchEmbed['getPreRenderObj']();
@@ -2693,7 +2759,8 @@ describe('Unit test case for ts embed', () => {
             test('should return context when embed container is already loaded', async () => {
                 const searchEmbed = new SearchEmbed(getRootEl(), defaultViewConfig);
                 searchEmbed.isEmbedContainerLoaded = true;
-                const triggerSpy = jest.spyOn(searchEmbed, 'trigger')
+                const triggerSpy = jest
+                    .spyOn(searchEmbed, 'trigger')
                     .mockResolvedValue(mockContext);
                 const context = await searchEmbed.getCurrentContext();
                 expect(context).toEqual(mockContext);
@@ -2702,7 +2769,8 @@ describe('Unit test case for ts embed', () => {
             test('should wait for embed container to load before returning context', async () => {
                 const searchEmbed = new SearchEmbed(getRootEl(), defaultViewConfig);
                 searchEmbed.isEmbedContainerLoaded = false;
-                const triggerSpy = jest.spyOn(searchEmbed, 'trigger')
+                const triggerSpy = jest
+                    .spyOn(searchEmbed, 'trigger')
                     .mockResolvedValue(mockContext);
                 const contextPromise = searchEmbed.getCurrentContext();
                 // Context should not be resolved yet
@@ -2888,9 +2956,11 @@ describe('Unit test case for ts embed', () => {
             });
             await appEmbed.render();
             jest.spyOn(appEmbed, 'trigger').mockRejectedValue(new Error('trigger failed'));
-            const removeChildSpy = jest.spyOn(Node.prototype, 'removeChild').mockImplementation(() => getRootEl());
+            const removeChildSpy = jest
+                .spyOn(Node.prototype, 'removeChild')
+                .mockImplementation(() => getRootEl());
             appEmbed.destroy();
-            await new Promise(resolve => setTimeout(resolve, 50));
+            await new Promise((resolve) => setTimeout(resolve, 50));
             expect(removeChildSpy).toHaveBeenCalled();
             embedConfig.setEmbedConfig(originalEmbedConfig);
         });
@@ -2915,7 +2985,9 @@ describe('Unit test case for ts embed', () => {
                 });
                 await appEmbed.render();
                 const triggerSpy = jest.spyOn(appEmbed, 'trigger').mockResolvedValue(null);
-                const removeChildSpy = jest.spyOn(Node.prototype, 'removeChild').mockImplementation(() => getRootEl());
+                const removeChildSpy = jest
+                    .spyOn(Node.prototype, 'removeChild')
+                    .mockImplementation(() => getRootEl());
                 appEmbed.destroy();
                 expect(triggerSpy).toHaveBeenCalledWith(HostEvent.DestroyEmbed);
                 expect(removeChildSpy).toHaveBeenCalled();
@@ -2934,12 +3006,14 @@ describe('Unit test case for ts embed', () => {
                 });
                 await appEmbed.render();
                 const triggerSpy = jest.spyOn(appEmbed, 'trigger').mockResolvedValue(null);
-                const removeChildSpy = jest.spyOn(Node.prototype, 'removeChild').mockImplementation(() => getRootEl());
+                const removeChildSpy = jest
+                    .spyOn(Node.prototype, 'removeChild')
+                    .mockImplementation(() => getRootEl());
                 appEmbed.destroy();
                 // Should be called immediately when config is enabled
                 expect(triggerSpy).toHaveBeenCalledWith(HostEvent.DestroyEmbed);
                 // Wait for the timeout to complete
-                await new Promise(resolve => setTimeout(resolve, 1100));
+                await new Promise((resolve) => setTimeout(resolve, 1100));
                 expect(removeChildSpy).toHaveBeenCalled();
             });
             it('should handle Promise.race with successful cleanup completion', async () => {
@@ -2956,11 +3030,15 @@ describe('Unit test case for ts embed', () => {
                 });
                 await appEmbed.render();
                 // Mock trigger to resolve quickly (before timeout)
-                const triggerSpy = jest.spyOn(appEmbed, 'trigger').mockImplementation(() => new Promise(resolve => setTimeout(() => resolve(null), 100)));
-                const removeChildSpy = jest.spyOn(Node.prototype, 'removeChild').mockImplementation(() => getRootEl());
+                const triggerSpy = jest
+                    .spyOn(appEmbed, 'trigger')
+                    .mockImplementation(() => new Promise((resolve) => setTimeout(() => resolve(null), 100)));
+                const removeChildSpy = jest
+                    .spyOn(Node.prototype, 'removeChild')
+                    .mockImplementation(() => getRootEl());
                 appEmbed.destroy();
                 // Wait for the trigger to complete
-                await new Promise(resolve => setTimeout(resolve, 200));
+                await new Promise((resolve) => setTimeout(resolve, 200));
                 expect(triggerSpy).toHaveBeenCalledWith(HostEvent.DestroyEmbed);
                 expect(removeChildSpy).toHaveBeenCalled();
             });
@@ -2978,11 +3056,15 @@ describe('Unit test case for ts embed', () => {
                 });
                 await appEmbed.render();
                 // Mock trigger to take longer than timeout
-                const triggerSpy = jest.spyOn(appEmbed, 'trigger').mockImplementation(() => new Promise(resolve => setTimeout(() => resolve(null), 500)));
-                const removeChildSpy = jest.spyOn(Node.prototype, 'removeChild').mockImplementation(() => getRootEl());
+                const triggerSpy = jest
+                    .spyOn(appEmbed, 'trigger')
+                    .mockImplementation(() => new Promise((resolve) => setTimeout(() => resolve(null), 500)));
+                const removeChildSpy = jest
+                    .spyOn(Node.prototype, 'removeChild')
+                    .mockImplementation(() => getRootEl());
                 appEmbed.destroy();
                 // Wait for the timeout to complete
-                await new Promise(resolve => setTimeout(resolve, 200));
+                await new Promise((resolve) => setTimeout(resolve, 200));
                 expect(triggerSpy).toHaveBeenCalledWith(HostEvent.DestroyEmbed);
                 expect(removeChildSpy).toHaveBeenCalled();
             });
@@ -3010,11 +3092,11 @@ describe('Unit test case for ts embed', () => {
                         body: JSON.stringify({
                             variables: {
                                 session: { sessionId: 'session-123' },
-                                contextBookId: 'viz-456'
-                            }
-                        })
-                    }
-                })
+                                contextBookId: 'viz-456',
+                            },
+                        }),
+                    },
+                }),
             };
             const mockPort = {
                 postMessage: jest.fn(),
@@ -3045,8 +3127,8 @@ describe('Unit test case for ts embed', () => {
                 type: EmbedEvent.ApiIntercept,
                 data: JSON.stringify({
                     input: '/prism/?op=GetChartWithData',
-                    init: {}
-                })
+                    init: {},
+                }),
             };
             const mockPort = {
                 postMessage: jest.fn(),
@@ -3078,8 +3160,8 @@ describe('Unit test case for ts embed', () => {
                 type: EmbedEvent.ApiIntercept,
                 data: JSON.stringify({
                     input: '/prism/?op=GetChartWithData',
-                    init: {}
-                })
+                    init: {},
+                }),
             };
             const mockPort = {
                 postMessage: jest.fn(),
@@ -3096,7 +3178,7 @@ describe('Unit test case for ts embed', () => {
                 // handleInterceptEvent
                 const result = await capturedGetUnsavedAnswerTml({
                     sessionId: 'session-123',
-                    vizId: 'viz-456'
+                    vizId: 'viz-456',
                 });
                 expect(mockProcessTrigger).toHaveBeenCalled();
                 const callArgs = mockProcessTrigger.mock.calls[0];
@@ -3106,8 +3188,8 @@ describe('Unit test case for ts embed', () => {
                     type: 'getUnsavedAnswerTML',
                     parameters: {
                         sessionId: 'session-123',
-                        vizId: 'viz-456'
-                    }
+                        vizId: 'viz-456',
+                    },
                 });
                 expect(result).toEqual(mockTmlResponse);
             });
@@ -3124,8 +3206,8 @@ describe('Unit test case for ts embed', () => {
                 type: EmbedEvent.ApiIntercept,
                 data: JSON.stringify({
                     input: '/api/test',
-                    init: {}
-                })
+                    init: {},
+                }),
             };
             const mockPort = {
                 postMessage: jest.fn(),
@@ -3149,8 +3231,8 @@ describe('Unit test case for ts embed', () => {
                 type: EmbedEvent.ApiIntercept,
                 data: JSON.stringify({
                     input: '/prism/?op=GetChartWithData',
-                    init: {}
-                })
+                    init: {},
+                }),
             };
             const mockPort = {
                 postMessage: jest.fn(),
@@ -3191,15 +3273,15 @@ describe('Unit test case for ts embed', () => {
                 type: EmbedEvent.ApiIntercept,
                 data: JSON.stringify({
                     input: '/prism/?op=GetChartWithData',
-                    init: {}
-                })
+                    init: {},
+                }),
             };
             const mockEventData2 = {
                 type: EmbedEvent.ApiIntercept,
                 data: JSON.stringify({
                     input: '/prism/?op=LoadContextBook',
-                    init: {}
-                })
+                    init: {},
+                }),
             };
             const mockPort = {
                 postMessage: jest.fn(),
@@ -3228,8 +3310,8 @@ describe('Unit test case for ts embed', () => {
                 type: EmbedEvent.ApiIntercept,
                 data: JSON.stringify({
                     input: '/prism/?op=GetChartWithData',
-                    init: {}
-                })
+                    init: {},
+                }),
             };
             const mockPort = {
                 postMessage: jest.fn(),
@@ -3260,8 +3342,8 @@ describe('Unit test case for ts embed', () => {
                 type: EmbedEvent.ApiIntercept,
                 data: JSON.stringify({
                     input: '/prism/?op=GetChartWithData',
-                    init: {}
-                })
+                    init: {},
+                }),
             };
             const mockPort = {
                 postMessage: jest.fn(),
@@ -3274,7 +3356,7 @@ describe('Unit test case for ts embed', () => {
                 expect(capturedGetUnsavedAnswerTml).toBeDefined();
                 const result = await capturedGetUnsavedAnswerTml({
                     sessionId: 'session-123',
-                    vizId: 'viz-456'
+                    vizId: 'viz-456',
                 });
                 expect(result).toBeUndefined();
             });
@@ -3289,8 +3371,8 @@ describe('Unit test case for ts embed', () => {
                 type: EmbedEvent.ApiIntercept,
                 data: JSON.stringify({
                     input: '/prism/?op=LoadContextBook',
-                    init: {}
-                })
+                    init: {},
+                }),
             };
             const mockPort = {
                 postMessage: jest.fn(),
@@ -3524,12 +3606,13 @@ describe('ShowPreRender with UpdateEmbedParams', () => {
     const setupPreRenderTest = async (preRenderId, initialConfig) => {
         createRootEleForEmbed();
         mockMessageChannel();
-        window.ResizeObserver = window.ResizeObserver
-            || jest.fn().mockImplementation(() => ({
-                disconnect: jest.fn(),
-                observe: jest.fn(),
-                unobserve: jest.fn(),
-            }));
+        window.ResizeObserver =
+            window.ResizeObserver ||
+                jest.fn().mockImplementation(() => ({
+                    disconnect: jest.fn(),
+                    observe: jest.fn(),
+                    unobserve: jest.fn(),
+                }));
         const embed1 = new LiveboardEmbed('#tsEmbedDiv', {
             preRenderId,
             ...initialConfig,
@@ -3680,7 +3763,8 @@ describe('ShowPreRender with UpdateEmbedParams', () => {
                 authType: AuthType.None,
             });
         });
-        // Matches the structure produced by createValidationError / embedErrorDetails
+        // Matches the structure produced by createValidationError /
+        // embedErrorDetails
         const makeNestedValidationData = (message = 'invalid payload') => ({
             type: EmbedEvent.Error,
             data: {
@@ -3690,7 +3774,8 @@ describe('ShowPreRender with UpdateEmbedParams', () => {
                 error: message,
             },
         });
-        // Matches the flat structure where errorType sits at the top level of data
+        // Matches the flat structure where errorType sits at the top level of
+        // data
         const makeFlatValidationData = (message = 'invalid payload') => ({
             errorType: EmbedErrorCodes.HOST_EVENT_VALIDATION,
             message,
@@ -3731,14 +3816,20 @@ describe('ShowPreRender with UpdateEmbedParams', () => {
         });
         test('delivers Error event to handler when useHostEventsV2 is true and shouldBypassPayloadValidation is undefined', () => {
             const errorHandler = jest.fn();
-            const embed = makeEmbed({ useHostEventsV2: true, shouldBypassPayloadValidation: undefined });
+            const embed = makeEmbed({
+                useHostEventsV2: true,
+                shouldBypassPayloadValidation: undefined,
+            });
             embed.on(EmbedEvent.Error, errorHandler);
             embed.executeCallbacks(EmbedEvent.Error, makeNestedValidationData());
             expect(errorHandler).toHaveBeenCalled();
         });
         test('delivers Error event to handler when useHostEventsV2 is true and shouldBypassPayloadValidation is false', () => {
             const errorHandler = jest.fn();
-            const embed = makeEmbed({ useHostEventsV2: true, shouldBypassPayloadValidation: false });
+            const embed = makeEmbed({
+                useHostEventsV2: true,
+                shouldBypassPayloadValidation: false,
+            });
             embed.on(EmbedEvent.Error, errorHandler);
             embed.executeCallbacks(EmbedEvent.Error, makeNestedValidationData());
             expect(errorHandler).toHaveBeenCalled();
@@ -3746,7 +3837,10 @@ describe('ShowPreRender with UpdateEmbedParams', () => {
         test('skips Error event when useHostEventsV2 is false regardless of shouldBypassPayloadValidation', () => {
             jest.spyOn(logger, 'warn');
             const errorHandler = jest.fn();
-            const embed = makeEmbed({ useHostEventsV2: false, shouldBypassPayloadValidation: undefined });
+            const embed = makeEmbed({
+                useHostEventsV2: false,
+                shouldBypassPayloadValidation: undefined,
+            });
             embed.on(EmbedEvent.Error, errorHandler);
             embed.executeCallbacks(EmbedEvent.Error, makeNestedValidationData());
             expect(errorHandler).not.toHaveBeenCalled();
@@ -3762,7 +3856,10 @@ describe('ShowPreRender with UpdateEmbedParams', () => {
         test('skips Error event when useHostEventsV2 is false and shouldBypassPayloadValidation is true', () => {
             jest.spyOn(logger, 'warn');
             const errorHandler = jest.fn();
-            const embed = makeEmbed({ useHostEventsV2: false, shouldBypassPayloadValidation: true });
+            const embed = makeEmbed({
+                useHostEventsV2: false,
+                shouldBypassPayloadValidation: true,
+            });
             embed.on(EmbedEvent.Error, errorHandler);
             embed.executeCallbacks(EmbedEvent.Error, makeNestedValidationData());
             expect(errorHandler).not.toHaveBeenCalled();
@@ -3787,14 +3884,20 @@ describe('ShowPreRender with UpdateEmbedParams', () => {
         });
         test('delivers Error event to EmbedEvent.ALL handler when not skipped', () => {
             const allHandler = jest.fn();
-            const embed = makeEmbed({ useHostEventsV2: true, shouldBypassPayloadValidation: false });
+            const embed = makeEmbed({
+                useHostEventsV2: true,
+                shouldBypassPayloadValidation: false,
+            });
             embed.on(EmbedEvent.ALL, allHandler);
             embed.executeCallbacks(EmbedEvent.Error, makeNestedValidationData());
             expect(allHandler).toHaveBeenCalled();
         });
         test('does not skip non-Error events even with HOST_EVENT_VALIDATION error code', () => {
             const customActionHandler = jest.fn();
-            const embed = makeEmbed({ useHostEventsV2: true, shouldBypassPayloadValidation: false });
+            const embed = makeEmbed({
+                useHostEventsV2: true,
+                shouldBypassPayloadValidation: false,
+            });
             embed.on(EmbedEvent.CustomAction, customActionHandler);
             embed.executeCallbacks(EmbedEvent.CustomAction, {
                 data: { code: EmbedErrorCodes.HOST_EVENT_VALIDATION },
@@ -3803,7 +3906,10 @@ describe('ShowPreRender with UpdateEmbedParams', () => {
         });
         test('does not skip Error events with unrelated error codes', () => {
             const errorHandler = jest.fn();
-            const embed = makeEmbed({ useHostEventsV2: true, shouldBypassPayloadValidation: false });
+            const embed = makeEmbed({
+                useHostEventsV2: true,
+                shouldBypassPayloadValidation: false,
+            });
             embed.on(EmbedEvent.Error, errorHandler);
             embed.executeCallbacks(EmbedEvent.Error, {
                 errorType: 'SOME_OTHER_ERROR',
@@ -3812,5 +3918,145 @@ describe('ShowPreRender with UpdateEmbedParams', () => {
             expect(errorHandler).toHaveBeenCalled();
         });
     });
+    describe('constructor init-path branching (SCAL-315058)', () => {
+        beforeEach(() => {
+            init({
+                thoughtSpotHost: 'tshost',
+                authType: AuthType.None,
+            });
+        });
+        it('sets hostElement from domSelector', () => {
+            const embed = new SearchEmbed(getRootEl(), defaultViewConfig);
+            expect(embed.hostElement).toBe(getRootEl());
+        });
+        it('skips isReadyForRenderPromise when init already completed', () => {
+            jest.spyOn(baseInstance, 'getIsInitCompleted').mockReturnValue(true);
+            const embed = new SearchEmbed(getRootEl(), defaultViewConfig);
+            expect(embed.shouldWaitForRenderPromise).toBe(false);
+            expect(embed.isReadyForRenderPromise).toBeUndefined();
+        });
+        it('sets isReadyForRenderPromise when init not yet completed', () => {
+            jest.spyOn(baseInstance, 'getIsInitCompleted').mockReturnValue(false);
+            const embed = new SearchEmbed(getRootEl(), defaultViewConfig);
+            expect(embed.shouldWaitForRenderPromise).toBe(true);
+            expect(embed.isReadyForRenderPromise).toBeInstanceOf(Promise);
+        });
+        it('afterInit runs synchronously when init already completed', () => {
+            jest.spyOn(baseInstance, 'getIsInitCompleted').mockReturnValue(true);
+            const embed = new SearchEmbed(getRootEl(), defaultViewConfig);
+            // thoughtSpotHost is set by afterInit;
+            // must be non-empty after constructor
+            expect(embed.thoughtSpotHost).toBeTruthy();
+        });
+        it('does not set isReadyForRenderPromise when shouldWaitForRenderPromise is false', () => {
+            jest.spyOn(baseInstance, 'getIsInitCompleted').mockReturnValue(true);
+            const embed = new SearchEmbed(getRootEl(), defaultViewConfig);
+            expect(embed.shouldWaitForRenderPromise).toBe(false);
+            // isReadyForRenderPromise must be undefined
+            //  so no unnecessary await occurs
+            expect(embed.isReadyForRenderPromise).toBeUndefined();
+        });
+        it('shouldWaitForRenderPromise flips to false after promise settles', async () => {
+            jest.spyOn(baseInstance, 'getIsInitCompleted').mockReturnValue(false);
+            const embed = new SearchEmbed(getRootEl(), defaultViewConfig);
+            expect(embed.shouldWaitForRenderPromise).toBe(true);
+            await embed.isReadyForRenderPromise;
+            expect(embed.shouldWaitForRenderPromise).toBe(false);
+        });
+        it('calls throwInitError when getInitPromise rejects', async () => {
+            jest.spyOn(baseInstance, 'getIsInitCompleted').mockReturnValue(false);
+            jest.spyOn(baseInstance, 'getInitPromise').mockReturnValue(Promise.reject(new Error('init failed')));
+            const embed = new SearchEmbed(getRootEl(), defaultViewConfig);
+            const throwInitErrorSpy = jest.spyOn(embed, 'throwInitError');
+            await embed.isReadyForRenderPromise;
+            expect(throwInitErrorSpy).toHaveBeenCalled();
+        });
+        it('shouldWaitForRenderPromise flips to false even when getInitPromise rejects', async () => {
+            jest.spyOn(baseInstance, 'getIsInitCompleted').mockReturnValue(false);
+            jest.spyOn(baseInstance, 'getInitPromise').mockReturnValue(Promise.reject(new Error('init failed')));
+            const embed = new SearchEmbed(getRootEl(), defaultViewConfig);
+            await embed.isReadyForRenderPromise;
+            expect(embed.shouldWaitForRenderPromise).toBe(false);
+        });
+    });
+    describe('preRender ID object includes placeHolder (SCAL-315058)', () => {
+        beforeAll(() => {
+            init({
+                thoughtSpotHost: 'tshost',
+                authType: AuthType.None,
+            });
+        });
+        it('getPreRenderIds returns placeHolder key', () => {
+            createRootEleForEmbed();
+            const embed = new LiveboardEmbed('#tsEmbedDiv', {
+                preRenderId: 'ph-test',
+                liveboardId: 'lb-id',
+            });
+            const ids = embed.getPreRenderIds();
+            expect(ids.placeHolder).toBe('tsEmbed-pre-render-placeholder-ph-test');
+        });
+    });
+    describe('isPreRenderConnected logic (SCAL-315058)', () => {
+        beforeAll(() => {
+            init({
+                thoughtSpotHost: 'tshost',
+                authType: AuthType.None,
+            });
+        });
+        it('returns false when preRenderWrapper is absent', () => {
+            createRootEleForEmbed();
+            const embed = new LiveboardEmbed('#tsEmbedDiv', {
+                preRenderId: 'conn-test',
+                liveboardId: 'lb-id',
+            });
+            expect(embed.isPreRenderConnected()).toBe(false);
+        });
+        it('returns true once preRenderWrapper and preRenderChild are set', () => {
+            createRootEleForEmbed();
+            const embed = new LiveboardEmbed('#tsEmbedDiv', {
+                preRenderId: 'conn-test-2',
+                liveboardId: 'lb-id',
+            });
+            embed.preRenderWrapper = document.createElement('div');
+            embed.preRenderChild = document.createElement('div');
+            expect(embed.isPreRenderConnected()).toBe(true);
+        });
+    });
+    describe('showPreRender inserts placeholder into hostElement (SCAL-315058)', () => {
+        beforeAll(() => {
+            // Clear spy implementations that may have leaked from prior
+            // describe blocks (e.g. getIsInitCompleted/getInitPromise mocks set
+            // in 'constructor init-path branching' persist across describes
+            // because clearAllMocks only clears call history, not
+            // implementations).
+            jest.restoreAllMocks();
+            jest.spyOn(authInstance, 'postLoginService').mockResolvedValue(undefined);
+            init({
+                thoughtSpotHost: 'tshost',
+                authType: AuthType.None,
+            });
+            window.ResizeObserver = jest.fn().mockImplementation(() => ({
+                disconnect: jest.fn(),
+                observe: jest.fn(),
+                unobserve: jest.fn(),
+            }));
+        });
+        it('showPreRender creates a placeholder element with the correct id', async () => {
+            createRootEleForEmbed();
+            const embed = new LiveboardEmbed('#tsEmbedDiv', {
+                preRenderId: 'ph-lifecycle-test',
+                liveboardId: 'lb-id',
+            });
+            await embed.preRender();
+            await waitFor(() => !!document.querySelector('#tsEmbed-pre-render-child-ph-lifecycle-test'));
+            await embed.showPreRender();
+            const placeholderEle = embed.getPreRenderPlaceHolderElement();
+            expect(placeholderEle).not.toBeNull();
+            expect(placeholderEle.id).toBe('tsEmbed-pre-render-placeholder-ph-lifecycle-test');
+            // placeholder is attached to a parent element (inside hostElement)
+            expect(placeholderEle.parentElement).not.toBeNull();
+            embed.destroy();
+        });
+    });
 });
 //# sourceMappingURL=ts-embed.spec.js.map