@thoughtspot/visual-embed-sdk 1.46.5 → 1.47.1

package/cjs/src/embed/ts-embed.spec.js

@@ -1824,22 +1824,6 @@ describe('Unit test case for ts embed', () => {
             await (0, test_utils_1.executeAfterWait)(() => {
                 (0, test_utils_1.expectUrlMatchesWithParams)((0, test_utils_1.getIFrameSrc)(), `http://${thoughtSpotHost}/?embedApp=true${exports.defaultParams}#/embed/viz/${liveboardId}`);
             });
-            const defaultConfig = {
-                disableWorksheetChange: false,
-                hideWorksheetSelector: false,
-                hideSageAnswerHeader: false,
-                hideAutocompleteSuggestions: false,
-                hideSampleQuestions: false,
-                isProductTour: false,
-                dataPanelV2: false,
-            };
-            const sageEmbed = new index_1.SageEmbed((0, test_utils_1.getRootEl)(), {
-                ...defaultConfig,
-            });
-            sageEmbed.render();
-            await (0, test_utils_1.executeAfterWait)(() => {
-                (0, test_utils_1.expectUrlMatch)((0, test_utils_1.getIFrameSrc)(), `http://${thoughtSpotHost}/?embedApp=true&enableDataPanelV2=false&isSageEmbed=true&disableWorksheetChange=false&hideWorksheetSelector=false&hideEurekaSuggestions=false&isProductTour=false&hideSageAnswerHeader=false&hideAction=%5B%22reportError%22%5D#/embed/eureka`);
-            });
         });
         it('Should add contextMenuEnabledOnWhichClick flag to the iframe with left value', async () => {
             const liveboardEmbed = new index_1.LiveboardEmbed((0, test_utils_1.getRootEl)(), {
@@ -1851,23 +1835,6 @@ describe('Unit test case for ts embed', () => {
             await (0, test_utils_1.executeAfterWait)(() => {
                 (0, test_utils_1.expectUrlMatchesWithParams)((0, test_utils_1.getIFrameSrc)(), `http://${thoughtSpotHost}/?embedApp=true${exports.defaultParams}&contextMenuEnabledOnWhichClick=left#/embed/viz/${liveboardId}`);
             });
-            const defaultConfig = {
-                disableWorksheetChange: false,
-                hideWorksheetSelector: false,
-                hideSageAnswerHeader: false,
-                hideAutocompleteSuggestions: false,
-                hideSampleQuestions: false,
-                isProductTour: false,
-                dataPanelV2: false,
-            };
-            const sageEmbed = new index_1.SageEmbed((0, test_utils_1.getRootEl)(), {
-                ...defaultConfig,
-                contextMenuTrigger: types_1.ContextMenuTriggerOptions.LEFT_CLICK,
-            });
-            sageEmbed.render();
-            await (0, test_utils_1.executeAfterWait)(() => {
-                (0, test_utils_1.expectUrlMatch)((0, test_utils_1.getIFrameSrc)(), `http://${thoughtSpotHost}/?embedApp=true&enableDataPanelV2=false&contextMenuEnabledOnWhichClick=left&isSageEmbed=true&disableWorksheetChange=false&hideWorksheetSelector=false&hideEurekaSuggestions=false&isProductTour=false&hideSageAnswerHeader=false&hideAction=%5B%22reportError%22%5D#/embed/eureka`);
-            });
         });
         it('Should add contextMenuEnabledOnWhichClick flag to the iframe with right value', async () => {
             const liveboardEmbed = new index_1.LiveboardEmbed((0, test_utils_1.getRootEl)(), {
@@ -1879,23 +1846,6 @@ describe('Unit test case for ts embed', () => {
             await (0, test_utils_1.executeAfterWait)(() => {
                 (0, test_utils_1.expectUrlMatchesWithParams)((0, test_utils_1.getIFrameSrc)(), `http://${thoughtSpotHost}/?embedApp=true${exports.defaultParams}&contextMenuEnabledOnWhichClick=right#/embed/viz/${liveboardId}`);
             });
-            const defaultConfig = {
-                disableWorksheetChange: false,
-                hideWorksheetSelector: false,
-                hideSageAnswerHeader: false,
-                hideAutocompleteSuggestions: false,
-                hideSampleQuestions: false,
-                isProductTour: false,
-                dataPanelV2: false,
-            };
-            const sageEmbed = new index_1.SageEmbed((0, test_utils_1.getRootEl)(), {
-                ...defaultConfig,
-                contextMenuTrigger: types_1.ContextMenuTriggerOptions.RIGHT_CLICK,
-            });
-            sageEmbed.render();
-            await (0, test_utils_1.executeAfterWait)(() => {
-                (0, test_utils_1.expectUrlMatch)((0, test_utils_1.getIFrameSrc)(), `http://${thoughtSpotHost}/?embedApp=true&enableDataPanelV2=false&contextMenuEnabledOnWhichClick=right&isSageEmbed=true&disableWorksheetChange=false&hideWorksheetSelector=false&hideEurekaSuggestions=false&isProductTour=false&hideSageAnswerHeader=false&hideAction=%5B%22reportError%22%5D#/embed/eureka`);
-            });
         });
         it('Should add contextMenuEnabledOnWhichClick flag to the iframe with both value', async () => {
             const liveboardEmbed = new index_1.LiveboardEmbed((0, test_utils_1.getRootEl)(), {
@@ -1907,23 +1857,6 @@ describe('Unit test case for ts embed', () => {
             await (0, test_utils_1.executeAfterWait)(() => {
                 (0, test_utils_1.expectUrlMatchesWithParams)((0, test_utils_1.getIFrameSrc)(), `http://${thoughtSpotHost}/?embedApp=true${exports.defaultParams}&contextMenuEnabledOnWhichClick=both#/embed/viz/${liveboardId}`);
             });
-            const defaultConfig = {
-                disableWorksheetChange: false,
-                hideWorksheetSelector: false,
-                hideSageAnswerHeader: false,
-                hideAutocompleteSuggestions: false,
-                hideSampleQuestions: false,
-                isProductTour: false,
-                dataPanelV2: false,
-            };
-            const sageEmbed = new index_1.SageEmbed((0, test_utils_1.getRootEl)(), {
-                ...defaultConfig,
-                contextMenuTrigger: types_1.ContextMenuTriggerOptions.BOTH_CLICKS,
-            });
-            sageEmbed.render();
-            await (0, test_utils_1.executeAfterWait)(() => {
-                (0, test_utils_1.expectUrlMatch)((0, test_utils_1.getIFrameSrc)(), `http://${thoughtSpotHost}/?embedApp=true&enableDataPanelV2=false&contextMenuEnabledOnWhichClick=both&isSageEmbed=true&disableWorksheetChange=false&hideWorksheetSelector=false&hideEurekaSuggestions=false&isProductTour=false&hideSageAnswerHeader=false&hideAction=%5B%22reportError%22%5D#/embed/eureka`);
-            });
         });
     });
     describe('validate getThoughtSpotPostUrlParams', () => {
@@ -2908,6 +2841,34 @@ describe('Unit test case for ts embed', () => {
             appEmbed.destroy();
             expect((0, test_utils_1.getRootEl)().nextElementSibling.innerHTML).toBe('');
         });
+        it('should not call trigger or remove DOM if destroy is called before render', () => {
+            const appEmbed = new index_1.AppEmbed((0, test_utils_1.getRootEl)(), {
+                frameParams: { width: '100%', height: '100%' },
+            });
+            const triggerSpy = jest.spyOn(appEmbed, 'trigger');
+            const removeChildSpy = jest.spyOn(Node.prototype, 'removeChild');
+            appEmbed.destroy();
+            expect(triggerSpy).not.toHaveBeenCalled();
+            expect(removeChildSpy).not.toHaveBeenCalled();
+        });
+        it('should still remove DOM element when trigger rejects (waitForCleanupOnDestroy: true)', async () => {
+            const originalEmbedConfig = embedConfig.getEmbedConfig();
+            embedConfig.setEmbedConfig({
+                ...originalEmbedConfig,
+                waitForCleanupOnDestroy: true,
+                cleanupTimeout: 1000,
+            });
+            const appEmbed = new index_1.AppEmbed((0, test_utils_1.getRootEl)(), {
+                frameParams: { width: '100%', height: '100%' },
+            });
+            await appEmbed.render();
+            jest.spyOn(appEmbed, 'trigger').mockRejectedValue(new Error('trigger failed'));
+            const removeChildSpy = jest.spyOn(Node.prototype, 'removeChild').mockImplementation(() => (0, test_utils_1.getRootEl)());
+            appEmbed.destroy();
+            await new Promise(resolve => setTimeout(resolve, 50));
+            expect(removeChildSpy).toHaveBeenCalled();
+            embedConfig.setEmbedConfig(originalEmbedConfig);
+        });
         describe('with waitForCleanupOnDestroy configuration', () => {
             let originalEmbedConfig;
             beforeEach(() => {