@thoughtspot/visual-embed-sdk 1.46.1 → 1.46.3

package/src/utils/graphql/answerService/answerService.spec.ts

@@ -312,6 +312,68 @@ describe('Answer service tests', () => {
         await expect(answerService.getUnderlyingDataForPoint(['col2'])).rejects.toThrow();
     });
 
+    test.each([
+        ['DATE', 12345, 'epoch-date'],
+        ['DATE_TIME', 98765, 'epoch-datetime'],
+        ['TIME', 55555, 'epoch-time'],
+    ])('getUnderlyingDataForPoint should pass epochRange with startEpoch for %s type with numeric value %d', async (dataType, value, sourceId) => {
+        fetchMock.mockResponses(
+            JSON.stringify({
+                data: {
+                    getSourceDetailById: [{
+                        columns: [{ id: 'id1', name: 'col1' }],
+                    }],
+                },
+            }),
+            JSON.stringify({
+                data: {
+                    Answer__getUnaggregatedAnswer: {
+                        id: { ...defaultSession },
+                        answer: {
+                            visualizations: [{
+                                columns: [{
+                                    column: {
+                                        id: 'oid1',
+                                        name: 'col1',
+                                        referencedColumns: [{ guid: 'id1' }],
+                                    },
+                                }],
+                            }],
+                        },
+                    },
+                },
+            }),
+        );
+        const answerService = createAnswerService({
+            sources: [{ header: { guid: sourceId } }],
+        }, [{
+            selectedAttributes: [{
+                column: { id: 'oid1', name: 'col1', dataType },
+                value,
+            }],
+            selectedMeasures: [],
+        }]);
+        await answerService.getUnderlyingDataForPoint(['col1']);
+        expect(fetchMock).toHaveBeenCalledWith(
+            'https://tshost/prism/?op=GetUnAggregatedAnswerSession',
+            expect.objectContaining({
+                body: JSON.stringify({
+                    operationName: 'GetUnAggregatedAnswerSession',
+                    query: queries.getUnaggregatedAnswerSession,
+                    variables: {
+                        session: defaultSession,
+                        columns: [{
+                            columnId: 'oid1',
+                            dataValue: [{
+                                epochRange: { startEpoch: value },
+                            }],
+                        }],
+                    },
+                }),
+            }),
+        );
+    });
+
     test('addFilter should call the right API', async () => {
         fetchMock.mockResponses(
             JSON.stringify({

package/src/utils/graphql/answerService/answerService.ts

@@ -14,7 +14,7 @@ export interface SessionInterface {
     acSession: { sessionId: string; genNo: number };
 }
 
-// eslint-disable-next-line no-shadow
+ 
 export enum OperationType {
     GetChartWithData = 'GetChartWithData',
     GetTableWithHeadlineData = 'GetTableWithHeadlineData',
@@ -25,6 +25,8 @@ export interface UnderlyingDataPoint {
     dataValue: any;
 }
 
+export const DATA_TYPES = ['DATE', 'DATE_TIME', 'TIME'];
+
 /**
  * AnswerService provides a simple way to work with ThoughtSpot Answers.
  *
@@ -34,10 +36,11 @@ export interface UnderlyingDataPoint {
  *
  * You can use this service to:
  *
- * - Add or remove columns from Answers (`addColumns`, `removeColumns`, `addColumnsByName`)
- * - Apply filters to Answers (`addFilter`)
- * - Get data from Answers in different formats (JSON, CSV, PNG) (`fetchData`, `fetchCSVBlob`, `fetchPNGBlob`)
- * - Get data for specific points in visualizations (`getUnderlyingDataForPoint`)
+ * - Add or remove columns from Answers (`addColumns`, `removeColumns`,
+ * `addColumnsByName`) - Apply filters to Answers (`addFilter`)
+ * - Get data from Answers in different formats (JSON, CSV, PNG) (`fetchData`,
+ * `fetchCSVBlob`, `fetchPNGBlob`) - Get data for specific points in visualizations
+ * (`getUnderlyingDataForPoint`)
  * - Run custom queries (`executeQuery`)
  * - Add visualizations to Liveboards (`addDisplayedVizToLiveboard`)
  *
@@ -70,7 +73,7 @@ export interface UnderlyingDataPoint {
  * });
  * ```
  * 
- * @version SDK: 1.25.0| ThoughtSpot: 9.10.0.cl
+ * @version SDK: 1.25.0 | ThoughtSpot: 9.10.0.cl
  * @group Events
  */
 export class AnswerService {
@@ -149,6 +152,7 @@ export class AnswerService {
      *    ]);
      *    console.log(await service.fetchData());
      * });
+     * ```
      */
     public async addColumnsByName(columnNames: string[]) {
         const sourceDetail = await this.getSourceDetail();
@@ -308,7 +312,7 @@ export class AnswerService {
      *     const data = await underlying.fetchData(0, 100);
      *  })
      * ```
-     * @version SDK: 1.25.0| ThoughtSpot: 9.10.0.cl
+     * @version SDK: 1.25.0 | ThoughtSpot: 9.10.0.cl
      */
     public async getUnderlyingDataForPoint(
         outputColumnNames: string[],
@@ -465,7 +469,7 @@ function getSelectedPointsForUnderlyingDataQuery(
         const dataType = colVal.column.dataType;
         const id = colVal.column.id;
         let dataValue;
-        if (dataType === 'DATE') {
+        if (DATA_TYPES.includes(dataType)) {
             if (Number.isFinite(colVal.value)) {
                 dataValue = [{
                     epochRange: {
@@ -504,12 +508,12 @@ function getSelectedPointsForUnderlyingDataQuery(
 function getDisplayedViz(visualizations: any[], displayMode: string) {
     if (displayMode === 'CHART_MODE') {
         return visualizations.find(
-            // eslint-disable-next-line no-underscore-dangle
+             
             (viz: any) => viz.__typename === 'ChartViz',
         );
     }
     return visualizations.find(
-        // eslint-disable-next-line no-underscore-dangle
+         
         (viz: any) => viz.__typename === 'TableViz',
     );
 }

package/src/utils/graphql/preview-service.ts

@@ -1,4 +1,4 @@
-/* eslint-disable quotes */
+ 
 import { graphqlQuery } from "./graphql-request";
 
 export const getPreviewQuery = `

package/src/utils/processData.ts

@@ -83,10 +83,10 @@ function processNoCookieAccess(e: any, containerEl: Element) {
     } = getEmbedConfig();
     if (!ignoreNoCookieAccess) {
         if (!suppressNoCookieAccessAlert && !suppressErrorAlerts) {
-            // eslint-disable-next-line no-alert
+             
             alert(ERROR_MESSAGE.THIRD_PARTY_COOKIE_BLOCKED_ALERT);
         }
-        // eslint-disable-next-line no-param-reassign
+         
         containerEl.innerHTML = loginFailedMessage;
     }
     notifyAuthFailure(AuthFailureType.NO_COOKIE_ACCESS);
@@ -107,11 +107,11 @@ export function processAuthFailure(e: any, containerEl: Element) {
     const isTrustedAuth = authType === AuthType.TrustedAuthToken || authType === AuthType.TrustedAuthTokenCookieless;
     const isEmbeddedSSOInfoFailure = isEmbeddedSSO && e?.data?.type === AuthFailureType.UNAUTHENTICATED_FAILURE;
     if (autoLogin && isTrustedAuth) {
-        // eslint-disable-next-line no-param-reassign
+         
         containerEl.innerHTML = loginFailedMessage;
         notifyAuthFailure(AuthFailureType.IDLE_SESSION_TIMEOUT);
     } else if (authType !== AuthType.None && !disableLoginFailurePage && !isEmbeddedSSOInfoFailure) {
-        // eslint-disable-next-line no-param-reassign
+         
         containerEl.innerHTML = loginFailedMessage;
         notifyAuthFailure(AuthFailureType.OTHER);
     }
@@ -126,7 +126,7 @@ export function processAuthFailure(e: any, containerEl: Element) {
  */
 function processAuthLogout(e: any, containerEl: Element) {
     const { loginFailedMessage } = getEmbedConfig();
-    // eslint-disable-next-line no-param-reassign
+     
     containerEl.innerHTML = loginFailedMessage;
     resetCachedAuthToken();
     disableAutoLogin();

package/src/utils.ts

@@ -600,6 +600,20 @@ export const validateHttpUrl = (url: string): [boolean, Error | null] => {
     }
 };
 
+/**
+ * Resolves enablePastConversationsSidebar with
+ * spotterSidebarConfig taking precedence over the
+ * standalone flag.
+ */
+export const resolveEnablePastConversationsSidebar = (params: {
+    spotterSidebarConfigValue?: boolean;
+    standaloneValue?: boolean;
+}): boolean | undefined => (
+    params.spotterSidebarConfigValue !== undefined
+        ? params.spotterSidebarConfigValue
+        : params.standaloneValue
+);
+
 /**
  * Sets a query parameter if the value is defined.
  * @param queryParams - The query params object to modify