@thoughtspot/visual-embed-sdk 1.45.1 → 1.45.3

package/src/authToken.spec.ts

@@ -1,7 +1,8 @@
 import { getAuthenticationToken, resetCachedAuthToken, validateAuthToken } from './authToken';
+import * as authTokenModule from './authToken';
 import * as authServiceInstance from './utils/authService/authService';
-import { EmbedConfig } from './types';
-import { formatTemplate } from './utils';
+import { EmbedConfig, AuthType } from './types';
+import { formatTemplate, storeValueInWindow } from './utils';
 import { logger } from './utils/logger';
 import { ERROR_MESSAGE } from './errors';
 
@@ -75,4 +76,92 @@ describe('AuthToken Unit tests', () => {
 
         loggerSpy.mockRestore();
     });
+
+    describe('getAuthenticationToken: cached token skip validation condition', () => {
+        beforeEach(() => {
+            resetCachedAuthToken();
+            jest.clearAllMocks();
+        });
+
+        test('should validate cached token when validation is not skipped', async () => {
+            const cachedToken = 'cached-token-123';
+            storeValueInWindow('cachedAuthToken', cachedToken);
+            
+            const validateAuthTokenSpy = jest.spyOn(authTokenModule, 'validateAuthToken')
+                .mockImplementation(() => Promise.resolve(true));
+
+            const getAuthTokenMock = jest.fn().mockResolvedValue('new-token-456');
+            const config: EmbedConfig = {
+                thoughtSpotHost: 'test',
+                authType: AuthType.TrustedAuthToken,
+                getAuthToken: getAuthTokenMock,
+                disableTokenVerification: false,
+            };
+
+            const token = await getAuthenticationToken(config, false);
+
+            expect(token).toBe(cachedToken);
+            // Should validate cached token (condition at line 23 is true)
+            expect(validateAuthTokenSpy).toHaveBeenCalledWith(config, cachedToken, true);
+            expect(getAuthTokenMock).not.toHaveBeenCalled();
+
+            validateAuthTokenSpy.mockReset();
+        });
+
+        test('should skip cached token validation when disableTokenVerification is true', async () => {
+            const cachedToken = 'cached-token-123';
+            storeValueInWindow('cachedAuthToken', cachedToken);
+            
+            const validateAuthTokenSpy = jest.spyOn(authTokenModule, 'validateAuthToken')
+                .mockImplementation(() => Promise.resolve(true));
+
+            const newToken = 'new-token-456';
+            const getAuthTokenMock = jest.fn().mockResolvedValue(newToken);
+            const config: EmbedConfig = {
+                thoughtSpotHost: 'test',
+                authType: AuthType.TrustedAuthToken,
+                getAuthToken: getAuthTokenMock,
+                disableTokenVerification: true,
+            };
+
+            const token = await getAuthenticationToken(config, false);
+
+            expect(token).toBe(newToken);
+            // Should not validate cached token (condition at line 23 is false)
+            expect(validateAuthTokenSpy).not.toHaveBeenCalledWith(config, cachedToken, true);
+            // But should validate new token (though it returns early when disableTokenVerification is true)
+            expect(validateAuthTokenSpy).toHaveBeenCalledWith(config, newToken);
+            expect(getAuthTokenMock).toHaveBeenCalled();
+
+            validateAuthTokenSpy.mockReset();
+        });
+
+        test('should skip cached token validation when skipvalidation is true', async () => {
+            const cachedToken = 'cached-token-123';
+            storeValueInWindow('cachedAuthToken', cachedToken);
+            
+            const validateAuthTokenSpy = jest.spyOn(authTokenModule, 'validateAuthToken')
+                .mockImplementation(() => Promise.resolve(true));
+
+            const newToken = 'new-token-456';
+            const getAuthTokenMock = jest.fn().mockResolvedValue(newToken);
+            const config: EmbedConfig = {
+                thoughtSpotHost: 'test',
+                authType: AuthType.TrustedAuthToken,
+                getAuthToken: getAuthTokenMock,
+                disableTokenVerification: false,
+            };
+
+            const token = await getAuthenticationToken(config, true);
+
+            expect(token).toBe(newToken);
+            // Should not validate cached token (condition at line 23 is false)
+            expect(validateAuthTokenSpy).not.toHaveBeenCalledWith(config, cachedToken, true);
+            // But should validate new token
+            expect(validateAuthTokenSpy).toHaveBeenCalledWith(config, newToken);
+            expect(getAuthTokenMock).toHaveBeenCalled();
+
+            validateAuthTokenSpy.mockReset();
+        });
+    });
 });

package/src/authToken.ts

@@ -16,11 +16,11 @@ const storeAuthTokenInCache = (token: string): void => {
  *
  * @param embedConfig
  */
-export async function getAuthenticationToken(embedConfig: EmbedConfig): Promise<string> {
+export async function getAuthenticationToken(embedConfig: EmbedConfig, skipvalidation: boolean = false): Promise<string> {
     const cachedAuthToken = getCacheAuthToken();
     // Since we don't have token validation enabled , we cannot tell if the
     // cached token is valid or not. So we will always fetch a new token.
-    if (cachedAuthToken && !embedConfig.disableTokenVerification) {
+    if (cachedAuthToken && !embedConfig.disableTokenVerification && !skipvalidation) {
         let isCachedTokenStillValid;
         try {
             isCachedTokenStillValid = await validateAuthToken(embedConfig, cachedAuthToken, true);

package/src/css-variables.ts

@@ -852,4 +852,64 @@ export interface CustomCssVariables {
      * Width of the Spotter chat window.
      */
     '--ts-var-spotter-chat-width'?: string;
+
+    /**
+     * Border color for the saved chats sidebar container.
+     */
+    '--ts-var-saved-chats-border-color'?: string;
+
+    /**
+     * Background color for the saved chats sidebar container.
+     */
+    '--ts-var-saved-chats-bg'?: string;
+
+    /**
+     * Text color for the saved chats sidebar container.
+     */
+    '--ts-var-saved-chats-text-color'?: string;
+
+    /**
+     * Border color for the saved chats sidebar header.
+     */
+    '--ts-var-saved-chats-header-border'?: string;
+
+    /**
+     * Color for the saved chats sidebar title text.
+     */
+    '--ts-var-saved-chats-title-color'?: string;
+
+    /**
+     * Background color for buttons (new chat, toggle, footer) in the saved chats sidebar.
+     */
+    '--ts-var-saved-chats-btn-bg'?: string;
+
+    /**
+     * Hover background color for buttons in the saved chats sidebar.
+     */
+    '--ts-var-saved-chats-btn-hover-bg'?: string;
+
+    /**
+     * Text color for conversation items in the saved chats sidebar.
+     */
+    '--ts-var-saved-chats-conv-text-color'?: string;
+
+    /**
+     * Background color for conversation items on hover in the saved chats sidebar.
+     */
+    '--ts-var-saved-chats-conv-hover-bg'?: string;
+
+    /**
+     * Background color for the active/selected conversation in the saved chats sidebar.
+     */
+    '--ts-var-saved-chats-conv-active-bg'?: string;
+
+    /**
+     * Border color for the saved chats sidebar footer.
+     */
+    '--ts-var-saved-chats-footer-border'?: string;
+
+    /**
+     * Color for section title text (e.g., "Recent", "Older") in the saved chats sidebar.
+     */
+    '--ts-var-saved-chats-section-title-color'?: string;
   }

package/src/embed/app.spec.ts

@@ -443,6 +443,38 @@ describe('App embed tests', () => {
         });
     });
 
+    test('should set hideToolResponseCardBranding to true in url via spotterChatConfig', async () => {
+        const appEmbed = new AppEmbed(getRootEl(), {
+            ...defaultViewConfig,
+            spotterChatConfig: {
+                hideToolResponseCardBranding: true,
+            },
+        } as AppViewConfig);
+        appEmbed.render();
+        await executeAfterWait(() => {
+            expectUrlMatchesWithParams(
+                getIFrameSrc(),
+                `http://${thoughtSpotHost}/?embedApp=true&profileAndHelpInNavBarHidden=false&hideToolResponseCardBranding=true${defaultParamsPost}#/home`,
+            );
+        });
+    });
+
+    test('should set toolResponseCardBrandingLabel in url via spotterChatConfig', async () => {
+        const appEmbed = new AppEmbed(getRootEl(), {
+            ...defaultViewConfig,
+            spotterChatConfig: {
+                toolResponseCardBrandingLabel: 'MyBrand',
+            },
+        } as AppViewConfig);
+        appEmbed.render();
+        await executeAfterWait(() => {
+            expectUrlMatchesWithParams(
+                getIFrameSrc(),
+                `http://${thoughtSpotHost}/?embedApp=true&profileAndHelpInNavBarHidden=false&toolResponseCardBrandingLabel=MyBrand${defaultParamsPost}#/home`,
+            );
+        });
+    });
+
     test('should set isLiveboardXLSXCSVDownloadEnabled to false in url', async () => {
         const appEmbed = new AppEmbed(getRootEl(), {
             ...defaultViewConfig,

package/src/embed/app.ts

@@ -9,7 +9,7 @@
  */
 
 import { logger } from '../utils/logger';
-import { calculateVisibleElementData, getQueryParamString, isUndefined, isValidCssMargin } from '../utils';
+import { calculateVisibleElementData, getQueryParamString, isUndefined, isValidCssMargin, setParamIfDefined, validateHttpUrl } from '../utils';
 import {
     Param,
     DOMSelector,
@@ -17,8 +17,12 @@ import {
     EmbedEvent,
     MessagePayload,
     AllEmbedViewConfig,
+    ErrorDetailsTypes,
+    EmbedErrorCodes,
 } from '../types';
 import { V1Embed } from './ts-embed';
+import { SpotterChatViewConfig, SpotterSidebarViewConfig } from './conversation';
+import { ERROR_MESSAGE } from '../errors';
 
 /**
  * Pages within the ThoughtSpot app that can be embedded.
@@ -672,6 +676,42 @@ export interface AppViewConfig extends AllEmbedViewConfig {
      * @version SDK: 1.45.0 | ThoughtSpot: 26.2.0.cl
      */
     updatedSpotterChatPrompt?: boolean;
+    /**
+     * Configuration for the Spotter sidebar UI customization.
+     * Only applicable when navigating to Spotter within the app.
+     *
+     * Supported embed types: `AppEmbed`
+     * @example
+     * ```js
+     * const embed = new AppEmbed('#tsEmbed', {
+     *    ... //other embed view config
+     *    spotterSidebarConfig: {
+     *        enablePastConversationsSidebar: true,
+     *        spotterSidebarTitle: 'My Conversations',
+     *    },
+     * })
+     * ```
+     * @version SDK: 1.46.0 | ThoughtSpot: 26.3.0.cl
+     */
+    spotterSidebarConfig?: SpotterSidebarViewConfig;
+    /**
+     * Configuration for customizing Spotter chat UI
+     * branding in tool response cards.
+     *
+     * Supported embed types: `AppEmbed`
+     * @example
+     * ```js
+     * const embed = new AppEmbed('#tsEmbed', {
+     *    ... //other embed view config
+     *    spotterChatConfig: {
+     *        hideToolResponseCardBranding: true,
+     *        toolResponseCardBrandingLabel: 'MyBrand',
+     *    },
+     * })
+     * ```
+     * @version SDK: 1.46.0 | ThoughtSpot: 26.4.0.cl
+     */
+    spotterChatConfig?: SpotterChatViewConfig;
     /**
      * This is the minimum height (in pixels) for a full-height App.
      * Setting this height helps resolve issues with empty Apps and
@@ -763,6 +803,8 @@ export class AppEmbed extends V1Embed {
             isCentralizedLiveboardFilterUXEnabled = false,
             isLinkParametersEnabled,
             updatedSpotterChatPrompt,
+            spotterSidebarConfig,
+            spotterChatConfig,
             minimumHeight,
             isThisPeriodInDateFiltersEnabled,
         } = this.viewConfig;
@@ -793,6 +835,60 @@ export class AppEmbed extends V1Embed {
             params[Param.UpdatedSpotterChatPrompt] = !!updatedSpotterChatPrompt;
         }
 
+        // Handle spotterSidebarConfig params
+        if (spotterSidebarConfig) {
+            const {
+                enablePastConversationsSidebar,
+                spotterSidebarTitle,
+                spotterSidebarDefaultExpanded,
+                spotterChatRenameLabel,
+                spotterChatDeleteLabel,
+                spotterDeleteConversationModalTitle,
+                spotterPastConversationAlertMessage,
+                spotterDocumentationUrl,
+                spotterBestPracticesLabel,
+                spotterConversationsBatchSize,
+                spotterNewChatButtonTitle,
+            } = spotterSidebarConfig;
+
+            setParamIfDefined(params, Param.EnablePastConversationsSidebar, enablePastConversationsSidebar, true);
+            setParamIfDefined(params, Param.SpotterSidebarDefaultExpanded, spotterSidebarDefaultExpanded, true);
+            setParamIfDefined(params, Param.SpotterSidebarTitle, spotterSidebarTitle);
+            setParamIfDefined(params, Param.SpotterChatRenameLabel, spotterChatRenameLabel);
+            setParamIfDefined(params, Param.SpotterChatDeleteLabel, spotterChatDeleteLabel);
+            setParamIfDefined(params, Param.SpotterDeleteConversationModalTitle, spotterDeleteConversationModalTitle);
+            setParamIfDefined(params, Param.SpotterPastConversationAlertMessage, spotterPastConversationAlertMessage);
+            setParamIfDefined(params, Param.SpotterBestPracticesLabel, spotterBestPracticesLabel);
+            setParamIfDefined(params, Param.SpotterConversationsBatchSize, spotterConversationsBatchSize);
+            setParamIfDefined(params, Param.SpotterNewChatButtonTitle, spotterNewChatButtonTitle);
+
+            // URL param with validation
+            if (spotterDocumentationUrl !== undefined) {
+                const [isValid, validationError] = validateHttpUrl(spotterDocumentationUrl);
+                if (isValid) {
+                    params[Param.SpotterDocumentationUrl] = spotterDocumentationUrl;
+                } else {
+                    this.handleError({
+                        errorType: ErrorDetailsTypes.VALIDATION_ERROR,
+                        message: ERROR_MESSAGE.INVALID_SPOTTER_DOCUMENTATION_URL,
+                        code: EmbedErrorCodes.INVALID_URL,
+                        error: validationError?.message || ERROR_MESSAGE.INVALID_SPOTTER_DOCUMENTATION_URL,
+                    });
+                }
+            }
+        }
+
+        // Handle spotterChatConfig params
+        if (spotterChatConfig) {
+            const {
+                hideToolResponseCardBranding,
+                toolResponseCardBrandingLabel,
+            } = spotterChatConfig;
+
+            setParamIfDefined(params, Param.HideToolResponseCardBranding, hideToolResponseCardBranding, true);
+            setParamIfDefined(params, Param.ToolResponseCardBrandingLabel, toolResponseCardBrandingLabel);
+        }
+
         if (hideObjectSearch) {
             params[Param.HideObjectSearch] = !!hideObjectSearch;
         }

package/src/embed/conversation.spec.ts

@@ -295,7 +295,9 @@ describe('ConversationEmbed', () => {
             searchOptions: {
                 searchQuery: 'searchQuery',
             },
-            enablePastConversationsSidebar: true,
+            spotterSidebarConfig: {
+                enablePastConversationsSidebar: true,
+            },
         };
 
         const conversationEmbed = new SpotterEmbed(getRootEl(), viewConfig);
@@ -312,7 +314,9 @@ describe('ConversationEmbed', () => {
             searchOptions: {
                 searchQuery: 'searchQuery',
             },
-            enablePastConversationsSidebar: false,
+            spotterSidebarConfig: {
+                enablePastConversationsSidebar: false,
+            },
         };
 
         const conversationEmbed = new SpotterEmbed(getRootEl(), viewConfig);
@@ -334,7 +338,9 @@ describe('ConversationEmbed', () => {
             dataPanelV2: true,
             showSpotterLimitations: true,
             hideSampleQuestions: true,
-            enablePastConversationsSidebar: true,
+            spotterSidebarConfig: {
+                enablePastConversationsSidebar: true,
+            },
         };
 
         const conversationEmbed = new SpotterEmbed(getRootEl(), viewConfig);
@@ -345,6 +351,44 @@ describe('ConversationEmbed', () => {
         );
     });
 
+    it('should render the conversation embed with tool response card branding hidden', async () => {
+        const viewConfig: SpotterEmbedViewConfig = {
+            worksheetId: 'worksheetId',
+            searchOptions: {
+                searchQuery: 'searchQuery',
+            },
+            spotterChatConfig: {
+                hideToolResponseCardBranding: true,
+            },
+        };
+
+        const conversationEmbed = new SpotterEmbed(getRootEl(), viewConfig);
+        await conversationEmbed.render();
+        expectUrlMatchesWithParams(
+            getIFrameSrc(),
+            `http://${thoughtSpotHost}/v2/?${defaultParams}&isSpotterExperienceEnabled=true&hideToolResponseCardBranding=true#/embed/insights/conv-assist?worksheet=worksheetId&query=searchQuery`,
+        );
+    });
+
+    it('should render the conversation embed with custom tool response card branding label', async () => {
+        const viewConfig: SpotterEmbedViewConfig = {
+            worksheetId: 'worksheetId',
+            searchOptions: {
+                searchQuery: 'searchQuery',
+            },
+            spotterChatConfig: {
+                toolResponseCardBrandingLabel: 'MyBrand',
+            },
+        };
+
+        const conversationEmbed = new SpotterEmbed(getRootEl(), viewConfig);
+        await conversationEmbed.render();
+        expectUrlMatchesWithParams(
+            getIFrameSrc(),
+            `http://${thoughtSpotHost}/v2/?${defaultParams}&isSpotterExperienceEnabled=true&toolResponseCardBrandingLabel=MyBrand#/embed/insights/conv-assist?worksheet=worksheetId&query=searchQuery`,
+        );
+    });
+
     it('should ensure deprecated ConversationEmbed class maintains same functionality as SpotterEmbed', async () => {
         const viewConfig: SpotterEmbedViewConfig = {
             worksheetId: 'worksheetId',
@@ -402,4 +446,74 @@ describe('ConversationEmbed', () => {
             `http://${thoughtSpotHost}/v2/?${defaultParams}&isSpotterExperienceEnabled=true&updatedSpotterChatPrompt=false#/embed/insights/conv-assist?worksheet=worksheetId&query=searchQuery`,
         );
     });
+
+    describe('spotter sidebar config params', () => {
+        it.each([
+            ['enablePastConversationsSidebar', true, 'enablePastConversationsSidebar=true'],
+            ['spotterSidebarTitle', 'My Conversations', 'spotterSidebarTitle=My%20Conversations'],
+            ['spotterSidebarDefaultExpanded', true, 'spotterSidebarDefaultExpanded=true'],
+            ['spotterChatRenameLabel', 'Edit Name', 'spotterChatRenameLabel=Edit%20Name'],
+            ['spotterChatDeleteLabel', 'Remove', 'spotterChatDeleteLabel=Remove'],
+            ['spotterDeleteConversationModalTitle', 'Remove Conversation', 'spotterDeleteConversationModalTitle=Remove%20Conversation'],
+            ['spotterPastConversationAlertMessage', 'Viewing past conversation', 'spotterPastConversationAlertMessage=Viewing%20past%20conversation'],
+            ['spotterBestPracticesLabel', 'Help Tips', 'spotterBestPracticesLabel=Help%20Tips'],
+            ['spotterConversationsBatchSize', 50, 'spotterConversationsBatchSize=50'],
+            ['spotterNewChatButtonTitle', 'Start New Conversation', 'spotterNewChatButtonTitle=Start%20New%20Conversation'],
+            ['spotterDocumentationUrl', 'https://docs.example.com/spotter', 'spotterDocumentationUrl=https%3A%2F%2Fdocs.example.com%2Fspotter'],
+        ])('should render with spotterSidebarConfig.%s', async (configKey, configValue, expectedParam) => {
+            const viewConfig: SpotterEmbedViewConfig = {
+                worksheetId: 'worksheetId',
+                spotterSidebarConfig: {
+                    [configKey]: configValue,
+                },
+            };
+            const conversationEmbed = new SpotterEmbed(getRootEl(), viewConfig);
+            await conversationEmbed.render();
+            expectUrlMatchesWithParams(
+                getIFrameSrc(),
+                `http://${thoughtSpotHost}/v2/?${defaultParams}&isSpotterExperienceEnabled=true&${expectedParam}#/embed/insights/conv-assist?worksheet=worksheetId&query=`,
+            );
+        });
+
+        it.each([
+            ['invalid URL format', 'invalid-url'],
+            ['invalid protocol (ftp)', 'ftp://docs.example.com/spotter'],
+        ])('should handle error for spotterSidebarConfig.spotterDocumentationUrl with %s', async (_, invalidUrl) => {
+            const viewConfig: SpotterEmbedViewConfig = {
+                worksheetId: 'worksheetId',
+                spotterSidebarConfig: {
+                    spotterDocumentationUrl: invalidUrl,
+                },
+            };
+            const conversationEmbed = new SpotterEmbed(getRootEl(), viewConfig);
+            (conversationEmbed as any).handleError = jest.fn();
+            await conversationEmbed.render();
+            expect((conversationEmbed as any).handleError).toHaveBeenCalledWith(
+                expect.objectContaining({
+                    errorType: ErrorDetailsTypes.VALIDATION_ERROR,
+                    message: ERROR_MESSAGE.INVALID_SPOTTER_DOCUMENTATION_URL,
+                    code: EmbedErrorCodes.INVALID_URL,
+                }),
+            );
+        });
+
+        it('should render with multiple spotterSidebarConfig options', async () => {
+            const viewConfig: SpotterEmbedViewConfig = {
+                worksheetId: 'worksheetId',
+                spotterSidebarConfig: {
+                    enablePastConversationsSidebar: true,
+                    spotterSidebarTitle: 'Chats',
+                    spotterSidebarDefaultExpanded: true,
+                    spotterNewChatButtonTitle: 'New',
+                    spotterConversationsBatchSize: 25,
+                },
+            };
+            const conversationEmbed = new SpotterEmbed(getRootEl(), viewConfig);
+            await conversationEmbed.render();
+            expectUrlMatchesWithParams(
+                getIFrameSrc(),
+                `http://${thoughtSpotHost}/v2/?${defaultParams}&isSpotterExperienceEnabled=true&enablePastConversationsSidebar=true&spotterSidebarDefaultExpanded=true&spotterSidebarTitle=Chats&spotterConversationsBatchSize=25&spotterNewChatButtonTitle=New#/embed/insights/conv-assist?worksheet=worksheetId&query=`,
+            );
+        });
+    });
 });