@thoughtspot/visual-embed-sdk 1.41.0 → 1.41.1

package/src/css-variables.ts

@@ -27,7 +27,8 @@ export interface CustomCssVariables {
      * Font color of the text on toggle buttons such as
      * **All**, **Answers**, and **Liveboards** on the Home page (Classic experience),
      * the text color of the chart and table tiles on Home page (New modular Homepage
-     * experience), and title text on the AI-generated charts and tables.
+     * experience), title text on the AI-generated charts and tables, and object titles on
+     * list pages such as *Liveboards* and *Answers*.
      * The default color code is #2770EF.
      *
      */

package/src/embed/app.spec.ts

@@ -344,6 +344,20 @@ describe('App embed tests', () => {
         });
     });
 
+    test('should set isPNGInScheduledEmailsEnabled to true in url', async () => {
+        const appEmbed = new AppEmbed(getRootEl(), {
+            ...defaultViewConfig,
+            isPNGInScheduledEmailsEnabled: true,
+        } as AppViewConfig);
+        appEmbed.render();
+        await executeAfterWait(() => {
+            expectUrlMatchesWithParams(
+                getIFrameSrc(),
+                `http://${thoughtSpotHost}/?embedApp=true&profileAndHelpInNavBarHidden=false&isPNGInScheduledEmailsEnabled=true${defaultParamsPost}#/home`,
+            );
+        });
+    });
+
     test('should set liveboardXLSXCSVDownload to true in url', async () => {
         const appEmbed = new AppEmbed(getRootEl(), {
             ...defaultViewConfig,

package/src/embed/app.ts

@@ -537,6 +537,23 @@ export interface AppViewConfig extends AllEmbedViewConfig {
      */
     isLiveboardStylingAndGroupingEnabled?: boolean;
 
+    /**
+     * This flag is used to enable/disable the png embedding of liveboard in scheduled mails
+     * 
+     * Supported embed types: `AppEmbed`, `LiveboardEmbed`
+     * @type {boolean}
+     * @version SDK: 1.42.0 | ThoughtSpot: 10.14.0.cl
+     * @example
+     * ```js
+     * // Replace <EmbedComponent> with embed component name. For example, AppEmbed or LiveboardEmbed
+     * const embed = new <EmbedComponent>('#tsEmbed', {
+     *    ... // other embed view config
+     *    isPNGInScheduledEmailsEnabled: true,
+     * })
+     * ```
+     */
+    isPNGInScheduledEmailsEnabled?: boolean;
+
     /**
      * This flag is used to enable the full height lazy load data.
      * 
@@ -619,7 +636,7 @@ export class AppEmbed extends V1Embed {
             hideOrgSwitcher,
             enableSearchAssist,
             fullHeight,
-            dataPanelV2 = false,
+            dataPanelV2 = true,
             hideLiveboardHeader = false,
             showLiveboardTitle = true,
             showLiveboardDescription = true,
@@ -645,6 +662,7 @@ export class AppEmbed extends V1Embed {
             coverAndFilterOptionInPDF = false,
             liveboardXLSXCSVDownload = false,
             isLiveboardStylingAndGroupingEnabled,
+            isPNGInScheduledEmailsEnabled = false,
         } = this.viewConfig;
 
         let params: any = {};
@@ -728,6 +746,10 @@ export class AppEmbed extends V1Embed {
             params[Param.IsLiveboardStylingAndGroupingEnabled] = isLiveboardStylingAndGroupingEnabled;
         }
 
+        if (isPNGInScheduledEmailsEnabled !== undefined) {
+            params[Param.isPNGInScheduledEmailsEnabled] = isPNGInScheduledEmailsEnabled;
+        }
+
         params[Param.DataPanelV2Enabled] = dataPanelV2;
         params[Param.HideHomepageLeftNav] = hideHomepageLeftNav;
         params[Param.ModularHomeExperienceEnabled] = modularHomeExperience;

package/src/embed/conversation.ts

@@ -61,8 +61,8 @@ export interface SpotterEmbedViewConfig extends Omit<BaseViewConfig, 'primaryAct
      * Flag to control Data panel experience
      *
      * Supported embed types: `SageEmbed`, `AppEmbed`, `SearchBarEmbed`, `LiveboardEmbed`, `SearchEmbed`
-     * @default false
-     * @version SDK: 1.36.0 | ThoughtSpot Cloud: 10.4.0.cl
+     * @default true
+     * @version SDK: 1.43.0 | ThoughtSpot Cloud: 10.14.0.cl
      * @example
      * ```js
      * // Replace <EmbedComponent> with embed component name. For example, SageEmbed, AppEmbed, or SearchBarEmbed

package/src/embed/liveboard.spec.ts

@@ -41,6 +41,16 @@ const thoughtSpotHost = 'tshost';
 const prefixParams = '&isLiveboardEmbed=true';
 const prefixParamsVizEmbed = '&isLiveboardEmbed=true&isVizEmbed=true';
 
+const mockGetSessionInfo = (mockSessionInfo?: any) => {
+    jest.spyOn(SessionInfoService, 'getSessionInfo').mockResolvedValue(mockSessionInfo || {
+        releaseVersion: '1.0.0',
+        userGUID: '1234567890',
+        currentOrgId: 1,
+        privileges: [],
+        mixpanelToken: '1234567890',
+    })
+};
+
 beforeAll(() => {
     init({
         thoughtSpotHost,
@@ -77,7 +87,7 @@ describe('Liveboard/viz embed tests', () => {
         await executeAfterWait(() => {
             expectUrlMatchesWithParams(
                 getIFrameSrc(),
-                `http://${thoughtSpotHost}/?embedApp=true${defaultParams}${prefixParams}&enableDataPanelV2=false#/embed/viz/${liveboardId}`,
+                `http://${thoughtSpotHost}/?embedApp=true${defaultParams}${prefixParams}&enableDataPanelV2=true#/embed/viz/${liveboardId}`,
             );
         });
     });
@@ -158,6 +168,21 @@ describe('Liveboard/viz embed tests', () => {
         });
     });
 
+    test('should set isPNGInScheduledEmailsEnabled to true in url', async () => {
+        const liveboardEmbed = new LiveboardEmbed(getRootEl(), {
+            isPNGInScheduledEmailsEnabled: true,
+            ...defaultViewConfig,
+            liveboardId,
+        } as LiveboardViewConfig);
+        liveboardEmbed.render();
+        await executeAfterWait(() => {
+            expectUrlMatchesWithParams(
+                getIFrameSrc(),
+                `http://${thoughtSpotHost}/?embedApp=true${defaultParams}&isPNGInScheduledEmailsEnabled=true${prefixParams}#/embed/viz/${liveboardId}`,
+            );
+        });
+    });
+
     test('should set visible actions as empty array', async () => {
         const liveboardEmbed = new LiveboardEmbed(getRootEl(), {
             visibleActions: [],
@@ -631,6 +656,8 @@ describe('Liveboard/viz embed tests', () => {
 
     test('navigateToLiveboard should trigger the navigate event with the correct path', async (done) => {
         mockMessageChannel();
+        // mock getSessionInfo
+        mockGetSessionInfo();
         const liveboardEmbed = new LiveboardEmbed(getRootEl(), {
             ...defaultViewConfig,
         } as LiveboardViewConfig);
@@ -641,16 +668,24 @@ describe('Liveboard/viz embed tests', () => {
             postMessageToParent(iframe.contentWindow, {
                 type: EmbedEvent.APP_INIT,
             });
+            postMessageToParent(iframe.contentWindow, {
+                type: EmbedEvent.AuthInit,
+            });
+            liveboardEmbed.navigateToLiveboard('lb1', 'viz1');
         });
+
         executeAfterWait(() => {
-            liveboardEmbed.navigateToLiveboard('lb1', 'viz1');
             expect(onSpy).toHaveBeenCalledWith(HostEvent.Navigate, 'embed/viz/lb1/viz1');
             done();
-        });
+        }, 1002);
     });
 
     test('navigateToLiveboard with preRender', async (done) => {
         mockMessageChannel();
+
+        // mock getSessionInfo
+        mockGetSessionInfo();
+
         const liveboardEmbed = new LiveboardEmbed(getRootEl(), {
             ...defaultViewConfig,
             preRenderId: 'test',
@@ -662,12 +697,15 @@ describe('Liveboard/viz embed tests', () => {
             postMessageToParent(iframe.contentWindow, {
                 type: EmbedEvent.APP_INIT,
             });
+            postMessageToParent(iframe.contentWindow, {
+                type: EmbedEvent.AuthInit,
+            });
         });
         executeAfterWait(() => {
             liveboardEmbed.navigateToLiveboard('lb1', 'viz1');
             expect(onSpy).toHaveBeenCalledWith(HostEvent.Navigate, 'embed/viz/lb1/viz1');
             done();
-        });
+        }, 1002);
     });
     test('should set runtime parametere values in url params', async () => {
         const liveboardEmbed = new LiveboardEmbed(getRootEl(), {
@@ -689,6 +727,21 @@ describe('Liveboard/viz embed tests', () => {
         });
     });
 
+    test('should set showSpotterLimitations parameter in url params', async () => {
+        const liveboardEmbed = new LiveboardEmbed(getRootEl(), {
+            ...defaultViewConfig,
+            liveboardId,
+            showSpotterLimitations: true,
+        } as LiveboardViewConfig);
+        await liveboardEmbed.render();
+        await executeAfterWait(() => {
+            expectUrlMatchesWithParams(
+                getIFrameSrc(),
+                `http://${thoughtSpotHost}/?embedApp=true${defaultParams}${prefixParams}&showSpotterLimitations=true#/embed/viz/${liveboardId}`,
+            );
+        });
+    });
+
     test('SetActiveTab Hostevent should not trigger the navigate event with the correct path, for vizEmbed', async () => {
         const mockProcessTrigger = jest.spyOn(tsEmbed.TsEmbed.prototype, 'trigger');
         const liveboardEmbed = new LiveboardEmbed(getRootEl(), {
@@ -820,7 +873,6 @@ describe('Liveboard/viz embed tests', () => {
             expect((document.getElementById(libEmbed.getPreRenderIds().wrapper) as any)[ts]).toEqual(
                 libEmbed,
             );
-
             await executeAfterWait(() => {
                 const iframe = getIFrameEl();
                 postMessageToParent(iframe.contentWindow, {
@@ -852,7 +904,7 @@ describe('Liveboard/viz embed tests', () => {
                 done();
             });
         });
-       
+
         test('it should navigateToLiveboard with liveboard id is not passed with AuthInit event', async (done) => {
             mockMessageChannel();
             const consoleSpy = jest.spyOn(console, 'error');
@@ -861,13 +913,7 @@ describe('Liveboard/viz embed tests', () => {
                 preRenderId: testPreRenderId,
             });
 
-            jest.spyOn(SessionInfoService, 'getSessionInfo').mockResolvedValue({
-                releaseVersion: '1.0.0',
-                userGUID: '1234567890',
-                currentOrgId: 1,
-                privileges: [],
-                mixpanelToken: '1234567890',
-            });
+            mockGetSessionInfo();
             let resizeObserverCb: any;
             (window as any).ResizeObserver =
                 window.ResizeObserver ||
@@ -905,7 +951,6 @@ describe('Liveboard/viz embed tests', () => {
                 });
             });
 
-
             await executeAfterWait(() => {
                 const iFrame = document.getElementById(
                     libEmbed.getPreRenderIds().child,
@@ -918,6 +963,59 @@ describe('Liveboard/viz embed tests', () => {
             }, 1005);
         });
 
+
+        test('should replace existing preRender when replaceExistingPreRender is true', async () => {
+            const testPreRenderId = 'testReplacePreRender';
+
+            // Stub ResizeObserver for JSDOM
+            (window as any).ResizeObserver = (window as any).ResizeObserver
+                || jest.fn().mockImplementation(() => ({
+                    disconnect: jest.fn(),
+                    observe: jest.fn(),
+                    unobserve: jest.fn(),
+                }));
+
+            // Create initial embed and show preRender (this will create the
+            // preRender wrapper/child)
+            const embedA = new LiveboardEmbed(getRootEl(), {
+                preRenderId: testPreRenderId,
+            });
+
+            await embedA.showPreRender();
+
+            await waitFor(() => !!getIFrameEl());
+
+            const ids = embedA.getPreRenderIds();
+            const oldWrapper = document.getElementById(ids.wrapper);
+            const oldChild = document.getElementById(ids.child);
+
+            const tsKey = '__tsEmbed';
+            expect((oldWrapper as any)[tsKey]).toBe(embedA);
+
+            // Create a new embed instance and preRender with
+            // replaceExistingPreRender = true
+            const embedB = new LiveboardEmbed(getRootEl(), {
+                preRenderId: testPreRenderId,
+            });
+            const prerenderGenericSpy = jest.spyOn(embedB, 'prerenderGeneric');
+
+            await embedB.preRender(false, true);
+
+            await waitFor(() => (document.getElementById(ids.wrapper) as any)?.[tsKey] === embedB);
+
+            const newWrapper = document.getElementById(ids.wrapper);
+            const newChild = document.getElementById(ids.child);
+
+            // Should have called prerenderGeneric for the new embed instance
+            expect(prerenderGenericSpy).toHaveBeenCalledTimes(1);
+
+            // Wrapper should be replaced (new wrapper element), child iframe
+            // may be reused
+            expect(newWrapper).not.toBe(oldWrapper);
+
+            // __tsEmbed on wrapper should now point to the new embed instance
+            expect((newWrapper as any)[tsKey]).toBe(embedB);
+        });
     });
 
     describe('LazyLoadingForFullHeight functionality', () => {

package/src/embed/liveboard.ts

@@ -46,7 +46,7 @@ export interface LiveboardViewConfig extends BaseViewConfig, LiveboardOtherViewC
      * incrementally as users scroll the page to view the charts and tables.
      *
      * @version SDK: 1.1.0 | ThoughtSpot: ts7.may.cl, 7.2.1
-     * 
+     *
      * Supported embed types: `LiveboardEmbed`
      * @example
      * ```js
@@ -61,7 +61,7 @@ export interface LiveboardViewConfig extends BaseViewConfig, LiveboardOtherViewC
      * This is the minimum height(in pixels) for a full-height Liveboard.
      * Setting this height helps resolve issues with empty Liveboards and
      * other screens navigable from a Liveboard.
-     * 
+     *
      * Supported embed types: `LiveboardEmbed`
      * @version SDK: 1.5.0 | ThoughtSpot: ts7.oct.cl, 7.2.1
      * @default 500
@@ -90,7 +90,7 @@ export interface LiveboardViewConfig extends BaseViewConfig, LiveboardOtherViewC
     /**
      * The Liveboard to display in the embedded view.
      * Use either liveboardId or pinboardId to reference the Liveboard to embed.
-     * 
+     *
      * Supported embed types: `LiveboardEmbed`
      * @version SDK: 1.3.0 | ThoughtSpot ts7.aug.cl, 7.2.1
      * @example
@@ -108,7 +108,7 @@ export interface LiveboardViewConfig extends BaseViewConfig, LiveboardOtherViewC
     pinboardId?: string;
     /**
      * The visualization within the Liveboard to display.
-     * 
+     *
      * Supported embed types: `LiveboardEmbed`
      * @version SDK: 1.9.1 | ThoughtSpot: 8.1.0.cl, 8.4.1-sw
      * @example
@@ -123,7 +123,7 @@ export interface LiveboardViewConfig extends BaseViewConfig, LiveboardOtherViewC
     /**
      * If set to true, all filter chips from a
      * Liveboard page will be read-only (no X buttons)
-     * 
+     *
      * Supported embed types: `LiveboardEmbed`
      * @version SDK: 1.3.0 | ThoughtSpot ts7.aug.cl, 7.2.1.sw
      * @example
@@ -139,7 +139,7 @@ export interface LiveboardViewConfig extends BaseViewConfig, LiveboardOtherViewC
      * Array of visualization IDs which should be visible when the Liveboard
      * renders. This can be changed by triggering the `SetVisibleVizs`
      * event.
-     * 
+     *
      * Supported embed types: `LiveboardEmbed`
      * @version SDK: 1.9.1 | ThoughtSpot: 8.1.0.cl, 8.4.1-sw
      * @example
@@ -161,7 +161,7 @@ export interface LiveboardViewConfig extends BaseViewConfig, LiveboardOtherViewC
     /**
      * Render embedded Liveboards and visualizations in the
      * new Liveboard experience mode.
-     * 
+     *
      * Supported embed types: `LiveboardEmbed`
      * @version SDK: 1.14.0 | ThoughtSpot: 8.6.0.cl, 8.8.1-sw
      * @example
@@ -176,7 +176,7 @@ export interface LiveboardViewConfig extends BaseViewConfig, LiveboardOtherViewC
     /**
      * Set a Liveboard tab as an active tab.
      * Specify the tab ID.
-     * 
+     *
      * Supported embed types: `LiveboardEmbed`
      * @example
      * ```js
@@ -190,7 +190,7 @@ export interface LiveboardViewConfig extends BaseViewConfig, LiveboardOtherViewC
     activeTabId?: string;
     /**
      * Show or hide the tab panel of the embedded Liveboard.
-     * 
+     *
      * Supported embed types: `LiveboardEmbed`
      * @version SDK: 1.25.0 | ThoughtSpot: 9.6.0.cl, 9.8.0.sw
      * @example
@@ -211,7 +211,7 @@ export interface LiveboardViewConfig extends BaseViewConfig, LiveboardOtherViewC
      *
      * Since, this will show preview images, be careful that it may show
      * undesired data to the user when using row level security.
-     * 
+     *
      * Supported embed types: `LiveboardEmbed`
      * @example
      * ```js
@@ -227,8 +227,8 @@ export interface LiveboardViewConfig extends BaseViewConfig, LiveboardOtherViewC
     showPreviewLoader?: boolean;
     /**
      * The Liveboard to run on regular intervals to fetch the cdw token.
-     * 
-     * Supported embed types: `LiveboardEmbed`  
+     *
+     * Supported embed types: `LiveboardEmbed`
      * @hidden
      * @version SDK: 1.35.0 | ThoughtSpot:10.6.0.cl
      * @example
@@ -242,7 +242,7 @@ export interface LiveboardViewConfig extends BaseViewConfig, LiveboardOtherViewC
 
     /**
      * The Liveboard is set to force a token fetch during the initial load.
-     * 
+     *
      * Supported embed types: `LiveboardEmbed`
      * @hidden
      * @version SDK: 1.35.0 | ThoughtSpot:10.6.0.cl
@@ -259,7 +259,7 @@ export interface LiveboardViewConfig extends BaseViewConfig, LiveboardOtherViewC
      * The source connection ID for authentication.
      * @hidden
      * @version SDK: 1.35.0 | ThoughtSpot:10.6.0.cl
-     * 
+     *
      * Supported embed types: `LiveboardEmbed`
      * @example
      * ```js
@@ -273,7 +273,7 @@ export interface LiveboardViewConfig extends BaseViewConfig, LiveboardOtherViewC
      * The list of tab IDs to hide from the embedded.
      * This Tabs will be hidden from their respective LBs.
      * Use this to hide an tabID.
-     * 
+     *
      * Supported embed types: `LiveboardEmbed`
      * @example
      * ```js
@@ -293,7 +293,7 @@ export interface LiveboardViewConfig extends BaseViewConfig, LiveboardOtherViewC
      * Only the tabs specified in the array will be shown in the Liveboard.
      *
      * Use either `visibleTabs` or `hiddenTabs`.
-     * 
+     *
      * Supported embed types: `LiveboardEmbed`
      * @version SDK: 1.26.0 | ThoughtSpot: 9.7.0.cl, 10.1.0.sw
      * @example
@@ -310,7 +310,7 @@ export interface LiveboardViewConfig extends BaseViewConfig, LiveboardOtherViewC
     visibleTabs?: string[];
     /**
      * This flag is used to enable/disable the styling and grouping in a Liveboard
-     * 
+     *
      * Supported embed types: `LiveboardEmbed`, `AppEmbed`
      * @type {boolean}
      * @version SDK: 1.40.0 | ThoughtSpot: 10.11.0.cl
@@ -324,9 +324,25 @@ export interface LiveboardViewConfig extends BaseViewConfig, LiveboardOtherViewC
      * ```
      */
     isLiveboardStylingAndGroupingEnabled?: boolean;
+    /**
+     * This flag is used to enable/disable the png embedding of liveboard in scheduled mails
+     *
+     * Supported embed types: `AppEmbed`, `LiveboardEmbed`
+     * @type {boolean}
+     * @version SDK: 1.42.0 | ThoughtSpot: 10.14.0.cl
+     * @example
+     * ```js
+     * // Replace <EmbedComponent> with embed component name. For example, AppEmbed or LiveboardEmbed
+     * const embed = new <EmbedComponent>('#tsEmbed', {
+     *    ... // other embed view config
+     *    isPNGInScheduledEmailsEnabled: true,
+     * })
+     * ```
+     */
+    isPNGInScheduledEmailsEnabled?: boolean;
     /**
      * This flag is used to enable the full height lazy load data.
-     * 
+     *
      * @example
      * ```js
      * const embed = new LiveboardEmbed('#embed-container', {
@@ -335,7 +351,7 @@ export interface LiveboardViewConfig extends BaseViewConfig, LiveboardOtherViewC
      *    lazyLoadingForFullHeight: true,
      * })
      * ```
-     * 
+     *
      * @type {boolean}
      * @default false
      * @version SDK: 1.40.0 | ThoughtSpot:10.12.0.cl
@@ -343,13 +359,13 @@ export interface LiveboardViewConfig extends BaseViewConfig, LiveboardOtherViewC
     lazyLoadingForFullHeight?: boolean;
     /**
      * The margin to be used for lazy loading.
-     * 
+     *
      * For example, if the margin is set to '10px',
      * the visualization will be loaded 10px before the its top edge is visible in the
      * viewport.
-     * 
+     *
      * The format is similar to CSS margin.
-     * 
+     *
      * @example
      * ```js
      * const embed = new LiveboardEmbed('#embed-container', {
@@ -364,6 +380,22 @@ export interface LiveboardViewConfig extends BaseViewConfig, LiveboardOtherViewC
      * @version SDK: 1.40.0 | ThoughtSpot:10.12.0.cl
      */
     lazyLoadingMargin?: string;
+    /**
+     * showSpotterLimitations : show limitation text
+     * of the spotter underneath the chat input.
+     * default is false.
+     *
+     * @example
+     * ```js
+     * const embed = new LiveboardEmbed('#embed-container', {
+     *    // ...other options
+     *    showSpotterLimitations: true,
+     * })
+     * ```
+     * @type {boolean}
+     * @version SDK: 1.41.1 | ThoughtSpot: 10.5.0.cl
+     */
+    showSpotterLimitations?: boolean;
 }
 
 /**
@@ -429,7 +461,7 @@ export class LiveboardEmbed extends V1Embed {
             hideIrrelevantChipsInLiveboardTabs = false,
             enableAskSage,
             enable2ColumnLayout,
-            dataPanelV2 = false,
+            dataPanelV2 = true,
             enableCustomColumnGroups = false,
             oAuthPollingInterval,
             isForceRedirect,
@@ -437,6 +469,8 @@ export class LiveboardEmbed extends V1Embed {
             coverAndFilterOptionInPDF = false,
             liveboardXLSXCSVDownload = false,
             isLiveboardStylingAndGroupingEnabled,
+            isPNGInScheduledEmailsEnabled = false,
+            showSpotterLimitations,
         } = this.viewConfig;
 
         const preventLiveboardFilterRemoval = this.viewConfig.preventLiveboardFilterRemoval
@@ -504,6 +538,14 @@ export class LiveboardEmbed extends V1Embed {
             params[Param.IsLiveboardStylingAndGroupingEnabled] = isLiveboardStylingAndGroupingEnabled;
         }
 
+        if (isPNGInScheduledEmailsEnabled !== undefined) {
+            params[Param.isPNGInScheduledEmailsEnabled] = isPNGInScheduledEmailsEnabled;
+        }
+
+        if (showSpotterLimitations !== undefined) {
+            params[Param.ShowSpotterLimitations] = showSpotterLimitations;
+        }
+
         params[Param.LiveboardHeaderSticky] = isLiveboardHeaderSticky;
         params[Param.LiveboardHeaderV2] = isLiveboardCompactHeaderEnabled;
         params[Param.ShowLiveboardVerifiedBadge] = showLiveboardVerifiedBadge;

package/src/embed/sage.spec.ts

@@ -18,7 +18,7 @@ const defaultConfig: SageViewConfig = {
     hideAutocompleteSuggestions: false,
     hideSampleQuestions: false,
     isProductTour: false,
-    dataPanelV2: false,
+    dataPanelV2: true,
 };
 
 const thoughtSpotHost = 'tshost';
@@ -43,7 +43,7 @@ describe('Sage  embed tests', () => {
         await executeAfterWait(() => {
             expectUrlMatch(
                 getIFrameSrc(),
-                `http://${thoughtSpotHost}/?embedApp=true&enableDataPanelV2=false&isSageEmbed=true&disableWorksheetChange=false&hideWorksheetSelector=false&hideEurekaSuggestions=false&isProductTour=false&hideSageAnswerHeader=false&hideAction=%5B%22reportError%22%5D#/embed/eureka`,
+                `http://${thoughtSpotHost}/?embedApp=true&enableDataPanelV2=true&isSageEmbed=true&disableWorksheetChange=false&hideWorksheetSelector=false&hideEurekaSuggestions=false&isProductTour=false&hideSageAnswerHeader=false&hideAction=%5B%22reportError%22%5D#/embed/eureka`,
             );
         });
     });
@@ -54,7 +54,7 @@ describe('Sage  embed tests', () => {
         await executeAfterWait(() => {
             expectUrlMatch(
                 getIFrameSrc(),
-                `http://${thoughtSpotHost}/?embedApp=true&enableDataPanelV2=false&isSageEmbed=true&disableWorksheetChange=false&hideWorksheetSelector=false&hideEurekaSuggestions=false&isProductTour=true&hideSageAnswerHeader=false&hideAction=%5B%22reportError%22%5D#/embed/eureka`,
+                `http://${thoughtSpotHost}/?embedApp=true&enableDataPanelV2=true&isSageEmbed=true&disableWorksheetChange=false&hideWorksheetSelector=false&hideEurekaSuggestions=false&isProductTour=true&hideSageAnswerHeader=false&hideAction=%5B%22reportError%22%5D#/embed/eureka`,
             );
         });
     });
@@ -68,7 +68,7 @@ describe('Sage  embed tests', () => {
         await executeAfterWait(() => {
             expectUrlMatch(
                 getIFrameSrc(),
-                `http://${thoughtSpotHost}/?embedApp=true&enableDataPanelV2=false&isSageEmbed=true&disableWorksheetChange=true&hideWorksheetSelector=false&hideEurekaSuggestions=false&isProductTour=false&hideSageAnswerHeader=false&hideAction=%5B%22reportError%22%5D#/embed/eureka`,
+                `http://${thoughtSpotHost}/?embedApp=true&enableDataPanelV2=true&isSageEmbed=true&disableWorksheetChange=true&hideWorksheetSelector=false&hideEurekaSuggestions=false&isProductTour=false&hideSageAnswerHeader=false&hideAction=%5B%22reportError%22%5D#/embed/eureka`,
             );
         });
     });
@@ -82,7 +82,7 @@ describe('Sage  embed tests', () => {
         await executeAfterWait(() => {
             expectUrlMatch(
                 getIFrameSrc(),
-                `http://${thoughtSpotHost}/?embedApp=true&enableDataPanelV2=false&isSageEmbed=true&disableWorksheetChange=false&hideWorksheetSelector=true&hideEurekaSuggestions=false&isProductTour=false&hideSageAnswerHeader=false&hideAction=%5B%22reportError%22%5D#/embed/eureka`,
+                `http://${thoughtSpotHost}/?embedApp=true&enableDataPanelV2=true&isSageEmbed=true&disableWorksheetChange=false&hideWorksheetSelector=true&hideEurekaSuggestions=false&isProductTour=false&hideSageAnswerHeader=false&hideAction=%5B%22reportError%22%5D#/embed/eureka`,
             );
         });
     });
@@ -96,7 +96,7 @@ describe('Sage  embed tests', () => {
         await executeAfterWait(() => {
             expectUrlMatch(
                 getIFrameSrc(),
-                `http://${thoughtSpotHost}/?embedApp=true&enableDataPanelV2=false&isSageEmbed=true&disableWorksheetChange=false&hideWorksheetSelector=false&hideEurekaSuggestions=false&isProductTour=false&hideSageAnswerHeader=true&hideAction=%5B%22reportError%22%5D#/embed/eureka`,
+                `http://${thoughtSpotHost}/?embedApp=true&enableDataPanelV2=true&isSageEmbed=true&disableWorksheetChange=false&hideWorksheetSelector=false&hideEurekaSuggestions=false&isProductTour=false&hideSageAnswerHeader=true&hideAction=%5B%22reportError%22%5D#/embed/eureka`,
             );
         });
     });
@@ -110,7 +110,7 @@ describe('Sage  embed tests', () => {
         await executeAfterWait(() => {
             expectUrlMatch(
                 getIFrameSrc(),
-                `http://${thoughtSpotHost}/?embedApp=true&enableDataPanelV2=false&isSageEmbed=true&disableWorksheetChange=false&hideWorksheetSelector=false&hideEurekaSuggestions=true&isProductTour=false&hideSageAnswerHeader=false&hideAction=%5B%22reportError%22%5D#/embed/eureka`,
+                `http://${thoughtSpotHost}/?embedApp=true&enableDataPanelV2=true&isSageEmbed=true&disableWorksheetChange=false&hideWorksheetSelector=false&hideEurekaSuggestions=true&isProductTour=false&hideSageAnswerHeader=false&hideAction=%5B%22reportError%22%5D#/embed/eureka`,
             );
         });
     });
@@ -137,7 +137,7 @@ describe('Sage  embed tests', () => {
         await executeAfterWait(() => {
             expectUrlMatch(
                 getIFrameSrc(),
-                `http://${thoughtSpotHost}/?embedApp=true&enableDataPanelV2=false&isSageEmbed=true&disableWorksheetChange=false&hideWorksheetSelector=false&hideEurekaSuggestions=false&isProductTour=false&hideSageAnswerHeader=false&hideAction=%5B%22reportError%22%5D#/embed/eureka?worksheet=worksheet-id`,
+                `http://${thoughtSpotHost}/?embedApp=true&enableDataPanelV2=true&isSageEmbed=true&disableWorksheetChange=false&hideWorksheetSelector=false&hideEurekaSuggestions=false&isProductTour=false&hideSageAnswerHeader=false&hideAction=%5B%22reportError%22%5D#/embed/eureka?worksheet=worksheet-id`,
             );
         });
     });
@@ -154,7 +154,7 @@ describe('Sage  embed tests', () => {
         await executeAfterWait(() => {
             expectUrlMatch(
                 getIFrameSrc(),
-                `http://${thoughtSpotHost}/?embedApp=true&enableDataPanelV2=false&isSageEmbed=true&disableWorksheetChange=false&hideWorksheetSelector=false&hideEurekaSuggestions=false&isProductTour=false&hideSageAnswerHeader=false&hideAction=%5B%22reportError%22%5D#/embed/eureka?worksheet=worksheet-id&query=test%20query`,
+                `http://${thoughtSpotHost}/?embedApp=true&enableDataPanelV2=true&isSageEmbed=true&disableWorksheetChange=false&hideWorksheetSelector=false&hideEurekaSuggestions=false&isProductTour=false&hideSageAnswerHeader=false&hideAction=%5B%22reportError%22%5D#/embed/eureka?worksheet=worksheet-id&query=test%20query`,
             );
         });
     });
@@ -171,7 +171,7 @@ describe('Sage  embed tests', () => {
         await executeAfterWait(() => {
             expectUrlMatch(
                 getIFrameSrc(),
-                `http://${thoughtSpotHost}/?embedApp=true&enableDataPanelV2=false&isSageEmbed=true&disableWorksheetChange=false&hideWorksheetSelector=false&hideEurekaSuggestions=false&hideAction=%5B%22reportError%22%5D#/embed/eureka?executeSearch=true&query=test-query`,
+                `http://${thoughtSpotHost}/?embedApp=true&enableDataPanelV2=true&isSageEmbed=true&disableWorksheetChange=false&hideWorksheetSelector=false&hideEurekaSuggestions=false&hideAction=%5B%22reportError%22%5D#/embed/eureka?executeSearch=true&query=test-query`,
             );
         });
     });
@@ -189,4 +189,18 @@ describe('Sage  embed tests', () => {
             );
         });
     });
+
+    test('should set enableDataPanelV2 to false if data panel v2 flag is false', async () => {
+        const sageEmbed = new SageEmbed(getRootEl(), {
+            ...defaultConfig,
+            dataPanelV2: false,
+        });
+        await sageEmbed.render();
+        await executeAfterWait(() => {
+            expectUrlMatch(
+                getIFrameSrc(),
+                `http://${thoughtSpotHost}/?embedApp=true&enableDataPanelV2=false&isSageEmbed=true&disableWorksheetChange=false&hideWorksheetSelector=false&hideEurekaSuggestions=false&isProductTour=false&hideSageAnswerHeader=false&hideAction=%5B%22reportError%22%5D#/embed/eureka`,
+            );
+        });
+    });
 });