@thoughtspot/visual-embed-sdk 1.40.1-alpha.2 → 1.40.1

package/src/embed/liveboard.ts

@@ -408,12 +408,6 @@ export class LiveboardEmbed extends V1Embed {
      * embedded Liveboard or visualization.
      */
     protected getEmbedParams() {
-        const params = this.getEmbedParamsObject();
-        const queryParams = getQueryParamString(params, true);
-        return queryParams;
-    }
-
-    protected getEmbedParamsObject() {
         let params: any = {};
         params = this.getBaseQueryParams(params);
         const {
@@ -517,33 +511,9 @@ export class LiveboardEmbed extends V1Embed {
         params[Param.DataPanelV2Enabled] = dataPanelV2;
         params[Param.EnableCustomColumnGroups] = enableCustomColumnGroups;
         params[Param.CoverAndFilterOptionInPDF] = coverAndFilterOptionInPDF;
+        const queryParams = getQueryParamString(params, true);
 
-        if (oAuthPollingInterval !== undefined) {
-            params[Param.OauthPollingInterval] = oAuthPollingInterval;
-        }
-
-        if (isForceRedirect) {
-            params[Param.IsForceRedirect] = isForceRedirect;
-        }
-
-        if (dataSourceId !== undefined) {
-            params[Param.DataSourceId] = dataSourceId;
-        }
-
-
-        if (isLiveboardStylingAndGroupingEnabled !== undefined) {
-            params[Param.IsLiveboardStylingAndGroupingEnabled] = isLiveboardStylingAndGroupingEnabled;
-        }
-
-        params[Param.LiveboardHeaderSticky] = isLiveboardHeaderSticky;
-        params[Param.LiveboardHeaderV2] = isLiveboardCompactHeaderEnabled;
-        params[Param.ShowLiveboardVerifiedBadge] = showLiveboardVerifiedBadge;
-        params[Param.ShowLiveboardReverifyBanner] = showLiveboardReverifyBanner;
-        params[Param.HideIrrelevantFiltersInTab] = hideIrrelevantChipsInLiveboardTabs;
-        params[Param.DataPanelV2Enabled] = dataPanelV2;
-        params[Param.EnableCustomColumnGroups] = enableCustomColumnGroups;
-        params[Param.CoverAndFilterOptionInPDF] = coverAndFilterOptionInPDF;
-        return params;
+        return queryParams;
     }
 
     private getIframeSuffixSrc(liveboardId: string, vizId: string, activeTabId: string) {
@@ -674,12 +644,29 @@ export class LiveboardEmbed extends V1Embed {
         }
     }
 
+    /**
+     * @hidden
+     * Internal state to track the current liveboard id.
+     * This is used to navigate to the correct liveboard when the prerender is visible.
+     */
+    public currentLiveboardState = {
+        liveboardId: this.viewConfig.liveboardId,
+        vizId: this.viewConfig.vizId,
+        activeTabId: this.viewConfig.activeTabId,
+    };
+
     protected beforePrerenderVisible(): void {
         const embedObj = this.getPreRenderObj<LiveboardEmbed>();
 
-        const libId = this.currentLiveboardId;
-        this.navigateToLiveboard(libId, this.viewConfig.vizId, this.viewConfig.activeTabId, () => {
-            if (embedObj) embedObj.currentLiveboardId = libId;
+        this.executeAfterEmbedContainerLoaded(() => {
+            this.navigateToLiveboard(this.viewConfig.liveboardId, this.viewConfig.vizId, this.viewConfig.activeTabId);
+            if (embedObj) {
+                embedObj.currentLiveboardState = {
+                    liveboardId: this.viewConfig.liveboardId,
+                    vizId: this.viewConfig.vizId,
+                    activeTabId: this.viewConfig.activeTabId,
+                };
+            }
         });
     }
 
@@ -754,15 +741,13 @@ export class LiveboardEmbed extends V1Embed {
         return this;
     }
 
-    public currentLiveboardId: string = this.viewConfig.liveboardId;
-
-    public navigateToLiveboard(liveboardId: string, vizId?: string, activeTabId?: string, onNavigateCalled?: () => void) {
+    public navigateToLiveboard(liveboardId: string, vizId?: string, activeTabId?: string) {
         const path = this.getIframeSuffixSrc(liveboardId, vizId, activeTabId);
         this.viewConfig.liveboardId = liveboardId;
         this.viewConfig.activeTabId = activeTabId;
         this.viewConfig.vizId = vizId;
         if (this.isRendered) {
-            this.triggerAfterLoad(HostEvent.Navigate, path.substring(1), onNavigateCalled);
+            this.trigger(HostEvent.Navigate, path.substring(1));
         } else if (this.viewConfig.preRenderId) {
             this.preRender(true);
         } else {

package/src/embed/sage.ts

@@ -153,7 +153,12 @@ export class SageEmbed extends V1Embed {
         super(domSelector, viewConfig);
     }
 
-    protected getEmbedParamsObject() {
+    /**
+     * Constructs a map of parameters to be passed on to the
+     * embedded Eureka or Sage search page.
+     * @returns {string} query string
+     */
+    protected getEmbedParams(): string {
         const {
             disableWorksheetChange,
             hideWorksheetSelector,
@@ -179,16 +184,6 @@ export class SageEmbed extends V1Embed {
         params[Param.IsProductTour] = !!isProductTour;
         params[Param.HideSageAnswerHeader] = !!hideSageAnswerHeader;
 
-        return params;
-    }
-
-    /**
-     * Constructs a map of parameters to be passed on to the
-     * embedded Eureka or Sage search page.
-     * @returns {string} query string
-     */
-    protected getEmbedParams(): string {
-        const params = this.getEmbedParamsObject();
         return getQueryParamString(params, true);
     }
 

package/src/embed/search-bar.tsx

@@ -118,7 +118,12 @@ export class SearchBarEmbed extends TsEmbed {
         this.viewConfig = viewConfig;
     }
 
-    protected getEmbedParamsObject() {
+    /**
+     * Construct the URL of the embedded ThoughtSpot search to be
+     * loaded in the iframe
+     * @param dataSources A list of data source GUIDs
+     */
+    private getIFrameSrc() {
         const {
             searchOptions,
             dataSource,
@@ -126,6 +131,7 @@ export class SearchBarEmbed extends TsEmbed {
             useLastSelectedSources = false,
             excludeSearchTokenStringFromURL,
         } = this.viewConfig;
+        const path = 'search-bar-embed';
         const queryParams = this.getBaseQueryParams();
 
         queryParams[Param.HideActions] = [...(queryParams[Param.HideActions] ?? [])];
@@ -153,19 +159,6 @@ export class SearchBarEmbed extends TsEmbed {
             queryParams[Param.UseLastSelectedDataSource] = false;
         }
         queryParams[Param.searchEmbed] = true;
-
-        return queryParams;
-    }
-
-    /**
-     * Construct the URL of the embedded ThoughtSpot search to be
-     * loaded in the iframe
-     * @param dataSources A list of data source GUIDs
-     */
-    private getIFrameSrc() {
-        const queryParams = this.getEmbedParamsObject();
-        const path = 'search-bar-embed';
-       
         let query = '';
         const queryParamsString = getQueryParamString(queryParams, true);
         if (queryParamsString) {

package/src/embed/search.ts

@@ -331,7 +331,7 @@ export const HiddenActionItemByDefaultForSearchEmbed = [
 ];
 
 export interface SearchAppInitData extends DefaultAppInitData {
-    searchOptions?: SearchOptions;
+  searchOptions?: SearchOptions;
 }
 
 /**
@@ -381,7 +381,7 @@ export class SearchEmbed extends TsEmbed {
         return { ...defaultAppInitData, ...this.getSearchInitData() };
     }
 
-    protected getEmbedParamsObject() {
+    protected getEmbedParams(): string {
         const {
             hideResults,
             enableSearchAssist,
@@ -398,7 +398,7 @@ export class SearchEmbed extends TsEmbed {
             collapseSearchBarInitially = false,
             enableCustomColumnGroups = false,
             isOnBeforeGetVizDataInterceptEnabled = false,
-
+            /* eslint-disable-next-line max-len */
             dataPanelCustomGroupsAccordionInitialState = DataPanelCustomColumnGroupsAccordionState.EXPAND_ALL,
             focusSearchBarOnRender = true,
             excludeRuntimeParametersfromURL,
@@ -443,7 +443,7 @@ export class SearchEmbed extends TsEmbed {
         }
 
         if (isOnBeforeGetVizDataInterceptEnabled) {
-
+            /* eslint-disable-next-line max-len */
             queryParams[Param.IsOnBeforeGetVizDataInterceptEnabled] = isOnBeforeGetVizDataInterceptEnabled;
         }
 
@@ -460,7 +460,7 @@ export class SearchEmbed extends TsEmbed {
         }
 
         queryParams[Param.searchEmbed] = true;
-
+        /* eslint-disable-next-line max-len */
         queryParams[Param.CollapseSearchBarInitially] = collapseSearchBarInitially || collapseSearchBar;
         queryParams[Param.EnableCustomColumnGroups] = enableCustomColumnGroups;
         if (dataPanelCustomGroupsAccordionInitialState
@@ -468,23 +468,12 @@ export class SearchEmbed extends TsEmbed {
             || dataPanelCustomGroupsAccordionInitialState
             === DataPanelCustomColumnGroupsAccordionState.EXPAND_FIRST
         ) {
-
+            /* eslint-disable-next-line max-len */
             queryParams[Param.DataPanelCustomGroupsAccordionInitialState] = dataPanelCustomGroupsAccordionInitialState;
         } else {
-
+            /* eslint-disable-next-line max-len */
             queryParams[Param.DataPanelCustomGroupsAccordionInitialState] = DataPanelCustomColumnGroupsAccordionState.EXPAND_ALL;
         }
-        return queryParams;
-    }
-
-    protected getEmbedParams() {
-        const {
-            runtimeParameters,
-            runtimeFilters,
-            excludeRuntimeParametersfromURL,
-            excludeRuntimeFiltersfromURL,
-        } = this.viewConfig;
-        const queryParams = this.getEmbedParamsObject();
         let query = '';
         const queryParamsString = getQueryParamString(queryParams, true);
         if (queryParamsString) {