@thoughtspot/visual-embed-sdk 1.40.1-alpha.2 → 1.40.1-alpha.3

package/src/embed/liveboard.spec.ts

@@ -368,6 +368,36 @@ describe('Liveboard/viz embed tests', () => {
         });
     });
 
+    test('should add liveboardXLSXCSVDownload flag and set value to true to the iframe src', async () => {
+        const liveboardEmbed = new LiveboardEmbed(getRootEl(), {
+            ...defaultViewConfig,
+            liveboardId,
+            liveboardXLSXCSVDownload: true,
+        } as LiveboardViewConfig);
+        liveboardEmbed.render();
+        await executeAfterWait(() => {
+            expectUrlMatchesWithParams(
+                getIFrameSrc(),
+                `http://${thoughtSpotHost}/?embedApp=true${defaultParams}&isLiveboardXLSXCSVDownloadEnabled=true${prefixParams}#/embed/viz/${liveboardId}`,
+            );
+        });
+    });
+
+    test('should add liveboardXLSXCSVDownload flag and set value to false to the iframe src', async () => {
+        const liveboardEmbed = new LiveboardEmbed(getRootEl(), {
+            ...defaultViewConfig,
+            liveboardId,
+            liveboardXLSXCSVDownload: false,
+        } as LiveboardViewConfig);
+        liveboardEmbed.render();
+        await executeAfterWait(() => {
+            expectUrlMatchesWithParams(
+                getIFrameSrc(),
+                `http://${thoughtSpotHost}/?embedApp=true${defaultParams}&isLiveboardXLSXCSVDownloadEnabled=false&${prefixParams}#/embed/viz/${liveboardId}`,
+            );
+        });
+    });
+
     test('should not append runtime filters in URL if excludeRuntimeFiltersfromURL is true', async () => {
         const liveboardEmbed = new LiveboardEmbed(getRootEl(), {
             ...defaultViewConfig,
@@ -601,14 +631,6 @@ describe('Liveboard/viz embed tests', () => {
 
     test('navigateToLiveboard should trigger the navigate event with the correct path', async (done) => {
         mockMessageChannel();
-        // mock getSessionInfo
-        jest.spyOn(SessionInfoService, 'getSessionInfo').mockResolvedValue({
-            releaseVersion: '1.0.0',
-            userGUID: '1234567890',
-            currentOrgId: 1,
-            privileges: [],
-            mixpanelToken: '1234567890',
-        });
         const liveboardEmbed = new LiveboardEmbed(getRootEl(), {
             ...defaultViewConfig,
         } as LiveboardViewConfig);
@@ -619,30 +641,16 @@ describe('Liveboard/viz embed tests', () => {
             postMessageToParent(iframe.contentWindow, {
                 type: EmbedEvent.APP_INIT,
             });
-            postMessageToParent(iframe.contentWindow, {
-                type: EmbedEvent.AuthInit,
-            });
-            liveboardEmbed.navigateToLiveboard('lb1', 'viz1');
         });
-
         executeAfterWait(() => {
+            liveboardEmbed.navigateToLiveboard('lb1', 'viz1');
             expect(onSpy).toHaveBeenCalledWith(HostEvent.Navigate, 'embed/viz/lb1/viz1');
             done();
-        }, 1002);
+        });
     });
 
     test('navigateToLiveboard with preRender', async (done) => {
         mockMessageChannel();
-
-        // mock getSessionInfo
-        jest.spyOn(SessionInfoService, 'getSessionInfo').mockResolvedValue({
-            releaseVersion: '1.0.0',
-            userGUID: '1234567890',
-            currentOrgId: 1,
-            privileges: [],
-            mixpanelToken: '1234567890',
-        });
-        
         const liveboardEmbed = new LiveboardEmbed(getRootEl(), {
             ...defaultViewConfig,
             preRenderId: 'test',
@@ -654,15 +662,12 @@ describe('Liveboard/viz embed tests', () => {
             postMessageToParent(iframe.contentWindow, {
                 type: EmbedEvent.APP_INIT,
             });
-            postMessageToParent(iframe.contentWindow, {
-                type: EmbedEvent.AuthInit,
-            });
         });
         executeAfterWait(() => {
             liveboardEmbed.navigateToLiveboard('lb1', 'viz1');
             expect(onSpy).toHaveBeenCalledWith(HostEvent.Navigate, 'embed/viz/lb1/viz1');
             done();
-        }, 1002);
+        });
     });
     test('should set runtime parametere values in url params', async () => {
         const liveboardEmbed = new LiveboardEmbed(getRootEl(), {
@@ -787,7 +792,7 @@ describe('Liveboard/viz embed tests', () => {
             });
         });
 
-        test('it should navigateToLiveboard with liveboard id is not passed', async (done) => {
+        test('it should navigateToLiveboard with liveboard id is not passed with EmbedListenerReady event', async (done) => {
             mockMessageChannel();
             const consoleSpy = jest.spyOn(console, 'error');
             const testPreRenderId = 'testPreRender';
@@ -816,12 +821,19 @@ describe('Liveboard/viz embed tests', () => {
                 libEmbed,
             );
 
+            await executeAfterWait(() => {
+                const iframe = getIFrameEl();
+                postMessageToParent(iframe.contentWindow, {
+                    type: EmbedEvent.EmbedListenerReady,
+                });
+            });
+
             const testLiveboardId = 'testLiveboardId';
             const newLibEmbed = new LiveboardEmbed(getRootEl(), {
                 preRenderId: testPreRenderId,
                 liveboardId: testLiveboardId,
-                activeTabId: 'tab1',
-                vizId: 'viz1',
+                vizId: 'testVizId',
+                activeTabId: 'testActiveTabId',
             });
             const navigateToLiveboardSpy = jest.spyOn(newLibEmbed, 'navigateToLiveboard');
             await newLibEmbed.showPreRender();
@@ -832,7 +844,7 @@ describe('Liveboard/viz embed tests', () => {
                 ) as HTMLIFrameElement;
 
                 // should render the generic link
-                expect(navigateToLiveboardSpy).toHaveBeenCalledWith(testLiveboardId, 'viz1', 'tab1', expect.any(Function));
+                expect(navigateToLiveboardSpy).toHaveBeenCalledWith(testLiveboardId, 'testVizId', 'testActiveTabId');
                 expect(iFrame.src).toMatch(/http:\/\/tshost\/.*&isLiveboardEmbed=true.*#$/);
 
                 expect(consoleSpy).toHaveBeenCalledTimes(0);
@@ -840,6 +852,72 @@ describe('Liveboard/viz embed tests', () => {
                 done();
             });
         });
+       
+        test('it should navigateToLiveboard with liveboard id is not passed with AuthInit event', async (done) => {
+            mockMessageChannel();
+            const consoleSpy = jest.spyOn(console, 'error');
+            const testPreRenderId = 'testPreRender';
+            const libEmbed = new LiveboardEmbed(getRootEl(), {
+                preRenderId: testPreRenderId,
+            });
+
+            jest.spyOn(SessionInfoService, 'getSessionInfo').mockResolvedValue({
+                releaseVersion: '1.0.0',
+                userGUID: '1234567890',
+                currentOrgId: 1,
+                privileges: [],
+                mixpanelToken: '1234567890',
+            });
+            let resizeObserverCb: any;
+            (window as any).ResizeObserver =
+                window.ResizeObserver ||
+                jest.fn().mockImplementation((resizeObserverCbParam: any) => {
+                    resizeObserverCb = resizeObserverCbParam;
+                    return {
+                        disconnect: jest.fn(),
+                        observe: jest.fn(),
+                        unobserve: jest.fn(),
+                    };
+                });
+            await libEmbed.preRender();
+            await waitFor(() => !!getIFrameEl());
+            const ts = '__tsEmbed';
+            expect((document.getElementById(libEmbed.getPreRenderIds().wrapper) as any)[ts]).toEqual(
+                libEmbed,
+            );
+            const testLiveboardId = 'testLiveboardId';
+            const newLibEmbed = new LiveboardEmbed(getRootEl(), {
+                preRenderId: testPreRenderId,
+                liveboardId: testLiveboardId,
+                vizId: 'testVizId',
+                activeTabId: 'testActiveTabId',
+            });
+            const navigateToLiveboardSpy = jest.spyOn(newLibEmbed, 'navigateToLiveboard');
+
+            await newLibEmbed.showPreRender();
+
+            await executeAfterWait(() => {
+                const iFrame = document.getElementById(
+                    newLibEmbed.getPreRenderIds().child,
+                ) as HTMLIFrameElement;
+                postMessageToParent(iFrame.contentWindow, {
+                    type: EmbedEvent.AuthInit,
+                });
+            });
+
+
+            await executeAfterWait(() => {
+                const iFrame = document.getElementById(
+                    libEmbed.getPreRenderIds().child,
+                ) as HTMLIFrameElement;
+                // should render the generic link
+                expect(navigateToLiveboardSpy).toHaveBeenCalledWith(testLiveboardId, 'testVizId', 'testActiveTabId');
+                expect(iFrame.src).toMatch(/http:\/\/tshost\/.*&isLiveboardEmbed=true.*#$/);
+                expect(consoleSpy).toHaveBeenCalledTimes(0);
+                done();
+            }, 1005);
+        });
+
     });
 
     describe('LazyLoadingForFullHeight functionality', () => {
@@ -1113,4 +1191,157 @@ describe('Liveboard/viz embed tests', () => {
             });
         });
     });
+
+    describe('Liveboard Embed Container Loading and PreRender', () => {
+        beforeEach(() => {
+            document.body.innerHTML = getDocumentBody();
+        });
+
+        test('should call navigateToLiveboard after embed container is loaded in beforePrerenderVisible', async () => {
+            const liveboardEmbed = new LiveboardEmbed(getRootEl(), {
+                liveboardId,
+                vizId,
+                activeTabId,
+                ...defaultViewConfig,
+            });
+
+            const navigateToLiveboardSpy = jest.spyOn(liveboardEmbed, 'navigateToLiveboard').mockResolvedValue(undefined);
+
+            // Mock embed container as not loaded initially
+            liveboardEmbed.isEmbedContainerLoaded = false;
+
+            // Call beforePrerenderVisible
+            liveboardEmbed['beforePrerenderVisible']();
+
+            // navigateToLiveboard should not be called immediately
+            expect(navigateToLiveboardSpy).not.toHaveBeenCalled();
+
+            // Simulate embed container becoming ready
+            liveboardEmbed.isEmbedContainerLoaded = true;
+            liveboardEmbed['executeEmbedContainerReadyCallbacks']();
+
+            // Now navigateToLiveboard should be called
+            expect(navigateToLiveboardSpy).toHaveBeenCalledWith(liveboardId, vizId, activeTabId);
+        });
+
+        test('should update currentLiveboardState for prerender object when embed container loads', async () => {
+            const liveboardEmbed = new LiveboardEmbed(getRootEl(), {
+                liveboardId,
+                vizId,
+                activeTabId,
+                ...defaultViewConfig,
+            });
+
+            const mockPreRenderObj = {
+                currentLiveboardState: {},
+            };
+
+            jest.spyOn(liveboardEmbed as any, 'getPreRenderObj').mockReturnValue(mockPreRenderObj as any);
+            jest.spyOn(liveboardEmbed, 'navigateToLiveboard').mockResolvedValue(undefined);
+
+            // Mock embed container as not loaded initially
+            liveboardEmbed.isEmbedContainerLoaded = false;
+
+            // Call beforePrerenderVisible
+            liveboardEmbed['beforePrerenderVisible']();
+
+            // Simulate embed container becoming ready
+            liveboardEmbed.isEmbedContainerLoaded = true;
+            liveboardEmbed['executeEmbedContainerReadyCallbacks']();
+
+            // Check that currentLiveboardState was updated
+            expect(mockPreRenderObj.currentLiveboardState).toEqual({
+                liveboardId,
+                vizId,
+                activeTabId,
+            });
+        });
+
+        test('should handle beforePrerenderVisible when embed container is already loaded', async () => {
+            const liveboardEmbed = new LiveboardEmbed(getRootEl(), {
+                liveboardId,
+                vizId,
+                activeTabId,
+                ...defaultViewConfig,
+            });
+
+            const navigateToLiveboardSpy = jest.spyOn(liveboardEmbed, 'navigateToLiveboard').mockResolvedValue(undefined);
+
+            // Mock embed container as already loaded
+            liveboardEmbed.isEmbedContainerLoaded = true;
+
+            // Call beforePrerenderVisible
+            liveboardEmbed['beforePrerenderVisible']();
+
+            // navigateToLiveboard should be called immediately
+            expect(navigateToLiveboardSpy).toHaveBeenCalledWith(liveboardId, vizId, activeTabId);
+        });
+
+        test('should handle beforePrerenderVisible without prerender object', async () => {
+            const liveboardEmbed = new LiveboardEmbed(getRootEl(), {
+                liveboardId,
+                vizId,
+                activeTabId,
+                ...defaultViewConfig,
+            });
+
+            jest.spyOn(liveboardEmbed as any, 'getPreRenderObj').mockReturnValue(null);
+            const navigateToLiveboardSpy = jest.spyOn(liveboardEmbed, 'navigateToLiveboard').mockResolvedValue(undefined);
+
+            // Mock embed container as not loaded initially
+            liveboardEmbed.isEmbedContainerLoaded = false;
+
+            // Call beforePrerenderVisible
+            liveboardEmbed['beforePrerenderVisible']();
+
+            // Simulate embed container becoming ready
+            liveboardEmbed.isEmbedContainerLoaded = true;
+            liveboardEmbed['executeEmbedContainerReadyCallbacks']();
+
+            // navigateToLiveboard should still be called
+            expect(navigateToLiveboardSpy).toHaveBeenCalledWith(liveboardId, vizId, activeTabId);
+        });
+
+        test('should work with all liveboard parameters', async () => {
+            const customLiveboardId = 'custom-liveboard-id';
+            const customVizId = 'custom-viz-id';
+            const customActiveTabId = 'custom-active-tab-id';
+
+            const liveboardEmbed = new LiveboardEmbed(getRootEl(), {
+                liveboardId: customLiveboardId,
+                vizId: customVizId,
+                activeTabId: customActiveTabId,
+                ...defaultViewConfig,
+            });
+
+            const navigateToLiveboardSpy = jest.spyOn(liveboardEmbed, 'navigateToLiveboard').mockResolvedValue(undefined);
+
+            // Mock embed container as already loaded
+            liveboardEmbed.isEmbedContainerLoaded = true;
+
+            // Call beforePrerenderVisible
+            liveboardEmbed['beforePrerenderVisible']();
+
+            // Check that all parameters are passed correctly
+            expect(navigateToLiveboardSpy).toHaveBeenCalledWith(customLiveboardId, customVizId, customActiveTabId);
+        });
+
+        test('should work with minimal liveboard parameters', async () => {
+            const liveboardEmbed = new LiveboardEmbed(getRootEl(), {
+                liveboardId,
+                ...defaultViewConfig,
+            });
+
+            const navigateToLiveboardSpy = jest.spyOn(liveboardEmbed, 'navigateToLiveboard').mockResolvedValue(undefined);
+
+            // Mock embed container as already loaded
+            liveboardEmbed.isEmbedContainerLoaded = true;
+
+            // Call beforePrerenderVisible
+            liveboardEmbed['beforePrerenderVisible']();
+
+            // Check that undefined parameters are passed correctly
+            expect(navigateToLiveboardSpy).toHaveBeenCalledWith(liveboardId, undefined, undefined);
+        });
+    });
 });

package/src/embed/liveboard.ts

@@ -408,12 +408,6 @@ export class LiveboardEmbed extends V1Embed {
      * embedded Liveboard or visualization.
      */
     protected getEmbedParams() {
-        const params = this.getEmbedParamsObject();
-        const queryParams = getQueryParamString(params, true);
-        return queryParams;
-    }
-
-    protected getEmbedParamsObject() {
         let params: any = {};
         params = this.getBaseQueryParams(params);
         const {
@@ -441,6 +435,7 @@ export class LiveboardEmbed extends V1Embed {
             isForceRedirect,
             dataSourceId,
             coverAndFilterOptionInPDF = false,
+            liveboardXLSXCSVDownload = false,
             isLiveboardStylingAndGroupingEnabled,
         } = this.viewConfig;
 
@@ -517,33 +512,10 @@ export class LiveboardEmbed extends V1Embed {
         params[Param.DataPanelV2Enabled] = dataPanelV2;
         params[Param.EnableCustomColumnGroups] = enableCustomColumnGroups;
         params[Param.CoverAndFilterOptionInPDF] = coverAndFilterOptionInPDF;
+        params[Param.LiveboardXLSXCSVDownload] = !!liveboardXLSXCSVDownload;
+        const queryParams = getQueryParamString(params, true);
 
-        if (oAuthPollingInterval !== undefined) {
-            params[Param.OauthPollingInterval] = oAuthPollingInterval;
-        }
-
-        if (isForceRedirect) {
-            params[Param.IsForceRedirect] = isForceRedirect;
-        }
-
-        if (dataSourceId !== undefined) {
-            params[Param.DataSourceId] = dataSourceId;
-        }
-
-
-        if (isLiveboardStylingAndGroupingEnabled !== undefined) {
-            params[Param.IsLiveboardStylingAndGroupingEnabled] = isLiveboardStylingAndGroupingEnabled;
-        }
-
-        params[Param.LiveboardHeaderSticky] = isLiveboardHeaderSticky;
-        params[Param.LiveboardHeaderV2] = isLiveboardCompactHeaderEnabled;
-        params[Param.ShowLiveboardVerifiedBadge] = showLiveboardVerifiedBadge;
-        params[Param.ShowLiveboardReverifyBanner] = showLiveboardReverifyBanner;
-        params[Param.HideIrrelevantFiltersInTab] = hideIrrelevantChipsInLiveboardTabs;
-        params[Param.DataPanelV2Enabled] = dataPanelV2;
-        params[Param.EnableCustomColumnGroups] = enableCustomColumnGroups;
-        params[Param.CoverAndFilterOptionInPDF] = coverAndFilterOptionInPDF;
-        return params;
+        return queryParams;
     }
 
     private getIframeSuffixSrc(liveboardId: string, vizId: string, activeTabId: string) {
@@ -674,12 +646,29 @@ export class LiveboardEmbed extends V1Embed {
         }
     }
 
+    /**
+     * @hidden
+     * Internal state to track the current liveboard id.
+     * This is used to navigate to the correct liveboard when the prerender is visible.
+     */
+    public currentLiveboardState = {
+        liveboardId: this.viewConfig.liveboardId,
+        vizId: this.viewConfig.vizId,
+        activeTabId: this.viewConfig.activeTabId,
+    };
+
     protected beforePrerenderVisible(): void {
         const embedObj = this.getPreRenderObj<LiveboardEmbed>();
 
-        const libId = this.currentLiveboardId;
-        this.navigateToLiveboard(libId, this.viewConfig.vizId, this.viewConfig.activeTabId, () => {
-            if (embedObj) embedObj.currentLiveboardId = libId;
+        this.executeAfterEmbedContainerLoaded(() => {
+            this.navigateToLiveboard(this.viewConfig.liveboardId, this.viewConfig.vizId, this.viewConfig.activeTabId);
+            if (embedObj) {
+                embedObj.currentLiveboardState = {
+                    liveboardId: this.viewConfig.liveboardId,
+                    vizId: this.viewConfig.vizId,
+                    activeTabId: this.viewConfig.activeTabId,
+                };
+            }
         });
     }
 
@@ -754,15 +743,13 @@ export class LiveboardEmbed extends V1Embed {
         return this;
     }
 
-    public currentLiveboardId: string = this.viewConfig.liveboardId;
-
-    public navigateToLiveboard(liveboardId: string, vizId?: string, activeTabId?: string, onNavigateCalled?: () => void) {
+    public navigateToLiveboard(liveboardId: string, vizId?: string, activeTabId?: string) {
         const path = this.getIframeSuffixSrc(liveboardId, vizId, activeTabId);
         this.viewConfig.liveboardId = liveboardId;
         this.viewConfig.activeTabId = activeTabId;
         this.viewConfig.vizId = vizId;
         if (this.isRendered) {
-            this.triggerAfterLoad(HostEvent.Navigate, path.substring(1), onNavigateCalled);
+            this.trigger(HostEvent.Navigate, path.substring(1));
         } else if (this.viewConfig.preRenderId) {
             this.preRender(true);
         } else {

package/src/embed/sage.ts

@@ -153,7 +153,12 @@ export class SageEmbed extends V1Embed {
         super(domSelector, viewConfig);
     }
 
-    protected getEmbedParamsObject() {
+    /**
+     * Constructs a map of parameters to be passed on to the
+     * embedded Eureka or Sage search page.
+     * @returns {string} query string
+     */
+    protected getEmbedParams(): string {
         const {
             disableWorksheetChange,
             hideWorksheetSelector,
@@ -179,16 +184,6 @@ export class SageEmbed extends V1Embed {
         params[Param.IsProductTour] = !!isProductTour;
         params[Param.HideSageAnswerHeader] = !!hideSageAnswerHeader;
 
-        return params;
-    }
-
-    /**
-     * Constructs a map of parameters to be passed on to the
-     * embedded Eureka or Sage search page.
-     * @returns {string} query string
-     */
-    protected getEmbedParams(): string {
-        const params = this.getEmbedParamsObject();
         return getQueryParamString(params, true);
     }
 

package/src/embed/search-bar.tsx

@@ -118,7 +118,12 @@ export class SearchBarEmbed extends TsEmbed {
         this.viewConfig = viewConfig;
     }
 
-    protected getEmbedParamsObject() {
+    /**
+     * Construct the URL of the embedded ThoughtSpot search to be
+     * loaded in the iframe
+     * @param dataSources A list of data source GUIDs
+     */
+    private getIFrameSrc() {
         const {
             searchOptions,
             dataSource,
@@ -126,6 +131,7 @@ export class SearchBarEmbed extends TsEmbed {
             useLastSelectedSources = false,
             excludeSearchTokenStringFromURL,
         } = this.viewConfig;
+        const path = 'search-bar-embed';
         const queryParams = this.getBaseQueryParams();
 
         queryParams[Param.HideActions] = [...(queryParams[Param.HideActions] ?? [])];
@@ -153,19 +159,6 @@ export class SearchBarEmbed extends TsEmbed {
             queryParams[Param.UseLastSelectedDataSource] = false;
         }
         queryParams[Param.searchEmbed] = true;
-
-        return queryParams;
-    }
-
-    /**
-     * Construct the URL of the embedded ThoughtSpot search to be
-     * loaded in the iframe
-     * @param dataSources A list of data source GUIDs
-     */
-    private getIFrameSrc() {
-        const queryParams = this.getEmbedParamsObject();
-        const path = 'search-bar-embed';
-       
         let query = '';
         const queryParamsString = getQueryParamString(queryParams, true);
         if (queryParamsString) {

package/src/embed/search.ts

@@ -331,7 +331,7 @@ export const HiddenActionItemByDefaultForSearchEmbed = [
 ];
 
 export interface SearchAppInitData extends DefaultAppInitData {
-    searchOptions?: SearchOptions;
+  searchOptions?: SearchOptions;
 }
 
 /**
@@ -381,7 +381,7 @@ export class SearchEmbed extends TsEmbed {
         return { ...defaultAppInitData, ...this.getSearchInitData() };
     }
 
-    protected getEmbedParamsObject() {
+    protected getEmbedParams(): string {
         const {
             hideResults,
             enableSearchAssist,
@@ -398,7 +398,7 @@ export class SearchEmbed extends TsEmbed {
             collapseSearchBarInitially = false,
             enableCustomColumnGroups = false,
             isOnBeforeGetVizDataInterceptEnabled = false,
-
+            /* eslint-disable-next-line max-len */
             dataPanelCustomGroupsAccordionInitialState = DataPanelCustomColumnGroupsAccordionState.EXPAND_ALL,
             focusSearchBarOnRender = true,
             excludeRuntimeParametersfromURL,
@@ -443,7 +443,7 @@ export class SearchEmbed extends TsEmbed {
         }
 
         if (isOnBeforeGetVizDataInterceptEnabled) {
-
+            /* eslint-disable-next-line max-len */
             queryParams[Param.IsOnBeforeGetVizDataInterceptEnabled] = isOnBeforeGetVizDataInterceptEnabled;
         }
 
@@ -460,7 +460,7 @@ export class SearchEmbed extends TsEmbed {
         }
 
         queryParams[Param.searchEmbed] = true;
-
+        /* eslint-disable-next-line max-len */
         queryParams[Param.CollapseSearchBarInitially] = collapseSearchBarInitially || collapseSearchBar;
         queryParams[Param.EnableCustomColumnGroups] = enableCustomColumnGroups;
         if (dataPanelCustomGroupsAccordionInitialState
@@ -468,23 +468,12 @@ export class SearchEmbed extends TsEmbed {
             || dataPanelCustomGroupsAccordionInitialState
             === DataPanelCustomColumnGroupsAccordionState.EXPAND_FIRST
         ) {
-
+            /* eslint-disable-next-line max-len */
             queryParams[Param.DataPanelCustomGroupsAccordionInitialState] = dataPanelCustomGroupsAccordionInitialState;
         } else {
-
+            /* eslint-disable-next-line max-len */
             queryParams[Param.DataPanelCustomGroupsAccordionInitialState] = DataPanelCustomColumnGroupsAccordionState.EXPAND_ALL;
         }
-        return queryParams;
-    }
-
-    protected getEmbedParams() {
-        const {
-            runtimeParameters,
-            runtimeFilters,
-            excludeRuntimeParametersfromURL,
-            excludeRuntimeFiltersfromURL,
-        } = this.viewConfig;
-        const queryParams = this.getEmbedParamsObject();
         let query = '';
         const queryParamsString = getQueryParamString(queryParams, true);
         if (queryParamsString) {