@thoughtspot/visual-embed-sdk 1.39.2 → 1.39.3

package/src/utils/global-styles.ts

@@ -5,7 +5,7 @@ export const addPreviewStylesIfNotPresent = () => {
     }
 
     const previewStyles = `
-        <link rel="stylesheet" href="https://cdn.jsdelivr.net/npm/ag-grid-community@32.0.2/styles/ag-grid.min.css">
+        <link rel="stylesheet" href="https://cdn.jsdelivr.net/npm/ag-grid-community@32.0.2/styles/ag-grid.min.css" integrity="sha384-PvEsKa6emq5KYa9mf+Q7eYF5C2OCacYzZ+hBngp21NA4o1A9iU9smnytEmqUFbEZ" crossorigin="anonymous">
         <style id="ts-preview-style">
            .ts-viz-preview-loader {
                 position: absolute;

package/src/utils/graphql/nlsService/conversation-service.ts

@@ -64,7 +64,13 @@ export class Conversation {
             );
             const data = responses[0].data;
             return {
-                data: data.asstRespData.nlsAnsData.sageQuerySuggestions[0],
+                convId: this.conversationId,
+                messageId: responses[0].msgId,
+                data: {
+                    ...data.asstRespData.nlsAnsData.sageQuerySuggestions[0],
+                    convId: this.conversationId,
+                    messageId: responses[0].msgId,
+                },
                 error: null,
             };
         } catch (error) {

package/src/utils.spec.ts

@@ -15,6 +15,7 @@ import {
     getValueFromWindow,
     handlePresentEvent,
     handleExitPresentMode,
+    getTypeFromValue,
 } from './utils';
 import { RuntimeFilterOp } from './types';
 import { logger } from './utils/logger';
@@ -284,6 +285,27 @@ describe('unit test for utils', () => {
     test('isUndefined', () => {
         expect(isUndefined(undefined)).toBe(true);
         expect(isUndefined({})).toBe(false);
+        expect(isUndefined(null)).toBe(false);
+        expect(isUndefined('')).toBe(false);
+        expect(isUndefined(0)).toBe(false);
+    });
+
+    test('removeTypename should handle edge cases', () => {
+        expect(removeTypename(null)).toBe(null);
+        expect(removeTypename(undefined)).toBe(undefined);
+        expect(removeTypename('string')).toBe('string');
+        expect(removeTypename(123)).toBe(123);
+    });
+
+    test('getTypeFromValue should return correct types', () => {
+        expect(getTypeFromValue('test')).toEqual(['char', 'string']);
+        expect(getTypeFromValue(123)).toEqual(['double', 'double']);
+        expect(getTypeFromValue(true)).toEqual(['boolean', 'boolean']);
+        expect(getTypeFromValue(false)).toEqual(['boolean', 'boolean']);
+        expect(getTypeFromValue(null)).toEqual(['', '']);
+        expect(getTypeFromValue(undefined)).toEqual(['', '']);
+        expect(getTypeFromValue({})).toEqual(['', '']);
+        expect(getTypeFromValue([])).toEqual(['', '']);
     });
 
     describe('getValueFromWindow and storeValueInWindow', () => {
@@ -303,6 +325,13 @@ describe('unit test for utils', () => {
         test('Return undefined if key is not found', () => {
             expect(getValueFromWindow('notFound')).toBe(undefined);
         });
+
+        test('Store with ignoreIfAlreadyExists option', () => {
+            storeValueInWindow('test2', 'firstValue');
+            const result = storeValueInWindow('test2', 'secondValue', { ignoreIfAlreadyExists: true });
+            expect(result).toBe('firstValue');
+            expect(getValueFromWindow('test2')).toBe('firstValue');
+        });
     });
 });