@thoughtspot/visual-embed-sdk 1.39.0 → 1.39.2-alpha.1

package/src/embed/sage.ts

@@ -48,39 +48,39 @@ export interface SageViewConfig
     showObjectResults?: boolean;
     /**
      * flag used by the TS product tour page to show the blue search bar
-     * even after the search is completed. This is different from Thoughtspot Embedded
+     * even after the search is completed. This is different from ThoughtSpot Embedded
      * Sage Embed experience where it mimics closer to the non-embed case.
      * The Sample questions container is collapsed when this value is set after
      * does a search.
-     * @version SDK: 1.26.0 | Thoughtspot: 9.8.0.cl
+     * @version SDK: 1.26.0 | ThoughtSpot: 9.8.0.cl
      * @hidden
      */
     isProductTour?: boolean;
     /**
      * Show or hide the search bar title.
-     * @version SDK: 1.29.0 | Thoughtspot: 9.8.0.cl, 9.8.0.sw
-     * @deprecated Thoughtspot: 9.10.0.cl | search bar doesn't have the title from 9.10.0.cl
+     * @version SDK: 1.29.0 | ThoughtSpot: 9.8.0.cl, 9.8.0.sw
+     * @deprecated ThoughtSpot: 9.10.0.cl | search bar doesn't have the title from 9.10.0.cl
      */
     hideSearchBarTitle?: boolean;
     /**
      * Show or hide the Answer header, that is, the `AI Answer` title
      * at the top of the Answer page.
-     * @version SDK: 1.26.0 | Thoughtspot: 9.10.0.cl
+     * @version SDK: 1.26.0 | ThoughtSpot: 9.10.0.cl
      */
     hideSageAnswerHeader?: boolean;
     /**
      * Disable the worksheet selection option.
-     * @version SDK: 1.26.0 | Thoughtspot: 9.8.0.cl, 9.8.0.sw
+     * @version SDK: 1.26.0 | ThoughtSpot: 9.8.0.cl, 9.8.0.sw
      */
     disableWorksheetChange?: boolean;
     /**
      * Hide the worksheet selection panel.
-     * @version SDK: 1.26.0 | Thoughtspot: 9.8.0.cl, 9.8.0.sw
+     * @version SDK: 1.26.0 | ThoughtSpot: 9.8.0.cl, 9.8.0.sw
      */
     hideWorksheetSelector?: boolean;
     /**
      * Show or hide autocomplete suggestions for the search query string.
-     * @version SDK: 1.26.0 | Thoughtspot: 9.8.0.cl, 9.8.0.sw
+     * @version SDK: 1.26.0 | ThoughtSpot: 9.8.0.cl, 9.8.0.sw
      */
     hideAutocompleteSuggestions?: boolean;
     /**
@@ -96,7 +96,7 @@ export interface SageViewConfig
      * selected for the search operation.
      * 
      * Supported embed types: `SageEmbed`
-     * @version SDK: 1.26.0 | Thoughtspot: 9.8.0.cl, 9.8.0.sw
+     * @version SDK: 1.26.0 | ThoughtSpot: 9.8.0.cl, 9.8.0.sw
      * @example
      * ```js
      * const embed = new SageEmbed('#tsEmbed', {
@@ -129,7 +129,7 @@ export interface SageViewConfig
      *    executeSearch: true,
      * }
      * ```
-     * @version SDK: 1.26.0 | Thoughtspot: 9.8.0.cl, 9.8.0.sw
+     * @version SDK: 1.26.0 | ThoughtSpot: 9.8.0.cl, 9.8.0.sw
      */
     searchOptions?: SearchOptions;
 }

package/src/embed/search.ts

@@ -272,7 +272,7 @@ export interface SearchViewConfig
     /**
      * To set the initial state of the search bar in case of saved-answers.
      * @default false
-     * @version SDK: 1.32.0 | Thoughtspot: 10.0.0.cl
+     * @version SDK: 1.32.0 | ThoughtSpot: 10.0.0.cl
      * @deprecated Use {@link collapseSearchBar} instead
      */
     collapseSearchBarInitially?: boolean;
@@ -280,7 +280,7 @@ export interface SearchViewConfig
      * Flag to enable onBeforeSearchExecute Embed Event
      * 
      * Supported embed types: `SearchEmbed`
-     * @version: SDK: 1.29.0 | Thoughtspot: 10.1.0.cl
+     * @version: SDK: 1.29.0 | ThoughtSpot: 10.1.0.cl
      */
     isOnBeforeGetVizDataInterceptEnabled?: boolean;
     /**
@@ -292,7 +292,7 @@ export interface SearchViewConfig
      * - EXPAND_FIRST: Expand the first accordion and collapse the rest.
      * 
      * Supported embed types: `SearchEmbed`
-     * @version SDK: 1.32.0 | Thoughtspot: 10.0.0.cl
+     * @version SDK: 1.32.0 | ThoughtSpot: 10.0.0.cl
      * @default DataPanelCustomColumnGroupsAccordionState.EXPAND_ALL
      * @example
      * ```js
@@ -309,7 +309,7 @@ export interface SearchViewConfig
      * lands on search embed page.
      * 
      * Supported embed types: `SearchEmbed`
-     * @version SDK: 1.32.0 | Thoughtspot: 10.3.0.cl
+     * @version SDK: 1.32.0 | ThoughtSpot: 10.3.0.cl
      * @default true
      * @example
      * ```js

package/src/embed/ts-embed.spec.ts

@@ -1360,6 +1360,231 @@ describe('Unit test case for ts embed', () => {
         });
     });
 
+    describe('Preauth Cache for FullAppEmbed with PrimaryNavBar', () => {
+        beforeAll(() => {
+            jest.clearAllMocks();
+            init({
+                thoughtSpotHost,
+                authType: AuthType.None,
+            });
+        });
+        afterEach(() => {
+            jest.clearAllMocks();
+        });
+        
+        afterAll(() => {
+            jest.clearAllMocks();
+        });
+
+        const setupPreauthTest = async (
+            embedType: 'AppEmbed' | 'SearchEmbed',
+            showPrimaryNavbar?: boolean,
+            overrideOrgId?: number,
+            disablePreauthCache?: boolean
+        ) => {
+            jest.spyOn(window, 'addEventListener').mockImplementationOnce(
+                (event, handler, options) => {
+                    handler({
+                        data: { type: 'xyz' },
+                        ports: [3000],
+                        source: null,
+                    });
+                },
+            );
+            mockProcessTrigger.mockResolvedValueOnce({ session: 'test' });
+            jest.spyOn(baseInstance, 'getAuthPromise').mockResolvedValueOnce(true);
+
+            let mockGetPreauthInfo = null;
+            
+            // Determine if preauth cache should be enabled
+            const isAppEmbedWithPrimaryNavbar = embedType === 'AppEmbed' && showPrimaryNavbar === true;
+            const shouldDisableCache = overrideOrgId || disablePreauthCache || isAppEmbedWithPrimaryNavbar;
+            
+            if (shouldDisableCache) {
+                mockGetPreauthInfo = jest.spyOn(sessionInfoService, 'getPreauthInfo')
+                    .mockImplementation(jest.fn());
+            } else {
+                mockGetPreauthInfo = jest.spyOn(sessionInfoService, 'getPreauthInfo')
+                    .mockResolvedValue({ info: { test: 'data' } });
+            }
+
+            const mockPreauthInfoFetch = jest.spyOn(authService, 'fetchPreauthInfoService')
+                .mockResolvedValueOnce({
+                    ok: true,
+                    headers: new Headers({ 'content-type': 'application/json' }),
+                    json: async () => ({
+                        info: { test: 'data' },
+                    }),
+                } as any);
+
+            const viewConfig: any = {
+                frameParams: { width: 1280, height: 720 },
+            };
+
+            if (showPrimaryNavbar !== undefined) {
+                viewConfig.showPrimaryNavbar = showPrimaryNavbar;
+            }
+            if (overrideOrgId !== undefined) {
+                viewConfig.overrideOrgId = overrideOrgId;
+            }
+
+            // Mock getEmbedConfig for disablePreauthCache
+            if (disablePreauthCache !== undefined) {
+                jest.spyOn(embedConfig, 'getEmbedConfig').mockReturnValueOnce({
+                    thoughtSpotHost,
+                    authType: AuthType.None,
+                    disablePreauthCache,
+                });
+            }
+
+            let embed;
+            if (embedType === 'AppEmbed') {
+                embed = new AppEmbed(getRootEl(), viewConfig);
+            } else {
+                embed = new SearchEmbed(getRootEl(), viewConfig);
+            }
+
+            const iFrame: any = document.createElement('div');
+            iFrame.contentWindow = {
+                postMessage: jest.fn(),
+            };
+            jest.spyOn(iFrame, 'addEventListener').mockImplementationOnce(
+                (event, handler, options) => {
+                    handler({});
+                },
+            );
+            jest.spyOn(document, 'createElement').mockReturnValueOnce(iFrame);
+
+            await embed.render();
+
+            return {
+                embed,
+                mockGetPreauthInfo,
+                mockPreauthInfoFetch,
+                iFrame,
+            };
+        };
+
+        test('should disable preauth cache for FullAppEmbed with showPrimaryNavbar = true (default)', async () => {
+            const { mockGetPreauthInfo } = await setupPreauthTest('AppEmbed', true);
+            
+            // Wait for any async operations
+            await executeAfterWait(() => {
+                expect(mockGetPreauthInfo).toHaveBeenCalledTimes(0);
+            });
+        });
+
+        test('should enable preauth cache for FullAppEmbed with showPrimaryNavbar = undefined (no longer defaults to true)', async () => {
+            const { mockGetPreauthInfo } = await setupPreauthTest('AppEmbed', undefined);
+            
+            await executeAfterWait(() => {
+                expect(mockGetPreauthInfo).toHaveBeenCalledTimes(1);
+                expect(mockProcessTrigger).toHaveBeenCalledWith(
+                    expect.any(Object),
+                    HostEvent.InfoSuccess,
+                    'http://tshost',
+                    expect.objectContaining({ info: expect.any(Object) }),
+                );
+            });
+        });
+
+        test('should enable preauth cache for FullAppEmbed with showPrimaryNavbar = false', async () => {
+            const { mockGetPreauthInfo } = await setupPreauthTest('AppEmbed', false);
+            
+            await executeAfterWait(() => {
+                expect(mockGetPreauthInfo).toHaveBeenCalledTimes(1);
+                expect(mockProcessTrigger).toHaveBeenCalledWith(
+                    expect.any(Object),
+                    HostEvent.InfoSuccess,
+                    'http://tshost',
+                    expect.objectContaining({ info: expect.any(Object) }),
+                );
+            });
+        });
+
+        test('should enable preauth cache for SearchEmbed regardless of showPrimaryNavbar', async () => {
+            const { mockGetPreauthInfo } = await setupPreauthTest('SearchEmbed', true);
+            
+            await executeAfterWait(() => {
+                expect(mockGetPreauthInfo).toHaveBeenCalledTimes(1);
+                expect(mockProcessTrigger).toHaveBeenCalledWith(
+                    expect.any(Object),
+                    HostEvent.InfoSuccess,
+                    'http://tshost',
+                    expect.objectContaining({ info: expect.any(Object) }),
+                );
+            });
+        });
+
+        test('should enable preauth cache for SearchEmbed (verifies fix for embed type regression)', async () => {
+            const { mockGetPreauthInfo } = await setupPreauthTest('SearchEmbed', false);
+            
+            await executeAfterWait(() => {
+                expect(mockGetPreauthInfo).toHaveBeenCalledTimes(1);
+                expect(mockProcessTrigger).toHaveBeenCalledWith(
+                    expect.any(Object),
+                    HostEvent.InfoSuccess,
+                    'http://tshost',
+                    expect.objectContaining({ info: expect.any(Object) }),
+                );
+            });
+        });
+
+        test('should disable preauth cache for FullAppEmbed with overrideOrgId (combined condition)', async () => {
+            const { mockGetPreauthInfo } = await setupPreauthTest('AppEmbed', false, 123);
+            
+            await executeAfterWait(() => {
+                expect(mockGetPreauthInfo).toHaveBeenCalledTimes(0);
+            });
+        });
+
+        test('should disable preauth cache for FullAppEmbed with disablePreauthCache = true', async () => {
+            const { mockGetPreauthInfo } = await setupPreauthTest('AppEmbed', false, undefined, true);
+            
+            await executeAfterWait(() => {
+                expect(mockGetPreauthInfo).toHaveBeenCalledTimes(0);
+            });
+        });
+    });
+
+    describe('isFullAppEmbedWithVisiblePrimaryNavbar helper method', () => {
+        beforeAll(() => {
+            init({
+                thoughtSpotHost,
+                authType: AuthType.None,
+            });
+        });
+
+        afterEach(() => {
+            jest.clearAllMocks();
+        });
+
+        test('should return true for AppEmbed with showPrimaryNavbar = true', () => {
+            const appEmbed = new AppEmbed(getRootEl(), { showPrimaryNavbar: true });
+            expect(appEmbed['isFullAppEmbedWithVisiblePrimaryNavbar']()).toBe(true);
+        });
+
+        test('should return false for AppEmbed with showPrimaryNavbar = undefined (no longer defaults to true)', () => {
+            const appEmbed = new AppEmbed(getRootEl(), {});
+            expect(appEmbed['isFullAppEmbedWithVisiblePrimaryNavbar']()).toBe(false);
+        });
+
+        test('should return false for AppEmbed with showPrimaryNavbar = false', () => {
+            const appEmbed = new AppEmbed(getRootEl(), { showPrimaryNavbar: false });
+            expect(appEmbed['isFullAppEmbedWithVisiblePrimaryNavbar']()).toBe(false);
+        });
+
+        test('should return false for SearchEmbed (not FullAppEmbed)', () => {
+            const searchEmbed = new SearchEmbed(getRootEl(), {});
+            expect(searchEmbed['isFullAppEmbedWithVisiblePrimaryNavbar']()).toBe(false);
+        });
+
+        test('should return false for LiveboardEmbed (not FullAppEmbed)', () => {
+            const liveboardEmbed = new LiveboardEmbed(getRootEl(), { liveboardId: 'test-id' });
+            expect(liveboardEmbed['isFullAppEmbedWithVisiblePrimaryNavbar']()).toBe(false);
+        });
+    });
+
     describe('when thoughtSpotHost have value and authPromise return error', () => {
         beforeAll(() => {
             init({

package/src/embed/ts-embed.ts

@@ -264,13 +264,32 @@ export class TsEmbed {
         //    - cached auth info would be for wrong org
         //    - info call response changes for each different overrideOrgId
         // 2. disablePreauthCache is explicitly set to true
+        // 3. FullAppEmbed has primary navbar visible since:
+        //    - primary navbar requires fresh auth state for navigation
+        //    - cached auth may not reflect current user permissions
         const isDisabled = (
             this.viewConfig.overrideOrgId !== undefined
             || this.embedConfig.disablePreauthCache === true
+            || this.isFullAppEmbedWithVisiblePrimaryNavbar()
         );
         return !isDisabled;
     }
 
+    /**
+     * Checks if current embed is FullAppEmbed with visible primary navbar
+     * @returns boolean
+     */
+    private isFullAppEmbedWithVisiblePrimaryNavbar(): boolean {
+        const appViewConfig = this.viewConfig as any;
+        
+        // Check if this is a FullAppEmbed (AppEmbed)
+        // showPrimaryNavbar defaults to true if not explicitly set to false
+        return (
+            appViewConfig.embedComponentType === 'AppEmbed' 
+            && appViewConfig.showPrimaryNavbar === true
+        );
+    }
+
     /**
      * fix for ts7.sep.cl
      * will be removed for ts7.oct.cl