@thoughtspot/visual-embed-sdk 1.35.6 → 1.35.8

package/src/embed/ts-embed.spec.ts

@@ -153,11 +153,9 @@ describe('Unit test case for ts embed', () => {
             mockProcessTrigger.mockResolvedValue({ session: 'test' });
             await executeAfterWait(async () => {
                 const payload = { newVizName: 'test' };
-                expect(
-                    await searchEmbed.triggerUIPassThrough(
-                        UIPassthroughEvent.PinAnswerToLiveboard,
-                        payload,
-                    ),
+                await searchEmbed.triggerUIPassThrough(
+                    UIPassthroughEvent.PinAnswerToLiveboard,
+                    payload,
                 );
                 expect(mockProcessTrigger).toHaveBeenCalledWith(
                     getIFrameEl(),
@@ -171,6 +169,47 @@ describe('Unit test case for ts embed', () => {
             });
         });
 
+        test('Host event with empty param', async () => {
+            const liveboardEmbed = new LiveboardEmbed(getRootEl(), {
+                liveboardId: '123',
+                ...defaultViewConfig,
+            });
+            liveboardEmbed.render();
+            mockProcessTrigger.mockResolvedValue({ session: 'test' });
+            await executeAfterWait(async () => {
+                await liveboardEmbed.trigger(
+                    HostEvent.Save,
+                );
+                expect(mockProcessTrigger).toHaveBeenCalledWith(
+                    getIFrameEl(),
+                    HostEvent.Save,
+                    'http://tshost',
+                    {},
+                );
+            });
+        });
+
+        test('Host event with falsy param', async () => {
+            const liveboardEmbed = new LiveboardEmbed(getRootEl(), {
+                liveboardId: '123',
+                ...defaultViewConfig,
+            });
+            liveboardEmbed.render();
+            mockProcessTrigger.mockResolvedValue({ session: 'test' });
+            await executeAfterWait(async () => {
+                await liveboardEmbed.trigger(
+                    HostEvent.Save,
+                    false,
+                );
+                expect(mockProcessTrigger).toHaveBeenCalledWith(
+                    getIFrameEl(),
+                    HostEvent.Save,
+                    'http://tshost',
+                    false,
+                );
+            });
+        });
+
         test('should set proper height, width and min-height to iframe', async () => {
             // we dont have origin specific policies so just checking if
             // policies are ending with ;
@@ -250,19 +289,21 @@ describe('Unit test case for ts embed', () => {
                 const iframe = getIFrameEl();
                 postMessageToParent(iframe.contentWindow, mockEmbedEventPayload, mockPort);
             });
-            expect(mockPort.postMessage).toHaveBeenCalledWith({
-                type: EmbedEvent.APP_INIT,
-                data: {
-                    customisations,
-                    authToken: '',
-                    runtimeFilterParams: null,
-                    runtimeParameterParams: null,
-                    hiddenHomeLeftNavItems: [],
-                    hiddenHomepageModules: [],
-                    hostConfig: undefined,
-                    reorderedHomepageModules: [],
-                    customVariablesForThirdPartyTools,
-                },
+            await executeAfterWait(() => {
+                expect(mockPort.postMessage).toHaveBeenCalledWith({
+                    type: EmbedEvent.APP_INIT,
+                    data: {
+                        customisations,
+                        authToken: '',
+                        runtimeFilterParams: null,
+                        runtimeParameterParams: null,
+                        hiddenHomeLeftNavItems: [],
+                        hiddenHomepageModules: [],
+                        hostConfig: undefined,
+                        reorderedHomepageModules: [],
+                        customVariablesForThirdPartyTools,
+                    },
+                });
             });
         });
 
@@ -283,19 +324,21 @@ describe('Unit test case for ts embed', () => {
                 const iframe = getIFrameEl();
                 postMessageToParent(iframe.contentWindow, mockEmbedEventPayload, mockPort);
             });
-            expect(mockPort.postMessage).toHaveBeenCalledWith({
-                type: EmbedEvent.APP_INIT,
-                data: {
-                    customisations: customisationsView,
-                    authToken: '',
-                    runtimeFilterParams: null,
-                    runtimeParameterParams: null,
-                    hiddenHomeLeftNavItems: [],
-                    hiddenHomepageModules: [],
-                    hostConfig: undefined,
-                    reorderedHomepageModules: [],
-                    customVariablesForThirdPartyTools,
-                },
+            await executeAfterWait(() => {
+                expect(mockPort.postMessage).toHaveBeenCalledWith({
+                    type: EmbedEvent.APP_INIT,
+                    data: {
+                        customisations: customisationsView,
+                        authToken: '',
+                        runtimeFilterParams: null,
+                        runtimeParameterParams: null,
+                        hiddenHomeLeftNavItems: [],
+                        hiddenHomepageModules: [],
+                        hostConfig: undefined,
+                        reorderedHomepageModules: [],
+                        customVariablesForThirdPartyTools,
+                    },
+                });
             });
         });
 
@@ -321,19 +364,21 @@ describe('Unit test case for ts embed', () => {
                 const iframe = getIFrameEl();
                 postMessageToParent(iframe.contentWindow, mockEmbedEventPayload, mockPort);
             });
-            expect(mockPort.postMessage).toHaveBeenCalledWith({
-                type: EmbedEvent.APP_INIT,
-                data: {
-                    customisations,
-                    authToken: '',
-                    hostConfig: undefined,
-                    runtimeFilterParams: null,
-                    runtimeParameterParams: null,
-                    hiddenHomeLeftNavItems: [],
-                    hiddenHomepageModules: [HomepageModule.MyLibrary, HomepageModule.Learning],
-                    reorderedHomepageModules: [],
-                    customVariablesForThirdPartyTools,
-                },
+            await executeAfterWait(() => {
+                expect(mockPort.postMessage).toHaveBeenCalledWith({
+                    type: EmbedEvent.APP_INIT,
+                    data: {
+                        customisations,
+                        authToken: '',
+                        hostConfig: undefined,
+                        runtimeFilterParams: null,
+                        runtimeParameterParams: null,
+                        hiddenHomeLeftNavItems: [],
+                        hiddenHomepageModules: [HomepageModule.MyLibrary, HomepageModule.Learning],
+                        reorderedHomepageModules: [],
+                        customVariablesForThirdPartyTools,
+                    },
+                });
             });
         });
 
@@ -356,20 +401,21 @@ describe('Unit test case for ts embed', () => {
                 const iframe = getIFrameEl();
                 postMessageToParent(iframe.contentWindow, mockEmbedEventPayload, mockPort);
             });
-
-            expect(mockPort.postMessage).toHaveBeenCalledWith({
-                type: EmbedEvent.APP_INIT,
-                data: {
-                    customisations,
-                    authToken: '',
-                    hostConfig: undefined,
-                    runtimeFilterParams: null,
-                    runtimeParameterParams: null,
-                    hiddenHomeLeftNavItems: [],
-                    hiddenHomepageModules: [],
-                    reorderedHomepageModules: [],
-                    customVariablesForThirdPartyTools,
-                },
+            await executeAfterWait(() => {
+                expect(mockPort.postMessage).toHaveBeenCalledWith({
+                    type: EmbedEvent.APP_INIT,
+                    data: {
+                        customisations,
+                        authToken: '',
+                        hostConfig: undefined,
+                        runtimeFilterParams: null,
+                        runtimeParameterParams: null,
+                        hiddenHomeLeftNavItems: [],
+                        hiddenHomepageModules: [],
+                        reorderedHomepageModules: [],
+                        customVariablesForThirdPartyTools,
+                    },
+                });
             });
         });
 
@@ -395,19 +441,22 @@ describe('Unit test case for ts embed', () => {
                 const iframe = getIFrameEl();
                 postMessageToParent(iframe.contentWindow, mockEmbedEventPayload, mockPort);
             });
-            expect(mockPort.postMessage).toHaveBeenCalledWith({
-                type: EmbedEvent.APP_INIT,
-                data: {
-                    customisations,
-                    authToken: '',
-                    hostConfig: undefined,
-                    runtimeFilterParams: null,
-                    runtimeParameterParams: null,
-                    hiddenHomeLeftNavItems: [],
-                    hiddenHomepageModules: [],
-                    reorderedHomepageModules: [HomepageModule.MyLibrary, HomepageModule.Watchlist],
-                    customVariablesForThirdPartyTools,
-                },
+            await executeAfterWait(() => {
+                expect(mockPort.postMessage).toHaveBeenCalledWith({
+                    type: EmbedEvent.APP_INIT,
+                    data: {
+                        customisations,
+                        authToken: '',
+                        hostConfig: undefined,
+                        runtimeFilterParams: null,
+                        runtimeParameterParams: null,
+                        hiddenHomeLeftNavItems: [],
+                        hiddenHomepageModules: [],
+                        reorderedHomepageModules:
+                            [HomepageModule.MyLibrary, HomepageModule.Watchlist],
+                        customVariablesForThirdPartyTools,
+                    },
+                });
             });
         });
 
@@ -436,19 +485,21 @@ describe('Unit test case for ts embed', () => {
                 const iframe = getIFrameEl();
                 postMessageToParent(iframe.contentWindow, mockEmbedEventPayload, mockPort);
             });
-            expect(mockPort.postMessage).toHaveBeenCalledWith({
-                type: EmbedEvent.APP_INIT,
-                data: {
-                    customisations,
-                    authToken: '',
-                    runtimeFilterParams: null,
-                    runtimeParameterParams: 'param1=color&paramVal1=blue',
-                    hiddenHomeLeftNavItems: [],
-                    hiddenHomepageModules: [],
-                    hostConfig: undefined,
-                    reorderedHomepageModules: [],
-                    customVariablesForThirdPartyTools,
-                },
+            await executeAfterWait(() => {
+                expect(mockPort.postMessage).toHaveBeenCalledWith({
+                    type: EmbedEvent.APP_INIT,
+                    data: {
+                        customisations,
+                        authToken: '',
+                        runtimeFilterParams: null,
+                        runtimeParameterParams: 'param1=color&paramVal1=blue',
+                        hiddenHomeLeftNavItems: [],
+                        hiddenHomepageModules: [],
+                        hostConfig: undefined,
+                        reorderedHomepageModules: [],
+                        customVariablesForThirdPartyTools,
+                    },
+                });
             });
         });
 
@@ -478,19 +529,21 @@ describe('Unit test case for ts embed', () => {
                 const iframe = getIFrameEl();
                 postMessageToParent(iframe.contentWindow, mockEmbedEventPayload, mockPort);
             });
-            expect(mockPort.postMessage).toHaveBeenCalledWith({
-                type: EmbedEvent.APP_INIT,
-                data: {
-                    customisations,
-                    authToken: '',
-                    runtimeFilterParams: 'col1=color&op1=EQ&val1=blue',
-                    runtimeParameterParams: null,
-                    hiddenHomeLeftNavItems: [],
-                    hiddenHomepageModules: [],
-                    hostConfig: undefined,
-                    reorderedHomepageModules: [],
-                    customVariablesForThirdPartyTools,
-                },
+            await executeAfterWait(() => {
+                expect(mockPort.postMessage).toHaveBeenCalledWith({
+                    type: EmbedEvent.APP_INIT,
+                    data: {
+                        customisations,
+                        authToken: '',
+                        runtimeFilterParams: 'col1=color&op1=EQ&val1=blue',
+                        runtimeParameterParams: null,
+                        hiddenHomeLeftNavItems: [],
+                        hiddenHomepageModules: [],
+                        hostConfig: undefined,
+                        reorderedHomepageModules: [],
+                        customVariablesForThirdPartyTools,
+                    },
+                });
             });
         });
 
@@ -519,19 +572,21 @@ describe('Unit test case for ts embed', () => {
                 const iframe = getIFrameEl();
                 postMessageToParent(iframe.contentWindow, mockEmbedEventPayload, mockPort);
             });
-            expect(mockPort.postMessage).toHaveBeenCalledWith({
-                type: EmbedEvent.APP_INIT,
-                data: {
-                    customisations,
-                    authToken: '',
-                    runtimeFilterParams: null,
-                    runtimeParameterParams: null,
-                    hiddenHomeLeftNavItems: [],
-                    hiddenHomepageModules: [],
-                    hostConfig: undefined,
-                    reorderedHomepageModules: [],
-                    customVariablesForThirdPartyTools,
-                },
+            await executeAfterWait(() => {
+                expect(mockPort.postMessage).toHaveBeenCalledWith({
+                    type: EmbedEvent.APP_INIT,
+                    data: {
+                        customisations,
+                        authToken: '',
+                        runtimeFilterParams: null,
+                        runtimeParameterParams: null,
+                        hiddenHomeLeftNavItems: [],
+                        hiddenHomepageModules: [],
+                        hostConfig: undefined,
+                        reorderedHomepageModules: [],
+                        customVariablesForThirdPartyTools,
+                    },
+                });
             });
         });
 
@@ -561,19 +616,21 @@ describe('Unit test case for ts embed', () => {
                 const iframe = getIFrameEl();
                 postMessageToParent(iframe.contentWindow, mockEmbedEventPayload, mockPort);
             });
-            expect(mockPort.postMessage).toHaveBeenCalledWith({
-                type: EmbedEvent.APP_INIT,
-                data: {
-                    customisations,
-                    authToken: '',
-                    runtimeFilterParams: null,
-                    runtimeParameterParams: null,
-                    hiddenHomeLeftNavItems: [],
-                    hiddenHomepageModules: [],
-                    hostConfig: undefined,
-                    reorderedHomepageModules: [],
-                    customVariablesForThirdPartyTools,
-                },
+            await executeAfterWait(() => {
+                expect(mockPort.postMessage).toHaveBeenCalledWith({
+                    type: EmbedEvent.APP_INIT,
+                    data: {
+                        customisations,
+                        authToken: '',
+                        runtimeFilterParams: null,
+                        runtimeParameterParams: null,
+                        hiddenHomeLeftNavItems: [],
+                        hiddenHomepageModules: [],
+                        hostConfig: undefined,
+                        reorderedHomepageModules: [],
+                        customVariablesForThirdPartyTools,
+                    },
+                });
             });
         });
 
@@ -599,20 +656,23 @@ describe('Unit test case for ts embed', () => {
                 const iframe = getIFrameEl();
                 postMessageToParent(iframe.contentWindow, mockEmbedEventPayload, mockPort);
             });
-            expect(mockPort.postMessage).toHaveBeenCalledWith({
-                type: EmbedEvent.APP_INIT,
-                data: {
-                    customisations,
-                    authToken: '',
-                    hostConfig: undefined,
-                    runtimeFilterParams: null,
-                    runtimeParameterParams: null,
-                    hiddenHomeLeftNavItems:
-                        [HomeLeftNavItem.Home, HomeLeftNavItem.MonitorSubscription],
-                    hiddenHomepageModules: [],
-                    reorderedHomepageModules: [],
-                    customVariablesForThirdPartyTools,
-                },
+
+            await executeAfterWait(() => {
+                expect(mockPort.postMessage).toHaveBeenCalledWith({
+                    type: EmbedEvent.APP_INIT,
+                    data: {
+                        customisations,
+                        authToken: '',
+                        hostConfig: undefined,
+                        runtimeFilterParams: null,
+                        runtimeParameterParams: null,
+                        hiddenHomeLeftNavItems:
+                      [HomeLeftNavItem.Home, HomeLeftNavItem.MonitorSubscription],
+                        hiddenHomepageModules: [],
+                        reorderedHomepageModules: [],
+                        customVariablesForThirdPartyTools,
+                    },
+                });
             });
         });
 
@@ -796,6 +856,7 @@ describe('Unit test case for ts embed', () => {
                 authType: AuthType.TrustedAuthTokenCookieless,
                 getAuthToken: () => Promise.reject(),
             });
+            jest.spyOn(logger, 'error').mockResolvedValue(true);
         });
 
         afterEach(() => {

package/src/embed/ts-embed.ts

@@ -60,6 +60,7 @@ import {
     FrameParams,
     ContextMenuTriggerOptions,
     RuntimeFilter,
+    DefaultAppInitData,
 } from '../types';
 import { uploadMixpanelEvent, MIXPANEL_EVENT } from '../mixpanel-service';
 import { processEventData, processAuthFailure } from '../utils/processData';
@@ -319,43 +320,62 @@ export class TsEmbed {
         });
     }
 
+    protected async getAuthTokenForCookielessInit() {
+        let authToken = '';
+        if (this.embedConfig.authType !== AuthType.TrustedAuthTokenCookieless) return authToken;
+
+        try {
+            authToken = await getAuthenticationToken(this.embedConfig);
+        } catch (e) {
+            processAuthFailure(e, this.isPreRendered ? this.preRenderWrapper : this.el);
+            throw e;
+        }
+
+        return authToken;
+    }
+
+    protected async getDefaultAppInitData(): Promise<DefaultAppInitData> {
+        const authToken = await this.getAuthTokenForCookielessInit();
+        return {
+            customisations: getCustomisations(this.embedConfig, this.viewConfig),
+            authToken,
+            runtimeFilterParams: this.viewConfig.excludeRuntimeFiltersfromURL
+                ? getRuntimeFilters(this.viewConfig.runtimeFilters)
+                : null,
+            runtimeParameterParams: this.viewConfig.excludeRuntimeParametersfromURL
+                ? getRuntimeParameters(this.viewConfig.runtimeParameters || [])
+                : null,
+            hiddenHomepageModules: this.viewConfig.hiddenHomepageModules || [],
+            reorderedHomepageModules: this.viewConfig.reorderedHomepageModules || [],
+            hostConfig: this.embedConfig.hostConfig,
+            hiddenHomeLeftNavItems: this.viewConfig?.hiddenHomeLeftNavItems
+                ? this.viewConfig?.hiddenHomeLeftNavItems
+                : [],
+            customVariablesForThirdPartyTools:
+            this.embedConfig.customVariablesForThirdPartyTools || {},
+        };
+    }
+
+    protected async getAppInitData() {
+        return this.getDefaultAppInitData();
+    }
+
     /**
      * Send Custom style as part of payload of APP_INIT
      * @param _
      * @param responder
      */
     private appInitCb = async (_: any, responder: any) => {
-        let authToken = '';
-        if (this.embedConfig.authType === AuthType.TrustedAuthTokenCookieless) {
-            try {
-                authToken = await getAuthenticationToken(this.embedConfig);
-            } catch (e) {
-                processAuthFailure(e, this.isPreRendered ? this.preRenderWrapper : this.el);
-                return;
-            }
+        try {
+            const appInitData = await this.getAppInitData();
+            this.isAppInitialized = true;
+            responder({
+                type: EmbedEvent.APP_INIT,
+                data: appInitData,
+            });
+        } catch (e) {
+            logger.error(`AppInit failed, Error : ${e?.message}`);
         }
-        this.isAppInitialized = true;
-        responder({
-            type: EmbedEvent.APP_INIT,
-            data: {
-                customisations: getCustomisations(this.embedConfig, this.viewConfig),
-                authToken,
-                runtimeFilterParams: this.viewConfig.excludeRuntimeFiltersfromURL
-                    ? getRuntimeFilters(this.viewConfig.runtimeFilters)
-                    : null,
-                runtimeParameterParams: this.viewConfig.excludeRuntimeParametersfromURL
-                    ? getRuntimeParameters(this.viewConfig.runtimeParameters || [])
-                    : null,
-                hiddenHomepageModules: this.viewConfig.hiddenHomepageModules || [],
-                reorderedHomepageModules: this.viewConfig.reorderedHomepageModules || [],
-                hostConfig: this.embedConfig.hostConfig,
-                hiddenHomeLeftNavItems: this.viewConfig?.hiddenHomeLeftNavItems
-                    ? this.viewConfig?.hiddenHomeLeftNavItems
-                    : [],
-                customVariablesForThirdPartyTools:
-                    this.embedConfig.customVariablesForThirdPartyTools || {},
-            },
-        });
     };
 
     /**
@@ -1013,7 +1033,7 @@ export class TsEmbed {
      */
     public async trigger<HostEventT extends HostEvent, PayloadT>(
         messageType: HostEventT,
-        data?: TriggerPayload<PayloadT, HostEventT>,
+        data: TriggerPayload<PayloadT, HostEventT> = ({} as any),
     ): Promise<TriggerResponse<PayloadT, HostEventT>> {
         uploadMixpanelEvent(`${MIXPANEL_EVENT.VISUAL_SDK_TRIGGER}-${messageType}`);
 
@@ -1026,7 +1046,7 @@ export class TsEmbed {
             this.handleError('Host event type is undefined');
             return null;
         }
-
+        // send an empty object, this is needed for liveboard default handlers
         return this.hostEventClient.triggerHostEvent(messageType, data);
     }
 

package/src/types.ts

@@ -4624,3 +4624,15 @@ export enum LogLevel {
      */
     TRACE = 'TRACE',
 }
+
+export interface DefaultAppInitData {
+    customisations: CustomisationsInterface;
+    authToken: string;
+    runtimeFilterParams: string | null;
+    runtimeParameterParams: string | null;
+    hiddenHomepageModules: HomepageModule[];
+    reorderedHomepageModules: string[];
+    hostConfig: Record<string, any>;
+    hiddenHomeLeftNavItems: string[];
+    customVariablesForThirdPartyTools: Record<string, any>;
+}