@thoughtspot/visual-embed-sdk 1.35.10 → 1.35.11

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@thoughtspot/visual-embed-sdk",
-    "version": "1.35.10",
+    "version": "1.35.11",
     "description": "ThoughtSpot Embed SDK",
     "module": "lib/src/index.js",
     "main": "dist/tsembed.js",

package/src/embed/app.ts

@@ -257,8 +257,17 @@ export interface AppViewConfig extends Omit<ViewConfig, 'visibleTabs'> {
      */
     enableSearchAssist?: boolean;
     /**
-     * If set to true, the embedded object container dynamically resizes
-     * according to the height of the pages which support fullHeight mode.
+     * If set to true, the Liveboard container dynamically resizes
+     * according to the height of the Liveboard.
+     *
+     * **Note**: Using fullHeight loads all visualizations
+     * on the Liveboard simultaneously, which results in
+     * multiple warehouse queries and potentially a
+     * longer wait for the topmost visualizations to
+     * display on the screen. Setting fullHeight to
+     * `false` fetches visualizations incrementally as
+     * users scroll the page to view the charts and tables.
+     *
      * @version SDK: 1.21.0 | ThoughtSpot: 9.4.0.cl, 9.4.0-sw
      * @example
      * ```js

package/src/embed/hostEventClient/contracts.ts

@@ -4,7 +4,7 @@ export enum UIPassthroughEvent {
   PinAnswerToLiveboard = 'addVizToPinboard',
   SaveAnswer = 'saveAnswer',
   GetDiscoverabilityStatus = 'getDiscoverabilityStatus',
-  GetAvailableUIPassthroughs = 'getAvailableUIPassthroughs',
+  GetAvailableUIPassthroughs = 'getAvailableUiPassthroughs',
   GetAnswerConfig = 'getAnswerPageConfig',
   GetLiveboardConfig = 'getPinboardPageConfig',
 }

package/src/embed/liveboard.spec.ts

@@ -1,5 +1,5 @@
 import { LiveboardViewConfig, LiveboardEmbed } from './liveboard';
-import { init } from '../index';
+import { init, UIPassthroughEvent } from '../index';
 import {
     Action,
     AuthType,
@@ -767,4 +767,25 @@ describe('Liveboard/viz embed tests', () => {
             });
         });
     });
+
+    describe('Host events for liveborad', () => {
+        test('Host event with empty param', async () => {
+            const mockProcessTrigger = jest.spyOn(tsEmbed.TsEmbed.prototype, 'trigger');
+            const liveboardEmbed = new LiveboardEmbed(getRootEl(), {
+                liveboardId: '123',
+                ...defaultViewConfig,
+                vizId: 'testViz',
+            });
+            liveboardEmbed.render();
+            mockProcessTrigger.mockResolvedValue({ session: 'test' });
+            await executeAfterWait(async () => {
+                await liveboardEmbed.trigger(
+                    HostEvent.Save,
+                );
+                expect(mockProcessTrigger).toHaveBeenCalledWith(
+                    HostEvent.Save, { vizId: 'testViz' },
+                );
+            });
+        });
+    });
 });

package/src/embed/liveboard.ts

@@ -37,12 +37,14 @@ export interface LiveboardViewConfig
     /**
      * If set to true, the embedded object container dynamically resizes
      * according to the height of the Liveboard.
+     *
      * **Note**:  Using fullHeight loads all visualizations on the
      * Liveboard simultaneously, which results in multiple warehouse
      * queries and potentially a longer wait for the topmost
      * visualizations to display on the screen.
      * Setting `fullHeight` to `false` fetches visualizations
      * incrementally as users scroll the page to view the charts and tables.
+     *
      * @version SDK: 1.1.0 | ThoughtSpot: ts7.may.cl, 7.2.1
      * @example
      * ```js
@@ -640,7 +642,7 @@ export class LiveboardEmbed extends V1Embed {
      */
     public trigger<HostEventT extends HostEvent>(
         messageType: HostEventT,
-        data?: HostEventRequest<HostEventT>,
+        data: HostEventRequest<HostEventT> = ({} as any),
     ): Promise<HostEventResponse<HostEventT>> {
         const dataWithVizId = data;
         if (messageType === HostEvent.SetActiveTab) {