@thoughtspot/visual-embed-sdk 1.33.0-alpha.2 → 1.33.0

package/src/utils/processData.spec.ts

@@ -1,3 +1,4 @@
+import { disable } from 'mixpanel-browser';
 import * as processDataInstance from './processData';
 import * as answerServiceInstance from './graphql/answerService/answerService';
 import * as auth from '../auth';
@@ -171,4 +172,19 @@ describe('Unit test for process data', () => {
         expect(el.innerHTML).toBe('Hello');
         expect(embedConfigInstance.getEmbedConfig().autoLogin).toBe(false);
     });
+
+    test('process authFailure AuthType=None', () => {
+        const e = { type: EmbedEvent.AuthFailure };
+        jest.spyOn(embedConfigInstance, 'getEmbedConfig').mockReturnValue({
+            loginFailedMessage: 'Hello',
+            authType: AuthType.EmbeddedSSO,
+            disableLoginFailurePage: true,
+        });
+        const el: any = {};
+        expect(processDataInstance.processEventData(e.type, e, '', el)).toEqual({
+            type: e.type,
+        });
+        expect(base.notifyAuthFailure).not.toBeCalled();
+        expect(el.innerHTML).not.toBe('Hello');
+    });
 });

package/src/utils/processData.ts

@@ -78,8 +78,8 @@ function processNoCookieAccess(e: any, containerEl: Element) {
  * @param containerEl
  */
 export function processAuthFailure(e: any, containerEl: Element) {
-    const { loginFailedMessage, authType } = getEmbedConfig();
-    if (authType !== AuthType.None) {
+    const { loginFailedMessage, authType, disableLoginFailurePage } = getEmbedConfig();
+    if (authType !== AuthType.None && !disableLoginFailurePage) {
         // eslint-disable-next-line no-param-reassign
         containerEl.innerHTML = loginFailedMessage;
         notifyAuthFailure(AuthFailureType.OTHER);

package/src/utils/processTrigger.spec.ts

@@ -67,4 +67,23 @@ describe('Unit test for processTrigger', () => {
         expect(messageChannelMock.port1.close).toBeCalled();
         expect(triggerPromise).rejects.toEqual(res.data.error);
     });
+
+    test('should close channel.port1 when timeout exceeds TRIGGER_TIMEOUT', async () => {
+        const messageType = HostEvent.Search;
+        const thoughtSpotHost = 'http://localhost:3000';
+        const data = {};
+        mockMessageChannel();
+
+        const triggerPromise = _processTriggerInstance.processTrigger(
+            iFrame,
+            messageType,
+            thoughtSpotHost,
+            data,
+        );
+
+        jest.advanceTimersByTime(_processTriggerInstance.TRIGGER_TIMEOUT);
+
+        expect(messageChannelMock.port1.close).toBeCalled();
+        await expect(triggerPromise).resolves.toBeInstanceOf(Error);
+    });
 });

package/src/utils/processTrigger.ts

@@ -31,7 +31,7 @@ function postIframeMessage(
     return iFrame.contentWindow.postMessage(message, thoughtSpotHost, [channel?.port2]);
 }
 
-const TRIGGER_TIMEOUT = 30000;
+export const TRIGGER_TIMEOUT = 30000;
 
 /**
  *

package/src/utils.ts

@@ -206,7 +206,6 @@ export const getCustomisations = (
     embedConfig: EmbedConfig,
     viewConfig: ViewConfig,
 ): CustomisationsInterface => {
-    const customCssUrlFromEmbedConfig = embedConfig.customCssUrl;
     const customizationsFromViewConfig = viewConfig.customizations;
     const customizationsFromEmbedConfig = embedConfig.customizations
         || ((embedConfig as any).customisations as CustomisationsInterface);
@@ -221,8 +220,7 @@ export const getCustomisations = (
             },
             customCSSUrl:
                 customizationsFromViewConfig?.style?.customCSSUrl
-                || customizationsFromEmbedConfig?.style?.customCSSUrl
-                || customCssUrlFromEmbedConfig,
+                || customizationsFromEmbedConfig?.style?.customCSSUrl,
         },
         content: {
             ...customizationsFromEmbedConfig?.content,