@thoughtspot/visual-embed-sdk 1.29.0-alpha.fullH → 1.29.0

package/src/embed/liveboard.spec.ts

@@ -110,6 +110,21 @@ describe('Liveboard/viz embed tests', () => {
         });
     });
 
+    test('should set enable2ColumnLayout to true in url', async () => {
+        const liveboardEmbed = new LiveboardEmbed(getRootEl(), {
+            enable2ColumnLayout: true,
+            ...defaultViewConfig,
+            liveboardId,
+        } as LiveboardViewConfig);
+        liveboardEmbed.render();
+        await executeAfterWait(() => {
+            expectUrlMatchesWithParams(
+                getIFrameSrc(),
+                `http://${thoughtSpotHost}/?embedApp=true${defaultParams}&enable2ColumnLayout=true${prefixParams}#/embed/viz/${liveboardId}`,
+            );
+        });
+    });
+
     test('should set visible actions as empty array', async () => {
         const liveboardEmbed = new LiveboardEmbed(getRootEl(), {
             visibleActions: [],
@@ -231,6 +246,28 @@ describe('Liveboard/viz embed tests', () => {
         });
     });
 
+    test('Should not append runtime parameters in URL if excludeRuntimeParametersfromURL is true', async () => {
+        const liveboardEmbed = new LiveboardEmbed(getRootEl(), {
+            ...defaultViewConfig,
+            liveboardId,
+            vizId,
+            runtimeParameters: [
+                {
+                    name: 'sales',
+                    value: 1000,
+                },
+            ],
+            excludeRuntimeParametersfromURL: true,
+        } as LiveboardViewConfig);
+        liveboardEmbed.render();
+        await executeAfterWait(() => {
+            expectUrlMatchesWithParams(
+                getIFrameSrc(),
+                `http://${thoughtSpotHost}/?embedApp=true${defaultParams}${prefixParamsVizEmbed}#/embed/viz/${liveboardId}/${vizId}`,
+            );
+        });
+    });
+
     test('should append runtime filters in URL if excludeRuntimeFiltersfromURL is undefined', async () => {
         const liveboardEmbed = new LiveboardEmbed(getRootEl(), {
             ...defaultViewConfig,
@@ -269,6 +306,63 @@ describe('Liveboard/viz embed tests', () => {
             expect(onSpy).toHaveBeenCalledWith(EmbedEvent.EmbedHeight, expect.anything());
         });
     });
+
+    test('should not call setIFrameHeight if currentPath starts with "/embed/viz/"', () => {
+        const myObject = new LiveboardEmbed(getRootEl(), {
+            ...defaultViewConfig,
+            fullHeight: true,
+            liveboardId,
+        } as LiveboardViewConfig) as any;
+        const spySetIFrameHeight = jest.spyOn(myObject, 'setIFrameHeight');
+
+        myObject.render();
+        myObject.setIframeHeightForNonEmbedLiveboard({
+            data: { currentPath: '/embed/viz/' },
+            type: 'Route',
+        });
+
+        // Assert that setIFrameHeight is not called
+        expect(spySetIFrameHeight).not.toHaveBeenCalled();
+    });
+
+    test('should not call setIFrameHeight if currentPath starts with "/embed/insights/viz/"', () => {
+        const myObject = new LiveboardEmbed(getRootEl(), {
+            ...defaultViewConfig,
+            fullHeight: true,
+            liveboardId,
+        } as LiveboardViewConfig) as any;
+        const spySetIFrameHeight = jest.spyOn(myObject, 'setIFrameHeight');
+
+        myObject.render();
+        myObject.setIframeHeightForNonEmbedLiveboard({
+            data: { currentPath: '/embed/insights/viz/' },
+            type: 'Route',
+        });
+
+        // Assert that setIFrameHeight is not called
+        expect(spySetIFrameHeight).not.toHaveBeenCalled();
+    });
+
+    test('should  call setIFrameHeight if currentPath starts with "/some/other/path/"', () => {
+        const myObject = new LiveboardEmbed(getRootEl(), {
+            ...defaultViewConfig,
+            fullHeight: true,
+            liveboardId,
+        } as LiveboardViewConfig) as any;
+        const spySetIFrameHeight = jest
+            .spyOn(myObject, 'setIFrameHeight')
+            .mockImplementation(jest.fn());
+
+        myObject.render();
+        myObject.setIframeHeightForNonEmbedLiveboard({
+            data: { currentPath: '/some/other/path/' },
+            type: 'Route',
+        });
+
+        // Assert that setIFrameHeight is not called
+        expect(spySetIFrameHeight).toHaveBeenCalled();
+    });
+
     test('Should set the visible vizs', async () => {
         const liveboardEmbed = new LiveboardEmbed(getRootEl(), {
             ...defaultViewConfig,
@@ -467,22 +561,23 @@ describe('Liveboard/viz embed tests', () => {
 
             let resizeObserverCb: any;
             (window as any).ResizeObserver = window.ResizeObserver
-            || jest.fn().mockImplementation((resizeObserverCbParam) => {
-                resizeObserverCb = resizeObserverCbParam;
-                return ({
-                    disconnect: jest.fn(),
-                    observe: jest.fn(),
-                    unobserve: jest.fn(),
+                || jest.fn().mockImplementation((resizeObserverCbParam) => {
+                    resizeObserverCb = resizeObserverCbParam;
+                    return {
+                        disconnect: jest.fn(),
+                        observe: jest.fn(),
+                        unobserve: jest.fn(),
+                    };
                 });
-            });
 
             libEmbed.preRender();
 
             await waitFor(() => !!getIFrameEl());
 
             const ts = '__tsEmbed';
-            expect(document.getElementById(libEmbed.getPreRenderIds().wrapper)[ts])
-                .toEqual(libEmbed);
+            expect(document.getElementById(libEmbed.getPreRenderIds().wrapper)[ts]).toEqual(
+                libEmbed,
+            );
 
             const testLiveboardId = 'testLiveboardId';
             const newLibEmbed = new LiveboardEmbed(getRootEl(), {

package/src/embed/liveboard.ts

@@ -4,28 +4,19 @@
  * Embed a ThoughtSpot Liveboard or visualization
  * https://developers.thoughtspot.com/docs/?pageid=embed-pinboard
  * https://developers.thoughtspot.com/docs/?pageid=embed-a-viz
- *
  * @summary Liveboard & visualization embed
  * @author Ayon Ghosh <ayon.ghosh@thoughtspot.com>
  */
 
 import { ERROR_MESSAGE } from '../errors';
 import {
-    EmbedEvent,
-    MessagePayload,
-    Param,
-    RuntimeFilter,
-    DOMSelector,
-    HostEvent,
-    ViewConfig,
+    DOMSelector, EmbedEvent, HostEvent, MessagePayload, Param, ViewConfig,
 } from '../types';
 import { getQueryParamString, isUndefined } from '../utils';
-import { getAuthPromise } from './base';
 import { V1Embed } from './ts-embed';
 
 /**
  * The configuration for the embedded Liveboard or visualization page view.
- *
  * @group Embed components
  */
 export interface LiveboardViewConfig
@@ -42,9 +33,7 @@ export interface LiveboardViewConfig
      * visualizations to display on the screen.
      * Setting `fullHeight` to `false` fetches visualizations
      * incrementally as users scroll the page to view the charts and tables.
-     *
      * @version SDK: 1.1.0 | ThoughtSpot: ts7.may.cl, 7.2.1
-     *
      * @example
      * ```js
      * const embed = new LiveboardEmbed('#embed', {
@@ -58,7 +47,6 @@ export interface LiveboardViewConfig
      * This is the minimum height(in pixels) for a full-height Liveboard.
      * Setting this height helps resolve issues with empty Liveboards and
      * other screens navigable from a Liveboard.
-     *
      * @version SDK: 1.5.0 | ThoughtSpot: ts7.oct.cl, 7.2.1
      * @default 500
      * @example
@@ -73,7 +61,6 @@ export interface LiveboardViewConfig
     defaultHeight?: number;
     /**
      * @Deprecated If set to true, the context menu in visualizations will be enabled.
-     *
      * @example
      * ```js
      * const embed = new LiveboardEmbed('#tsEmbed', {
@@ -81,14 +68,12 @@ export interface LiveboardViewConfig
      *    enableVizTransformations:true,
      * })
      * ```
-     *
      * @version: SDK: 1.1.0 | ThoughtSpot: 8.1.0.sw
      */
     enableVizTransformations?: boolean;
     /**
      * The Liveboard to display in the embedded view.
      * Use either liveboardId or pinboardId to reference the Liveboard to embed.
-     *
      * @version SDK: 1.3.0 | ThoughtSpot ts7.aug.cl, 7.2.1
      * @example
      * ```js
@@ -100,15 +85,12 @@ export interface LiveboardViewConfig
     liveboardId?: string;
     /**
      * To support backward compatibility
-     *
      * @hidden
      */
     pinboardId?: string;
     /**
      * The visualization within the Liveboard to display.
-     *
      * @version SDK: 1.9.1 | ThoughtSpot: 8.1.0.cl, 8.4.1-sw
-     *
      * @example
      * ```js
      * const embed = new LiveboardEmbed('#embed-container', {
@@ -121,7 +103,6 @@ export interface LiveboardViewConfig
     /**
      * If set to true, all filter chips from a
      * Liveboard page will be read-only (no X buttons)
-     *
      * @version SDK: 1.3.0 | ThoughtSpot ts7.aug.cl, 7.2.1.sw
      * @example
      * ```js
@@ -136,9 +117,7 @@ export interface LiveboardViewConfig
      * Array of visualization IDs which should be visible when the Liveboard
      * renders. This can be changed by triggering the `SetVisibleVizs`
      * event.
-     *
      * @version SDK: 1.9.1 | ThoughtSpot: 8.1.0.cl, 8.4.1-sw
-     *
      * @example
      * ```js
      * const embed = new LiveboardEmbed('#embed-container', {
@@ -152,14 +131,12 @@ export interface LiveboardViewConfig
     visibleVizs?: string[];
     /**
      * To support backward compatibility
-     *
      * @hidden
      */
     preventPinboardFilterRemoval?: boolean;
     /**
      * Render embedded Liveboards and visualizations in the
      * new Liveboard experience mode.
-     *
      * @version SDK: 1.14.0 | ThoughtSpot: 8.6.0.cl, 8.8.1-sw
      * @example
      * ```js
@@ -173,7 +150,6 @@ export interface LiveboardViewConfig
     /**
      * Set a Liveboard tab as an active tab.
      * Specify the tab ID.
-     *
      * @example
      * ```js
      * const embed = new LiveboardEmbed('#tsEmbed', {
@@ -186,9 +162,7 @@ export interface LiveboardViewConfig
     activeTabId?: string;
     /**
      * Show or hide the tab panel of the embedded Liveboard.
-     *
      * @version SDK: 1.25.0 | Thoughtspot: 9.6.0.cl, 9.8.0.sw
-     *
      * @example
      * ```js
      * const embed = new LiveboardEmbed('#embed-container', {
@@ -200,7 +174,6 @@ export interface LiveboardViewConfig
     hideTabPanel?: boolean;
     /**
      * Show or hide the Liveboard header.
-     *
      * @version SDK: 1.26.0 | Thoughtspot: 9.7.0.cl, 9.8.0.sw
      * @default false
      * @example
@@ -216,7 +189,6 @@ export interface LiveboardViewConfig
      * Show or hide the Liveboard title.
      * @default false
      * @version SDK: 1.26.0 | Thoughtspot: 9.7.0.cl, 9.8.0.sw
-     *
      * @example
      * ```js
      * const embed = new LiveboardEmbed('#embed-container', {
@@ -230,7 +202,6 @@ export interface LiveboardViewConfig
      * Show or hide the Liveboard description.
      * @default false
      * @version SDK: 1.26.0 | Thoughtspot: 9.7.0.cl, 9.8.0.sw
-     *
      * @example
      * ```js
      * const embed = new LiveboardEmbed('#embed-container', {
@@ -244,7 +215,6 @@ export interface LiveboardViewConfig
      * Control the position and visibility of
      * the Liveboard header as the users scroll down the
      * embedded Liveboard page.
-     *
      * @example
      * ```js
      * const embed = new LiveboardEmbed('#embed', {
@@ -257,7 +227,6 @@ export interface LiveboardViewConfig
     isLiveboardHeaderSticky?: boolean;
     /**
      * enable or disable ask sage
-     *
      * @default false
      * @version SDK: 1.29.0 | Thoughtspot: 9.12.0.cl
      * @example
@@ -269,13 +238,26 @@ export interface LiveboardViewConfig
      * ```
      */
     enableAskSage?: boolean;
+    /**
+     * This flag is used to enable the 2 column layout in liveboard
+     * @type {boolean}
+     * @default false
+     * @version SDK: 1.32.0 | ThoughtSpot:10.1.0.cl
+     * @example
+     * ```js
+     * const embed = new LiveboardEmbed('#embed-container', {
+     *    ... // other options
+     *    enable2ColumnLayout: true,
+     * })
+     * ```
+     */
+    enable2ColumnLayout?: boolean;
 }
 
 /**
  * Embed a ThoughtSpot Liveboard or visualization. When rendered it already
  * waits for the authentication to complete, so you need not wait for
  * `AuthStatus.SUCCESS`.
- *
  * @example
  * ```js
  * import { .. } from '@thoughtspot/visual-embed-sdk';
@@ -325,6 +307,7 @@ export class LiveboardEmbed extends V1Embed {
             showLiveboardTitle,
             isLiveboardHeaderSticky = true,
             enableAskSage,
+            enable2ColumnLayout,
         } = this.viewConfig;
 
         const preventLiveboardFilterRemoval = this.viewConfig.preventLiveboardFilterRemoval
@@ -352,6 +335,9 @@ export class LiveboardEmbed extends V1Embed {
         if (liveboardV2 !== undefined) {
             params[Param.LiveboardV2Enabled] = liveboardV2;
         }
+        if (enable2ColumnLayout !== undefined) {
+            params[Param.Enable2ColumnLayout] = enable2ColumnLayout;
+        }
         if (hideTabPanel) {
             params[Param.HideTabPanel] = hideTabPanel;
         }
@@ -409,11 +395,10 @@ export class LiveboardEmbed extends V1Embed {
     /**
      * Set the iframe height as per the computed height received
      * from the ThoughtSpot app.
-     *
      * @param data The event payload
      */
     private updateIFrameHeight = (data: MessagePayload) => {
-        this.setIFrameHeight(Math.max(data.data + 16, this.defaultHeight));
+        this.setIFrameHeight(Math.max(data.data, this.defaultHeight));
     };
 
     private embedIframeCenter = (data: MessagePayload, responder: any) => {
@@ -422,9 +407,13 @@ export class LiveboardEmbed extends V1Embed {
     };
 
     private setIframeHeightForNonEmbedLiveboard = (data: MessagePayload) => {
-        if (!data.data.currentPath.startsWith('/embed/viz/')) {
-            this.setIFrameHeight(this.defaultHeight);
+        if (
+            data.data.currentPath.startsWith('/embed/viz/')
+            || data.data.currentPath.startsWith('/embed/insights/viz/')
+        ) {
+            return;
         }
+        this.setIFrameHeight(this.defaultHeight);
     };
 
     private setActiveTab(data: { tabId: string }) {
@@ -459,7 +448,6 @@ export class LiveboardEmbed extends V1Embed {
 
     /**
      * Triggers an event to the embedded app
-     *
      * @param messageType The event type
      * @param data The payload to send with the message
      */
@@ -477,7 +465,6 @@ export class LiveboardEmbed extends V1Embed {
 
     /**
      * Render an embedded ThoughtSpot Liveboard or visualization
-     *
      * @param renderOptions An object specifying the Liveboard ID,
      * visualization ID and the runtime filters.
      */

package/src/embed/sage.spec.ts

@@ -12,7 +12,6 @@ import {
 const defaultConfig: SageViewConfig = {
     disableWorksheetChange: false,
     hideWorksheetSelector: false,
-    hideSearchBarTitle: false,
     hideSageAnswerHeader: false,
     hideAutocompleteSuggestions: false,
     hideSampleQuestions: false,
@@ -36,22 +35,22 @@ describe('Sage  embed tests', () => {
 
     test('should render sage', async () => {
         const sageEmbed = new SageEmbed(getRootEl(), defaultConfig);
-        sageEmbed.render();
+        await sageEmbed.render();
         await executeAfterWait(() => {
             expectUrlMatch(
                 getIFrameSrc(),
-                `http://${thoughtSpotHost}/?embedApp=true&isSageEmbed=true&disableWorksheetChange=false&hideWorksheetSelector=false&hideEurekaSuggestions=false&isProductTour=false&hideSearchBarTitle=false&hideSageAnswerHeader=false&hideAction=%5B"reportError","save","pin","editACopy","saveAsView","updateTSL","editTSL","onDeleteAnswer","share"%5D#/embed/eureka`,
+                `http://${thoughtSpotHost}/?embedApp=true&isSageEmbed=true&disableWorksheetChange=false&hideWorksheetSelector=false&hideEurekaSuggestions=false&isProductTour=false&hideSageAnswerHeader=false&hideAction=%5B%22reportError%22%5D#/embed/eureka`,
             );
         });
     });
 
     test('should render sage with product tour flag set', async () => {
         const sageEmbed = new SageEmbed(getRootEl(), { ...defaultConfig, isProductTour: true });
-        sageEmbed.render();
+        await sageEmbed.render();
         await executeAfterWait(() => {
             expectUrlMatch(
                 getIFrameSrc(),
-                `http://${thoughtSpotHost}/?embedApp=true&isSageEmbed=true&disableWorksheetChange=false&hideWorksheetSelector=false&hideEurekaSuggestions=false&isProductTour=true&hideSearchBarTitle=false&hideSageAnswerHeader=false&hideAction=%5B"reportError","save","pin","editACopy","saveAsView","updateTSL","editTSL","onDeleteAnswer","share"%5D#/embed/eureka`,
+                `http://${thoughtSpotHost}/?embedApp=true&isSageEmbed=true&disableWorksheetChange=false&hideWorksheetSelector=false&hideEurekaSuggestions=false&isProductTour=true&hideSageAnswerHeader=false&hideAction=%5B%22reportError%22%5D#/embed/eureka`,
             );
         });
     });
@@ -61,11 +60,11 @@ describe('Sage  embed tests', () => {
             ...defaultConfig,
             disableWorksheetChange: true,
         });
-        sageEmbed.render();
+        await sageEmbed.render();
         await executeAfterWait(() => {
             expectUrlMatch(
                 getIFrameSrc(),
-                `http://${thoughtSpotHost}/?embedApp=true&isSageEmbed=true&disableWorksheetChange=true&hideWorksheetSelector=false&hideEurekaSuggestions=false&isProductTour=false&hideSearchBarTitle=false&hideSageAnswerHeader=false&hideAction=%5B"reportError","save","pin","editACopy","saveAsView","updateTSL","editTSL","onDeleteAnswer","share"%5D#/embed/eureka`,
+                `http://${thoughtSpotHost}/?embedApp=true&isSageEmbed=true&disableWorksheetChange=true&hideWorksheetSelector=false&hideEurekaSuggestions=false&isProductTour=false&hideSageAnswerHeader=false&hideAction=%5B%22reportError%22%5D#/embed/eureka`,
             );
         });
     });
@@ -75,25 +74,11 @@ describe('Sage  embed tests', () => {
             ...defaultConfig,
             hideWorksheetSelector: true,
         });
-        sageEmbed.render();
+        await sageEmbed.render();
         await executeAfterWait(() => {
             expectUrlMatch(
                 getIFrameSrc(),
-                `http://${thoughtSpotHost}/?embedApp=true&isSageEmbed=true&disableWorksheetChange=false&hideWorksheetSelector=true&hideEurekaSuggestions=false&isProductTour=false&hideSearchBarTitle=false&hideSageAnswerHeader=false&hideAction=%5B"reportError","save","pin","editACopy","saveAsView","updateTSL","editTSL","onDeleteAnswer","share"%5D#/embed/eureka`,
-            );
-        });
-    });
-
-    test('should render sage with hideSearchBarTitle flag', async () => {
-        const sageEmbed = new SageEmbed(getRootEl(), {
-            ...defaultConfig,
-            hideSearchBarTitle: true,
-        });
-        sageEmbed.render();
-        await executeAfterWait(() => {
-            expectUrlMatch(
-                getIFrameSrc(),
-                `http://${thoughtSpotHost}/?embedApp=true&isSageEmbed=true&disableWorksheetChange=false&hideWorksheetSelector=false&hideEurekaSuggestions=false&isProductTour=false&hideSearchBarTitle=true&hideSageAnswerHeader=false&hideAction=%5B"reportError","save","pin","editACopy","saveAsView","updateTSL","editTSL","onDeleteAnswer","share"%5D#/embed/eureka`,
+                `http://${thoughtSpotHost}/?embedApp=true&isSageEmbed=true&disableWorksheetChange=false&hideWorksheetSelector=true&hideEurekaSuggestions=false&isProductTour=false&hideSageAnswerHeader=false&hideAction=%5B%22reportError%22%5D#/embed/eureka`,
             );
         });
     });
@@ -103,11 +88,11 @@ describe('Sage  embed tests', () => {
             ...defaultConfig,
             hideSageAnswerHeader: true,
         });
-        sageEmbed.render();
+        await sageEmbed.render();
         await executeAfterWait(() => {
             expectUrlMatch(
                 getIFrameSrc(),
-                `http://${thoughtSpotHost}/?embedApp=true&isSageEmbed=true&disableWorksheetChange=false&hideWorksheetSelector=false&hideEurekaSuggestions=false&isProductTour=false&hideSearchBarTitle=false&hideSageAnswerHeader=true&hideAction=%5B"reportError","save","pin","editACopy","saveAsView","updateTSL","editTSL","onDeleteAnswer","share"%5D#/embed/eureka`,
+                `http://${thoughtSpotHost}/?embedApp=true&isSageEmbed=true&disableWorksheetChange=false&hideWorksheetSelector=false&hideEurekaSuggestions=false&isProductTour=false&hideSageAnswerHeader=true&hideAction=%5B%22reportError%22%5D#/embed/eureka`,
             );
         });
     });
@@ -117,11 +102,11 @@ describe('Sage  embed tests', () => {
             ...defaultConfig,
             hideAutocompleteSuggestions: true,
         });
-        sageEmbed.render();
+        await sageEmbed.render();
         await executeAfterWait(() => {
             expectUrlMatch(
                 getIFrameSrc(),
-                `http://${thoughtSpotHost}/?embedApp=true&isSageEmbed=true&disableWorksheetChange=false&hideWorksheetSelector=false&hideEurekaSuggestions=true&isProductTour=false&hideSearchBarTitle=false&hideSageAnswerHeader=false&hideAction=%5B"reportError","save","pin","editACopy","saveAsView","updateTSL","editTSL","onDeleteAnswer","share"%5D#/embed/eureka`,
+                `http://${thoughtSpotHost}/?embedApp=true&isSageEmbed=true&disableWorksheetChange=false&hideWorksheetSelector=false&hideEurekaSuggestions=true&isProductTour=false&hideSageAnswerHeader=false&hideAction=%5B%22reportError%22%5D#/embed/eureka`,
             );
         });
     });
@@ -130,11 +115,11 @@ describe('Sage  embed tests', () => {
         const sageEmbed = new SageEmbed(getRootEl(), {
             showObjectSuggestions: true,
         });
-        sageEmbed.render();
+        await sageEmbed.render();
         await executeAfterWait(() => {
             expectUrlMatch(
                 getIFrameSrc(),
-                `http://${thoughtSpotHost}/?embedApp=true&isSageEmbed=true&disableWorksheetChange=false&hideWorksheetSelector=false&hideEurekaSuggestions=false&isProductTour=false&hideSearchBarTitle=false&hideSageAnswerHeader=false&hideAction=%5B"reportError","save","pin","editACopy","saveAsView","updateTSL","editTSL","onDeleteAnswer","share"%5D#/embed/eureka`,
+                `http://${thoughtSpotHost}/?embedApp=true&isSageEmbed=true&disableWorksheetChange=false&hideWorksheetSelector=false&hideEurekaSuggestions=false&isProductTour=false&hideSageAnswerHeader=false&hideAction=%5B%22reportError%22%5D#/embed/eureka`,
             );
         });
     });
@@ -144,11 +129,11 @@ describe('Sage  embed tests', () => {
             ...defaultConfig,
             dataSource: 'worksheet-id',
         });
-        sageEmbed.render();
+        await sageEmbed.render();
         await executeAfterWait(() => {
             expectUrlMatch(
                 getIFrameSrc(),
-                `http://${thoughtSpotHost}/?embedApp=true&isSageEmbed=true&disableWorksheetChange=false&hideWorksheetSelector=false&hideEurekaSuggestions=false&isProductTour=false&hideSearchBarTitle=false&hideSageAnswerHeader=false&hideAction=%5B"reportError","save","pin","editACopy","saveAsView","updateTSL","editTSL","onDeleteAnswer","share"%5D#/embed/eureka?worksheet=worksheet-id`,
+                `http://${thoughtSpotHost}/?embedApp=true&isSageEmbed=true&disableWorksheetChange=false&hideWorksheetSelector=false&hideEurekaSuggestions=false&isProductTour=false&hideSageAnswerHeader=false&hideAction=%5B%22reportError%22%5D#/embed/eureka?worksheet=worksheet-id`,
             );
         });
     });
@@ -161,11 +146,11 @@ describe('Sage  embed tests', () => {
                 searchQuery: 'test query', // also tests for query with spaces
             },
         });
-        sageEmbed.render();
+        await sageEmbed.render();
         await executeAfterWait(() => {
             expectUrlMatch(
                 getIFrameSrc(),
-                `http://${thoughtSpotHost}/?embedApp=true&isSageEmbed=true&disableWorksheetChange=false&hideWorksheetSelector=false&hideEurekaSuggestions=false&isProductTour=false&hideSearchBarTitle=false&hideSageAnswerHeader=false&hideAction=%5B"reportError","save","pin","editACopy","saveAsView","updateTSL","editTSL","onDeleteAnswer","share"%5D#/embed/eureka?worksheet=worksheet-id&query=test%20query`,
+                `http://${thoughtSpotHost}/?embedApp=true&isSageEmbed=true&disableWorksheetChange=false&hideWorksheetSelector=false&hideEurekaSuggestions=false&isProductTour=false&hideSageAnswerHeader=false&hideAction=%5B%22reportError%22%5D#/embed/eureka?worksheet=worksheet-id&query=test%20query`,
             );
         });
     });
@@ -178,11 +163,11 @@ describe('Sage  embed tests', () => {
                 executeSearch: true,
             },
         });
-        sageEmbed.render();
+        await sageEmbed.render();
         await executeAfterWait(() => {
             expectUrlMatch(
                 getIFrameSrc(),
-                `http://${thoughtSpotHost}/?embedApp=true&isSageEmbed=true&disableWorksheetChange=false&hideWorksheetSelector=false&hideEurekaSuggestions=false&hideAction=%5B"reportError","save","pin","editACopy","saveAsView","updateTSL","editTSL","onDeleteAnswer","share"%5D#/embed/eureka?executeSearch=true&query=test-query`,
+                `http://${thoughtSpotHost}/?embedApp=true&isSageEmbed=true&disableWorksheetChange=false&hideWorksheetSelector=false&hideEurekaSuggestions=false&hideAction=%5B%22reportError%22%5D#/embed/eureka?executeSearch=true&query=test-query`,
             );
         });
     });