@thoughtspot/visual-embed-sdk 1.29.0-alpha.7 → 1.29.0-alpha.SCAL-205893-1

package/src/embed/base.ts

@@ -30,6 +30,7 @@ import {
     notifyLogout,
     setAuthEE,
     AuthEventEmitter,
+    postLoginService,
 } from '../auth';
 import { uploadMixpanelEvent, MIXPANEL_EVENT } from '../mixpanel-service';
 import { getEmbedConfig, setEmbedConfig } from './embedConfig';
@@ -75,6 +76,8 @@ export const handleAuth = (): Promise<boolean> => {
             if (!isLoggedIn) {
                 notifyAuthFailure(AuthFailureType.SDK);
             } else {
+                // Post login service is called after successful login.
+                postLoginService();
                 notifyAuthSDKSuccess();
             }
         },

package/src/embed/embed.spec.ts

@@ -9,6 +9,7 @@ import {
     getIFrameEl,
     getRootEl,
 } from '../test/test-utils';
+import * as authInstance from '../auth';
 
 const thoughtSpotHost = 'tshost';
 const defaultViewConfig = {
@@ -24,6 +25,7 @@ beforeAll(() => {
         authType: AuthType.None,
     });
     spyOn(window, 'alert');
+    jest.spyOn(authInstance, 'postLoginService').mockResolvedValue(true);
 });
 
 describe('test view config', () => {

package/src/embed/events.spec.ts

@@ -20,6 +20,7 @@ import {
     postMessageToParent,
 } from '../test/test-utils';
 import { LiveboardViewConfig } from './liveboard';
+import * as authInstance from '../auth';
 
 const thoughtSpotHost = 'tshost';
 const defaultViewConfig = {
@@ -36,6 +37,7 @@ beforeAll(() => {
         authType: AuthType.None,
     });
     spyOn(window, 'alert');
+    jest.spyOn(authInstance, 'postLoginService').mockReturnValue(true);
 });
 
 describe('test communication between host app and ThoughtSpot', () => {

package/src/embed/liveboard.spec.ts

@@ -23,6 +23,7 @@ import {
 } from '../test/test-utils';
 import * as tsEmbed from './ts-embed';
 import * as processTriggerInstance from '../utils/processTrigger';
+import * as auth from '../auth';
 
 const defaultViewConfig = {
     frameParams: {
@@ -43,6 +44,7 @@ beforeAll(() => {
         thoughtSpotHost,
         authType: AuthType.None,
     });
+    jest.spyOn(auth, 'postLoginService').mockImplementation(() => Promise.resolve({}));
 });
 
 describe('Liveboard/viz embed tests', () => {

package/src/embed/pinboard.spec.ts

@@ -13,6 +13,7 @@ import {
     expectUrlMatchesWithParams,
 } from '../test/test-utils';
 import { version } from '../../package.json';
+import * as auth from '../auth';
 
 const defaultViewConfig = {
     frameParams: {
@@ -30,6 +31,7 @@ beforeAll(() => {
         thoughtSpotHost,
         authType: AuthType.None,
     });
+    jest.spyOn(auth, 'postLoginService').mockReturnValue(true);
 });
 
 describe('Pinboard/viz embed tests', () => {

package/src/embed/sage.spec.ts

@@ -9,6 +9,8 @@ import {
     getRootEl,
 } from '../test/test-utils';
 
+import * as authInstance from '../auth';
+
 const defaultConfig: SageViewConfig = {
     disableWorksheetChange: false,
     hideWorksheetSelector: false,
@@ -26,6 +28,7 @@ beforeAll(() => {
         authType: AuthType.None,
     });
     spyOn(window, 'alert');
+    jest.spyOn(authInstance, 'postLoginService').mockResolvedValue(true);
 });
 
 describe('Sage  embed tests', () => {

package/src/embed/search.spec.ts

@@ -36,6 +36,7 @@ beforeAll(() => {
         thoughtSpotHost,
         authType: AuthType.None,
     });
+    jest.spyOn(authInstance, 'postLoginService').mockImplementation(() => Promise.resolve({}));
     spyOn(window, 'alert');
 });
 

package/src/embed/ts-embed-trigger.spec.ts

@@ -8,9 +8,12 @@ import {
     getRootEl,
 } from '../test/test-utils';
 
+import * as authInstance from '../auth';
+
 describe('Trigger', () => {
     beforeEach(() => {
         document.body.innerHTML = getDocumentBody();
+        jest.spyOn(authInstance, 'postLoginService').mockResolvedValue(true);
     });
     test('should trigger the event', async (done) => {
         init({

package/src/embed/ts-embed.spec.ts

@@ -83,6 +83,10 @@ describe('Unit test case for ts embed', () => {
         resetCachedAuthToken();
     });
 
+    beforeAll(() => {
+        jest.spyOn(authInstance, 'postLoginService').mockResolvedValue(true);
+    });
+
     describe('AuthExpire embedEvent in cookieless authentication authType', () => {
         beforeAll(() => {
             jest.spyOn(authInstance, 'doCookielessTokenAuth').mockResolvedValueOnce(true);
@@ -680,6 +684,7 @@ describe('Unit test case for ts embed', () => {
             const mockPort: any = {
                 postMessage: jest.fn(),
             };
+            const loggerSpy = jest.spyOn(logger, 'error').mockResolvedValueOnce(true);
             await executeAfterWait(() => {
                 const iframe = getIFrameEl();
                 postMessageToParent(iframe.contentWindow, mockEmbedEventPayload, mockPort);
@@ -689,6 +694,7 @@ describe('Unit test case for ts embed', () => {
                 expect(baseInstance.notifyAuthFailure).toBeCalledWith(
                     authInstance.AuthFailureType.EXPIRY,
                 );
+                expect(loggerSpy).toHaveBeenCalledTimes(1);
             });
 
             jest.spyOn(authService, 'verifyTokenService').mockClear();
@@ -707,6 +713,7 @@ describe('Unit test case for ts embed', () => {
             const searchEmbed = new SearchEmbed(getRootEl(), { ...defaultViewConfig, preRenderId: 'test' });
             jest.spyOn(baseInstance, 'notifyAuthFailure');
             searchEmbed.preRender();
+            const loggerSpy = jest.spyOn(logger, 'error').mockResolvedValueOnce(true);
             const mockPort: any = {
                 postMessage: jest.fn(),
             };
@@ -720,6 +727,7 @@ describe('Unit test case for ts embed', () => {
                 expect(baseInstance.notifyAuthFailure).toBeCalledWith(
                     authInstance.AuthFailureType.EXPIRY,
                 );
+                expect(loggerSpy).toHaveBeenCalledTimes(1);
             });
 
             jest.spyOn(authService, 'verifyTokenService').mockClear();

package/src/embed/ts-embed.ts

@@ -349,6 +349,7 @@ export class TsEmbed {
                     data: { authToken },
                 });
             } catch (e) {
+                logger.error(`Received invalid token. Error : ${e?.message}`);
                 processAuthFailure(e, this.isPreRendered ? this.preRenderWrapper : this.el);
             }
         } else if (autoLogin) {
@@ -597,6 +598,7 @@ export class TsEmbed {
      * @param url - The URL of the embedded ThoughtSpot app.
      */
     protected async renderIFrame(url: string): Promise<any> {
+        console.log('here 7');
         if (this.isError) {
             return null;
         }
@@ -606,8 +608,10 @@ export class TsEmbed {
         if (url.length > URL_MAX_LENGTH) {
             // warn: The URL is too long
         }
+        console.log('here 8');
 
         return renderInQueue((nextInQueue) => {
+            console.log('here 6');
             const initTimestamp = Date.now();
 
             this.executeCallbacks(EmbedEvent.Init, {
@@ -620,6 +624,7 @@ export class TsEmbed {
             uploadMixpanelEvent(MIXPANEL_EVENT.VISUAL_SDK_RENDER_START);
             return getAuthPromise()
                 ?.then((isLoggedIn: boolean) => {
+                    console.log('here 9', isLoggedIn);
                     if (!isLoggedIn) {
                         this.handleInsertionIntoDOM(this.embedConfig.loginFailedMessage);
                         return;
@@ -644,7 +649,9 @@ export class TsEmbed {
                     this.iFrame.addEventListener('error', () => {
                         nextInQueue();
                     });
+                    console.log('here 10', this.iFrame);
                     this.handleInsertionIntoDOM(this.iFrame);
+                    console.log('here 11', document.body.innerHTML);
                     const prefetchIframe = document.querySelectorAll('.prefetchIframe');
                     if (prefetchIframe.length) {
                         prefetchIframe.forEach((el) => {

package/src/index.ts

@@ -21,8 +21,9 @@ import { PinboardEmbed, LiveboardViewConfig, LiveboardEmbed } from './embed/live
 import { SearchEmbed, SearchViewConfig } from './embed/search';
 import { SearchBarEmbed, SearchBarViewConfig } from './embed/search-bar';
 import {
-    AuthFailureType, AuthStatus, AuthEvent, AuthEventEmitter, getSessionInfo,
+    AuthFailureType, AuthStatus, AuthEvent, AuthEventEmitter,
 } from './auth';
+import { getSessionInfo } from './utils/sessionInfoService';
 import {
     AuthType,
     RuntimeFilter,

package/src/mixpanel-service.spec.ts

@@ -6,6 +6,8 @@ import {
     testResetMixpanel,
 } from './mixpanel-service';
 import { AuthType } from './types';
+import { SessionInfo } from './utils/sessionInfoService';
+import { logger } from './utils/logger';
 
 const config = {
     thoughtSpotHost: 'https://10.87.89.232',
@@ -29,7 +31,7 @@ describe('Unit test for mixpanel', () => {
             mixpanelToken: 'abc123',
             userGUID: '12345',
             isPublicUser: false,
-        };
+        } as SessionInfo;
         initMixpanel(sessionInfo);
         expect(mixpanel.init).toHaveBeenCalledWith(sessionInfo.mixpanelToken, undefined, 'tsEmbed');
         expect(mixpanel.identify).toHaveBeenCalledWith(sessionInfo.userGUID);
@@ -49,7 +51,7 @@ describe('Unit test for mixpanel', () => {
             clusterId: 'newClusterId',
             clusterName: 'newClusterName',
             releaseVersion: 'newReleaseVersion',
-        };
+        } as SessionInfo;
         initMixpanel(sessionInfo);
 
         expect(mixpanel.init).toHaveBeenCalledWith(sessionInfo.mixpanelToken, undefined, 'tsEmbed');
@@ -74,8 +76,15 @@ describe('Unit test for mixpanel', () => {
             mixpanelToken: 'abc123',
             userGUID: '12345',
             isPublicUser: false,
-        };
+        } as SessionInfo;
         initMixpanel(sessionInfo);
         expect(mixpanel.track).toHaveBeenCalledTimes(2);
     });
+
+    test('init mixpanel with no mixpanel token', () => {
+        jest.spyOn(logger, 'error').mockReturnValueOnce(true);
+        initMixpanel({ test: 'dummy' } as any);
+        expect(logger.error).toHaveBeenCalled();
+        expect(mixpanel.register_once).not.toHaveBeenCalled();
+    });
 });

package/src/mixpanel-service.ts

@@ -1,5 +1,6 @@
 import * as mixpanel from 'mixpanel-browser';
 import { logger } from './utils/logger';
+import { SessionInfo } from './utils/sessionInfoService';
 
 export const EndPoints = {
     CONFIG: '/callosum/v1/system/config',
@@ -55,8 +56,9 @@ function emptyQueue() {
  *
  * @param sessionInfo
  */
-export function initMixpanel(sessionInfo: any): void {
+export function initMixpanel(sessionInfo: SessionInfo): void {
     if (!sessionInfo || !sessionInfo.mixpanelToken) {
+        logger.error('Mixpanel token not found in session info');
         return;
     }
     // On a public cluster the user is anonymous, so don't set the identify to

package/src/react/index.spec.tsx

@@ -24,6 +24,9 @@ import {
 
 import { version } from '../../package.json';
 
+import * as auth from '../auth';
+import * as sessionService from '../utils/sessionInfoService';
+
 const thoughtSpotHost = 'localhost';
 
 beforeAll(() => {
@@ -31,6 +34,10 @@ beforeAll(() => {
         thoughtSpotHost,
         authType: AuthType.None,
     });
+    jest.spyOn(auth, 'postLoginService').mockReturnValue(true);
+    jest.spyOn(sessionService, 'getSessionInfo').mockReturnValue({
+        userGUID: 'abcd',
+    });
     spyOn(window, 'alert');
 });
 

package/src/react/index.tsx

@@ -381,4 +381,5 @@ export {
     HomeLeftNavItem,
     HomepageModule,
     LogLevel,
+    getSessionInfo,
 } from '../index';