@thoughtspot/visual-embed-sdk 1.28.3 → 1.28.5-alpha-1

package/src/embed/sage.spec.ts

@@ -12,7 +12,6 @@ import {
 const defaultConfig: SageViewConfig = {
     disableWorksheetChange: false,
     hideWorksheetSelector: false,
-    hideSearchBarTitle: false,
     hideSageAnswerHeader: false,
     hideAutocompleteSuggestions: false,
     hideSampleQuestions: false,
@@ -36,22 +35,22 @@ describe('Sage  embed tests', () => {
 
     test('should render sage', async () => {
         const sageEmbed = new SageEmbed(getRootEl(), defaultConfig);
-        sageEmbed.render();
+        await sageEmbed.render();
         await executeAfterWait(() => {
             expectUrlMatch(
                 getIFrameSrc(),
-                `http://${thoughtSpotHost}/?embedApp=true&isSageEmbed=true&disableWorksheetChange=false&hideWorksheetSelector=false&hideEurekaSuggestions=false&isProductTour=false&hideSearchBarTitle=false&hideSageAnswerHeader=false&hideAction=%5B"reportError","save","pin","editACopy","saveAsView","updateTSL","editTSL","onDeleteAnswer","share"%5D#/embed/eureka`,
+                `http://${thoughtSpotHost}/?embedApp=true&isSageEmbed=true&disableWorksheetChange=false&hideWorksheetSelector=false&hideEurekaSuggestions=false&isProductTour=false&hideSageAnswerHeader=false&hideAction=%5B%22reportError%22%5D#/embed/eureka`,
             );
         });
     });
 
     test('should render sage with product tour flag set', async () => {
         const sageEmbed = new SageEmbed(getRootEl(), { ...defaultConfig, isProductTour: true });
-        sageEmbed.render();
+        await sageEmbed.render();
         await executeAfterWait(() => {
             expectUrlMatch(
                 getIFrameSrc(),
-                `http://${thoughtSpotHost}/?embedApp=true&isSageEmbed=true&disableWorksheetChange=false&hideWorksheetSelector=false&hideEurekaSuggestions=false&isProductTour=true&hideSearchBarTitle=false&hideSageAnswerHeader=false&hideAction=%5B"reportError","save","pin","editACopy","saveAsView","updateTSL","editTSL","onDeleteAnswer","share"%5D#/embed/eureka`,
+                `http://${thoughtSpotHost}/?embedApp=true&isSageEmbed=true&disableWorksheetChange=false&hideWorksheetSelector=false&hideEurekaSuggestions=false&isProductTour=true&hideSageAnswerHeader=false&hideAction=%5B%22reportError%22%5D#/embed/eureka`,
             );
         });
     });
@@ -61,11 +60,11 @@ describe('Sage  embed tests', () => {
             ...defaultConfig,
             disableWorksheetChange: true,
         });
-        sageEmbed.render();
+        await sageEmbed.render();
         await executeAfterWait(() => {
             expectUrlMatch(
                 getIFrameSrc(),
-                `http://${thoughtSpotHost}/?embedApp=true&isSageEmbed=true&disableWorksheetChange=true&hideWorksheetSelector=false&hideEurekaSuggestions=false&isProductTour=false&hideSearchBarTitle=false&hideSageAnswerHeader=false&hideAction=%5B"reportError","save","pin","editACopy","saveAsView","updateTSL","editTSL","onDeleteAnswer","share"%5D#/embed/eureka`,
+                `http://${thoughtSpotHost}/?embedApp=true&isSageEmbed=true&disableWorksheetChange=true&hideWorksheetSelector=false&hideEurekaSuggestions=false&isProductTour=false&hideSageAnswerHeader=false&hideAction=%5B%22reportError%22%5D#/embed/eureka`,
             );
         });
     });
@@ -75,25 +74,11 @@ describe('Sage  embed tests', () => {
             ...defaultConfig,
             hideWorksheetSelector: true,
         });
-        sageEmbed.render();
+        await sageEmbed.render();
         await executeAfterWait(() => {
             expectUrlMatch(
                 getIFrameSrc(),
-                `http://${thoughtSpotHost}/?embedApp=true&isSageEmbed=true&disableWorksheetChange=false&hideWorksheetSelector=true&hideEurekaSuggestions=false&isProductTour=false&hideSearchBarTitle=false&hideSageAnswerHeader=false&hideAction=%5B"reportError","save","pin","editACopy","saveAsView","updateTSL","editTSL","onDeleteAnswer","share"%5D#/embed/eureka`,
-            );
-        });
-    });
-
-    test('should render sage with hideSearchBarTitle flag', async () => {
-        const sageEmbed = new SageEmbed(getRootEl(), {
-            ...defaultConfig,
-            hideSearchBarTitle: true,
-        });
-        sageEmbed.render();
-        await executeAfterWait(() => {
-            expectUrlMatch(
-                getIFrameSrc(),
-                `http://${thoughtSpotHost}/?embedApp=true&isSageEmbed=true&disableWorksheetChange=false&hideWorksheetSelector=false&hideEurekaSuggestions=false&isProductTour=false&hideSearchBarTitle=true&hideSageAnswerHeader=false&hideAction=%5B"reportError","save","pin","editACopy","saveAsView","updateTSL","editTSL","onDeleteAnswer","share"%5D#/embed/eureka`,
+                `http://${thoughtSpotHost}/?embedApp=true&isSageEmbed=true&disableWorksheetChange=false&hideWorksheetSelector=true&hideEurekaSuggestions=false&isProductTour=false&hideSageAnswerHeader=false&hideAction=%5B%22reportError%22%5D#/embed/eureka`,
             );
         });
     });
@@ -103,11 +88,11 @@ describe('Sage  embed tests', () => {
             ...defaultConfig,
             hideSageAnswerHeader: true,
         });
-        sageEmbed.render();
+        await sageEmbed.render();
         await executeAfterWait(() => {
             expectUrlMatch(
                 getIFrameSrc(),
-                `http://${thoughtSpotHost}/?embedApp=true&isSageEmbed=true&disableWorksheetChange=false&hideWorksheetSelector=false&hideEurekaSuggestions=false&isProductTour=false&hideSearchBarTitle=false&hideSageAnswerHeader=true&hideAction=%5B"reportError","save","pin","editACopy","saveAsView","updateTSL","editTSL","onDeleteAnswer","share"%5D#/embed/eureka`,
+                `http://${thoughtSpotHost}/?embedApp=true&isSageEmbed=true&disableWorksheetChange=false&hideWorksheetSelector=false&hideEurekaSuggestions=false&isProductTour=false&hideSageAnswerHeader=true&hideAction=%5B%22reportError%22%5D#/embed/eureka`,
             );
         });
     });
@@ -117,11 +102,11 @@ describe('Sage  embed tests', () => {
             ...defaultConfig,
             hideAutocompleteSuggestions: true,
         });
-        sageEmbed.render();
+        await sageEmbed.render();
         await executeAfterWait(() => {
             expectUrlMatch(
                 getIFrameSrc(),
-                `http://${thoughtSpotHost}/?embedApp=true&isSageEmbed=true&disableWorksheetChange=false&hideWorksheetSelector=false&hideEurekaSuggestions=true&isProductTour=false&hideSearchBarTitle=false&hideSageAnswerHeader=false&hideAction=%5B"reportError","save","pin","editACopy","saveAsView","updateTSL","editTSL","onDeleteAnswer","share"%5D#/embed/eureka`,
+                `http://${thoughtSpotHost}/?embedApp=true&isSageEmbed=true&disableWorksheetChange=false&hideWorksheetSelector=false&hideEurekaSuggestions=true&isProductTour=false&hideSageAnswerHeader=false&hideAction=%5B%22reportError%22%5D#/embed/eureka`,
             );
         });
     });
@@ -130,11 +115,11 @@ describe('Sage  embed tests', () => {
         const sageEmbed = new SageEmbed(getRootEl(), {
             showObjectSuggestions: true,
         });
-        sageEmbed.render();
+        await sageEmbed.render();
         await executeAfterWait(() => {
             expectUrlMatch(
                 getIFrameSrc(),
-                `http://${thoughtSpotHost}/?embedApp=true&isSageEmbed=true&disableWorksheetChange=false&hideWorksheetSelector=false&hideEurekaSuggestions=false&isProductTour=false&hideSearchBarTitle=false&hideSageAnswerHeader=false&hideAction=%5B"reportError","save","pin","editACopy","saveAsView","updateTSL","editTSL","onDeleteAnswer","share"%5D#/embed/eureka`,
+                `http://${thoughtSpotHost}/?embedApp=true&isSageEmbed=true&disableWorksheetChange=false&hideWorksheetSelector=false&hideEurekaSuggestions=false&isProductTour=false&hideSageAnswerHeader=false&hideAction=%5B%22reportError%22%5D#/embed/eureka`,
             );
         });
     });
@@ -144,11 +129,11 @@ describe('Sage  embed tests', () => {
             ...defaultConfig,
             dataSource: 'worksheet-id',
         });
-        sageEmbed.render();
+        await sageEmbed.render();
         await executeAfterWait(() => {
             expectUrlMatch(
                 getIFrameSrc(),
-                `http://${thoughtSpotHost}/?embedApp=true&isSageEmbed=true&disableWorksheetChange=false&hideWorksheetSelector=false&hideEurekaSuggestions=false&isProductTour=false&hideSearchBarTitle=false&hideSageAnswerHeader=false&hideAction=%5B"reportError","save","pin","editACopy","saveAsView","updateTSL","editTSL","onDeleteAnswer","share"%5D#/embed/eureka?worksheet=worksheet-id`,
+                `http://${thoughtSpotHost}/?embedApp=true&isSageEmbed=true&disableWorksheetChange=false&hideWorksheetSelector=false&hideEurekaSuggestions=false&isProductTour=false&hideSageAnswerHeader=false&hideAction=%5B%22reportError%22%5D#/embed/eureka?worksheet=worksheet-id`,
             );
         });
     });
@@ -161,11 +146,11 @@ describe('Sage  embed tests', () => {
                 searchQuery: 'test query', // also tests for query with spaces
             },
         });
-        sageEmbed.render();
+        await sageEmbed.render();
         await executeAfterWait(() => {
             expectUrlMatch(
                 getIFrameSrc(),
-                `http://${thoughtSpotHost}/?embedApp=true&isSageEmbed=true&disableWorksheetChange=false&hideWorksheetSelector=false&hideEurekaSuggestions=false&isProductTour=false&hideSearchBarTitle=false&hideSageAnswerHeader=false&hideAction=%5B"reportError","save","pin","editACopy","saveAsView","updateTSL","editTSL","onDeleteAnswer","share"%5D#/embed/eureka?worksheet=worksheet-id&query=test%20query`,
+                `http://${thoughtSpotHost}/?embedApp=true&isSageEmbed=true&disableWorksheetChange=false&hideWorksheetSelector=false&hideEurekaSuggestions=false&isProductTour=false&hideSageAnswerHeader=false&hideAction=%5B%22reportError%22%5D#/embed/eureka?worksheet=worksheet-id&query=test%20query`,
             );
         });
     });
@@ -178,11 +163,11 @@ describe('Sage  embed tests', () => {
                 executeSearch: true,
             },
         });
-        sageEmbed.render();
+        await sageEmbed.render();
         await executeAfterWait(() => {
             expectUrlMatch(
                 getIFrameSrc(),
-                `http://${thoughtSpotHost}/?embedApp=true&isSageEmbed=true&disableWorksheetChange=false&hideWorksheetSelector=false&hideEurekaSuggestions=false&hideAction=%5B"reportError","save","pin","editACopy","saveAsView","updateTSL","editTSL","onDeleteAnswer","share"%5D#/embed/eureka?executeSearch=true&query=test-query`,
+                `http://${thoughtSpotHost}/?embedApp=true&isSageEmbed=true&disableWorksheetChange=false&hideWorksheetSelector=false&hideEurekaSuggestions=false&hideAction=%5B%22reportError%22%5D#/embed/eureka?executeSearch=true&query=test-query`,
             );
         });
     });

package/src/embed/sage.ts

@@ -7,9 +7,7 @@
  * @author Mourya Balabhadra <mourya.balabhadra@thoughtspot.com>
  */
 
-import {
-    Action, DOMSelector, Param, ViewConfig,
-} from '../types';
+import { DOMSelector, Param, ViewConfig } from '../types';
 import { getQueryParamString } from '../utils';
 import { V1Embed } from './ts-embed';
 
@@ -54,7 +52,7 @@ export interface SageViewConfig
     showObjectResults?: boolean;
     /**
      * flag used by the TS product tour page to show the blue search bar
-     * even after the search is completed. This is different from TSE Sage Embed
+     * even after the search is completed. This is different from Thoughtspot Embedded Sage Embed
      * experience where it mimics closer to the non-embed case.
      * The Sample questions container is collapsed when this value is set after
      * does a search.
@@ -65,8 +63,9 @@ export interface SageViewConfig
     isProductTour?: boolean;
     /**
      * Show or hide the search bar title.
+     * @version SDK: 1.29.0 | Thoughtspot: 9.8.0.cl, 9.8.0.sw
      *
-     * @version SDK: 1.26.0 | Thoughtspot: 9.8.0.cl, 9.8.0.sw
+     * @deprecated Thoughtspot: 9.10.0.cl | search bar doesn't have the title from 9.10.0.cl
      */
     hideSearchBarTitle?: boolean;
     /**
@@ -136,16 +135,6 @@ export interface SageViewConfig
      */
     searchOptions?: SearchOptions;
 }
-export const HiddenActionItemByDefaultForSageEmbed = [
-    Action.Save,
-    Action.Pin,
-    Action.EditACopy,
-    Action.SaveAsView,
-    Action.UpdateTML,
-    Action.EditTML,
-    Action.AnswerDelete,
-    Action.Share,
-];
 /**
  * Embed ThoughtSpot LLM and GPT-based Natural Language Search component.
  *
@@ -178,7 +167,6 @@ export class SageEmbed extends V1Embed {
             showObjectSuggestions,
             hideSampleQuestions,
             isProductTour,
-            hideSearchBarTitle,
             hideSageAnswerHeader,
             hideAutocompleteSuggestions,
         } = this.viewConfig;
@@ -195,12 +183,7 @@ export class SageEmbed extends V1Embed {
         }
         params[Param.HideSampleQuestions] = !!hideSampleQuestions;
         params[Param.IsProductTour] = !!isProductTour;
-        params[Param.HideSearchBarTitle] = !!hideSearchBarTitle;
         params[Param.HideSageAnswerHeader] = !!hideSageAnswerHeader;
-        params[Param.HideActions] = [
-            ...(params[Param.HideActions] ?? []),
-            ...HiddenActionItemByDefaultForSageEmbed,
-        ];
 
         return getQueryParamString(params, true);
     }

package/src/embed/search.spec.ts

@@ -356,12 +356,13 @@ describe('Search embed tests', () => {
         const searchEmbed = new SearchEmbed(getRootEl(), {
             ...defaultViewConfig,
             answerId,
+            collapseSearchBarInitially: true,
         });
         searchEmbed.render();
         await executeAfterWait(() => {
             expectUrlMatchesWithParams(
                 getIFrameSrc(),
-                `http://${thoughtSpotHost}/v2/?${defaultParamsWithHiddenActions}&dataSourceMode=expand&useLastSelectedSources=false${prefixParams}#/embed/saved-answer/${answerId}`,
+                `http://${thoughtSpotHost}/v2/?${defaultParamsWithHiddenActions}&dataSourceMode=expand&useLastSelectedSources=false&collapseSearchBarInitially=true${prefixParams}#/embed/saved-answer/${answerId}`,
             );
         });
     });

package/src/embed/search.ts

@@ -7,20 +7,24 @@
  * @author Ayon Ghosh <ayon.ghosh@thoughtspot.com>
  */
 
-import { getReleaseVersion } from '../auth';
-import { ERROR_MESSAGE } from '../errors';
 import {
-    Action, DOMSelector, DataSourceVisualMode, Param, ViewConfig,
+    DataSourceVisualMode,
+    DOMSelector,
+    Param,
+    Action,
+    ViewConfig,
 } from '../types';
 import {
+    getQueryParamString,
     checkReleaseVersionInBeta,
     getFilterQuery,
-    getQueryParamString,
     getRuntimeParameters,
 } from '../utils';
+import { TsEmbed } from './ts-embed';
+import { ERROR_MESSAGE } from '../errors';
 import { getAuthPromise } from './base';
+import { getReleaseVersion } from '../auth';
 import { getEmbedConfig } from './embedConfig';
-import { TsEmbed } from './ts-embed';
 
 /**
  * Configuration for search options.
@@ -59,6 +63,7 @@ export interface SearchViewConfig
      * but can be expanded manually.
      *
      * @version: SDK: 1.1.0 | ThoughtSpot: 8.1.0.sw
+     *
      * @example
      * ```js
      * const embed = new SearchEmbed('#tsEmbed', {
@@ -72,6 +77,7 @@ export interface SearchViewConfig
      * Show or hide the data sources panel.
      *
      * @version: SDK: 1.2.0 | ThoughtSpot: 9.1.0.sw
+     *
      * @example
      * ```js
      * const embed = new SearchEmbed('#tsEmbed', {
@@ -87,6 +93,7 @@ export interface SearchViewConfig
      * using raw answer data.
      *
      * @version: SDK: 1.2.0 | ThoughtSpot: 9.1.0.sw
+     *
      * @example
      * ```js
      * const embed = new SearchEmbed('#tsEmbed', {
@@ -96,14 +103,11 @@ export interface SearchViewConfig
      * ```
      */
     hideResults?: boolean;
-    /**
-     * If set to true, expands all the data sources panel.
-     */
-    expandAllDataSource?: boolean;
     /**
      * If set to true, the Search Assist feature is enabled.
      *
      * @version SDK: 1.13.0 | ThoughtSpot: 8.5.0.cl, 8.8.1-sw
+     *
      * @example
      * ```js
      * const embed = new SearchEmbed('#tsEmbed', {
@@ -118,6 +122,7 @@ export interface SearchViewConfig
      * format for presenting search data.
      *
      * @version: SDK: 1.1.0 | ThoughtSpot: 8.1.0.sw
+     *
      * @example
      * ```js
      * const embed = new SearchEmbed('#tsEmbed', {
@@ -131,6 +136,7 @@ export interface SearchViewConfig
      * Only a single data source is supported currently.
      *
      * @deprecated Use `dataSource` instead.
+     *
      * @example
      * ```js
      * const embed = new SearchEmbed('#tsEmbed', {
@@ -144,6 +150,7 @@ export interface SearchViewConfig
      * The array of data source GUIDs to set on load.
      *
      * @version: SDK: 1.19.0
+     *
      * @example
      * ```js
      * const embed = new SearchEmbed('#tsEmbed', {
@@ -185,6 +192,7 @@ export interface SearchViewConfig
      * The GUID of a saved answer to load initially.
      *
      * @version: SDK: 1.1.0 | ThoughtSpot: 8.1.0.sw
+     *
      * @example
      * ```js
      * const embed = new SearchEmbed('#tsEmbed', {
@@ -199,6 +207,7 @@ export interface SearchViewConfig
      * The chart/table should still be visible.
      *
      * @version SDK: 1.21.0 | ThoughtSpot: 9.2.0.cl, 9.5.0.sw
+     *
      * @example
      * ```js
      * const embed = new SearchEmbed('#tsEmbed', {
@@ -213,6 +222,7 @@ export interface SearchViewConfig
      *
      * @default false
      * @version SDK: 1.26.0 | Thoughtspot: 9.7.0.cl
+     *
      * @example
      * ```js
      * const embed = new SearchEmbed('#tsEmbed', {
@@ -228,6 +238,28 @@ export interface SearchViewConfig
      * @version: SDK: 1.24.0
      */
     useLastSelectedSources?: boolean;
+    /**
+     * To set the initial state of the search bar in case of saved-answers.
+     *
+     * @default false
+     * @version SDK: 1.32.0 | Thoughtspot: 10.0.0.cl
+     */
+    collapseSearchBarInitially?: boolean;
+    /**
+     * To enable custom column groups in data panel v2
+     *
+     * @version SDK: 1.32.0 | Thoughtspot: 10.0.0.cl
+     * @default false
+     *
+     * @example
+     * ```js
+     * const embed = new SearchEmbed('#tsEmbed', {
+     *   ... // other options
+     *   enableCustomColumnGroups: true,
+     * });
+     * ```
+     */
+    enableCustomColumnGroups?: boolean;
 }
 
 export const HiddenActionItemByDefaultForSearchEmbed = [
@@ -273,7 +305,6 @@ export class SearchEmbed extends TsEmbed {
     protected getEmbedParams(): string {
         const {
             hideResults,
-            expandAllDataSource,
             enableSearchAssist,
             forceTable,
             searchOptions,
@@ -285,6 +316,8 @@ export class SearchEmbed extends TsEmbed {
             dataPanelV2 = false,
             useLastSelectedSources = false,
             runtimeParameters,
+            collapseSearchBarInitially = false,
+            enableCustomColumnGroups = false,
         } = this.viewConfig;
         const queryParams = this.getBaseQueryParams();
 
@@ -331,6 +364,8 @@ export class SearchEmbed extends TsEmbed {
         }
 
         queryParams[Param.searchEmbed] = true;
+        queryParams[Param.CollapseSearchBarInitially] = collapseSearchBarInitially;
+        queryParams[Param.EnableCustomColumnGroups] = enableCustomColumnGroups;
         let query = '';
         const queryParamsString = getQueryParamString(queryParams, true);
         if (queryParamsString) {

package/src/embed/ts-embed.spec.ts

@@ -1,39 +1,39 @@
 /* eslint-disable dot-notation */
-import * as authInstance from '../auth';
 import { resetCachedAuthToken } from '../authToken';
-import * as config from '../config';
 import {
-    AppEmbed,
     AuthType,
+    init,
     EmbedEvent,
-    LiveboardEmbed,
-    LiveboardViewConfig,
-    PinboardEmbed,
     SearchEmbed,
-    init,
+    PinboardEmbed,
+    LiveboardViewConfig,
+    AppEmbed,
+    LiveboardEmbed,
 } from '../index';
-import * as mixpanelInstance from '../mixpanel-service';
-import { MIXPANEL_EVENT } from '../mixpanel-service';
 import {
-    createRootEleForEmbed,
-    defaultParamsForPinboardEmbed,
+    Action, HomeLeftNavItem, RuntimeFilter, RuntimeFilterOp, HomepageModule, HostEvent,
+} from '../types';
+import {
     executeAfterWait,
-    expectUrlMatchesWithParams,
     getDocumentBody,
     getIFrameEl,
     getIFrameSrc,
     getRootEl,
-    mockMessageChannel,
     postMessageToParent,
+    defaultParamsForPinboardEmbed,
     waitFor,
+    expectUrlMatchesWithParams,
+    mockMessageChannel,
+    createRootEleForEmbed,
 } from '../test/test-utils';
-import {
-    Action, HomeLeftNavItem, HomepageModule, RuntimeFilter, RuntimeFilterOp,
-} from '../types';
+import * as config from '../config';
+import * as tsEmbedInstance from './ts-embed';
+import * as mixpanelInstance from '../mixpanel-service';
+import * as authInstance from '../auth';
+import * as baseInstance from './base';
+import { MIXPANEL_EVENT } from '../mixpanel-service';
 import * as authService from '../utils/authService/authService';
 import { logger } from '../utils/logger';
-import * as baseInstance from './base';
-import * as tsEmbedInstance from './ts-embed';
 
 const defaultViewConfig = {
     frameParams: {
@@ -417,10 +417,8 @@ describe('Unit test case for ts embed', () => {
                     authToken: '',
                     hostConfig: undefined,
                     runtimeFilterParams: null,
-                    hiddenHomeLeftNavItems: [
-                        HomeLeftNavItem.Home,
-                        HomeLeftNavItem.MonitorSubscription,
-                    ],
+                    hiddenHomeLeftNavItems:
+                        [HomeLeftNavItem.Home, HomeLeftNavItem.MonitorSubscription],
                     hiddenHomepageModules: [],
                     reorderedHomepageModules: [],
                 },
@@ -649,10 +647,7 @@ describe('Unit test case for ts embed', () => {
                 type: EmbedEvent.APP_INIT,
                 data: {},
             };
-            const searchEmbed = new SearchEmbed(getRootEl(), {
-                ...defaultViewConfig,
-                preRenderId: 'test',
-            });
+            const searchEmbed = new SearchEmbed(getRootEl(), { ...defaultViewConfig, preRenderId: 'test' });
             searchEmbed.preRender();
             const mockPort: any = {
                 postMessage: jest.fn(),
@@ -709,10 +704,7 @@ describe('Unit test case for ts embed', () => {
                 type: EmbedEvent.AuthExpire,
                 data: {},
             };
-            const searchEmbed = new SearchEmbed(getRootEl(), {
-                ...defaultViewConfig,
-                preRenderId: 'test',
-            });
+            const searchEmbed = new SearchEmbed(getRootEl(), { ...defaultViewConfig, preRenderId: 'test' });
             jest.spyOn(baseInstance, 'notifyAuthFailure');
             searchEmbed.preRender();
             const mockPort: any = {
@@ -1216,7 +1208,7 @@ describe('Unit test case for ts embed', () => {
             expectUrlMatchesWithParams(
                 getIFrameSrc(),
                 `http://${thoughtSpotHost}/?embedApp=true&primaryNavHidden=true&profileAndHelpInNavBarHidden=false&${defaultParamsForPinboardEmbed}`
-                    + `&foo=bar&baz=1&bool=true${defaultParamsPost}#/home`,
+                + `&foo=bar&baz=1&bool=true${defaultParamsPost}#/home`,
             );
         });
 
@@ -1232,7 +1224,7 @@ describe('Unit test case for ts embed', () => {
             expectUrlMatchesWithParams(
                 getIFrameSrc(),
                 `http://${thoughtSpotHost}/?embedApp=true&primaryNavHidden=true&profileAndHelpInNavBarHidden=false&${defaultParamsForPinboardEmbed}`
-                    + `&showAlerts=true${defaultParamsPost}#/home`,
+                + `&showAlerts=true${defaultParamsPost}#/home`,
             );
         });
         it('Sets the locale param', async () => {
@@ -1247,7 +1239,7 @@ describe('Unit test case for ts embed', () => {
             expectUrlMatchesWithParams(
                 getIFrameSrc(),
                 `http://${thoughtSpotHost}/?embedApp=true&primaryNavHidden=true&profileAndHelpInNavBarHidden=false&${defaultParamsForPinboardEmbed}`
-                    + `&locale=ja-JP${defaultParamsPost}#/home`,
+                + `&locale=ja-JP${defaultParamsPost}#/home`,
             );
         });
         it('Sets the iconSprite url', async () => {
@@ -1264,7 +1256,7 @@ describe('Unit test case for ts embed', () => {
             expectUrlMatchesWithParams(
                 getIFrameSrc(),
                 `http://${thoughtSpotHost}/?embedApp=true&primaryNavHidden=true&profileAndHelpInNavBarHidden=false&${defaultParamsForPinboardEmbed}`
-                    + `&iconSprite=iconSprite.com${defaultParamsPost}#/home`,
+                + `&iconSprite=iconSprite.com${defaultParamsPost}#/home`,
             );
         });
 
@@ -1331,6 +1323,28 @@ describe('Unit test case for ts embed', () => {
                 done();
             });
         });
+
+        it('Should set the override locale for number/date and currency format', async () => {
+            jest.spyOn(baseInstance, 'getAuthPromise').mockResolvedValue(true);
+            init({
+                thoughtSpotHost: 'tshost',
+                authType: AuthType.None,
+                numberFormatLocale: 'en-US',
+                dateFormatLocale: 'en-IN',
+                currencyFormat: 'USD',
+            });
+            const appEmbed = new AppEmbed(getRootEl(), {
+                frameParams: {
+                    width: '100%',
+                    height: '100%',
+                },
+            });
+            await appEmbed.render();
+            expectUrlMatchesWithParams(
+                getIFrameSrc(),
+                `http://${thoughtSpotHost}/?embedApp=true&primaryNavHidden=true&profileAndHelpInNavBarHidden=false&numberFormatLocale=en-US&dateFormatLocale=en-IN&currencyFormat=USD${defaultParamsPost}#/home`,
+            );
+        });
     });
 
     describe('When destroyed', () => {