@thoughtspot/visual-embed-sdk 1.28.0-preRender → 1.28.0

package/src/utils/authService/authService.spec.ts

@@ -1,11 +1,11 @@
 import {
-    fetchSessionInfoService,
-    fetchAuthTokenService,
+    EndPoints,
+    fetchAuthPostService,
     fetchAuthService,
+    fetchAuthTokenService,
     fetchBasicAuthService,
-    fetchAuthPostService,
+    fetchSessionInfoService,
     verifyTokenService,
-    EndPoints,
 } from '.';
 import { logger } from '../logger';
 
@@ -53,6 +53,18 @@ describe('Unit test for authService', () => {
         );
     });
 
+    test('fetchAuthService without username', async () => {
+        global.fetch = jest.fn(() => Promise.resolve({ success: true, ok: true }));
+        await fetchAuthService(thoughtSpotHost, undefined, authToken);
+        expect(fetch).toBeCalledWith(
+            `${thoughtSpotHost}${EndPoints.TOKEN_LOGIN}?auth_token=${authToken}`,
+            {
+                credentials: 'include',
+                redirect: 'manual',
+            },
+        );
+    });
+
     test('fetchAuthPostService', async () => {
         global.fetch = jest.fn(() => Promise.resolve({ success: true, ok: true }));
         await fetchAuthPostService(thoughtSpotHost, username, authToken);
@@ -68,6 +80,21 @@ describe('Unit test for authService', () => {
         });
     });
 
+    test('fetchAuthPostService without username', async () => {
+        global.fetch = jest.fn(() => Promise.resolve({ success: true, ok: true }));
+        await fetchAuthPostService(thoughtSpotHost, undefined, authToken);
+        expect(fetch).toBeCalledWith(`${thoughtSpotHost}${EndPoints.TOKEN_LOGIN}`, {
+            method: 'POST',
+            credentials: 'include',
+            redirect: 'manual',
+            body: 'auth_token=token',
+            headers: {
+                'content-type': 'application/x-www-form-urlencoded',
+                'x-requested-by': 'ThoughtSpot',
+            },
+        });
+    });
+
     test('fetchBasicAuthService called with manual redirect', async () => {
         global.fetch = jest.fn(() => Promise.resolve({ success: true, ok: true }));
         await fetchBasicAuthService(thoughtSpotHost, username, password);

package/src/utils/authService/authService.ts

@@ -47,7 +47,7 @@ export async function verifyTokenService(
         });
         return res.ok;
     } catch (e) {
-        logger.error(`Token Verification Service failed : ${e.message}`);
+        logger.warn(`Token Verification Service failed : ${e.message}`);
     }
 
     return false;
@@ -72,15 +72,15 @@ export async function fetchAuthService(
     username: string,
     authToken: string,
 ): Promise<any> {
-    return failureLoggedFetch(
-        `${thoughtSpotHost}${EndPoints.TOKEN_LOGIN}?username=${username}&auth_token=${authToken}`,
-        {
-            credentials: 'include',
-            // We do not want to follow the redirect, as it starts giving a CORS
-            // error
-            redirect: 'manual',
-        },
-    );
+    const fetchUrlParams = username
+        ? `username=${username}&auth_token=${authToken}`
+        : `auth_token=${authToken}`;
+    return failureLoggedFetch(`${thoughtSpotHost}${EndPoints.TOKEN_LOGIN}?${fetchUrlParams}`, {
+        credentials: 'include',
+        // We do not want to follow the redirect, as it starts giving a CORS
+        // error
+        redirect: 'manual',
+    });
 }
 
 /**
@@ -94,15 +94,16 @@ export async function fetchAuthPostService(
     username: string,
     authToken: string,
 ): Promise<any> {
+    const bodyPrams = username
+        ? `username=${encodeURIComponent(username)}&auth_token=${encodeURIComponent(authToken)}`
+        : `auth_token=${encodeURIComponent(authToken)}`;
     return failureLoggedFetch(`${thoughtSpotHost}${EndPoints.TOKEN_LOGIN}`, {
         method: 'POST',
         headers: {
             'content-type': 'application/x-www-form-urlencoded',
             'x-requested-by': 'ThoughtSpot',
         },
-        body: `username=${encodeURIComponent(username)}&auth_token=${encodeURIComponent(
-            authToken,
-        )}`,
+        body: bodyPrams,
         credentials: 'include',
         // We do not want to follow the redirect, as it starts giving a CORS
         // error