@thoughtspot/visual-embed-sdk 1.26.6 → 1.26.7

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@thoughtspot/visual-embed-sdk",
-    "version": "1.26.6",
+    "version": "1.26.7",
     "description": "ThoughtSpot Embed SDK",
     "module": "lib/src/index.js",
     "main": "dist/tsembed.js",

package/src/auth.ts

@@ -1,18 +1,19 @@
 import EventEmitter from 'eventemitter3';
+import { getAuthenticationToken, resetCachedAuthToken } from './authToken';
 import { initMixpanel } from './mixpanel-service';
 import {
-    AuthType, DOMSelector, EmbedConfig, EmbedEvent, Param,
+    AuthType, DOMSelector, EmbedConfig, EmbedEvent,
 } from './types';
 import { getDOMNode, getRedirectUrl } from './utils';
 import {
-    fetchSessionInfoService,
+    EndPoints,
+    fetchAuthPostService,
     fetchAuthService,
     fetchBasicAuthService,
     fetchLogoutService,
-    fetchAuthPostService,
-    EndPoints,
+    fetchSessionInfoService,
 } from './utils/authService';
-import { getAuthenticationToken, resetCachedAuthToken } from './authToken';
+import { logger } from './utils/logger';
 
 // eslint-disable-next-line import/no-mutable-exports
 export let loggedInStatus = false;
@@ -72,8 +73,8 @@ export enum AuthStatus {
      */
     LOGOUT = 'LOGOUT',
     /**
-     * Emitted when inPopup: true in the SAMLRedirect flow.
-     * And, we are waiting for popup to be triggered either programatically
+     * Emitted when inPopup is true in the SAMLRedirect flow and the
+     * popup is waiting to be triggered either programmatically
      * or by the trigger button.
      *
      * @version SDK: 1.19.0
@@ -126,8 +127,8 @@ export interface AuthEventEmitter {
  */
 export enum AuthEvent {
     /**
-     * Manually trigger the SSO popup. This is useful with
-     * authStatus: SAMLRedirect/OIDCRedicre and inPopup: true
+     * Manually trigger the SSO popup. This is useful when
+     * authStatus is SAMLRedirect/OIDCRedirect and inPopup is set to true
      */
     TRIGGER_SSO_POPUP = 'TRIGGER_SSO_POPUP',
 }
@@ -154,7 +155,7 @@ export function setAuthEE(eventEmitter: EventEmitter<AuthStatus | AuthEvent>): v
  */
 export function notifyAuthSDKSuccess(): void {
     if (!authEE) {
-        console.error('SDK not initialized');
+        logger.error('SDK not initialized');
         return;
     }
     authEE.emit(AuthStatus.SDK_SUCCESS);
@@ -165,7 +166,7 @@ export function notifyAuthSDKSuccess(): void {
  */
 export function notifyAuthSuccess(): void {
     if (!authEE) {
-        console.error('SDK not initialized');
+        logger.error('SDK not initialized');
         return;
     }
     authEE.emit(AuthStatus.SUCCESS, sessionInfo);
@@ -177,7 +178,7 @@ export function notifyAuthSuccess(): void {
  */
 export function notifyAuthFailure(failureType: AuthFailureType): void {
     if (!authEE) {
-        console.error('SDK not initialized');
+        logger.error('SDK not initialized');
         return;
     }
     authEE.emit(AuthStatus.FAILURE, failureType);
@@ -188,7 +189,7 @@ export function notifyAuthFailure(failureType: AuthFailureType): void {
  */
 export function notifyLogout(): void {
     if (!authEE) {
-        console.error('SDK not initialized');
+        logger.error('SDK not initialized');
         return;
     }
     authEE.emit(AuthStatus.LOGOUT);
@@ -472,6 +473,12 @@ export const logout = async (embedConfig: EmbedConfig): Promise<boolean> => {
     const { thoughtSpotHost } = embedConfig;
     await fetchLogoutService(thoughtSpotHost);
     resetCachedAuthToken();
+    const thoughtspotIframes = document.querySelectorAll("[data-ts-iframe='true']");
+    if (thoughtspotIframes?.length) {
+        thoughtspotIframes.forEach((el) => {
+            el.parentElement.innerHTML = embedConfig.loginFailedMessage;
+        });
+    }
     loggedInStatus = false;
     return loggedInStatus;
 };

package/src/embed/app.spec.ts

@@ -18,6 +18,7 @@ import {
 import { version } from '../../package.json';
 import * as config from '../config';
 import { TsEmbed, V1Embed } from './ts-embed';
+import { logger } from '../utils/logger';
 
 const defaultViewConfig = {
     frameParams: {
@@ -463,15 +464,15 @@ describe('App embed tests', () => {
                 },
             });
             await appEmbed.render();
-            spyOn(console, 'warn');
+            spyOn(logger, 'warn');
             appEmbed.navigateToPage(-1);
-            expect(console.warn).toHaveBeenCalledWith(
+            expect(logger.warn).toHaveBeenCalledWith(
                 'Path can only by a string when triggered without noReload',
             );
         });
 
         test('navigateToPage function use before render', async () => {
-            spyOn(console, 'log');
+            spyOn(logger, 'log');
             const appEmbed = new AppEmbed(getRootEl(), {
                 frameParams: {
                     width: '100%',
@@ -480,7 +481,7 @@ describe('App embed tests', () => {
             });
             appEmbed.navigateToPage(path);
             await appEmbed.render();
-            expect(console.log).toHaveBeenCalledWith(
+            expect(logger.log).toHaveBeenCalledWith(
                 'Please call render before invoking this method',
             );
         });

package/src/embed/app.ts

@@ -9,6 +9,7 @@
  * @author Ayon Ghosh <ayon.ghosh@thoughtspot.com>
  */
 
+import { logger } from '../utils/logger';
 import { getQueryParamString } from '../utils';
 import {
     Param, DOMSelector, HostEvent, ViewConfig, EmbedEvent, MessagePayload,
@@ -57,43 +58,43 @@ export enum Page {
  */
 export interface AppViewConfig extends Omit<ViewConfig, 'visibleTabs'> {
     /**
-     * If true, the main navigation bar within the ThoughtSpot app
+     * If true, the top navigation bar within the ThoughtSpot app
      * is displayed. By default, the navigation bar is hidden.
-     * This flag also control the homepage left nav-bar.
+     * This flag also controls the homepage left navigation bar.
      */
     showPrimaryNavbar?: boolean;
     /**
-     * Flag to control Homepage Left Nav Bar
-     * If showPrimaryNavbar is true, ie navigation bar(Global nav-bar) and Homepage left
-     * nav-bar is visible, this flag will only hide the homepage left nav.
-     * Precedence of showPrimaryNavbar flag > hideHomepageLeftNav flag.
+     * Control the visibility of the left navigation bar on the Homepage.
+     * If showPrimaryNavbar is true, that is, if the Global and Homepage
+     * nav-bars are visible, this flag will only hide the homepage left nav-bar.
+     * The showPrimaryNavbar flag takes precedence over the hideHomepageLeftNav.
      *
      * @default false
      * @version SDK: 1.27.0 | Thoughtspot: 9.8.0.cl
      */
     hideHomepageLeftNav?: boolean;
     /**
-     * If true, help and profile buttons will hide on NavBar. By default,
-     * they are shown.
+     * Control the visibility of the help (?) and profile buttons on the
+     * Global nav-bar. By default, these buttons are visible on the nav-bar.
      */
     disableProfileAndHelp?: boolean;
     /**
-     * If true, application switcher button will hide on NavBar. By default,
-     * they are shown.
+     * Control the visibility of the application switcher button on the nav-bar.
+     * By default, the application switcher is shown.
      */
     hideApplicationSwitcher?: boolean;
     /**
-     * If true, org switcher button will hide on NavBar. By default,
-     * they are shown.
+     * Control the visibility of the Org switcher button on the nav-bar.
+     * By default, the Org switcher button is shown.
      */
     hideOrgSwitcher?: boolean;
     /**
-     * A URL path within the app that is to be embedded.
+     * A URL path to the embedded application page
      * If both path and pageId attributes are defined, the path definition
      * takes precedence. This is the path post the `#/` in the URL of the standalone
      * ThoughtSpot app. Use this to open the embedded view to a specific path.
      *
-     * For eg, if you want the component to open to a specific liveboard
+     * For eg, if you want the component to open to a specific Liveboard
      * you could set the path to `pinboard/<liveboardId>/tab/<tabId>`.
      *
      * @example
@@ -281,8 +282,10 @@ export class AppEmbed extends V1Embed {
      *
      * @param pageId The ID of the page to be embedded.
      */
-    private getIFrameSrc() {
-        const { pageId, path, modularHomeExperience } = this.viewConfig;
+    public getIFrameSrc(): string {
+        const {
+            pageId, path, modularHomeExperience,
+        } = this.viewConfig;
         const pageRoute = this.formatPath(path) || this.getPageRoute(pageId, modularHomeExperience);
         let url = `${this.getRootIframeSrc()}/${pageRoute}`;
 
@@ -300,7 +303,7 @@ export class AppEmbed extends V1Embed {
      */
     protected updateIFrameHeight = (data: MessagePayload) => {
         this.setIFrameHeight(Math.max(data.data, this.iFrame?.scrollHeight));
-    }
+    };
 
     private embedIframeCenter = (data: MessagePayload, responder: any) => {
         const obj = this.getIframeCenter();
@@ -308,9 +311,7 @@ export class AppEmbed extends V1Embed {
     };
 
     private setIframeHeightForNonEmbedLiveboard = (data: MessagePayload) => {
-        const {
-            height: frameHeight, ...restParams
-        } = this.viewConfig.frameParams || {};
+        const { height: frameHeight, ...restParams } = this.viewConfig.frameParams || {};
         if (!data.data.currentPath.startsWith('/pinboard/')) {
             this.setIFrameHeight(frameHeight || this.defaultHeight);
         }
@@ -375,14 +376,14 @@ export class AppEmbed extends V1Embed {
      */
     public navigateToPage(path: string | number, noReload = false): void {
         if (!this.iFrame) {
-            console.log('Please call render before invoking this method');
+            logger.log('Please call render before invoking this method');
             return;
         }
         if (noReload) {
             this.trigger(HostEvent.Navigate, path);
         } else {
             if (typeof path !== 'string') {
-                console.warn('Path can only by a string when triggered without noReload');
+                logger.warn('Path can only by a string when triggered without noReload');
                 return;
             }
             const iframeSrc = this.iFrame.src;

package/src/embed/base.spec.ts

@@ -1,11 +1,11 @@
 /* eslint-disable no-console */
 /* eslint-disable @typescript-eslint/no-shadow */
 import EventEmitter from 'eventemitter3';
-import { EmbedConfig } from '../index';
 import * as auth from '../auth';
-import * as authService from '../utils/authService/authService';
 import * as authTokenService from '../authToken';
 import * as index from '../index';
+import { EmbedConfig } from '../index';
+import * as authService from '../utils/authService/authService';
 import * as base from './base';
 import * as embedConfigInstance from './embedConfig';
 
@@ -13,10 +13,11 @@ import {
     executeAfterWait,
     getAllIframeEl,
     getDocumentBody,
-    getRootEl,
     getIFrameSrc,
+    getRootEl,
 } from '../test/test-utils';
 import * as tokenizedFetchInstance from '../tokenizedFetch';
+import { logger } from '../utils/logger';
 
 const thoughtSpotHost = 'tshost';
 let authEE: EventEmitter;
@@ -412,11 +413,11 @@ describe('Base TS Embed', () => {
 describe('Base without init', () => {
     test('notify should error when called without init', () => {
         base.reset();
-        jest.spyOn(global.console, 'error').mockImplementation(() => undefined);
+        jest.spyOn(logger, 'error').mockImplementation(() => undefined);
         base.notifyAuthSuccess();
         base.notifyAuthFailure(auth.AuthFailureType.SDK);
         base.notifyLogout();
         base.notifyAuthSDKSuccess();
-        expect(global.console.error).toHaveBeenCalledTimes(4);
+        expect(logger.error).toHaveBeenCalledTimes(4);
     });
 });

package/src/embed/base.ts

@@ -10,30 +10,34 @@
  */
 import EventEmitter from 'eventemitter3';
 import uniq from 'lodash/uniq';
-import { tokenizedFetch } from '../tokenizedFetch';
-import { EndPoints } from '../utils/authService/authService';
-import { getThoughtSpotHost } from '../config';
-import { AuthType, EmbedConfig, PrefetchFeatures } from '../types';
 import {
-    authenticate,
-    logout as _logout,
+    AuthEvent,
+    AuthEventEmitter,
     AuthFailureType,
     AuthStatus,
-    AuthEvent,
+    logout as _logout,
+    authenticate,
     notifyAuthFailure,
     notifyAuthSDKSuccess,
     notifyAuthSuccess,
     notifyLogout,
     setAuthEE,
-    AuthEventEmitter,
 } from '../auth';
-import { uploadMixpanelEvent, MIXPANEL_EVENT } from '../mixpanel-service';
+import { getThoughtSpotHost } from '../config';
+import { MIXPANEL_EVENT, uploadMixpanelEvent } from '../mixpanel-service';
+import { tokenizedFetch } from '../tokenizedFetch';
+import {
+    AuthType, EmbedConfig, LogLevel, PrefetchFeatures,
+} from '../types';
+import { EndPoints } from '../utils/authService/authService';
+import { logger, setGlobalLogLevelOverride } from '../utils/logger';
 import { getEmbedConfig, setEmbedConfig } from './embedConfig';
 
 const CONFIG_DEFAULTS: Partial<EmbedConfig> = {
     loginFailedMessage: 'Not logged in',
     authTriggerText: 'Authorize',
     authType: AuthType.None,
+    logLevel: LogLevel.ERROR,
 };
 
 export interface executeTMLInput {
@@ -100,7 +104,7 @@ const hostUrlToFeatureUrl = {
 export const prefetch = (url?: string, prefetchFeatures?: PrefetchFeatures[]): void => {
     if (url === '') {
         // eslint-disable-next-line no-console
-        console.warn('The prefetch method does not have a valid URL');
+        logger.warn('The prefetch method does not have a valid URL');
     } else {
         const features = prefetchFeatures || [PrefetchFeatures.FullApp];
         let hostUrl = url || getEmbedConfig().thoughtSpotHost;
@@ -174,13 +178,16 @@ function backwardCompat(embedConfig: EmbedConfig): EmbedConfig {
  */
 export const init = (embedConfig: EmbedConfig): AuthEventEmitter => {
     sanity(embedConfig);
-    setEmbedConfig(
+    embedConfig = setEmbedConfig(
         backwardCompat({
             ...CONFIG_DEFAULTS,
             ...embedConfig,
             thoughtSpotHost: getThoughtSpotHost(embedConfig),
         }),
     );
+
+    setGlobalLogLevelOverride(embedConfig.logLevel);
+
     const authEE = new EventEmitter<AuthStatus | AuthEvent>();
     setAuthEE(authEE);
     handleAuth();

package/src/embed/embed.spec.ts

@@ -1,3 +1,4 @@
+import { logger } from '../utils/logger';
 import {
     init, AuthType, SearchEmbed, EmbedEvent,
 } from '../index';
@@ -51,7 +52,7 @@ describe('test view config', () => {
     });
 
     test('trying to register event handler after render should throw error', async () => {
-        spyOn(console, 'error');
+        spyOn(logger, 'error');
         const onErrorSpy = jest.fn();
         const searchEmbed = new SearchEmbed(getRootEl(), defaultViewConfig);
         searchEmbed

package/src/embed/embedConfig.ts

@@ -13,6 +13,7 @@ export const getEmbedConfig = (): EmbedConfig => config;
 
 /**
  * Sets the configuration embed was initialized with.
+ * And returns the new configuration.
  *
  * @param newConfig The configuration to set.
  * @version SDK: 1.27.0 | ThoughtSpot: *
@@ -20,4 +21,5 @@ export const getEmbedConfig = (): EmbedConfig => config;
  */
 export const setEmbedConfig = (newConfig: EmbedConfig) => {
     config = newConfig;
+    return newConfig;
 };

package/src/embed/events.spec.ts

@@ -1,3 +1,4 @@
+import { logger } from '../utils/logger';
 import {
     init,
     AuthType,
@@ -155,7 +156,7 @@ describe('test communication between host app and ThoughtSpot', () => {
             pinboardId: 'eca215d4-0d2c-4a55-90e3-d81ef6848ae0',
         } as LiveboardViewConfig);
         liveboardEmbed.render();
-        const spy1 = jest.spyOn(global.console, 'log');
+        const spy1 = jest.spyOn(logger, 'log');
 
         await executeAfterWait(() => {
             const iframe = getIFrameEl();
@@ -173,7 +174,7 @@ describe('test communication between host app and ThoughtSpot', () => {
             pinboardId: 'eca215d4-0d2c-4a55-90e3-d81ef6848ae0',
         } as LiveboardViewConfig);
         pinboardEmbed.render();
-        const spy1 = jest.spyOn(global.console, 'log');
+        const spy1 = jest.spyOn(logger, 'log');
 
         await executeAfterWait(() => {
             const iframe = getIFrameEl();

package/src/embed/liveboard.spec.ts

@@ -294,12 +294,13 @@ describe('Liveboard/viz embed tests', () => {
             liveboardV2: true,
             defaultHeight: 100,
             preventLiveboardFilterRemoval: true,
+            enableAskSage: true,
         } as LiveboardViewConfig);
         liveboardEmbed.render();
         await executeAfterWait(() => {
             expectUrlMatchesWithParams(
                 getIFrameSrc(),
-                `http://${thoughtSpotHost}/?embedApp=true${defaultParams}&preventPinboardFilterRemoval=true&isLiveboardEmbed=true&isPinboardV2Enabled=true#/embed/viz/${liveboardId}/tab/${activeTabId}`,
+                `http://${thoughtSpotHost}/?embedApp=true${defaultParams}&preventPinboardFilterRemoval=true&isLiveboardEmbed=true&isPinboardV2Enabled=true&enableAskSage=true#/embed/viz/${liveboardId}/tab/${activeTabId}`,
             );
         });
     });

package/src/embed/liveboard.ts

@@ -28,7 +28,7 @@ import { V1Embed } from './ts-embed';
  *
  * @group Embed components
  */
-export interface LiveboardViewConfig extends Omit<ViewConfig, 'hiddenHomepageModules' | 'hiddenHomeLeftNavItems'| 'reorderedHomepageModules'> {
+export interface LiveboardViewConfig extends Omit<ViewConfig, 'hiddenHomepageModules' | 'hiddenHomeLeftNavItems' | 'reorderedHomepageModules'> {
     /**
      * If set to true, the embedded object container dynamically resizes
      * according to the height of the Liveboard.
@@ -37,8 +37,8 @@ export interface LiveboardViewConfig extends Omit<ViewConfig, 'hiddenHomepageMod
      */
     fullHeight?: boolean;
     /**
-     * This is the minimum height(in pixels) for a full height Liveboard.
-     * Setting this height helps resolves issues with empty Liveboards and
+     * This is the minimum height(in pixels) for a full-height Liveboard.
+     * Setting this height helps resolve issues with empty Liveboards and
      * other screens navigable from a Liveboard.
      *
      * @version SDK: 1.5.0 | ThoughtSpot: ts7.oct.cl, 7.2.1
@@ -51,7 +51,7 @@ export interface LiveboardViewConfig extends Omit<ViewConfig, 'hiddenHomepageMod
     enableVizTransformations?: boolean;
     /**
      * The Liveboard to display in the embedded view.
-     * Use either of liveboardId or pinboardId to reference the Liveboard to embed.
+     * Use either liveboardId or pinboardId to reference the Liveboard to embed.
      *
      * @version SDK: 1.3.0 | ThoughtSpot ts7.aug.cl, 7.2.1
      */
@@ -70,80 +70,92 @@ export interface LiveboardViewConfig extends Omit<ViewConfig, 'hiddenHomepageMod
      * If set to true, all filter chips from a
      * Liveboard page will be read-only (no X buttons)
      *
-     * @version SDK: 1.3.0 | ThoughtSpot ts7.aug.cl, 7.2.1
+     * @version SDK: 1.3.0 | ThoughtSpot ts7.aug.cl, 7.2.1.sw
      */
     preventLiveboardFilterRemoval?: boolean;
     /**
-     * Array of viz ids which should be visible when the liveboard
-     * first renders. This can be changed by triggering the "SetVisibleVizs"
+     * Array of visualization IDs which should be visible when the Liveboard
+     * renders. This can be changed by triggering the `SetVisibleVizs`
      * event.
      *
      * @version SDK: 1.9.1 | ThoughtSpot: 8.1.0.cl, 8.4.1-sw
      */
     visibleVizs?: string[];
     /**
-     * To support backward compatibilty
+     * To support backward compatibility
      *
      * @hidden
      */
     preventPinboardFilterRemoval?: boolean;
     /**
-     * Render embedded Liveboards and visualizations in the new Liveboard experience mode
+     * Render embedded Liveboards and visualizations in the
+     * new Liveboard experience mode.
      *
      * @version SDK: 1.14.0 | ThoughtSpot: 8.6.0.cl, 8.8.1-sw
      */
     liveboardV2?: boolean;
     /**
-     * Tab ID of the Liveboard that is supposed to be active
+     * Set a Liveboard tab as an active tab.
+     * Specify the tab ID.
      *
      * @version SDK: 1.15.0 | ThoughtSpot: 8.7.0.cl, 8.8.1-sw
      */
     activeTabId?: string;
     /**
-     * Hide tab Panel of embedded LB
+     * Show or hide the tab panel of the embedded Liveboard.
      *
-     * @version SDK: 1.25.0 | Thoughtspot: 9.6.0.cl
+     * @version SDK: 1.25.0 | Thoughtspot: 9.6.0.cl, 9.8.0.sw
      */
     hideTabPanel?: boolean;
     /**
-     * Show or hide Liveboard header
+     * Show or hide the Liveboard header.
      *
-     * @version SDK: 1.26.0 | Thoughtspot: 9.7.0.cl
+     * @version SDK: 1.26.0 | Thoughtspot: 9.7.0.cl, 9.8.0.sw
      * @default false
      */
     hideLiveboardHeader?: boolean;
     /**
-     * Show or hide Liveboard title
+     * Show or hide the Liveboard title.
      *
-     * @version SDK: 1.26.0 | Thoughtspot: 9.7.0.cl
+     * @version SDK: 1.26.0 | Thoughtspot: 9.7.0.cl, 9.8.0.sw
      * @default false
      */
     showLiveboardTitle?: boolean;
     /**
-     * Show or hide Liveboard description
+     * Show or hide the Liveboard description.
      *
-     * @version SDK: 1.26.0 | Thoughtspot: 9.7.0.cl
+     * @version SDK: 1.26.0 | Thoughtspot: 9.7.0.cl, 9.8.0.sw
      * @default false
      */
     showLiveboardDescription?: boolean;
     /**
-     * Boolean for sticky Liveboard header.
+     * Control the position and visibility of
+     * the Liveboard header as the users scroll down the
+     * embedded Liveboard page.
      *
      * @example
      * ```js
      * const embed = new LiveboardEmbed('#embed', {
-     *   ... // other liveboard view config
+     *   ... // other Liveboard view config
      *   isLiveboardHeaderSticky: true,
      * });
      * ```
-     * @version SDK: 1.26.0 | Thoughtspot: 9.7.0.cl
+     * @version SDK: 1.26.0 | Thoughtspot: 9.7.0.cl, 9.8.0.sw
      */
     isLiveboardHeaderSticky?: boolean;
+    /**
+     * enable or disable ask sage
+     *
+     * @version SDK: 1.29.0 | Thoughtspot: 9.12.0.cl
+     * @default true
+     */
+    enableAskSage?: boolean;
 }
 
 /**
- * Embed a ThoughtSpot Liveboard or a Thoughtspot visualization. When rendered it already
- * waits for the authentication to complete, so no need to wait for AuthStatus.SUCCESS.
+ * Embed a ThoughtSpot Liveboard or visualization. When rendered it already
+ * waits for the authentication to complete, so you need not wait for
+ * `AuthStatus.SUCCESS`.
  *
  * @example
  * ```js
@@ -193,6 +205,7 @@ export class LiveboardEmbed extends V1Embed {
             showLiveboardDescription,
             showLiveboardTitle,
             isLiveboardHeaderSticky = true,
+            enableAskSage,
         } = this.viewConfig;
 
         const preventLiveboardFilterRemoval = this.viewConfig.preventLiveboardFilterRemoval
@@ -232,6 +245,9 @@ export class LiveboardEmbed extends V1Embed {
         if (showLiveboardTitle) {
             params[Param.ShowLiveboardTitle] = showLiveboardTitle;
         }
+        if (enableAskSage) {
+            params[Param.enableAskSage] = enableAskSage;
+        }
 
         params[Param.LiveboardHeaderSticky] = isLiveboardHeaderSticky;
 
@@ -255,9 +271,9 @@ export class LiveboardEmbed extends V1Embed {
 
     /**
      * Construct the URL of the embedded ThoughtSpot Liveboard or visualization
-     * to be loaded within the iframe.
+     * to be loaded within the iFrame.
      */
-    private getIFrameSrc() {
+    private getIFrameSrc(): string {
         const { vizId, activeTabId } = this.viewConfig;
         const liveboardId = this.viewConfig.liveboardId ?? this.viewConfig.pinboardId;
 
@@ -306,7 +322,7 @@ export class LiveboardEmbed extends V1Embed {
         if (isUndefined(embedObj)) return;
 
         const showDifferentLib = this.viewConfig.liveboardId
-        && embedObj.viewConfig.liveboardId !== this.viewConfig.liveboardId;
+            && embedObj.viewConfig.liveboardId !== this.viewConfig.liveboardId;
 
         if (showDifferentLib) {
             const libId = this.viewConfig.liveboardId;
@@ -373,4 +389,4 @@ export class LiveboardEmbed extends V1Embed {
 /**
  * @hidden
  */
-export class PinboardEmbed extends LiveboardEmbed {}
+export class PinboardEmbed extends LiveboardEmbed { }

package/src/embed/sage.spec.ts

@@ -158,14 +158,14 @@ describe('Sage  embed tests', () => {
             ...defaultConfig,
             dataSource: 'worksheet-id',
             searchOptions: {
-                searchQuery: 'test-query',
+                searchQuery: 'test query', // also tests for query with spaces
             },
         });
         sageEmbed.render();
         await executeAfterWait(() => {
             expectUrlMatch(
                 getIFrameSrc(),
-                `http://${thoughtSpotHost}/?embedApp=true&isSageEmbed=true&disableWorksheetChange=false&hideWorksheetSelector=false&hideEurekaSuggestions=false&isProductTour=false&hideSearchBarTitle=false&hideSageAnswerHeader=false&hideAction=%5B"reportError","save","pin","editACopy","saveAsView","updateTSL","editTSL","onDeleteAnswer","share"%5D#/embed/eureka?worksheet=worksheet-id&query=test-query`,
+                `http://${thoughtSpotHost}/?embedApp=true&isSageEmbed=true&disableWorksheetChange=false&hideWorksheetSelector=false&hideEurekaSuggestions=false&isProductTour=false&hideSearchBarTitle=false&hideSageAnswerHeader=false&hideAction=%5B"reportError","save","pin","editACopy","saveAsView","updateTSL","editTSL","onDeleteAnswer","share"%5D#/embed/eureka?worksheet=worksheet-id&query=test%20query`,
             );
         });
     });
@@ -182,7 +182,7 @@ describe('Sage  embed tests', () => {
         await executeAfterWait(() => {
             expectUrlMatch(
                 getIFrameSrc(),
-                `http://${thoughtSpotHost}/?embedApp=true&isSageEmbed=true&disableWorksheetChange=false&hideWorksheetSelector=false&hideEurekaSuggestions=false&hideAction=%5B"reportError","save","pin","editACopy","saveAsView","updateTSL","editTSL","onDeleteAnswer","share"%5D#/embed/eureka?query=test-query&executeSearch=true`,
+                `http://${thoughtSpotHost}/?embedApp=true&isSageEmbed=true&disableWorksheetChange=false&hideWorksheetSelector=false&hideEurekaSuggestions=false&hideAction=%5B"reportError","save","pin","editACopy","saveAsView","updateTSL","editTSL","onDeleteAnswer","share"%5D#/embed/eureka?executeSearch=true&query=test-query`,
             );
         });
     });