@thoughtspot/visual-embed-sdk 1.20.0-prerender.2 → 1.20.1

package/src/embed/app.ts

@@ -11,7 +11,11 @@
 
 import { getFilterQuery, getQueryParamString } from '../utils';
 import {
-    Param, RuntimeFilter, DOMSelector, HostEvent, ViewConfig,
+    Param,
+    RuntimeFilter,
+    DOMSelector,
+    HostEvent,
+    ViewConfig,
 } from '../types';
 import { V1Embed } from './ts-embed';
 
@@ -52,7 +56,6 @@ export enum Page {
 
 /**
  * The view configuration for full app embedding.
- *
  * @group Embed components
  */
 export interface AppViewConfig extends ViewConfig {
@@ -78,9 +81,8 @@ export interface AppViewConfig extends ViewConfig {
      */
     pageId?: Page;
     /**
-     * This puts a filter tag on the application. All metadata lists in the
-     * application, such as Liveboards and answers, would be filtered by this
-     * tag.
+     * This puts a filter tag on the application. All metadata lists in the application, such as
+     * Liveboards and answers, would be filtered by this tag.
      */
     tag?: string;
     /**
@@ -90,14 +92,12 @@ export interface AppViewConfig extends ViewConfig {
     /**
      * Render liveboards using the new v2 rendering mode
      * This is a transient flag which is primarily meant for internal use
-     *
      * @version SDK: 1.11.0 | ThoughtSpot: 8.3.0.cl, 8.4.1-sw
      * @hidden
      */
     liveboardV2?: boolean;
     /**
      * If set to true, the Search Assist feature is enabled.
-     *
      * @version SDK: 1.13.0 | ThoughtSpot: 8.5.0.cl, 8.8.1-sw
      */
     enableSearchAssist?: boolean;
@@ -105,7 +105,6 @@ export interface AppViewConfig extends ViewConfig {
 
 /**
  * Embeds full ThoughtSpot experience in a host application.
- *
  * @group Embed components
  */
 export class AppEmbed extends V1Embed {
@@ -120,22 +119,9 @@ export class AppEmbed extends V1Embed {
      * Constructs a map of parameters to be passed on to the
      * embedded Liveboard or visualization.
      */
-    protected getEmbedParams() {
-        const {
-            tag,
-            hideObjects,
-            liveboardV2,
-            showPrimaryNavbar,
-            disableProfileAndHelp,
-            enableSearchAssist,
-        } = this.viewConfig;
-
-        let params = {};
-        params[Param.EmbedApp] = true;
-        params[Param.PrimaryNavHidden] = !showPrimaryNavbar;
-        params[Param.HideProfleAndHelp] = !!disableProfileAndHelp;
-
-        params = this.getBaseQueryParams(params);
+    private getEmbedParams() {
+        const params = this.getBaseQueryParams();
+        const { tag, hideObjects, liveboardV2 } = this.viewConfig;
 
         if (tag) {
             params[Param.Tag] = tag;
@@ -147,10 +133,6 @@ export class AppEmbed extends V1Embed {
             params[Param.LiveboardV2Enabled] = liveboardV2;
         }
 
-        if (enableSearchAssist !== undefined) {
-            params[Param.EnableSearchAssist] = enableSearchAssist;
-        }
-
         const queryParams = getQueryParamString(params, true);
 
         return queryParams;
@@ -158,13 +140,21 @@ export class AppEmbed extends V1Embed {
 
     /**
      * Constructs the URL of the ThoughtSpot app page to be rendered.
-     *
      * @param pageId The ID of the page to be embedded.
      */
-    private getIFrameSrc() {
-        const { pageId, path } = this.viewConfig;
-        const pageRoute = this.formatPath(path) || this.getPageRoute(pageId);
-        let url = `${this.getRootIframeSrc()}/${pageRoute}`;
+    private getIFrameSrc(pageId: string, runtimeFilters: RuntimeFilter[]) {
+        const filterQuery = getFilterQuery(runtimeFilters || []);
+        const queryParams = this.getEmbedParams();
+        const queryString = [filterQuery, queryParams]
+            .filter(Boolean)
+            .join('&');
+        let url = `${this.getV1EmbedBasePath(
+            queryString,
+            this.viewConfig.showPrimaryNavbar,
+            this.viewConfig.disableProfileAndHelp,
+            true,
+            this.viewConfig.enableSearchAssist,
+        )}/${pageId}`;
 
         const tsPostHashParams = this.getThoughtSpotPostUrlParams();
         url = `${url}${tsPostHashParams}`;
@@ -174,7 +164,6 @@ export class AppEmbed extends V1Embed {
 
     /**
      * Gets the ThoughtSpot route of the page for a particular page ID.
-     *
      * @param pageId The identifier for a page in the ThoughtSpot app.
      */
     private getPageRoute(pageId: Page) {
@@ -199,7 +188,6 @@ export class AppEmbed extends V1Embed {
 
     /**
      * Formats the path provided by the user.
-     *
      * @param path The URL path.
      * @returns The URL path that the embedded app understands.
      */
@@ -218,13 +206,10 @@ export class AppEmbed extends V1Embed {
 
     /**
      * Navigate to particular page for app embed. eg:answers/pinboards/home
-     * This is used for embedding answers, pinboards, visualizations and full application
-     * only.
-     *
+     * This is used for embedding answers, pinboards, visualizations and full application only.
      * @param path string | number The string, set to iframe src and navigate to new page
      * eg: appEmbed.navigateToPage('pinboards')
-     * When used with `noReload` (default: true) this can also be a number
-     * like 1/-1 to go forward/back.
+     * When used with `noReload` this can also be a number like 1/-1 to go forward/back.
      * @param noReload boolean Trigger the navigation without reloading the page
      * @version SDK: 1.12.0 | ThoughtSpot: 8.4.0.cl, 8.4.1-sw
      */
@@ -237,28 +222,31 @@ export class AppEmbed extends V1Embed {
             this.trigger(HostEvent.Navigate, path);
         } else {
             if (typeof path !== 'string') {
-                console.warn('Path can only by a string when triggered without noReload');
+                console.warn(
+                    'Path can only by a string when triggered without noReload',
+                );
                 return;
             }
             const iframeSrc = this.iFrame.src;
             const embedPath = '#/embed';
             const currentPath = iframeSrc.includes(embedPath) ? embedPath : '#';
-            this.iFrame.src = `${iframeSrc.split(currentPath)[0]}${currentPath}/${path.replace(
-                /^\/?#?\//,
-                '',
-            )}`;
+            this.iFrame.src = `${
+                iframeSrc.split(currentPath)[0]
+            }${currentPath}/${path.replace(/^\/?#?\//, '')}`;
         }
     }
 
     /**
      * Renders the embedded application pages in the ThoughtSpot app.
-     *
      * @param renderOptions An object containing the page ID
      * to be embedded.
      */
     public render(): AppEmbed {
         super.render();
-        const src = this.getIFrameSrc();
+
+        const { pageId, runtimeFilters, path } = this.viewConfig;
+        const pageRoute = this.formatPath(path) || this.getPageRoute(pageId);
+        const src = this.getIFrameSrc(pageRoute, runtimeFilters);
         this.renderV1Embed(src);
 
         return this;

package/src/embed/base.spec.ts

@@ -62,7 +62,9 @@ describe('Base TS Embed', () => {
             callPrefetch: true,
         });
         expect(getAllIframeEl().length).toBe(1);
-        const prefetchIframe = document.querySelectorAll<HTMLIFrameElement>('.prefetchIframe');
+        const prefetchIframe = document.querySelectorAll<HTMLIFrameElement>(
+            '.prefetchIframe',
+        );
         expect(prefetchIframe.length).toBe(1);
         const firstIframe = <HTMLIFrameElement>prefetchIframe[0];
         expect(firstIframe.src).toBe(url);
@@ -77,7 +79,9 @@ describe('Base TS Embed', () => {
             index.PrefetchFeatures.LiveboardEmbed,
         ]);
         expect(getAllIframeEl().length).toBe(2);
-        const prefetchIframe = document.querySelectorAll<HTMLIFrameElement>('.prefetchIframe');
+        const prefetchIframe = document.querySelectorAll<HTMLIFrameElement>(
+            '.prefetchIframe',
+        );
         expect(prefetchIframe.length).toBe(2);
         const firstIframe = <HTMLIFrameElement>prefetchIframe[0];
         expect(firstIframe.src).toBe(searchUrl);
@@ -89,7 +93,9 @@ describe('Base TS Embed', () => {
         const url = '';
         index.prefetch(url);
         expect(getAllIframeEl().length).toBe(0);
-        const prefetchIframe = document.querySelectorAll<HTMLIFrameElement>('.prefetchIframe');
+        const prefetchIframe = document.querySelectorAll<HTMLIFrameElement>(
+            '.prefetchIframe',
+        );
         expect(prefetchIframe.length).toBe(0);
     });
 

package/src/embed/base.ts

@@ -46,7 +46,10 @@ export const getEmbedConfig = (): EmbedConfig => config;
 export const getAuthPromise = (): Promise<boolean> => authPromise;
 
 export {
-    notifyAuthFailure, notifyAuthSDKSuccess, notifyAuthSuccess, notifyLogout,
+    notifyAuthFailure,
+    notifyAuthSDKSuccess,
+    notifyAuthSuccess,
+    notifyLogout,
 };
 
 /**
@@ -77,16 +80,16 @@ const hostUrlToFeatureUrl = {
 };
 
 /**
- * Prefetches static resources from the specified URL. Web browsers can then cache the
- * prefetched resources and serve them from the user's local disk to provide faster access
- * to your app.
- *
+ * Prefetches static resources from the specified URL. Web browsers can then cache the prefetched resources and serve them from the user's local disk to provide faster access to your app.
  * @param url The URL provided for prefetch
  * @param prefetchFeatures Specify features which needs to be prefetched.
  * @version SDK: 1.4.0 | ThoughtSpot: ts7.sep.cl, 7.2.1
  * @group Global methods
  */
-export const prefetch = (url?: string, prefetchFeatures?: PrefetchFeatures[]): void => {
+export const prefetch = (
+    url?: string,
+    prefetchFeatures?: PrefetchFeatures[],
+): void => {
     if (url === '') {
         // eslint-disable-next-line no-console
         console.warn('The prefetch method does not have a valid URL');
@@ -94,25 +97,21 @@ export const prefetch = (url?: string, prefetchFeatures?: PrefetchFeatures[]): v
         const features = prefetchFeatures || [PrefetchFeatures.FullApp];
         let hostUrl = url || config.thoughtSpotHost;
         hostUrl = hostUrl[hostUrl.length - 1] === '/' ? hostUrl : `${hostUrl}/`;
-        uniq(features.map((feature) => hostUrlToFeatureUrl[feature](hostUrl))).forEach(
-            (prefetchUrl, index) => {
-                const iFrame = document.createElement('iframe');
-                iFrame.src = prefetchUrl;
-                iFrame.style.width = '0';
-                iFrame.style.height = '0';
-                iFrame.style.border = '0';
-                iFrame.classList.add('prefetchIframe');
-                iFrame.classList.add(`prefetchIframeNum-${index}`);
-                document.body.appendChild(iFrame);
-            },
-        );
+        uniq(
+            features.map((feature) => hostUrlToFeatureUrl[feature](hostUrl)),
+        ).forEach((prefetchUrl, index) => {
+            const iFrame = document.createElement('iframe');
+            iFrame.src = prefetchUrl;
+            iFrame.style.width = '0';
+            iFrame.style.height = '0';
+            iFrame.style.border = '0';
+            iFrame.classList.add('prefetchIframe');
+            iFrame.classList.add(`prefetchIframeNum-${index}`);
+            document.body.appendChild(iFrame);
+        });
     }
 };
 
-/**
- *
- * @param embedConfig
- */
 function sanity(embedConfig: EmbedConfig) {
     if (embedConfig.thoughtSpotHost === undefined) {
         throw new Error('ThoughtSpot host not provided');
@@ -122,19 +121,23 @@ function sanity(embedConfig: EmbedConfig) {
             throw new Error('Username not provided with Trusted auth');
         }
 
-        if (!embedConfig.authEndpoint && typeof embedConfig.getAuthToken !== 'function') {
-            throw new Error('Trusted auth should provide either authEndpoint or getAuthToken');
+        if (
+            !embedConfig.authEndpoint &&
+            typeof embedConfig.getAuthToken !== 'function'
+        ) {
+            throw new Error(
+                'Trusted auth should provide either authEndpoint or getAuthToken',
+            );
         }
     }
 }
 
-/**
- *
- * @param embedConfig
- */
 function backwardCompat(embedConfig: EmbedConfig): EmbedConfig {
     const newConfig = { ...embedConfig };
-    if (embedConfig.noRedirect !== undefined && embedConfig.inPopup === undefined) {
+    if (
+        embedConfig.noRedirect !== undefined &&
+        embedConfig.inPopup === undefined
+    ) {
         newConfig.inPopup = embedConfig.noRedirect;
     }
     return newConfig;
@@ -143,9 +146,9 @@ function backwardCompat(embedConfig: EmbedConfig): EmbedConfig {
 /**
  * Initializes the Visual Embed SDK globally and perform
  * authentication if applicable.
- *
  * @param embedConfig The configuration object containing ThoughtSpot host,
  * authentication mechanism and so on.
+ *
  * @example
  * ```js
  *   const authStatus = init({
@@ -154,8 +157,8 @@ function backwardCompat(embedConfig: EmbedConfig): EmbedConfig {
  *   });
  *   authStatus.on(AuthStatus.FAILURE, (reason) => { // do something here });
  * ```
- * @returns {@link AuthEventEmitter} event emitter which emits events on authentication success,
- *      failure and logout. See {@link AuthStatus}
+ *
+ * @returns {@link AuthEventEmitter} event emitter which emits events on authentication success, failure and logout. See {@link AuthStatus}
  * @version SDK: 1.0.0 | ThoughtSpot ts7.april.cl, 7.2.1
  * @group Authentication / Init
  */
@@ -174,12 +177,17 @@ export const init = (embedConfig: EmbedConfig): AuthEventEmitter => {
     uploadMixpanelEvent(MIXPANEL_EVENT.VISUAL_SDK_CALLED_INIT, {
         authType: config.authType,
         host: config.thoughtSpotHost,
-        usedCustomizationSheet: embedConfig.customizations?.style?.customCSSUrl != null,
-        usedCustomizationVariables: embedConfig.customizations?.style?.customCSS?.variables != null,
+        usedCustomizationSheet:
+            embedConfig.customizations?.style?.customCSSUrl != null,
+        usedCustomizationVariables:
+            embedConfig.customizations?.style?.customCSS?.variables != null,
         usedCustomizationRules:
-            embedConfig.customizations?.style?.customCSS?.rules_UNSTABLE != null,
-        usedCustomizationStrings: !!embedConfig.customizations?.content?.strings,
-        usedCustomizationIconSprite: !!embedConfig.customizations?.iconSpriteUrl,
+            embedConfig.customizations?.style?.customCSS?.rules_UNSTABLE !=
+            null,
+        usedCustomizationStrings: !!embedConfig.customizations?.content
+            ?.strings,
+        usedCustomizationIconSprite: !!embedConfig.customizations
+            ?.iconSpriteUrl,
     });
 
     if (config.callPrefetch) {
@@ -188,19 +196,16 @@ export const init = (embedConfig: EmbedConfig): AuthEventEmitter => {
     return authEE as AuthEventEmitter;
 };
 
-/**
- *
- */
 export function disableAutoLogin(): void {
     config.autoLogin = false;
 }
 
 /**
- * Logs out from ThoughtSpot. This also sets the autoLogin flag to false, to
- * prevent the SDK from automatically logging in again.
+ * Logs out from ThoughtSpot. This also sets the autoLogin flag to false, to prevent
+ * the SDK from automatically logging in again.
  *
- * You can call the `init` method again to re login, if autoLogin is set to
- * true in this second call it will be honored.
+ * You can call the `init` method again to re login, if autoLogin is set to true in this
+ * second call it will be honored.
  *
  * @param doNotDisableAutoLogin This flag when passed will not disable autoLogin
  * @returns Promise which resolves when logout completes.
@@ -220,12 +225,12 @@ export const logout = (doNotDisableAutoLogin = false): Promise<boolean> => {
 let renderQueue: Promise<any> = Promise.resolve();
 
 /**
- * Renders functions in a queue, resolves to next function only after the callback next
- * is called
- *
+ * Renders functions in a queue, resolves to next function only after the callback next is called
  * @param fn The function being registered
  */
-export const renderInQueue = (fn: (next?: (val?: any) => void) => Promise<any>): Promise<any> => {
+export const renderInQueue = (
+    fn: (next?: (val?: any) => void) => Promise<any>,
+): Promise<any> => {
     const { queueMultiRenders = false } = config;
     if (queueMultiRenders) {
         renderQueue = renderQueue.then(() => new Promise((res) => fn(res)));
@@ -236,9 +241,6 @@ export const renderInQueue = (fn: (next?: (val?: any) => void) => Promise<any>):
 };
 
 // For testing purposes only
-/**
- *
- */
 export function reset(): void {
     config = {} as any;
     setAuthEE(null);

package/src/embed/embed.spec.ts

@@ -1,6 +1,4 @@
-import {
-    init, AuthType, SearchEmbed, EmbedEvent,
-} from '../index';
+import { init, AuthType, SearchEmbed, EmbedEvent } from '../index';
 import {
     EVENT_WAIT_TIME,
     executeAfterWait,
@@ -61,7 +59,8 @@ describe('test view config', () => {
         await executeAfterWait(() => {
             expect(onErrorSpy).toHaveBeenCalledWith(
                 {
-                    error: 'Please register event handlers before calling render',
+                    error:
+                        'Please register event handlers before calling render',
                 },
                 expect.any(Function),
             );
@@ -85,7 +84,9 @@ describe('Custom CSS Url', () => {
         embed.render();
         executeAfterWait(() => {
             const iframe = getIFrameEl();
-            expect(iframe.src.includes('customCssUrl=bla.com/foo.css')).toBe(true);
+            expect(iframe.src.includes('customCssUrl=bla.com/foo.css')).toBe(
+                true,
+            );
             done();
         });
     });

package/src/embed/liveboard.spec.ts

@@ -15,10 +15,6 @@ import {
     getRootEl,
     defaultParams,
     defaultParamsWithoutHiddenActions,
-    expectUrlMatchesWithParams,
-    postMessageToParent,
-    getIFrameEl,
-    mockMessageChannel,
 } from '../test/test-utils';
 import { version } from '../../package.json';
 import * as processTriggerInstance from '../utils/processTrigger';
@@ -55,8 +51,7 @@ describe('Liveboard/viz embed tests', () => {
         } as LiveboardViewConfig);
         liveboardEmbed.render();
         await executeAfterWait(() => {
-            expectUrlMatchesWithParams(
-                getIFrameSrc(),
+            expect(getIFrameSrc()).toBe(
                 `http://${thoughtSpotHost}/?embedApp=true${defaultParams}${prefixParams}#/embed/viz/${liveboardId}`,
             );
         });
@@ -64,15 +59,18 @@ describe('Liveboard/viz embed tests', () => {
 
     test('should set disabled actions', async () => {
         const liveboardEmbed = new LiveboardEmbed(getRootEl(), {
-            disabledActions: [Action.DownloadAsCsv, Action.DownloadAsPdf, Action.DownloadAsXlsx],
+            disabledActions: [
+                Action.DownloadAsCsv,
+                Action.DownloadAsPdf,
+                Action.DownloadAsXlsx,
+            ],
             disabledActionReason: 'Action denied',
             ...defaultViewConfig,
             liveboardId,
         } as LiveboardViewConfig);
         liveboardEmbed.render();
         await executeAfterWait(() => {
-            expectUrlMatchesWithParams(
-                getIFrameSrc(),
+            expect(getIFrameSrc()).toBe(
                 `http://${thoughtSpotHost}/?embedApp=true&${defaultParamsWithoutHiddenActions}&disableAction=[%22${Action.DownloadAsCsv}%22,%22${Action.DownloadAsPdf}%22,%22${Action.DownloadAsXlsx}%22]&disableHint=Action%20denied&hideAction=[%22${Action.ReportError}%22]${prefixParams}#/embed/viz/${liveboardId}`,
             );
         });
@@ -80,14 +78,17 @@ describe('Liveboard/viz embed tests', () => {
 
     test('should set hidden actions', async () => {
         const liveboardEmbed = new LiveboardEmbed(getRootEl(), {
-            hiddenActions: [Action.DownloadAsCsv, Action.DownloadAsPdf, Action.DownloadAsXlsx],
+            hiddenActions: [
+                Action.DownloadAsCsv,
+                Action.DownloadAsPdf,
+                Action.DownloadAsXlsx,
+            ],
             ...defaultViewConfig,
             liveboardId,
         } as LiveboardViewConfig);
         liveboardEmbed.render();
         await executeAfterWait(() => {
-            expectUrlMatchesWithParams(
-                getIFrameSrc(),
+            expect(getIFrameSrc()).toBe(
                 `http://${thoughtSpotHost}/?embedApp=true&${defaultParamsWithoutHiddenActions}&hideAction=[%22${Action.ReportError}%22,%22${Action.DownloadAsCsv}%22,%22${Action.DownloadAsPdf}%22,%22${Action.DownloadAsXlsx}%22]${prefixParams}#/embed/viz/${liveboardId}`,
             );
         });
@@ -95,14 +96,17 @@ describe('Liveboard/viz embed tests', () => {
 
     test('should set visible actions', async () => {
         const liveboardEmbed = new LiveboardEmbed(getRootEl(), {
-            visibleActions: [Action.DownloadAsCsv, Action.DownloadAsPdf, Action.DownloadAsXlsx],
+            visibleActions: [
+                Action.DownloadAsCsv,
+                Action.DownloadAsPdf,
+                Action.DownloadAsXlsx,
+            ],
             ...defaultViewConfig,
             liveboardId,
         } as LiveboardViewConfig);
         liveboardEmbed.render();
         await executeAfterWait(() => {
-            expectUrlMatchesWithParams(
-                getIFrameSrc(),
+            expect(getIFrameSrc()).toBe(
                 `http://${thoughtSpotHost}/?embedApp=true${defaultParams}&visibleAction=[%22${Action.DownloadAsCsv}%22,%22${Action.DownloadAsPdf}%22,%22${Action.DownloadAsXlsx}%22]${prefixParams}#/embed/viz/${liveboardId}`,
             );
         });
@@ -116,8 +120,7 @@ describe('Liveboard/viz embed tests', () => {
         } as LiveboardViewConfig);
         liveboardEmbed.render();
         await executeAfterWait(() => {
-            expectUrlMatchesWithParams(
-                getIFrameSrc(),
+            expect(getIFrameSrc()).toBe(
                 `http://${thoughtSpotHost}/?embedApp=true${defaultParams}&visibleAction=[]${prefixParams}#/embed/viz/${liveboardId}`,
             );
         });
@@ -131,8 +134,7 @@ describe('Liveboard/viz embed tests', () => {
         } as LiveboardViewConfig);
         liveboardEmbed.render();
         await executeAfterWait(() => {
-            expectUrlMatchesWithParams(
-                getIFrameSrc(),
+            expect(getIFrameSrc()).toBe(
                 `http://${thoughtSpotHost}/?embedApp=true${defaultParams}&enableVizTransform=true${prefixParams}#/embed/viz/${liveboardId}`,
             );
         });
@@ -146,8 +148,7 @@ describe('Liveboard/viz embed tests', () => {
         } as LiveboardViewConfig);
         liveboardEmbed.render();
         await executeAfterWait(() => {
-            expectUrlMatchesWithParams(
-                getIFrameSrc(),
+            expect(getIFrameSrc()).toBe(
                 `http://${thoughtSpotHost}/?embedApp=true${defaultParams}&enableVizTransform=false${prefixParams}#/embed/viz/${liveboardId}`,
             );
         });
@@ -161,8 +162,7 @@ describe('Liveboard/viz embed tests', () => {
         } as LiveboardViewConfig);
         liveboardEmbed.render();
         await executeAfterWait(() => {
-            expectUrlMatchesWithParams(
-                getIFrameSrc(),
+            expect(getIFrameSrc()).toBe(
                 `http://${thoughtSpotHost}/?embedApp=true${defaultParams}${prefixParamsVizEmbed}#/embed/viz/${liveboardId}/${vizId}`,
             );
         });
@@ -183,15 +183,13 @@ describe('Liveboard/viz embed tests', () => {
         } as LiveboardViewConfig);
         liveboardEmbed.render();
         await executeAfterWait(() => {
-            expectUrlMatchesWithParams(
-                getIFrameSrc(),
+            expect(getIFrameSrc()).toBe(
                 `http://${thoughtSpotHost}/?embedApp=true&col1=sales&op1=EQ&val1=1000${defaultParams}${prefixParamsVizEmbed}#/embed/viz/${liveboardId}/${vizId}`,
             );
         });
     });
 
     test('should register event handler to adjust iframe height', async () => {
-        const onSpy = jest.spyOn(LiveboardEmbed.prototype, 'on');
         const liveboardEmbed = new LiveboardEmbed(getRootEl(), {
             ...defaultViewConfig,
             fullHeight: true,
@@ -199,10 +197,14 @@ describe('Liveboard/viz embed tests', () => {
             vizId,
         } as LiveboardViewConfig);
 
+        const onSpy = jest.spyOn(liveboardEmbed, 'on');
         liveboardEmbed.render();
 
         executeAfterWait(() => {
-            expect(onSpy).toHaveBeenCalledWith(EmbedEvent.EmbedHeight, expect.anything());
+            expect(onSpy).toHaveBeenCalledWith(
+                EmbedEvent.EmbedHeight,
+                expect.anything(),
+            );
         });
     });
     test('Should set the visible vizs', async () => {
@@ -213,14 +215,16 @@ describe('Liveboard/viz embed tests', () => {
         } as LiveboardViewConfig);
         liveboardEmbed.render();
         await executeAfterWait(() => {
-            expectUrlMatchesWithParams(
-                getIFrameSrc(),
+            expect(getIFrameSrc()).toBe(
                 `http://${thoughtSpotHost}/?embedApp=true${defaultParams}&pinboardVisibleVizs=[%22abcd%22,%22pqrs%22]${prefixParams}#/embed/viz/${liveboardId}`,
             );
         });
     });
     test('should process the trigger, for vizEmbed', async () => {
-        const mockProcessTrigger = spyOn(processTriggerInstance, 'processTrigger');
+        const mockProcessTrigger = spyOn(
+            processTriggerInstance,
+            'processTrigger',
+        );
         const liveboardEmbed = new LiveboardEmbed(getRootEl(), {
             enableVizTransformations: true,
             ...defaultViewConfig,
@@ -240,8 +244,7 @@ describe('Liveboard/viz embed tests', () => {
         } as LiveboardViewConfig);
         liveboardEmbed.render();
         await executeAfterWait(() => {
-            expectUrlMatchesWithParams(
-                getIFrameSrc(),
+            expect(getIFrameSrc()).toBe(
                 `http://${thoughtSpotHost}/?embedApp=true${defaultParams}&isLiveboardEmbed=true&isPinboardV2Enabled=true#/embed/viz/${liveboardId}/tab/${activeTabId}`,
             );
         });
@@ -256,8 +259,7 @@ describe('Liveboard/viz embed tests', () => {
         } as LiveboardViewConfig);
         liveboardEmbed.render();
         await executeAfterWait(() => {
-            expectUrlMatchesWithParams(
-                getIFrameSrc(),
+            expect(getIFrameSrc()).toBe(
                 `http://${thoughtSpotHost}/?embedApp=true${defaultParams}&preventPinboardFilterRemoval=true&isLiveboardEmbed=true&isPinboardV2Enabled=true#/embed/viz/${liveboardId}/tab/${activeTabId}`,
             );
         });
@@ -271,30 +273,9 @@ describe('Liveboard/viz embed tests', () => {
         } as LiveboardViewConfig);
         liveboardEmbed.render();
         await executeAfterWait(() => {
-            expectUrlMatchesWithParams(
-                getIFrameSrc(),
+            expect(getIFrameSrc()).toBe(
                 `http://${thoughtSpotHost}/?embedApp=true${defaultParams}&isContextMenuEnabledOnLeftClick=true&isLiveboardEmbed=true&isPinboardV2Enabled=true#/embed/viz/${liveboardId}/tab/${activeTabId}`,
             );
         });
     });
-
-    test('navigateToLiveboard should trigger the navigate event with the correct path', (done) => {
-        mockMessageChannel();
-        const liveboardEmbed = new LiveboardEmbed(getRootEl(), {
-            ...defaultViewConfig,
-        } as LiveboardViewConfig);
-        const onSpy = jest.spyOn(liveboardEmbed, 'trigger');
-        liveboardEmbed.prerenderGeneric();
-        executeAfterWait(() => {
-            const iframe = getIFrameEl();
-            postMessageToParent(iframe.contentWindow, {
-                type: EmbedEvent.APP_INIT,
-            });
-        });
-        executeAfterWait(() => {
-            liveboardEmbed.navigateToLiveboard('lb1', 'viz1');
-            expect(onSpy).toHaveBeenCalledWith(HostEvent.Navigate, '/embed/viz/lb1/viz1');
-            done();
-        });
-    });
 });