@thorprovider/adapters 5.0.0 → 5.0.1

package/src/providers/medusa/index.ts

@@ -49,7 +49,6 @@ import { validatePaymentId } from '../../utils/payment-utils';
 import { transformProduct, transformCart, transformCollection, transformCategory, transformOrder, transformCustomer, transformStockLocation, transformInventoryLevel, transformAddress, transformStorefrontConfig } from './transforms';
 import { MedusaAuthProvider } from './auth';
 import { getPaymentMethods } from './payment';
-import { MedusaAdminClient } from './admin';
 import {
   buildChannelScopeMetadata,
   filterByChannel,
@@ -164,19 +163,6 @@ export class MedusaProvider implements CommerceProvider {
    * Only created when adminConfig.apiKey is provided.
    */
   private sdkAdmin?: Medusa;
-
-  /**
-   * Admin client for Thor multi-tenant endpoints (`/admin/thor/`).
-   * Available when `adminConfig.apiKey` is provided.
-   *
-   * @example
-   * ```typescript
-   * const { customers } = await commerce.admin.getChannelCustomers('sc_01JXXXXX');
-   * const { api_keys } = await commerce.admin.getChannelApiKeys('sc_01JXXXXX');
-   * await commerce.admin.updateStorefrontConfig('sc_01JXXXXX', { theme_accent_color: '#EF4444', ... });
-   * ```
-   */
-  public readonly admin?: MedusaAdminClient;
   /** Cached distinct product status values — rarely changes, cached for process lifetime */
   private _cachedProductStatuses: string[] | null = null;
 
@@ -267,18 +253,12 @@ export class MedusaProvider implements CommerceProvider {
         debug: config.debug ?? false,
         // No publishableKey or auth config: this instance is admin-only, no JWT needed
       });
-      // Admin client for Thor multi-tenant custom endpoints (/admin/thor/)
-      (this as any).admin = new MedusaAdminClient({
-        baseUrl: config.baseUrl,
-        apiKey: config.adminConfig.apiKey,
-        debug: config.debug,
-      });
       this.logger.info('[Admin Auth] Dedicated admin SDK instance created with API key');
     }
 
     // Initialize auth provider if config is provided
     if (config.auth) {
-      this.auth = new MedusaAuthProvider(this.sdk, config.auth, config.debug, config.baseUrl, config.publishableKey);
+      this.auth = new MedusaAuthProvider(this.sdk, config.auth, config.debug);
       this.logger.info('Auth provider initialized');
     }
 

package/src/providers/medusa/live-smoke.test.ts

@@ -0,0 +1,412 @@
+/**
+ * Medusa Provider — Live Smoke Tests
+ *
+ * Exercises the adapter against a real Medusa backend (dev.erpthor.com).
+ * Guarded by MEDUSA_SMOKE_TEST=1 environment variable.
+ *
+ * Environment variables (all required when MEDUSA_SMOKE_TEST=1):
+ *   MEDUSA_BASE_URL          - Backend URL (e.g. https://dev.erpthor.com)
+ *   MEDUSA_PUBLISHABLE_KEY   - Publishable API key
+ *   MEDUSA_SECRET_KEY        - Secret admin API key (sk_...) for SDK Basic auth
+ *   MEDUSA_SALES_CHANNEL_ID  - Sales channel ID for scoped queries
+ *   MEDUSA_ADMIN_EMAIL       - Admin email for JWT auth (required for Thor admin endpoints)
+ *   MEDUSA_ADMIN_PASSWORD    - Admin password
+ *
+ * Optional:
+ *   MEDUSA_TEST_CUSTOMER_EMAIL    - Existing customer email for auth tests
+ *   MEDUSA_TEST_CUSTOMER_PASSWORD - Existing customer password
+ *
+ * Known issue: MedusaAdminClient uses x-medusa-access-token header which Medusa v2
+ * does not support. The backend requires Authorization: Bearer <JWT>. Group D tests
+ * work around this by obtaining a JWT via login and testing Thor admin endpoints directly.
+ */
+
+import { describe, expect, it, beforeAll } from 'vitest'
+import { MedusaProvider } from './index'
+import { MedusaAdminClient } from './admin'
+
+const runLive = process.env.MEDUSA_SMOKE_TEST === '1';
+
+function requiredEnv(name: string): string {
+  const value = process.env[name];
+  if (!value) throw new Error(`Missing required env var: ${name}`);
+  return value;
+}
+
+function optionalEnv(name: string): string | undefined {
+  return process.env[name] || undefined;
+}
+
+if (!runLive) {
+  describe('Medusa live smoke', () => {
+    it.skip('disabled unless MEDUSA_SMOKE_TEST=1', () => {});
+  });
+} else {
+  const baseUrl = requiredEnv('MEDUSA_BASE_URL');
+  const publishableKey = requiredEnv('MEDUSA_PUBLISHABLE_KEY');
+  const secretKey = requiredEnv('MEDUSA_SECRET_KEY');
+  const salesChannelId = requiredEnv('MEDUSA_SALES_CHANNEL_ID');
+  const adminEmail = requiredEnv('MEDUSA_ADMIN_EMAIL');
+  const adminPassword = requiredEnv('MEDUSA_ADMIN_PASSWORD');
+
+  // --------------------------------------------------------------------------
+  // Group A: Thor Plugin Store Endpoints (custom /store/thor/*)
+  // --------------------------------------------------------------------------
+  describe('Group A: Thor Store Plugin Endpoints', () => {
+    let provider: MedusaProvider;
+
+    beforeAll(() => {
+      provider = new MedusaProvider({
+        baseUrl,
+        publishableKey,
+        currencyCode: 'USD',
+        adminConfig: { apiKey: secretKey },
+      });
+    });
+
+    it('GET /store/thor/capabilities', async () => {
+      // capabilities is fetched in constructor, wait a tick then access
+      await new Promise((r) => setTimeout(r, 2000))
+      const caps = provider.capabilities
+      expect(caps).toBeDefined()
+      expect(caps).toHaveProperty('advancedSearch')
+    });
+
+    it('GET /store/thor/categories (channel-scoped)', async () => {
+      const categories = await provider.getCategories({ limit: 5 });
+      expect(categories).toBeInstanceOf(Array);
+    });
+
+    it('GET /store/thor/config (storefront config)', async () => {
+      const config = await provider.getStorefrontConfig();
+      // May return null if no config set for this channel — should not throw
+      expect(config === null || typeof config === 'object').toBe(true);
+    });
+
+    it('GET /store/thor/site-config (designer config)', async () => {
+      const config = await provider.getDesignerConfig();
+      expect(config === null || typeof config === 'object').toBe(true);
+    });
+
+    it('GET /store/search (advanced search)', async () => {
+      // Search depends on MeiliSearch being running on the backend — may 500 if not available
+      try {
+        const result = await provider.searchProductsAdvanced({ query: 'test', first: 3 })
+        expect(result).toHaveProperty('products')
+        expect(result.products).toBeInstanceOf(Array)
+      } catch (e: any) {
+        // MeiliSearch not running is acceptable in dev
+        console.log('Search endpoint unavailable (MeiliSearch down):', e.message?.slice(0, 80));
+      }
+    });
+  });
+
+  // --------------------------------------------------------------------------
+  // Group B: Standard Medusa Store Endpoints (via SDK)
+  // --------------------------------------------------------------------------
+  describe('Group B: Medusa Store Standard Endpoints', () => {
+    let provider: MedusaProvider;
+
+    beforeAll(() => {
+      provider = new MedusaProvider({
+        baseUrl,
+        publishableKey,
+        currencyCode: 'USD',
+        adminConfig: { apiKey: secretKey },
+      });
+    });
+
+    it('GET /store/products (list)', async () => {
+      const products = await provider.getProducts({ first: 3 });
+      expect(products).toBeInstanceOf(Array);
+      expect(products.length).toBeGreaterThan(0);
+      expect(products[0]).toHaveProperty('id');
+      expect(products[0]).toHaveProperty('title');
+    });
+
+    it('GET /store/products (by handle)', async () => {
+      const products = await provider.getProducts({ first: 1 });
+      expect(products.length).toBeGreaterThan(0);
+      const handle = products[0].handle;
+      expect(handle).toBeTruthy();
+
+      const product = await provider.getProduct(handle!);
+      expect(product).toBeDefined();
+      expect(product!.handle).toBe(handle);
+    });
+
+    it('GET /store/collections', async () => {
+      const collections = await provider.getCollections({});
+      expect(collections).toBeInstanceOf(Array);
+    });
+
+    it('GET /store/product-categories', async () => {
+      const categories = await provider.getCategories({ limit: 10 });
+      expect(categories).toBeInstanceOf(Array);
+    });
+
+    it('GET /store/regions', async () => {
+      const regions = await provider.getRegions();
+      expect(regions).toBeInstanceOf(Array);
+      expect(regions.length).toBeGreaterThan(0);
+      expect(regions[0]).toHaveProperty('id');
+    });
+
+    it('GET /store/regions/:id (countries)', async () => {
+      const regions = await provider.getRegions();
+      expect(regions.length).toBeGreaterThan(0);
+
+      const countries = await provider.getRegionCountries(regions[0].id);
+      expect(countries).toBeInstanceOf(Array);
+    });
+
+    describe('Cart lifecycle', () => {
+      let cartId: string;
+
+      it('POST /store/carts (create)', async () => {
+        const cart = await provider.createCart({})
+        expect(cart).toHaveProperty('id')
+        expect(cart.id).toBeTruthy()
+        cartId = cart.id as string
+      });
+
+      it('GET /store/carts/:id (retrieve)', async () => {
+        expect(cartId).toBeTruthy()
+        const cart = await provider.getCart(cartId as string)
+        expect(cart).toHaveProperty('id')
+        expect(cart!.id).toBe(cartId)
+      });
+
+      it('POST /store/carts/:id/line-items (add item)', async () => {
+        expect(cartId).toBeTruthy()
+        const products = await provider.getProducts({ first: 1 })
+        expect(products.length).toBeGreaterThan(0)
+        const variant = products[0].variants?.[0]
+        expect(variant).toBeDefined()
+
+        const cart = await provider.addToCart(cartId as string, [{
+          merchandiseId: variant!.id,
+          quantity: 1,
+        }])
+        expect(cart.lines.length).toBeGreaterThan(0)
+      });
+
+      it('POST /store/carts/:id/line-items/:lineId (update quantity)', async () => {
+        expect(cartId).toBeTruthy()
+        const cart = await provider.getCart(cartId as string)
+        expect(cart!.lines.length).toBeGreaterThan(0)
+        const lineId = cart!.lines[0].id as string
+
+        const updated = await provider.updateCart(cartId as string, [{
+          id: lineId,
+          merchandiseId: cart!.lines[0].merchandise.id,
+          quantity: 2,
+        }])
+        const line = updated.lines.find((l) => l.id === lineId)
+        expect(line?.quantity).toBe(2)
+      });
+
+      it('DELETE /store/carts/:id/line-items/:lineId (remove item)', async () => {
+        expect(cartId).toBeTruthy()
+        const cart = await provider.getCart(cartId as string)
+        expect(cart!.lines.length).toBeGreaterThan(0)
+        const lineId = cart!.lines[0].id as string
+
+        const updated = await provider.removeFromCart(cartId as string, [lineId])
+        expect(updated.lines.find((l) => l.id === lineId)).toBeUndefined()
+      });
+    });
+
+    it('GET /store/payment-providers', async () => {
+      const regions = await provider.getRegions()
+      expect(regions.length).toBeGreaterThan(0)
+
+      const methods = await provider.getPaymentMethods({ regionId: regions[0].id })
+      expect(methods).toBeInstanceOf(Array)
+    });
+  });
+
+  // --------------------------------------------------------------------------
+  // Group C: Customer Authentication (login, profile, addresses)
+  // --------------------------------------------------------------------------
+  describe('Group C: Customer Authentication', () => {
+    const testEmail = optionalEnv('MEDUSA_TEST_CUSTOMER_EMAIL')
+    const testPassword = optionalEnv('MEDUSA_TEST_CUSTOMER_PASSWORD')
+
+    it('login with test customer', async () => {
+      if (!testEmail || !testPassword) {
+        console.log('Skipping: MEDUSA_TEST_CUSTOMER_EMAIL/PASSWORD not set')
+        return
+      }
+
+      const provider = new MedusaProvider({
+        baseUrl,
+        publishableKey,
+        currencyCode: 'USD',
+        auth: {
+          method: 'jwt',
+          storage: 'memory',
+        },
+      });
+
+      const authProvider = provider.auth
+      expect(authProvider).toBeDefined()
+
+      const result = await authProvider!.login({ email: testEmail, password: testPassword })
+      expect(result.token || result.customer).toBeTruthy()
+      expect(result.customer).toBeDefined()
+      expect(result.customer!.email).toBe(testEmail)
+
+      // getCurrentCustomer
+      const customer = await authProvider!.getCurrentCustomer()
+      expect(customer).toBeDefined()
+      expect(customer!.email).toBe(testEmail)
+
+      // getAddresses
+      const addresses = await authProvider!.getAddresses()
+      expect(addresses).toBeInstanceOf(Array)
+
+      // Logout
+      await authProvider!.logout()
+    });
+  });
+
+  // --------------------------------------------------------------------------
+  // Group D: Admin Thor Plugin Endpoints (direct HTTP with JWT)
+  //
+  // NOTE: MedusaAdminClient uses x-medusa-access-token which is NOT supported
+  // by Medusa v2. These tests use direct fetch with Bearer JWT to verify the
+  // endpoints exist and respond correctly. This documents a real adapter bug.
+  // --------------------------------------------------------------------------
+  describe('Group D: Admin Thor Plugin Endpoints (direct JWT)', () => {
+    let jwt: string
+
+    beforeAll(async () => {
+      // Obtain admin JWT
+      const res = await fetch(`${baseUrl}/auth/user/emailpass`, {
+        method: 'POST',
+        headers: { 'Content-Type': 'application/json' },
+        body: JSON.stringify({ email: adminEmail, password: adminPassword }),
+      })
+      const data = await res.json() as { token?: string }
+      expect(data.token).toBeTruthy()
+      jwt = data.token as string
+    })
+
+    async function adminFetch(path: string): Promise<any> {
+      const res = await fetch(`${baseUrl}${path}`, {
+        headers: { Authorization: `Bearer ${jwt}` },
+      })
+      if (!res.ok) {
+        const text = await res.text()
+        throw new Error(`${res.status} ${path}: ${text}`)
+      }
+      return res.json()
+    }
+
+    it('GET /admin/thor/sales-channels/:id/customers', async () => {
+      const result = await adminFetch(`/admin/thor/sales-channels/${salesChannelId}/customers?limit=5`)
+      expect(result).toHaveProperty('customers')
+      expect(result.customers).toBeInstanceOf(Array)
+    })
+
+    it('GET /admin/thor/sales-channels/:id/api-keys', async () => {
+      const result = await adminFetch(`/admin/thor/sales-channels/${salesChannelId}/api-keys`)
+      expect(result).toHaveProperty('api_keys')
+      expect(result.api_keys).toBeInstanceOf(Array)
+    })
+
+    it('GET /admin/thor/sales-channels/:id/categories', async () => {
+      const result = await adminFetch(`/admin/thor/sales-channels/${salesChannelId}/categories?limit=10`)
+      expect(result).toHaveProperty('categories')
+      expect(result.categories).toBeInstanceOf(Array)
+    })
+
+    it('GET /admin/thor/storefront-config/:id (may 404)', async () => {
+      const res = await fetch(`${baseUrl}/admin/thor/storefront-config/${salesChannelId}`, {
+        headers: { Authorization: `Bearer ${jwt}` },
+      })
+      // 200 or 404 are both acceptable
+      expect([200, 404]).toContain(res.status)
+    })
+
+    it('GET /admin/thor/site-config/:id (may 404)', async () => {
+      const res = await fetch(`${baseUrl}/admin/thor/site-config/${salesChannelId}`, {
+        headers: { Authorization: `Bearer ${jwt}` },
+      })
+      expect([200, 404]).toContain(res.status)
+    })
+
+    it('GET /admin/thor/site-config/:id/history (may 404)', async () => {
+      const res = await fetch(`${baseUrl}/admin/thor/site-config/${salesChannelId}/history`, {
+        headers: { Authorization: `Bearer ${jwt}` },
+      })
+      expect([200, 404]).toContain(res.status)
+    })
+
+    it('BUG: MedusaAdminClient x-medusa-access-token returns 401', async () => {
+      // This documents the adapter bug: MedusaAdminClient sends x-medusa-access-token
+      // but Medusa v2 only accepts Authorization: Bearer for admin routes.
+      const res = await fetch(`${baseUrl}/admin/thor/sales-channels/${salesChannelId}/customers?limit=1`, {
+        headers: { 'x-medusa-access-token': jwt },
+      })
+      expect(res.status).toBe(401)
+    })
+  });
+
+  // --------------------------------------------------------------------------
+  // Group E: Admin Standard Medusa Endpoints (via SDK with Basic auth)
+  // --------------------------------------------------------------------------
+  describe('Group E: Admin Standard Medusa Endpoints', () => {
+    let provider: MedusaProvider;
+
+    beforeAll(() => {
+      provider = new MedusaProvider({
+        baseUrl,
+        publishableKey,
+        currencyCode: 'USD',
+        adminConfig: { apiKey: secretKey },
+      });
+    });
+
+    it('GET /admin/products (list)', async () => {
+      const result = await provider.getAdminProducts({ limit: 3 })
+      expect(result).toHaveProperty('products')
+      expect(result.products).toBeInstanceOf(Array)
+      expect(result.products.length).toBeGreaterThan(0)
+    })
+
+    it('GET /admin/products/:id (retrieve)', async () => {
+      const list = await provider.getAdminProducts({ limit: 1 })
+      expect(list.products.length).toBeGreaterThan(0)
+      const id = list.products[0].id
+
+      const product = await provider.getAdminProduct(id)
+      expect(product).toBeDefined()
+      expect(product!.id).toBe(id)
+    })
+
+    it('GET /admin/orders (list)', async () => {
+      const result = await provider.getAdminOrders({ limit: 3 })
+      expect(result).toHaveProperty('orders')
+      expect(result.orders).toBeInstanceOf(Array)
+    })
+
+    it('GET /admin/customers (list)', async () => {
+      const result = await provider.getAdminCustomers({ limit: 3 })
+      expect(result).toHaveProperty('customers')
+      expect(result.customers).toBeInstanceOf(Array)
+    })
+
+    it('GET /admin/regions (list)', async () => {
+      const result = await provider.getAdminRegions()
+      expect(result).toBeInstanceOf(Array)
+      expect(result.length).toBeGreaterThan(0)
+    })
+
+    it('GET /admin/stock-locations (list)', async () => {
+      const result = await provider.getStockLocations()
+      expect(result).toBeInstanceOf(Array)
+    })
+  });
+}