@thirdfy/agent-cli 0.4.2 → 0.5.0

package/src/runtime/providerHints/cex.mjs

@@ -1,59 +1,8 @@
 /**
- * Static provider hints. Centralized exchanges and their executors: Bitfinex, Hummingbot and Condor.
+ * Static provider hints. Centralized exchange executors: Hummingbot and Condor.
  * Each entry builds the hint for one provider id; `dispatch.mjs` picks the entry.
  */
 export const CEX_PROVIDER_HINTS = Object.freeze({
-  bitfinex: ({ provider }) => ({
-    provider,
-    category: 'cex_funding_and_spot',
-    canonicalReadAction: 'get_bitfinex_funding_ticker',
-    canonicalWriteAction: 'submit_bitfinex_funding_offer',
-    readActions: [
-      'get_bitfinex_funding_stats_hist',
-      'get_bitfinex_funding_ticker',
-      'get_bitfinex_funding_book',
-      'get_bitfinex_wallets',
-      'list_bitfinex_funding_offers',
-      'list_bitfinex_funding_offers_hist',
-      'list_bitfinex_funding_credits',
-      'list_bitfinex_funding_loans',
-      'get_bitfinex_funding_info',
-      'get_bitfinex_ledgers_hist',
-      'get_bitfinex_orders',
-    ],
-    orderManagementActions: [
-      'submit_bitfinex_funding_offer',
-      'cancel_bitfinex_funding_offer',
-      'transfer_bitfinex_between_wallets',
-      'get_bitfinex_orders',
-      'submit_bitfinex_order',
-      'update_bitfinex_order',
-      'cancel_bitfinex_order',
-    ],
-    credentialType: 'api_key',
-    credentialRef: 'bitfinex:funding-primary',
-    credentialUx: 'Bitfinex credentials are owned by Thirdfy API encrypted delegation storage. CLI commands pass credentialRef only; never apiKey/apiSecret.',
-    laneCompatibility: 'Use `thirdfy-agent actions --provider bitfinex` for discovery, then `thirdfy-agent run --run-mode thirdfy` with credentialRef in params. The CLI does not store, log, or sign raw exchange credentials.',
-    example: 'thirdfy-agent actions --provider bitfinex && thirdfy-agent run --run-mode thirdfy --action submit_bitfinex_funding_offer --params \'{"symbol":"fUSD","amount":"100","rate":"0.0002","period":2,"credentialRef":"bitfinex:funding-primary"}\'',
-    credentialProfiles: [
-      {
-        id: 'bitfinex_funding_v1',
-        credentialRef: 'bitfinex:funding-primary',
-        required: ['funding.read', 'funding.write', 'wallets.read'],
-      },
-      {
-        id: 'bitfinex_spot_v1',
-        credentialRef: 'bitfinex:spot-primary',
-        required: ['orders.read', 'orders.write', 'wallets.read'],
-      },
-    ],
-    setupBlockers: [
-      'CEX_CREDENTIAL_NOT_FOUND',
-      'BITFINEX_CREDENTIALS_NOT_IN_THIRDFY_DELEGATION_CONTEXT',
-      'BITFINEX_PERMISSION_SCOPE_MISSING',
-      'CEX_POLICY_ACTION_NOT_ALLOWED',
-    ],
-  }),
   hummingbot: ({ provider }) => ({
     provider,
     category: 'cex_executor',

package/src/runtime/bitfinexProbe.mjs

@@ -1,121 +0,0 @@
-import { createHmac } from 'crypto';
-import { DEFAULT_BITFINEX_BASE_URL, BITFINEX_PERMISSION_PROFILES } from '../core/constants.mjs';
-import { createCliError } from '../core/envelope.mjs';
-import { requestJson, safeJsonParse } from '../core/http.mjs';
-export function createBitfinexProbe() {
-function parseBitfinexPermissionRows(rawData) {
-  const rows = Array.isArray(rawData) ? rawData : [];
-  const parsed = {};
-  for (const row of rows) {
-    if (!Array.isArray(row) || row.length < 3) continue;
-    const scope = String(row[0] || '').trim().toLowerCase();
-    if (!scope) continue;
-    const read = Number(row[1]) === 1 ? 1 : 0;
-    const write = Number(row[2]) === 1 ? 1 : 0;
-    parsed[scope] = { read, write };
-  }
-  return parsed;
-}
-
-function getMissingBitfinexScopes(scopePermissions, permissionProfile = 'funding') {
-  const profile = BITFINEX_PERMISSION_PROFILES[permissionProfile] || BITFINEX_PERMISSION_PROFILES.funding;
-  const missing = [];
-  for (const [scope, required] of Object.entries(profile.required)) {
-    const actual = scopePermissions[scope] || { read: 0, write: 0 };
-    if (actual.read < required.read || actual.write < required.write) {
-      missing.push({
-        scope,
-        required,
-        actual,
-      });
-    }
-  }
-  return missing;
-}
-
-async function probeBitfinexPermissions({ apiKey, apiSecret, permissionProfile = 'funding', timeoutMs, baseUrl }) {
-  const normalizedBaseUrl = String(baseUrl || DEFAULT_BITFINEX_BASE_URL).trim().replace(/\/+$/, '');
-  const apiPath = '/v2/auth/r/permissions';
-  const nonce = Date.now().toString();
-  const payload = '{}';
-  const signature = createHmac('sha384', String(apiSecret || ''))
-    .update(`/api${apiPath}${nonce}${payload}`)
-    .digest('hex');
-  const controller = new AbortController();
-  const timer = setTimeout(() => controller.abort(), Number(timeoutMs || DEFAULT_TIMEOUT_MS));
-  try {
-    const response = await fetch(`${normalizedBaseUrl}${apiPath}`, {
-      method: 'POST',
-      headers: {
-        'content-type': 'application/json',
-        'bfx-apikey': String(apiKey || ''),
-        'bfx-nonce': nonce,
-        'bfx-signature': signature,
-      },
-      body: payload,
-      signal: controller.signal,
-    });
-    const text = await response.text();
-    const parsed = text ? safeJsonParse(text) : {};
-    const bitfinexApiError =
-      Array.isArray(parsed) && String(parsed[0] || '').trim().toLowerCase() === 'error'
-        ? {
-            code: Number(parsed[1]) || null,
-            message: String(parsed[2] || 'Unknown Bitfinex API error'),
-          }
-        : parsed && typeof parsed === 'object' && String(parsed.event || '').trim().toLowerCase() === 'error'
-          ? {
-              code: Number(parsed.code) || null,
-              message: String(parsed.msg || parsed.message || 'Unknown Bitfinex API error'),
-            }
-          : null;
-    if (!response.ok) {
-      throw createCliError(
-        'BITFINEX_PERMISSIONS_PROBE_FAILED',
-        `Bitfinex permissions probe failed with HTTP ${response.status}. Verify API key/secret and key validity before onboarding.`,
-        { statusCode: response.status }
-      );
-    }
-    if (bitfinexApiError) {
-      throw createCliError(
-        'BITFINEX_PERMISSIONS_PROBE_FAILED',
-        `Bitfinex permissions probe failed: ${bitfinexApiError.message}. Verify API key/secret and key validity before onboarding.`,
-        { statusCode: response.status, bitfinexApiError }
-      );
-    }
-    const scopePermissions = parseBitfinexPermissionRows(parsed);
-    const missingScopes = getMissingBitfinexScopes(scopePermissions, permissionProfile);
-    if (missingScopes.length > 0) {
-      throw createCliError(
-        'BITFINEX_PERMISSION_SCOPE_MISSING',
-        `Bitfinex key is missing required scopes (${missingScopes
-          .map((entry) => entry.scope)
-          .join(', ')}). Enable the ${permissionProfile} profile scopes and retry onboarding.`,
-        { missingScopes, scopePermissions, permissionProfile }
-      );
-    }
-    return {
-      venue: 'bitfinex',
-      permissionProfile,
-      checked: true,
-      scopes: scopePermissions,
-      missingScopes: [],
-    };
-  } catch (error) {
-    if (error?.payload) throw error;
-    throw createCliError(
-      'BITFINEX_PERMISSIONS_PROBE_FAILED',
-      `Could not verify Bitfinex key permissions. ${String(error?.message || 'Unknown probe error')}`,
-      {}
-    );
-  } finally {
-    clearTimeout(timer);
-  }
-}
-
-  return {
-    parseBitfinexPermissionRows,
-    getMissingBitfinexScopes,
-    probeBitfinexPermissions,
-  };
-}

package/src/runtime/execution/runners/fallbackHints.mjs

@@ -1,54 +0,0 @@
-/** Hints added to a failed execution answer (Bitfinex onboarding and similar next steps). */
-export function createFallbackHints(deps) {
-  const {
-    buildBitfinexOnboardingCommand,
-    inferBitfinexPermissionProfileFromAction,
-  } = deps;
-
-function applyExecutionFallbackHints(normalized, { flags, runMode, resolvedAction }) {
-  if (!normalized || typeof normalized !== 'object') return normalized;
-  const next = { ...normalized };
-  const reasons = new Set();
-  const topBlockedReason = String(next.blockedReason || '').trim();
-  if (topBlockedReason) reasons.add(topBlockedReason);
-  const blockedByReason = next.blockedByReason && typeof next.blockedByReason === 'object' ? next.blockedByReason : {};
-  for (const key of Object.keys(blockedByReason)) {
-    if (String(key || '').trim()) reasons.add(String(key).trim());
-  }
-  const resolvedActionLower = String(resolvedAction || '').trim().toLowerCase();
-  const looksBitfinexAction = resolvedActionLower.includes('bitfinex');
-  const permissionProfile = inferBitfinexPermissionProfileFromAction(resolvedActionLower);
-  const cexCredentialMissingSignals = new Set([
-    'CEX_CREDENTIAL_NOT_FOUND',
-    'BITFINEX_CREDENTIALS_NOT_IN_CONTEXT',
-    'BITFINEX_CREDENTIALS_NOT_IN_THIRDFY_DELEGATION_CONTEXT',
-    'BITFINEX_ENV_CREDENTIALS_NOT_CONFIGURED',
-  ]);
-  const hasMissingCredentialSignal = Array.from(reasons).some((code) => cexCredentialMissingSignals.has(code));
-  if (looksBitfinexAction && hasMissingCredentialSignal) {
-    next.onboardingHint = {
-      type: 'bitfinex_credentials',
-      message:
-        'Bitfinex credentials are missing for this delegated account. Onboard credentials first, then retry the same command.',
-      command: buildBitfinexOnboardingCommand(permissionProfile),
-    };
-  }
-  if (
-    looksBitfinexAction &&
-    runMode !== 'thirdfy' &&
-    runMode !== 'agent_wallet' &&
-    (topBlockedReason === 'SELF_MODE_REQUIRES_BUILD_TX' || topBlockedReason === 'HYBRID_MODE_REQUIRES_BUILD_TX')
-  ) {
-    next.onboardingHint = {
-      ...(next.onboardingHint || {}),
-      runMode: 'thirdfy',
-      runModeMessage: 'Bitfinex actions require delegated execute-intent rail. Re-run with --run-mode thirdfy.',
-    };
-  }
-  return next;
-}
-
-  return {
-    applyExecutionFallbackHints,
-  };
-}

package/src/runtime/onboardingHints.mjs

@@ -1,54 +0,0 @@
-import { BITFINEX_PERMISSION_PROFILES } from '../core/constants.mjs';
-export function createOnboardingHints() {
-function buildBitfinexOnboardingCommand(permissionProfile = 'funding') {
-  const profile = BITFINEX_PERMISSION_PROFILES[permissionProfile] || BITFINEX_PERMISSION_PROFILES.funding;
-  return [
-    'thirdfy-agent credentials upsert',
-    '--auth-token "$THIRDFY_AUTH_TOKEN"',
-    '--venue bitfinex',
-    `--permission-profile ${profile.id}`,
-    `--credential-ref ${profile.credentialRef}`,
-    '--api-key "<BITFINEX_API_KEY>"',
-    '--api-secret "<BITFINEX_API_SECRET>"',
-    '--verify-permissions',
-    '--json',
-  ].join(' ');
-}
-
-function inferBitfinexPermissionProfileFromAction(actionName) {
-  const action = String(actionName || '')
-    .trim()
-    .toLowerCase()
-    .replace(/[_\s]+/g, '-');
-  if (!action.includes('bitfinex')) return 'funding';
-  return action.includes('bitfinex-order') ? 'spot' : 'funding';
-}
-
-function buildTopLevelOnboardingHint(payload) {
-  const reason = String(payload?.blockedReason || payload?.error || '').trim();
-  const permissionProfile = inferBitfinexPermissionProfileFromAction(
-    payload?.resolvedAction || payload?.action || payload?.requestedAction
-  );
-  if (!reason) return null;
-  if (
-    [
-      'CEX_CREDENTIAL_NOT_FOUND',
-      'BITFINEX_CREDENTIALS_NOT_IN_CONTEXT',
-      'BITFINEX_CREDENTIALS_NOT_IN_THIRDFY_DELEGATION_CONTEXT',
-      'BITFINEX_ENV_CREDENTIALS_NOT_CONFIGURED',
-    ].includes(reason)
-  ) {
-    return {
-      type: 'bitfinex_credentials',
-      command: buildBitfinexOnboardingCommand(permissionProfile),
-    };
-  }
-  return null;
-}
-
-  return {
-    buildBitfinexOnboardingCommand,
-    inferBitfinexPermissionProfileFromAction,
-    buildTopLevelOnboardingHint,
-  };
-}