@thirdfy/agent-cli 0.2.76 → 0.2.78

package/src/runtime/validation/actionParamsGate.mjs

@@ -6,6 +6,47 @@ import {
   formatParamsSchemaValidationResult,
 } from './paramsSchema.mjs';
 
+const tokensOf = (action) =>
+  String(action || '')
+    .toLowerCase()
+    .split(/[-_\s]+/)
+    .filter(Boolean);
+
+function editDistance(a, b) {
+  const row = Array.from({ length: b.length + 1 }, (_, i) => i);
+  for (let i = 1; i <= a.length; i += 1) {
+    let prev = row[0];
+    row[0] = i;
+    for (let j = 1; j <= b.length; j += 1) {
+      const tmp = row[j];
+      row[j] = Math.min(row[j] + 1, row[j - 1] + 1, prev + (a[i - 1] === b[j - 1] ? 0 : 1));
+      prev = tmp;
+    }
+  }
+  return row[b.length];
+}
+
+/**
+ * Catalog actions closest to an unknown name: shared words first, then edit distance, so
+ * `open_avantis_position` suggests `place_avantis_perps_order` and typos find their action.
+ * Mirrors thirdfy-mcp `suggestCatalogActions`.
+ */
+export function suggestCatalogActions(requested, actions, limit = 5) {
+  const wanted = tokensOf(requested);
+  const target = wanted.join('_');
+  return (Array.isArray(actions) ? actions : [])
+    .filter((action) => action?.action && action.enabled !== false)
+    .map((action) => {
+      const name = tokensOf(action.action).join('_');
+      const shared = tokensOf(action.action).filter((token) => wanted.includes(token)).length;
+      return { name: action.action, shared, distance: editDistance(target, name) };
+    })
+    .filter((candidate) => candidate.shared > 0 || candidate.distance <= 3)
+    .sort((a, b) => b.shared - a.shared || a.distance - b.distance)
+    .slice(0, limit)
+    .map((candidate) => candidate.name);
+}
+
 export function resolveActionParamsSchema(resolved) {
   const meta = resolved?.resolvedActionMeta;
   if (!meta || typeof meta !== 'object') return null;
@@ -19,12 +60,22 @@ export function isReadOnlyCatalogAction(resolved) {
 export function validateResolvedActionParams(resolved, params) {
   const meta = resolved?.resolvedActionMeta;
   if (!meta || typeof meta !== 'object') {
+    // Same shape as thirdfy-mcp 0.1.6+: `error` stays PARAMS_SCHEMA_INVALID (callers match on it);
+    // `blockedReason: UNKNOWN_ACTION` plus `suggestions` point at real actions. With an agent key
+    // the list is the agent's own policy list, so the action may exist but not be allowed.
+    const suggestions = Array.isArray(resolved?.suggestions) ? resolved.suggestions : [];
     return {
       valid: false,
       skipped: false,
-      error: `Action "${resolved?.requestedAction || ''}" was not found in the Thirdfy catalog`,
+      error: `Action "${resolved?.requestedAction || ''}" is not in the Thirdfy catalog or is not allowed for this agent${
+        suggestions.length
+          ? `. Did you mean: ${suggestions.join(', ')}?`
+          : '. Use `thirdfy-agent actions` to list actions.'
+      }`,
       field: null,
       code: 'PARAMS_SCHEMA_INVALID',
+      blockedReason: 'UNKNOWN_ACTION',
+      suggestions,
     };
   }
 
@@ -57,11 +108,13 @@ export function enforceCatalogActionParams(resolved, flags, getPreparedParams) {
     return;
   }
   throw createCliError('PARAMS_SCHEMA_INVALID', result.error || 'Action params failed catalog schema validation', {
-    blockedReason: 'PARAMS_SCHEMA_INVALID',
+    blockedReason: result.blockedReason || 'PARAMS_SCHEMA_INVALID',
+    ...(Array.isArray(result.suggestions) ? { suggestions: result.suggestions } : {}),
     blockedStage: 'client_validation',
     validationError: result.error || null,
     field: result.field || null,
-    resolvedAction: resolved?.resolvedAction || null,
+    // An unknown action resolved to nothing; MCP reports `resolvedAction: null` for it too.
+    resolvedAction: result.blockedReason === 'UNKNOWN_ACTION' ? null : resolved?.resolvedAction || null,
     requestedAction: resolved?.requestedAction || null,
   });
 }