@things-factory/worksheet-base 4.3.137 → 4.3.138

package/server/controllers/inbound/unloading-worksheet-controller.ts

@@ -19,8 +19,8 @@ import {
   VAS_TARGET_TYPES,
   VAS_TYPES
 } from '@things-factory/sales-base'
-import { Domain } from '@things-factory/shell'
 import { PartnerSetting, Setting } from '@things-factory/setting-base'
+import { Domain } from '@things-factory/shell'
 import {
   Inventory,
   INVENTORY_ITEM_SOURCE,
@@ -31,12 +31,13 @@ import {
   InventoryNoGenerator,
   Location,
   Pallet,
-  Warehouse
+  Warehouse,
+  generateInventoryHistory
 } from '@things-factory/warehouse-base'
 
 import { RULE_TYPE, WORKSHEET_STATUS, WORKSHEET_TYPE } from '../../constants'
 import { Worksheet, WorksheetDetail } from '../../entities'
-import { DateGenerator, generateInventoryHistory } from '../../utils'
+import { DateGenerator } from '../../utils'
 import { VasWorksheetController } from '../vas/vas-worksheet-controller'
 
 export type UnloadingWorksheetDetail = Partial<WorksheetDetail> & {
@@ -95,11 +96,13 @@ export class UnloadingWorksheetController extends VasWorksheetController {
         'worksheet.bufferLocation.warehouse',
         'targetProduct',
         'targetProduct.product',
+        'targetProduct.productDetail',
         'targetProduct.product.productDetails',
         'targetProduct.product.productDetails.childProductDetail',
         'targetInventory',
         'targetInventory.inventory',
         'targetInventory.product',
+        'targetInventory.productDetail',
         'targetInventory.product.productDetails',
         'targetInventory.product.productDetails.childProductDetail'
       ]
@@ -121,6 +124,9 @@ export class UnloadingWorksheetController extends VasWorksheetController {
     const batchId: string = Boolean(arrivalNotice) ? targetProduct.batchId : targetInventory.batchId
     const batchIdRef: string = Boolean(arrivalNotice) ? targetProduct.batchIdRef : null
     const product: Product = Boolean(arrivalNotice) ? targetProduct.product : targetInventory.product
+    let productDetail: ProductDetail = Boolean(arrivalNotice)
+      ? targetProduct.productDetail
+      : targetInventory.productDetail
     const packingType: string = Boolean(arrivalNotice) ? targetProduct.packingType : targetInventory.packingType
     const packingSize: number = Boolean(arrivalNotice) ? targetProduct.packingSize : targetInventory.packingSize
     const remark: string = Boolean(arrivalNotice) ? targetProduct.remark : targetInventory.remark
@@ -140,6 +146,7 @@ export class UnloadingWorksheetController extends VasWorksheetController {
 
     const palletId: string = inventory?.palletId
     const cartonId: string = inventory?.cartonId
+    let matchingProduct
 
     if (!inventory?.palletId) {
       inventory.palletId = await generateId({
@@ -153,35 +160,24 @@ export class UnloadingWorksheetController extends VasWorksheetController {
     }
 
     if (productBarcode) {
-      const productDetails: ProductDetail[] = product?.productDetails.filter(detail => !detail.deletedAt)
-      const isMatchingBarcode: boolean = productDetails.map(detail => detail.gtin).includes(productBarcode)
-      if (!isMatchingBarcode) throw new Error(this.ERROR_MSG.FIND.NO_RESULT(productBarcode))
-
-      const foundProductDetail: ProductDetail = productDetails.find(
-        (detail: ProductDetail) =>
-          detail.gtin === productBarcode && detail.packingType === packingType && detail.packingSize == packingSize
+      matchingProduct = await this.getDirectQty(
+        {
+          ...productDetail,
+          product: targetInventory?.product
+        },
+        productBarcode,
+        qty
       )
 
-      if (!foundProductDetail) {
-        const orderProductDetail: ProductDetail = productDetails.find(
-          (parentDetail: ProductDetail) =>
-            parentDetail.packingType === packingType && parentDetail.packingSize == packingSize
-        )
-        if (!orderProductDetail)
-          throw new Error(
-            this.ERROR_MSG.FIND.NO_RESULT(`Packing Type ( ${packingType}) or Packing Size (${packingSize})`)
-          )
+      //validate matching product details based on scanned barcode
+      if (!matchingProduct) throw new Error(this.ERROR_MSG.FIND.NO_RESULT(productBarcode))
 
-        if (arrivalNotice) {
-          uom = targetProduct.uom
-        } else {
-          uom = orderProductDetail.uom
-        }
-        qty = (await this.getChildQty(productDetails, productBarcode, orderProductDetail)) * qty
-      } else {
-        uom = foundProductDetail.uom
-        qty
-      }
+      qty = matchingProduct.qty
+      uom = arrivalNotice ? targetProduct.uom : matchingProduct.uom
+    }
+
+    if (!uom) {
+      uom = productDetail.uom
     }
 
     const uomValue: number =
@@ -200,6 +196,7 @@ export class UnloadingWorksheetController extends VasWorksheetController {
     newInventory.cartonId = inventory.cartonId
     newInventory.batchId = batchId
     newInventory.product = product
+    newInventory.productDetail = productDetail
     newInventory.packingType = packingType
     newInventory.packingSize = packingSize
     newInventory.uom = uom
@@ -241,6 +238,7 @@ export class UnloadingWorksheetController extends VasWorksheetController {
       targetProduct.actualPackQty += qty
       targetProduct.status = ORDER_PRODUCT_STATUS.UNLOADED
       targetProduct.updater = this.user
+      targetProduct.productDetail = productDetail
       this.updateOrderTargets([targetProduct])
     } else if (returnOrder) {
       targetInventory.actualPalletQty++
@@ -270,9 +268,11 @@ export class UnloadingWorksheetController extends VasWorksheetController {
         'worksheet.bufferLocation.warehouse',
         'targetProduct',
         'targetProduct.product',
+        'targetProduct.productDetail',
         'targetProduct.product.productDetails',
         'targetProduct.product.productDetails.childProductDetail',
         'targetInventory',
+        'targetInventory.productDetail',
         'targetInventory.product',
         'targetInventory.product.productDetails',
         'targetInventory.product.productDetails.childProductDetail'
@@ -289,7 +289,7 @@ export class UnloadingWorksheetController extends VasWorksheetController {
 
     const targetProduct: OrderProduct = worksheetDetail.targetProduct
 
-    if (targetProduct.status == ORDER_PRODUCT_STATUS.EDITED)
+    if (targetProduct?.status == ORDER_PRODUCT_STATUS.EDITED)
       throw new Error('this product is pending for changes approval')
 
     const bizplace: Bizplace = worksheetDetail.bizplace
@@ -298,6 +298,9 @@ export class UnloadingWorksheetController extends VasWorksheetController {
     const returnOrder: ReturnOrder = worksheet.returnOrder
     const targetInventory: OrderInventory = worksheetDetail.targetInventory
     const product: Product = Boolean(arrivalNotice) ? targetProduct.product : targetInventory.product
+    const productDetail: ProductDetail = Boolean(arrivalNotice)
+      ? targetProduct.productDetail
+      : targetInventory.productDetail
     const packingType: string = Boolean(arrivalNotice) ? targetProduct.packingType : targetInventory.packingType
     const packingSize: number = Boolean(arrivalNotice) ? targetProduct.packingSize : targetInventory.packingSize
     const batchId: string = Boolean(arrivalNotice) ? targetProduct.batchId : targetInventory.batchId
@@ -309,15 +312,13 @@ export class UnloadingWorksheetController extends VasWorksheetController {
 
     qty++
 
-    const invQb: SelectQueryBuilder<Inventory> = await this.trxMgr
+    const invQb: SelectQueryBuilder<Inventory> = this.trxMgr
       .getRepository(Inventory)
       .createQueryBuilder('INV')
       .where('INV.domain_id = :domainId', { domainId: this.domain.id })
       .andWhere('INV.bizplace_id = :bizplaceId', { bizplaceId: bizplace.id })
-      .andWhere('INV.product_id = :productId', { productId: product.id })
+      .andWhere('INV.product_detail_id = :productDetailId', { productDetailId: productDetail.id })
       .andWhere('INV.batch_id = :batchId', { batchId: batchId })
-      .andWhere('INV.packing_type = :packingType', { packingType: packingType })
-      .andWhere('INV.packing_size = :packingSize', { packingSize: packingSize })
 
     if (arrivalNotice) invQb.andWhere('INV.ref_order_id = :arrivalNoticeId', { arrivalNoticeId: arrivalNotice.id })
     else if (returnOrder) invQb.andWhere('INV.ref_order_id = :returnOrderId', { returnOrderId: returnOrder.id })
@@ -357,6 +358,7 @@ export class UnloadingWorksheetController extends VasWorksheetController {
       newInventory.batchId = batchId
       newInventory.batchIdRef = batchIdRef
       newInventory.product = product
+      newInventory.productDetail = productDetail
       newInventory.packingType = packingType
       newInventory.packingSize = packingSize
       newInventory.uom = uom
@@ -421,6 +423,7 @@ export class UnloadingWorksheetController extends VasWorksheetController {
     inventoryItem.status = foundInventory.status
     inventoryItem.inboundOrderId = foundInventory.refOrderId
     inventoryItem.product = product
+    inventoryItem.productDetail = productDetail
     inventoryItem.inventory = foundInventory
     inventoryItem.source = INVENTORY_ITEM_SOURCE.INBOUND
     inventoryItem.domain = this.domain
@@ -457,10 +460,12 @@ export class UnloadingWorksheetController extends VasWorksheetController {
         'worksheet.bufferLocation.warehouse',
         'targetProduct',
         'targetProduct.product',
+        'targetProduct.productDetail',
         'targetProduct.product.productDetails',
         'targetProduct.product.productDetails.childProductDetail',
         'targetInventory',
         'targetInventory.product',
+        'targetInventory.productDetail',
         'targetInventory.product.productDetails',
         'targetInventory.product.productDetails.childProductDetail'
       ]
@@ -485,56 +490,41 @@ export class UnloadingWorksheetController extends VasWorksheetController {
     const returnOrder: ReturnOrder = worksheet.returnOrder
     const targetInventory: OrderInventory = worksheetDetail.targetInventory
     const product: Product = Boolean(arrivalNotice) ? targetProduct.product : targetInventory.product
+    let productDetail: ProductDetail = Boolean(arrivalNotice)
+      ? targetProduct.productDetail
+      : targetInventory.productDetail
     const packingType: string = Boolean(arrivalNotice) ? targetProduct.packingType : targetInventory.packingType
     const packingSize: number = Boolean(arrivalNotice) ? targetProduct.packingSize : targetInventory.packingSize
     const batchId: string = Boolean(arrivalNotice) ? targetProduct.batchId : targetInventory.batchId
-    let qty: number = 0
+    let qty: number = 1
     let uom: string = Boolean(arrivalNotice) ? targetProduct.uom : targetInventory.uom
     const cartonId: string = inventory.cartonId
     const orderId: string = Boolean(arrivalNotice) ? arrivalNotice.id : returnOrder.id
     await this.checkCartonDuplication(cartonId, orderId)
+    let matchingProduct
 
-    // search for matching product barcode
-    const productDetails: ProductDetail[] = product?.productDetails.filter(detail => !detail.deletedAt)
-    const isMatchingBarcode: boolean = productDetails.map(detail => detail.gtin).includes(productBarcode)
-    if (!isMatchingBarcode) throw new Error(this.ERROR_MSG.FIND.NO_RESULT(productBarcode))
-
-    // case for scanning parent packing type, packing size
-    const foundProductDetail: ProductDetail = productDetails.find(
-      (detail: ProductDetail) =>
-        detail.gtin === productBarcode && detail.packingType === packingType && detail.packingSize == packingSize
+    matchingProduct = await this.getDirectQty(
+      {
+        ...productDetail,
+        product: targetInventory?.product
+      },
+      productBarcode,
+      qty
     )
 
-    if (!foundProductDetail) {
-      const orderProductDetail: ProductDetail = productDetails.find(
-        (parentDetail: ProductDetail) =>
-          parentDetail.packingType === packingType && parentDetail.packingSize == packingSize
-      )
-      if (!orderProductDetail)
-        throw new Error(
-          this.ERROR_MSG.FIND.NO_RESULT(`Packing Type ( ${packingType}) or Packing Size (${packingSize})`)
-        )
+    //validate matching product details based on scanned barcode
+    if (!matchingProduct) throw new Error(this.ERROR_MSG.FIND.NO_RESULT(productBarcode))
 
-      if (arrivalNotice) {
-        uom = targetProduct.uom
-      } else {
-        uom = orderProductDetail.uom
-      }
-      qty = await this.getChildQty(productDetails, productBarcode, orderProductDetail)
-    } else {
-      uom = foundProductDetail.uom
-      qty++
-    }
+    qty = matchingProduct.qty
+    uom = arrivalNotice ? targetProduct.uom : matchingProduct.uom
 
-    const invQb: SelectQueryBuilder<Inventory> = await this.trxMgr
+    const invQb: SelectQueryBuilder<Inventory> = this.trxMgr
       .getRepository(Inventory)
       .createQueryBuilder('INV')
       .where('INV.domain_id = :domainId', { domainId: this.domain.id })
       .andWhere('INV.bizplace_id = :bizplaceId', { bizplaceId: bizplace.id })
-      .andWhere('INV.product_id = :productId', { productId: product.id })
+      .andWhere('INV.product_detail_id = :productDetailId', { productDetailId: productDetail.id })
       .andWhere('INV.batch_id = :batchId', { batchId: batchId })
-      .andWhere('INV.packing_type = :packingType', { packingType: packingType })
-      .andWhere('INV.packing_size = :packingSize', { packingSize: packingSize })
 
     if (arrivalNotice) invQb.andWhere('INV.ref_order_id = :arrivalNoticeId', { arrivalNoticeId: arrivalNotice.id })
     else if (returnOrder) invQb.andWhere('INV.ref_order_id = :returnOrderId', { returnOrderId: returnOrder.id })
@@ -574,6 +564,7 @@ export class UnloadingWorksheetController extends VasWorksheetController {
       newInventory.batchId = batchId
       newInventory.batchIdRef = batchIdRef
       newInventory.product = product
+      newInventory.productDetail = productDetail
       newInventory.packingType = packingType
       newInventory.packingSize = packingSize
       newInventory.uom = uom
@@ -627,13 +618,16 @@ export class UnloadingWorksheetController extends VasWorksheetController {
               : targetInventory.returnUomValue / targetInventory.returnQty) *
             100
         ) / 100
+      foundInventory.productDetail = productDetail
       if (arrivalNotice) targetProduct.actualPackQty = targetProduct.actualPackQty + qty
       else if (returnOrder) targetInventory.actualPackQty = targetInventory.actualPackQty + qty
+
       await this.trxMgr.getRepository(Inventory).save(foundInventory)
     }
 
     if (arrivalNotice) {
       targetProduct.updater = this.user
+      targetProduct.productDetail = productDetail
       this.updateOrderTargets([targetProduct])
     } else if (returnOrder) {
       targetInventory.updater = this.user
@@ -656,8 +650,10 @@ export class UnloadingWorksheetController extends VasWorksheetController {
         'worksheet.bufferLocation.warehouse',
         'targetProduct',
         'targetProduct.product',
+        'targetProduct.productDetail',
         'targetInventory',
-        'targetInventory.product'
+        'targetInventory.product',
+        'targetInventory.productDetail'
       ]
     })
     if (!worksheetDetail) throw new Error(this.ERROR_MSG.FIND.NO_RESULT(worksheetDetailName))
@@ -668,9 +664,7 @@ export class UnloadingWorksheetController extends VasWorksheetController {
     const returnOrder: ReturnOrder = worksheet.returnOrder
     const targetProduct: OrderProduct = worksheetDetail.targetProduct
     const targetInventory: OrderInventory = worksheetDetail.targetInventory
-    const product: Product = Boolean(arrivalNotice) ? targetProduct.product : targetInventory.product
-    const packingType: string = Boolean(arrivalNotice) ? targetProduct.packingType : targetInventory.packingType
-    const packingSize: number = Boolean(arrivalNotice) ? targetProduct.packingSize : targetInventory.packingSize
+    const productDetail: Product = Boolean(arrivalNotice) ? targetProduct.productDetail : targetInventory.productDetail
     const batchId: string = Boolean(arrivalNotice) ? targetProduct.batchId : targetInventory.batchId
 
     const invQb: SelectQueryBuilder<Inventory> = await this.trxMgr
@@ -678,10 +672,8 @@ export class UnloadingWorksheetController extends VasWorksheetController {
       .createQueryBuilder('INV')
       .where('INV.domain_id = :domainId', { domainId: this.domain.id })
       .andWhere('INV.bizplace_id = :bizplaceId', { bizplaceId: bizplace.id })
-      .andWhere('INV.product_id = :productId', { productId: product.id })
+      .andWhere('INV.product_detail_id = :productDetailId', { productDetailId: productDetail.id })
       .andWhere('INV.batch_id = :batchId', { batchId: batchId })
-      .andWhere('INV.packing_type = :packingType', { packingType: packingType })
-      .andWhere('INV.packing_size = :packingSize', { packingSize: packingSize })
 
     if (arrivalNotice) invQb.andWhere('INV.ref_order_id = :arrivalNoticeId', { arrivalNoticeId: arrivalNotice.id })
     else if (returnOrder) invQb.andWhere('INV.ref_order_id = :returnOrderId', { returnOrderId: returnOrder.id })
@@ -714,7 +706,7 @@ export class UnloadingWorksheetController extends VasWorksheetController {
       const inventoryId: string = inventoryIds[i]
       let inventory: Inventory = await this.trxMgr.getRepository(Inventory).findOne({
         where: { domain: this.domain, id: inventoryId },
-        relations: ['location', 'product']
+        relations: ['location', 'product', 'productDetail']
       })
 
       this.checkRecordValidity(inventory, {
@@ -744,14 +736,11 @@ export class UnloadingWorksheetController extends VasWorksheetController {
       if (orderType === ORDER_TYPES.ARRIVAL_NOTICE) {
         arrivalNotice = await this.trxMgr.getRepository(ArrivalNotice).findOne({
           where: { domain: this.domain, name: orderNo },
-          relations: ['orderProducts', 'orderProducts.product']
+          relations: ['orderProducts', 'orderProducts.product', 'orderProducts.productDetail']
         })
 
         targetProduct = arrivalNotice.orderProducts.find(
-          op =>
-            op.batchId == inventory.batchId &&
-            op.packingType == inventory.packingType &&
-            op.product.id === inventory.product.id
+          op => op.batchId == inventory.batchId && op.productDetail.id == inventory.productDetail.id
         )
 
         if (inventory.status == INVENTORY_STATUS.UNLOADED) {
@@ -770,18 +759,17 @@ export class UnloadingWorksheetController extends VasWorksheetController {
         worksheetDetail = await this.trxMgr
           .getRepository(WorksheetDetail)
           .findOne({ where: { domain: this.domain, targetProduct } })
+
+        //remove all related serial numbers
+        await this.trxMgr.getRepository(InventoryItem).delete({ inventory: inventoryId })
       } else {
         returnOrder = await this.trxMgr.getRepository(ReturnOrder).findOne({
           where: { domain: this.domain, name: orderNo },
-          relations: ['orderInventories', 'orderInventories.inventory', 'orderInventories.product']
+          relations: ['orderInventories', 'orderInventories.inventory', 'orderInventories.productDetail']
         })
 
         targetInventory = returnOrder.orderInventories.find(
-          oi =>
-            oi.batchId == inventory.batchId &&
-            oi.packingType == inventory.packingType &&
-            oi.product.id == inventory.product.id &&
-            oi.packingSize === inventory.packingSize
+          oi => oi.batchId == inventory.batchId && oi.productDetail.id == inventory.productDetail.id
         )
         if (inventory.status == INVENTORY_STATUS.UNLOADED) {
           targetInventory.actualPackQty -= qty

package/server/controllers/inspect/cycle-count-worksheet-controller.ts

@@ -103,16 +103,14 @@ export class CycleCountWorksheetController extends WorksheetController {
         let keyval = {
           batchId: 'batch_id',
           batchIdRef: 'batch_id_ref',
-          packingType: 'packing_type',
-          packingSize: 'packing_size',
-          productId: 'product_id'
+          productDetailId: 'product_detail_id'
         }
 
         qb.andWhere(
           new Brackets(qb => {
             orderInventory.forEach((itm, idx) => {
               // sample itm value
-              // batchId: 'WO00019730', batchIdRef: null, packingType: 'CARBOY', packingSize: 1, productId: '1d679587-c713-42d6-bd0a-74e587e39cc7'
+              // batchId: 'WO00019730', batchIdRef: null, productDetailId: '1d679587-c713-42d6-bd0a-74e587e39cc7'
               qb.orWhere(
                 new Brackets(qb2 => {
                   let first = true

package/server/controllers/outbound/loading-worksheet-controller.ts

@@ -12,11 +12,16 @@ import {
   OrderToteItem,
   ReleaseGood
 } from '@things-factory/sales-base'
-import { Inventory, INVENTORY_TRANSACTION_TYPE, Tote, TOTE_STATUS } from '@things-factory/warehouse-base'
+import {
+  generateInventoryHistory,
+  Inventory,
+  INVENTORY_TRANSACTION_TYPE,
+  Tote,
+  TOTE_STATUS
+} from '@things-factory/warehouse-base'
 
 import { WORKSHEET_STATUS, WORKSHEET_TYPE } from '../../constants'
 import { Worksheet, WorksheetDetail } from '../../entities'
-import { generateInventoryHistory } from '../../utils'
 import { VasWorksheetController } from '../vas/vas-worksheet-controller'
 
 export class LoadingWorksheetController extends VasWorksheetController {
@@ -48,7 +53,7 @@ export class LoadingWorksheetController extends VasWorksheetController {
       { domain: this.domain, name: releaseGoodNo },
       ['bizplace']
     )
-    return await this.updateWorksheet(
+    return await this.updateLoadWorksheet(
       WORKSHEET_TYPE.LOADING,
       releaseGood,
       worksheet,
@@ -114,9 +119,13 @@ export class LoadingWorksheetController extends VasWorksheetController {
         WORKSHEET_TYPE.LOADING,
         [
           'worksheet',
+
           'targetInventory',
+
           'targetInventory.inventory',
+
           'targetInventory.product',
+          'targetInventory.productDetail',
           'targetInventory.orderProduct'
         ]
       )
@@ -176,6 +185,7 @@ export class LoadingWorksheetController extends VasWorksheetController {
         newTargetInventory.releaseQty = remainQty
         newTargetInventory.releaseUomValue = remainUomValue
         newTargetInventory.product = targetInventory.product
+        newTargetInventory.productDetail = targetInventory.productDetail
         newTargetInventory.packingType = targetInventory.packingType
         newTargetInventory.batchId = targetInventory.batchId
         newTargetInventory.orderProduct = targetInventory.orderProduct

package/server/controllers/outbound/packing-worksheet-controller.ts

@@ -2,7 +2,7 @@ import { Equal, Not } from 'typeorm'
 
 import { ApplicationType } from '@things-factory/auth-base'
 import { Sellercraft, SellercraftStatus } from '@things-factory/integration-sellercraft'
-import { Product, ProductDetail } from '@things-factory/product-base'
+import { Product, ProductDetail, ProductBarcode } from '@things-factory/product-base'
 import { logger } from '@things-factory/env'
 import { ORDER_INVENTORY_STATUS, ORDER_STATUS, OrderInventory, ReleaseGood } from '@things-factory/sales-base'
 import { Setting } from '@things-factory/setting-base'
@@ -141,13 +141,15 @@ export class PackingWorksheetController extends VasWorksheetController {
         'targetInventory.releaseGood',
         'targetInventory.inventory',
         'targetInventory.inventory.location',
-        'targetInventory.product'
+        'targetInventory.product',
+        'targetInventory.productDetail'
       ]
     )
-    const releaseGood: ReleaseGood = worksheetDetail.targetInventory.releaseGood
     let targetInventory: OrderInventory = worksheetDetail.targetInventory
-    const product: Product = targetInventory.product
     let inventory: Inventory = targetInventory.inventory
+    const releaseGood: ReleaseGood = worksheetDetail.targetInventory.releaseGood
+    const product: Product = targetInventory.product
+    const productDetail: ProductDetail = targetInventory.productDetail
     const pickedQty: number = targetInventory.releaseQty
 
     if (packedQty > pickedQty) {
@@ -162,8 +164,7 @@ export class PackingWorksheetController extends VasWorksheetController {
         }
 
         let foundSerialNumber: InventoryItem = await this.trxMgr.getRepository(InventoryItem).findOne({
-          where: { domain: this.domain, serialNumber: serialNumber, product },
-          relations: ['product', 'inventory']
+          where: { domain: this.domain, serialNumber: serialNumber, productDetail }
         })
 
         if (foundSerialNumber) {
@@ -187,6 +188,7 @@ export class PackingWorksheetController extends VasWorksheetController {
           inventoryItem.source = INVENTORY_ITEM_SOURCE.OUTBOUND
           inventoryItem.outboundOrderId = releaseGood.id
           inventoryItem.product = product
+          inventoryItem.productDetail = productDetail
           inventoryItem.inventory = inventory
           inventoryItem.domain = this.domain
 
@@ -233,47 +235,39 @@ export class PackingWorksheetController extends VasWorksheetController {
       .innerJoinAndSelect('oi.releaseGood', 'rg')
       .innerJoinAndSelect('oi.inventory', 'inv')
       .leftJoinAndSelect('oi.orderProduct', 'op')
-      .innerJoinAndSelect('inv.product', 'prd')
-      .leftJoinAndSelect(
-        'prd.productDetails',
-        'pd',
-        'pd.product_id = oi.product_id AND pd.deleted_at is null AND pd.packing_type = oi.packing_type AND pd.packing_size = oi.packing_size AND pd.uom = oi.uom'
-      )
+      .innerJoinAndSelect('oi.product', 'prd')
+      .innerJoinAndSelect('oi.productDetail', 'pd')
+      .innerJoinAndSelect('pd.productBarcodes', 'pb')
       .where('wd.id = :id', { id: worksheetDetailName })
-      .andWhere('wd.type = :type', { type: WORKSHEET_TYPE.PACKING })
       .getOne()
 
-    const releaseGood: ReleaseGood = worksheetDetail.targetInventory.releaseGood
-    const product: Product = worksheetDetail.targetInventory.inventory.product
-    const filterProductDetails: ProductDetail[] = product?.productDetails.filter(detail => !detail.deletedAt)
     let targetInventory: OrderInventory = worksheetDetail.targetInventory
     let inventory: Inventory = targetInventory.inventory
     let packedQty: number = 1
     let pickedQty: number = targetInventory.releaseQty
+    const releaseGood: ReleaseGood = targetInventory.releaseGood
+    const product: Product = targetInventory.product
+    const productDetail: ProductDetail = targetInventory.productDetail
+    const productBarcodes: [ProductBarcode] = productDetail.productBarcodes
+    let matchingProduct
 
-    // search for matching product barcode
-    const productDetail: ProductDetail = product?.productDetails
-      .filter(detail => !detail.deletedAt)
-      .find(
-        detail =>
-          detail.gtin === productBarcode &&
-          detail.packingType === inventory.packingType &&
-          detail.packingSize === inventory.packingSize
-      )
+    if (!productBarcodes.find(itm => itm.gtin == productBarcode) && product?.isRequireSerialNumberScanningOutbound) {
+      throw new Error(this.ERROR_MSG.FIND.NO_RESULT(productBarcode))
+    }
 
-    if (!productDetail && !product?.isRequireSerialNumberScanningOutbound) {
-      let roProductDetail: ProductDetail = product?.productDetails.find(
-        (parentDetail: ProductDetail) =>
-          parentDetail.packingType === inventory.packingType && parentDetail.packingSize == inventory.packingSize
-      )
+    matchingProduct = await this.getDirectQty(
+      {
+        ...productDetail,
+        product: targetInventory?.product
+      },
+      productBarcode,
+      packedQty
+    )
 
-      roProductDetail.product = product
+    //validate matching product details based on scanned barcode
+    if (!matchingProduct) throw new Error(this.ERROR_MSG.FIND.NO_RESULT(productBarcode))
 
-      let childQty = await this.getChildQty(filterProductDetails, productBarcode, roProductDetail)
-      packedQty *= childQty
-    } else if (!productDetail) {
-      throw new Error(this.ERROR_MSG.FIND.NO_RESULT(productBarcode))
-    }
+    packedQty = matchingProduct.qty
 
     if (packedQty + targetInventory.packedQty > pickedQty) {
       throw new Error(this.ERROR_MSG.VALIDITY.CANT_PROCEED_STEP_BY('picking', `over release`))
@@ -288,7 +282,7 @@ export class PackingWorksheetController extends VasWorksheetController {
 
         let foundSerialNumber: InventoryItem = await this.trxMgr
           .getRepository(InventoryItem)
-          .findOne({ where: { domain: this.domain, serialNumber: serialNumber, product } })
+          .findOne({ where: { domain: this.domain, serialNumber: serialNumber, productDetail } })
 
         if (foundSerialNumber) {
           if (foundSerialNumber.inventoryId !== inventory.id) {
@@ -315,6 +309,7 @@ export class PackingWorksheetController extends VasWorksheetController {
           inventoryItem.outboundOrderId = releaseGood.id
           inventoryItem.source = INVENTORY_ITEM_SOURCE.OUTBOUND
           inventoryItem.product = product
+          inventoryItem.productDetail = productDetail
           inventoryItem.inventory = inventory
           inventoryItem.domain = this.domain