@things-factory/worksheet-base 3.7.13 → 3.8.1

package/server/graphql/resolvers/worksheet/picking/activate-picking.ts

@@ -7,7 +7,7 @@ import { MarketplaceOrder } from '@things-factory/marketplace-base'
 import { ORDER_STATUS, ReleaseGood } from '@things-factory/sales-base'
 import { Domain } from '@things-factory/shell'
 
-import { EcommerceController, PickingWorksheetController, SellercraftController } from '../../../../controllers'
+import { EcommerceController, PickingWorksheetController } from '../../../../controllers'
 import { Worksheet } from '../../../../entities'
 
 export const activatePickingResolver = {
@@ -40,11 +40,6 @@ export async function activatePicking(
       .getRepository(Sellercraft)
       .findOne({ domain: worksheet.bizplace.domain, status: SellercraftStatus.ACTIVE })
 
-    if (sellercraft) {
-      const sellercraftCtrl: SellercraftController = new SellercraftController(tx, domain, user)
-      await sellercraftCtrl.initiateOrderShipment(sellercraft, releaseGood)
-    }
-
     if (marketplaceStores?.length && !sellercraft) {
       if (marketplaceStores.some(store => store.isAutoUpdateStockQty)) {
         const worksheetDetails = worksheet.worksheetDetails

package/server/graphql/resolvers/worksheet/picking/complete-picking.ts

@@ -7,6 +7,7 @@ import { MarketplaceStore, MarketplaceTransporter } from '@things-factory/integr
 import { Sellercraft, SellercraftStatus } from '@things-factory/integration-sellercraft'
 import { MarketplaceOrder, MarketplaceOrderItem, MarketplaceOrderShipping } from '@things-factory/marketplace-base'
 import { ORDER_INVENTORY_STATUS, ORDER_STATUS, OrderInventory, ReleaseGood } from '@things-factory/sales-base'
+import { PartnerSetting, Setting } from '@things-factory/setting-base'
 import { Domain } from '@things-factory/shell'
 
 import { WORKSHEET_STATUS, WORKSHEET_TYPE } from '../../../../constants'
@@ -19,7 +20,6 @@ import {
 import { EcommerceController } from '../../../../controllers/ecommerce'
 import { WorksheetController } from '../../../../controllers/worksheet-controller'
 import { Worksheet, WorksheetDetail } from '../../../../entities'
-import { Setting, PartnerSetting } from '@things-factory/setting-base'
 
 export const completePickingResolver = {
   async completePicking(_: any, { releaseGoodNo }, context: any) {
@@ -84,6 +84,7 @@ export async function completePicking(
 
     if (sellercraft) {
       const sellercraftCtrl: SellercraftController = new SellercraftController(tx, domain, user)
+      await sellercraftCtrl.initiateOrderShipment(sellercraft, releaseGood)
       await sellercraftCtrl.initiateOrderDocument(sellercraft, releaseGood)
     } else {
       const companyDomain: Domain = releaseGood.bizplace.company.domain
@@ -192,23 +193,22 @@ export async function completePicking(
     const directActivatePackingWorksheet: Setting = await tx.getRepository(Setting).findOne({
       where: { domain: domain, category: 'id-rule', name: 'enable-direct-activate-packing-worksheet' }
     })
-    const partnerDirectActivatePackingWorksheetSetting: PartnerSetting = await tx.getRepository(PartnerSetting).findOne({
-      where: { setting: directActivatePackingWorksheet, domain: domain, partnerDomain: releaseGood.bizplace?.domain }
-    })
+    const partnerDirectActivatePackingWorksheetSetting: PartnerSetting = await tx
+      .getRepository(PartnerSetting)
+      .findOne({
+        where: { setting: directActivatePackingWorksheet, domain: domain, partnerDomain: releaseGood.bizplace?.domain }
+      })
 
     let packingWorksheet: Worksheet = await packingWSCtrl.generatePackingWorksheet(releaseGoodNo)
 
-    if (
-      directActivatePackingWorksheet != undefined && (directActivatePackingWorksheet.value).toLowerCase() == 'true'
-    ) {
+    if (directActivatePackingWorksheet != undefined && directActivatePackingWorksheet.value.toLowerCase() == 'true') {
       if (partnerDirectActivatePackingWorksheetSetting != undefined) {
-        if ((partnerDirectActivatePackingWorksheetSetting.value).toLowerCase() == 'true')
+        if (partnerDirectActivatePackingWorksheetSetting.value.toLowerCase() == 'true')
           await packingWSCtrl.activatePacking(packingWorksheet.name)
       } else {
         await packingWSCtrl.activatePacking(packingWorksheet.name)
       }
     }
-
   } else {
     // Find Existing Loading Worksheet if any
     let existLoadingWorksheet: Worksheet = await tx.getRepository(Worksheet).findOne({
@@ -232,8 +232,7 @@ export async function completePicking(
 
       const loadingWorksheetDetails: WorksheetDetail[] = loadingWorksheet.worksheetDetails
       await loadingWSCtrl.activateLoading(loadingWorksheet.name, loadingWorksheetDetails)
-    }
-    else {
+    } else {
       const loadingWSCtrl: LoadingWorksheetController = new LoadingWorksheetController(tx, domain, user)
       let loadingWorksheet: Worksheet = await loadingWSCtrl.updateLoadingWorksheet(
         releaseGoodNo,

package/server/graphql/resolvers/worksheet/recommend-putway-location.ts

@@ -1,8 +1,10 @@
+import { getRepository, In } from 'typeorm'
+
 import { ArrivalNotice, ReturnOrder } from '@things-factory/sales-base'
 import { Setting } from '@things-factory/setting-base'
 import { Domain } from '@things-factory/shell'
 import { Location, LOCATION_STATUS, LOCATION_TYPE, Warehouse } from '@things-factory/warehouse-base'
-import { In, getRepository, Not } from 'typeorm'
+
 import { WORKSHEET_STATUS, WORKSHEET_TYPE } from '../../../constants'
 import { Worksheet, WorksheetDetail } from '../../../entities'
 
@@ -69,7 +71,7 @@ export async function recommendLocationLevel1(
       domain,
       warehouse,
       status: LOCATION_STATUS.EMPTY,
-      type: Not(In([LOCATION_TYPE.BUFFER, LOCATION_TYPE.BIN]))
+      type: In([LOCATION_TYPE.SHELF, LOCATION_TYPE.FLOOR]) // should only recommend these types
     },
     order,
     take: optCnt

package/server/graphql/resolvers/worksheet/unloaded-inventories.ts

@@ -32,7 +32,7 @@ export const unloadedInventories = {
     const returnOrder: ReturnOrder = foundWorksheetDetails[0].worksheet.returnOrder
     const customerBizplace: Bizplace = foundWorksheetDetails[0].bizplace
     if (arrivalNotice) {
-      return await getRepository(Inventory).find({
+      let foundInv = await getRepository(Inventory).find({
         where: {
           domain,
           bizplace: customerBizplace,
@@ -44,6 +44,15 @@ export const unloadedInventories = {
         },
         relations: ['reusablePallet', 'product', 'bizplace']
       })
+      const items = foundInv.map((inv: Inventory) => {
+        const expirationDate: Date = inv.expirationDate ? new Date(inv.expirationDate) : null
+        return {
+          ...inv,
+          expirationDate: expirationDate
+        }
+      })
+
+      return items
     }
 
     if (returnOrder) {

package/server/utils/inventory-util.ts

@@ -115,8 +115,6 @@ export async function generateInventoryHistory(
   inventoryHistory.uom = inventory.uom
   inventoryHistory.qty = qty
   inventoryHistory.openingQty = openingQty
-  inventoryHistory.weight = 0
-  inventoryHistory.openingWeight = 0
   inventoryHistory.uomValue = uomValue
   inventoryHistory.openingUomValue = openingUomValue
   inventoryHistory.unitCost = inventory.unitCost