@things-factory/worklist 10.1.44 → 10.1.46

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@things-factory/worklist",
-  "version": "10.1.44",
+  "version": "10.1.46",
   "main": "dist-server/index.js",
   "browser": "dist-client/index.js",
   "things-factory": true,
@@ -37,14 +37,14 @@
     "@operato/moment-timezone-es": "^10.0.0",
     "@operato/p13n": "^10.0.0",
     "@operato/popup": "^10.15.0",
-    "@things-factory/attachment-base": "^10.1.44",
-    "@things-factory/auth-base": "^10.1.44",
-    "@things-factory/board-service": "^10.1.44",
-    "@things-factory/context-ui": "^10.1.44",
-    "@things-factory/organization": "^10.1.44",
-    "@things-factory/personalization": "^10.1.44",
-    "@things-factory/scheduler-client": "^10.1.44",
-    "@things-factory/shell": "^10.1.44"
+    "@things-factory/attachment-base": "^10.1.46",
+    "@things-factory/auth-base": "^10.1.46",
+    "@things-factory/board-service": "^10.1.46",
+    "@things-factory/context-ui": "^10.1.46",
+    "@things-factory/organization": "^10.1.46",
+    "@things-factory/personalization": "^10.1.46",
+    "@things-factory/scheduler-client": "^10.1.46",
+    "@things-factory/shell": "^10.1.46"
   },
-  "gitHead": "7c95c4e75e155e51c714409e865d96f317232c23"
+  "gitHead": "d3467cde550453f3348fed0ed6c79a12a6ba0db4"
 }

package/tests/person-open-work.test.ts

@@ -0,0 +1,91 @@
+import { join } from 'path'
+
+/**
+ * What a person holds, asked by someone else - through the real resolvers on sqlite.
+ *
+ * The person 360 shows a colleague's open work as counts (ADR-0067, the person 360 ruling; ADR-0091
+ * keeps the cases themselves to the people on them). The counts must be the same answer that person's
+ * own badges give - one rule, `open-work.ts` - and a person who is not a member of this domain gets
+ * no answer at all.
+ */
+
+const { createSqliteTestDataSource } = require(
+  join(__dirname, '..', '..', 'ops-master', 'test', 'support', 'database.cjs')
+)
+const DIST = join(__dirname, '..', 'dist-server')
+const { ActivityInstance } = require(join(DIST, 'service', 'activity-instance', 'activity-instance.js'))
+const { ActivityThread } = require(join(DIST, 'service', 'activity-thread', 'activity-thread.js'))
+const { ActivityApproval } = require(join(DIST, 'service', 'activity-approval', 'activity-approval.js'))
+const { PersonOpenWorkQuery } = require(join(DIST, 'service', 'activity-summary', 'person-open-work.js'))
+const { ActivitySummaryQuery } = require(join(DIST, 'service', 'activity-summary', 'activity-summary-query.js'))
+const shell = require('@things-factory/shell')
+const { User } = require('@things-factory/auth-base')
+
+let db: any
+let here: any
+let elsewhere: any
+let viewer: any
+let worker: any
+let stranger: any
+
+const asViewer = () => ({ state: { domain: here, user: viewer }, t: (key: string) => key }) as any
+const asWorker = () => ({ state: { domain: here, user: worker }, t: (key: string) => key }) as any
+const openWork = (userId: string) => new PersonOpenWorkQuery().personOpenWork(userId, asViewer())
+
+beforeAll(async () => {
+  db = createSqliteTestDataSource([ActivityInstance, ActivityThread, ActivityApproval])
+  await db.initialize()
+  shell.addDataSource('default', db)
+
+  here = await db.getRepository(shell.Domain).save({ name: 'here', subdomain: 'here' })
+  elsewhere = await db.getRepository(shell.Domain).save({ name: 'elsewhere', subdomain: 'elsewhere' })
+
+  const person = (name: string, domains: any[]) =>
+    db.getRepository(User).save({ name, email: `${name}@example.com`, password: 'x', status: 'activated', domains })
+
+  viewer = await person('viewer', [here])
+  worker = await person('worker', [here])
+  stranger = await person('stranger', [elsewhere])
+
+  const aCase = (name: string) =>
+    db.getRepository(ActivityInstance).save({ domain: here, name, state: 'issued', issuer: viewer })
+  const instance = await aCase('i')
+
+  /* Two threads the worker holds and one that ended - the ended one is not work. One thread per case and person. */
+  for (const state of ['assigned', 'started', 'ended']) {
+    await db
+      .getRepository(ActivityThread)
+      .save({ domain: here, name: state, round: 1, state, assignee: worker, activityInstance: await aCase(state) })
+  }
+
+  /* One approval waiting on the worker (ActivityApprovalJudgment.Pending is the empty string). */
+  const submitted = await db
+    .getRepository(ActivityThread)
+    .save({ domain: here, name: 's', round: 1, state: 'submitted', activityInstance: instance })
+  await db
+    .getRepository(ActivityApproval)
+    .save({ domain: here, activityThread: submitted, approver: worker, order: 1, round: 1, judgment: '' })
+})
+
+afterAll(async () => db?.destroy())
+
+it('★ counts what a colleague holds - threads not finished and approvals waiting', async () => {
+  const work = await openWork(worker.id)
+  expect(work).toEqual({ toDos: 2, approvalsPending: 1 })
+})
+
+it("★ gives the same numbers the person's own badges give", async () => {
+  const summary = new ActivitySummaryQuery()
+  const work = await openWork(worker.id)
+
+  expect(await summary.numberOfToDos({}, asWorker())).toBe(work.toDos)
+  expect(await summary.numberOfApprovalPendings({}, asWorker())).toBe(work.approvalsPending)
+})
+
+it('★ answers nothing for a person who is not a member of this domain', async () => {
+  expect(await openWork(stranger.id)).toBeNull()
+})
+
+it('holds zero for a member with nothing, which is not the same as no answer', async () => {
+  expect(await openWork(viewer.id)).toEqual({ toDos: 0, approvalsPending: 0 })
+})