@things-factory/worklist 10.1.42 → 10.1.46

package/tests/pick-race.pg.test.ts

@@ -0,0 +1,128 @@
+import { join } from 'path'
+
+/**
+ * Picking the same case at the same moment, on postgres.
+ *
+ * pick read the instance, checked it was issued or unassigned, then made a thread - holding nothing in
+ * between. Runs only when WORKLIST_PG_URL names a postgres server (see discard-versus-issue.pg.test.ts).
+ *
+ * A case waiting for one person must end with one thread, whoever wins; and one person pressing twice
+ * must not hold it twice.
+ */
+
+const url = process.env.WORKLIST_PG_URL
+const maybe = url ? describe : describe.skip
+
+maybe('picking at once, on postgres', () => {
+  const { DataSource } = require('typeorm')
+  const { entityClosure } = require(join(__dirname, '..', '..', 'ops-master', 'test', 'support', 'database.cjs'))
+  const { NamingStrategy } = require('@things-factory/shell/dist-server/initializers/naming-strategy.js')
+  const DIST = join(__dirname, '..', 'dist-server')
+  const { Activity } = require(join(DIST, 'service', 'activity', 'activity.js'))
+  const { ActivityInstance } = require(join(DIST, 'service', 'activity-instance', 'activity-instance.js'))
+  const { ActivityThread } = require(join(DIST, 'service', 'activity-thread', 'activity-thread.js'))
+  const { ActivityApproval } = require(join(DIST, 'service', 'activity-approval', 'activity-approval.js'))
+  const { pick } = require(join(DIST, 'controllers', 'activity-instance', 'pick.js'))
+  const { Domain } = require('@things-factory/shell')
+  const { Role, User } = require('@things-factory/auth-base')
+
+  let db: any
+  let domain: any
+  let role: any
+  let first: any
+  let second: any
+  let activity: any
+
+  beforeAll(async () => {
+    db = new DataSource({
+      type: 'postgres',
+      url,
+      synchronize: true,
+      dropSchema: true,
+      entities: entityClosure([Activity, ActivityInstance, ActivityThread, ActivityApproval]),
+      namingStrategy: new NamingStrategy()
+    })
+    await db.initialize()
+
+    domain = await db.getRepository(Domain).save({ name: 'd', subdomain: 'd' })
+    const person = (name: string) =>
+      db.getRepository(User).save({ name, email: `${name}@example.com`, password: 'x', status: 'activated', domains: [domain] })
+    first = await person('first')
+    second = await person('second')
+    role = await db.getRepository(Role).save({ domain, name: 'pickers', users: [first, second] })
+    activity = await db.getRepository(Activity).save({ domain, name: 'pick', activityType: 'standard', startingType: 'issue' })
+  }, 60000)
+
+  afterAll(async () => db?.destroy())
+
+  const as = (user: any) => (tx: any) => ({ state: { domain, user, tx }, t: (key: string) => key }) as any
+
+  const aCase = (round: number) =>
+    db.getRepository(ActivityInstance).save({
+      domain,
+      name: `p${round}`,
+      state: 'issued',
+      activity,
+      assigneeRole: role,
+      threadsMin: 1,
+      threadsMax: 1
+    })
+
+  const threadsOf = (instance: any) => db.getRepository(ActivityThread).count({ where: { activityInstance: { id: instance.id } } })
+
+  it('two people picking a case that waits for one: one thread, the other refused', async () => {
+    const endings: string[] = []
+
+    for (let round = 0; round < 20; round++) {
+      const instance = await aCase(round)
+
+      const results = await Promise.allSettled([
+        db.transaction((tx: any) => pick(instance.id, as(first)(tx))),
+        db.transaction((tx: any) => pick(instance.id, as(second)(tx)))
+      ])
+
+      const won = results.filter(one => one.status === 'fulfilled').length
+      endings.push(`${won} won, ${await threadsOf(instance)} threads`)
+
+      expect(await threadsOf(instance)).toBe(1)
+      expect(won).toBe(1)
+    }
+
+    console.log('endings', [...new Set(endings)].join(' · '))
+  }, 120000)
+
+  it('one person pressing twice holds the case once', async () => {
+    for (let round = 0; round < 20; round++) {
+      const instance = await aCase(100 + round)
+
+      await Promise.allSettled([
+        db.transaction((tx: any) => pick(instance.id, as(first)(tx))),
+        db.transaction((tx: any) => pick(instance.id, as(first)(tx)))
+      ])
+
+      expect(await threadsOf(instance)).toBe(1)
+    }
+  }, 120000)
+
+  it('a case waiting for two lets two people in at once', async () => {
+    for (let round = 0; round < 10; round++) {
+      const instance = await db.getRepository(ActivityInstance).save({
+        domain,
+        name: `two${round}`,
+        state: 'issued',
+        activity,
+        assigneeRole: role,
+        threadsMin: 2,
+        threadsMax: 2
+      })
+
+      const results = await Promise.allSettled([
+        db.transaction((tx: any) => pick(instance.id, as(first)(tx))),
+        db.transaction((tx: any) => pick(instance.id, as(second)(tx)))
+      ])
+
+      expect(results.map(one => one.status)).toEqual(['fulfilled', 'fulfilled'])
+      expect(await threadsOf(instance)).toBe(2)
+    }
+  }, 120000)
+})

package/translations/en.json

@@ -38,6 +38,9 @@
   "error.activity-instance is addressed to another role": "{id} is assigned to another role. only someone with that role can pick it.",
   "error.activity-instance is already issued": "this task ({id}) has already been issued with the {state} status.",
   "error.activity-instance is already terminated": "this task ({id}) has already been terminated with the {state} status.",
+  "error.activity-instance approval line is set": "this task already has its approval line; it is set on the task's detail screen.",
+  "error.activity-instance assignee not in this domain": "these are not people of this site: {emails}",
+  "error.activity-instance draft is gone": "this draft went out or was thrown away in the meantime. please read the list again.",
   "error.activity-instance not found": "this task ({activityInstance}) cannot be found.",
   "error.activity-instance not a draft any more": "this draft has already gone out, so it cannot be thrown away.",
   "error.activity-instance should not be assigned": "this task ({id}) is already in {actual} status and cannot be assigned.",

package/translations/ja.json

@@ -38,6 +38,9 @@
   "error.activity-instance is addressed to another role": "{id} は別の役割に割り当てられた業務です。その役割を持つ人だけが選択できます。",
   "error.activity-instance is already issued": "このタスク({id})はすでに{state}状態で発行されています。",
   "error.activity-instance is already terminated": "このタスク({id})はすでに{state}状態で終了しています。",
+  "error.activity-instance approval line is set": "この業務は決裁ラインが決まっています。決裁ラインは業務詳細で変更します。",
+  "error.activity-instance assignee not in this domain": "このサイトの人ではありません: {emails}",
+  "error.activity-instance draft is gone": "この下書きはその間に発行されたか破棄されました。一覧を読み直してください。",
   "error.activity-instance not found": "このタスク({activityInstance})が見つかりません。",
   "error.activity-instance not a draft any more": "この下書きはすでに発行されたため、破棄できません。",
   "error.activity-instance should not be assigned": "このタスク({id})はすでに{actual}状態のため、割り当てできません。",

package/translations/ko.json

@@ -38,6 +38,9 @@
   "error.activity-instance is addressed to another role": "{id} 는 다른 역할에 할당된 업무입니다. 그 역할을 가진 사람만 선택할 수 있습니다.",
   "error.activity-instance is already issued": "이 작업({id})은 이미 {state} 상태로 제기되었습니다.",
   "error.activity-instance is already terminated": "이 작업({id})는 이미 {state} 상태로 종료되었습니다.",
+  "error.activity-instance approval line is set": "이 업무는 결재선이 정해져 있습니다. 결재선은 업무 상세에서 바꿉니다.",
+  "error.activity-instance assignee not in this domain": "이 사업장 사람이 아닙니다: {emails}",
+  "error.activity-instance draft is gone": "이 초안은 그사이 발행되었거나 버려졌습니다. 목록을 새로 읽어 주십시오.",
   "error.activity-instance not found": "이 작업({activityInstance})을 찾을 수 없습니다.",
   "error.activity-instance not a draft any more": "이 초안은 이미 발행되어 버릴 수 없습니다.",
   "error.activity-instance should not be assigned": "이 작업({id})은 이미 {actual} 상태로 할당할 수 없습니다.",

package/translations/ms.json

@@ -38,6 +38,9 @@
   "error.activity-instance is addressed to another role": "{id} ditugaskan kepada peranan lain. hanya orang yang memegang peranan itu boleh memilihnya.",
   "error.activity-instance is already issued": "Tugas ini ({id}) telah dikeluarkan dengan status {state}.",
   "error.activity-instance is already terminated": "Tugas ini ({id}) telah tamat dengan status {state}.",
+  "error.activity-instance approval line is set": "tugas ini sudah mempunyai laluan kelulusan; ia ditetapkan pada skrin butiran tugas.",
+  "error.activity-instance assignee not in this domain": "ini bukan orang dalam domain ini: {emails}",
+  "error.activity-instance draft is gone": "draf ini telah dikeluarkan atau dibuang sementara itu. sila baca senarai semula.",
   "error.activity-instance not found": "Tugas ini ({activityInstance}) tidak dijumpai.",
   "error.activity-instance not a draft any more": "draf ini sudah dikeluarkan, jadi ia tidak boleh dibuang.",
   "error.activity-instance should not be assigned": "Tugas ini ({id}) sudah berada dalam status {actual} dan tidak boleh diberikan.",

package/translations/zh.json

@@ -38,6 +38,9 @@
   "error.activity-instance is addressed to another role": "{id} 已分配给其他角色。只有拥有该角色的人员才能选择。",
   "error.activity-instance is already issued": "此任务({id})已被以{state}状态提出。",
   "error.activity-instance is already terminated": "此任务({id})已以{state}状态终止。",
+  "error.activity-instance approval line is set": "此业务已设定审批线，请在业务详情中修改。",
+  "error.activity-instance assignee not in this domain": "以下不是本站点的人员：{emails}",
+  "error.activity-instance draft is gone": "此草稿在此期间已发布或已丢弃，请重新读取列表。",
   "error.activity-instance not found": "未找到此任务({activityInstance})。",
   "error.activity-instance not a draft any more": "此草稿已发布，无法丢弃。",
   "error.activity-instance should not be assigned": "此任务({id})已处于{actual}状态，无法分配。",