@things-factory/worklist 10.1.29 → 10.1.31

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@things-factory/worklist",
-  "version": "10.1.29",
+  "version": "10.1.31",
   "main": "dist-server/index.js",
   "browser": "dist-client/index.js",
   "things-factory": true,
@@ -37,14 +37,14 @@
     "@operato/moment-timezone-es": "^10.0.0",
     "@operato/p13n": "^10.0.0",
     "@operato/popup": "^10.15.0",
-    "@things-factory/attachment-base": "^10.1.29",
-    "@things-factory/auth-base": "^10.1.29",
-    "@things-factory/board-service": "^10.1.29",
-    "@things-factory/context-ui": "^10.1.29",
-    "@things-factory/organization": "^10.1.29",
-    "@things-factory/personalization": "^10.1.29",
-    "@things-factory/scheduler-client": "^10.1.29",
-    "@things-factory/shell": "^10.1.29"
+    "@things-factory/attachment-base": "^10.1.31",
+    "@things-factory/auth-base": "^10.1.31",
+    "@things-factory/board-service": "^10.1.31",
+    "@things-factory/context-ui": "^10.1.31",
+    "@things-factory/organization": "^10.1.31",
+    "@things-factory/personalization": "^10.1.31",
+    "@things-factory/scheduler-client": "^10.1.31",
+    "@things-factory/shell": "^10.1.31"
   },
-  "gitHead": "e6bf9dec003fe5e794746aaeb5852b3b50478232"
+  "gitHead": "5213e6f9913b40ea2618a2111d9884b792dbaa01"
 }

package/tests/pass-work-door.test.ts

@@ -0,0 +1,133 @@
+/**
+ * Which way a work door goes when its approval line is empty, and what gets written down.
+ *
+ * ── Why each of these ─────────────────────────────────────────────────────
+ * The branch itself was never in one place before: eight doors in operato-plant each read the line
+ * and decided, and none of them wrote anything, so a step skipped for want of an approver left no
+ * trace at all. Joined here, `run` cannot happen without the line being written - so the test that
+ * matters most is that the `run` branch writes exactly one row, with the reason that applies.
+ *
+ * The transaction check is not ceremony: a plain manager commits the row on its own, and then the
+ * log says something happened that the failing work never did.
+ */
+
+/*
+ * The entity is stood in for. Its decorators need `emitDecoratorMetadata`, which babel does not
+ * give jest (the repository's jest config says so, and says to test the pure logic on its own). The
+ * branch under test never reads the class - it only names the repository to save into.
+ */
+jest.mock('../server/service/work-door/work-door-journal.js', () => ({ WorkDoorJournal: class WorkDoorJournal {} }))
+
+import { WorkDoorEvent } from '../server/service/work-door/work-door-event.js'
+import { passWorkDoor } from '../server/service/work-door/pass-work-door.js'
+
+const domain = { id: 'd1' } as any
+
+/** A manager that looks transactional and remembers what was saved. */
+function openTx() {
+  const saved: any[] = []
+
+  return {
+    saved,
+    queryRunner: { isTransactionActive: true },
+    getRepository: () => ({ save: async (row: any) => ((saved.push(row), { ...row, id: 'j1' }) as any) })
+  } as any
+}
+
+const seatsThatStand = { roleHasMembers: async () => true, personIsHere: async () => true }
+
+const approvalDoor = (over: any = {}): any =>
+  ({ name: 'lot-hold-release', labelKey: 'activity.lot-hold-release.label', kind: 'approval', whenNoLine: 'run', ...over } as any)
+
+const subject = { kind: 'lot', id: 'LOT-1' }
+
+describe('passWorkDoor', () => {
+  it('refuses to run outside a transaction - the row would commit on its own', async () => {
+    const loose = { getRepository: () => ({ save: async (r: any) => r }) } as any
+
+    await expect(
+      passWorkDoor({ door: approvalDoor(), subject }, { tx: loose, domain, seats: seatsThatStand })
+    ).rejects.toThrow(/transaction/)
+  })
+
+  it('will not judge an assignment door - it waits for a role, not for a line', async () => {
+    const door = { name: 'job-order-dispatch', labelKey: 'k', kind: 'assignment' } as any
+
+    await expect(passWorkDoor({ door, subject }, { tx: openTx(), domain, seats: seatsThatStand })).rejects.toThrow(
+      /assignment door/
+    )
+  })
+
+  it('raises when the line stands, and writes nothing - the instance is the record', async () => {
+    const tx = openTx()
+    const activity = { approvalLine: [{ type: 'Role', value: 'r1' }] }
+
+    const verdict = await passWorkDoor({ door: approvalDoor(), activity, subject }, { tx, domain, seats: seatsThatStand })
+
+    expect(verdict.go).toBe('raise')
+    expect(tx.saved).toHaveLength(0)
+  })
+
+  it('runs with an empty line, and that is written down once', async () => {
+    const tx = openTx()
+
+    const verdict = await passWorkDoor({ door: approvalDoor(), subject }, { tx, domain, seats: seatsThatStand })
+
+    expect(verdict).toMatchObject({ go: 'run', because: WorkDoorEvent.RanWithoutLine })
+    expect(tx.saved).toHaveLength(1)
+    expect(tx.saved[0]).toMatchObject({
+      kind: WorkDoorEvent.RanWithoutLine,
+      door: 'lot-hold-release',
+      subjectKind: 'lot',
+      subjectId: 'LOT-1'
+    })
+  })
+
+  it('says so differently when the door was declared unused - the administrator has nothing to fix', async () => {
+    const tx = openTx()
+
+    const verdict = await passWorkDoor({ door: approvalDoor(), subject, notUsed: true }, { tx, domain, seats: seatsThatStand })
+
+    expect(verdict).toMatchObject({ go: 'run', because: WorkDoorEvent.RanNotUsed })
+    expect(tx.saved[0].kind).toBe(WorkDoorEvent.RanNotUsed)
+  })
+
+  it('refuses with the line\'s own reason where the door refuses, and writes nothing', async () => {
+    const tx = openTx()
+    const door = approvalDoor({ whenNoLine: 'refuse', because: 'irreversible' } as any)
+
+    const verdict: any = await passWorkDoor({ door, subject }, { tx, domain, seats: seatsThatStand })
+
+    expect(verdict.go).toBe('refuse')
+    expect(verdict.refusal.code).toBe('approval-line-missing')
+    expect(tx.saved).toHaveLength(0)
+  })
+
+  describe('as-established - the row decides, not the door', () => {
+    const door = approvalDoor({ name: 'non-working-withdrawal', whenNoLine: 'as-established', because: 'approval-is-the-act' } as any)
+
+    it('refuses when the row was established through approval', async () => {
+      const tx = openTx()
+
+      const verdict: any = await passWorkDoor(
+        { door, subject, establishedByApproval: true },
+        { tx, domain, seats: seatsThatStand }
+      )
+
+      expect(verdict.go).toBe('refuse')
+      expect(tx.saved).toHaveLength(0)
+    })
+
+    it('runs when it stood without approval', async () => {
+      const tx = openTx()
+
+      const verdict: any = await passWorkDoor(
+        { door, subject, establishedByApproval: false },
+        { tx, domain, seats: seatsThatStand }
+      )
+
+      expect(verdict.go).toBe('run')
+      expect(tx.saved).toHaveLength(1)
+    })
+  })
+})

package/translations/en.json

@@ -41,6 +41,8 @@
   "error.approval line names a person who cannot be found": "{seats}: the person named for that step cannot be found. name another approver.",
   "error.approval line names a role that nobody holds": "{seats}: nobody holds the role named for that step. add someone to that role.",
   "error.not authorized to handle this task": "you are not authorized to perform this task.",
+  "error.work-door-not-used-reason-missing": "enter why this task is not used.",
+  "error.work-door-unknown": "unknown task \"{name}\". use a task name from the status screen.",
   "field.activity-type": "activity type",
   "field.approval-changed-at": "last change",
   "field.approval-drafter": "submitted by",
@@ -202,6 +204,7 @@
   "label.what-changes": "what changes on approval",
   "label.what-it-was-judged-from": "what it was judged from",
   "label.yes": "yes",
+  "menu.work-doors": "approval and assignment forms",
   "text.activity-activated": "{name} is now on for this domain.",
   "text.activity-change-failed": "{name} was not changed: {why}",
   "text.activity-change-not-allowed": "you are not allowed to change {name}. ask an administrator for the activity privilege.",
@@ -228,6 +231,8 @@
   "text.copy-failed": "could not copy",
   "text.copy-payload": "copy this value as raw json",
   "text.decision-keys-count": "{n} decision key(s)",
+  "text.door-filled-from": "set in {name}",
+  "text.door-form-from": "{name}'s form — it cannot be changed from here",
   "text.draft": "draft",
   "text.due-just-passed": "just passed",
   "text.due-left-in": "{span} left",
@@ -283,6 +288,10 @@
   "text.task_is_saved_successfully": "task is saved successfully",
   "text.task_is_started_successfully": "task is started successfully.",
   "text.timeline-count": "{count} entries",
+  "text.work-doors-lead": "shows whether each approval and assignment step has approvers or receivers. without them, an approval completes as soon as it is raised and an assignment reaches nobody.",
+  "text.work-doors-next-line": "set an approval line on {count} work forms —",
+  "text.work-doors-next-seats": "{standing} of {offered} roles are set up. set up roles first to use them in approval lines —",
+  "text.work-doors-read-failed": "could not read the approval forms.",
   "text.write-your-comment-as-reference": "write your comment.",
   "title.activity": "activity",
   "title.activity application": "activity application",
@@ -324,5 +333,7 @@
   "title.my workspace": "my workspace",
   "title.pick activity": "pick an activity to handle",
   "title.todo list": "to do",
+  "title.work-doors": "approval and assignment forms in this plant",
+  "title.work-doors-next": "What to do next",
   "title.worklist dashboard": "worklist dashboard"
-}
+}

package/translations/ja.json

@@ -41,6 +41,8 @@
   "error.approval line names a person who cannot be found": "{seats} の段階に指定した人が見つかりません。承認者を指定し直してください。",
   "error.approval line names a role that nobody holds": "{seats} の段階に指定した役割に人がいません。その役割に人を追加してください。",
   "error.not authorized to handle this task": "このタスクを処理する権限がありません。",
+  "error.work-door-not-used-reason-missing": "使用しない理由を入力してください。",
+  "error.work-door-unknown": "「{name}」は不明な業務です。状況画面の業務名を使用してください。",
   "field.activity-type": "業務タイプ",
   "field.approval-changed-at": "最終変更",
   "field.approval-drafter": "起案者",
@@ -202,6 +204,7 @@
   "label.what-changes": "承認すると変わること",
   "label.what-it-was-judged-from": "判断の根拠",
   "label.yes": "はい",
+  "menu.work-doors": "承認・割当様式の状況",
   "text.activity-activated": "{name} をこのドメインで使用するようにしました。",
   "text.activity-change-failed": "{name} を変更できませんでした: {why}",
   "text.activity-change-not-allowed": "{name} を変更する権限がありません。管理者に業務活動の権限を依頼してください。",
@@ -228,6 +231,8 @@
   "text.copy-failed": "コピーできません",
   "text.copy-payload": "この値を原文(JSON)でコピーします",
   "text.decision-keys-count": "判断項目 {n}件",
+  "text.door-filled-from": "{name} で設定されています",
+  "text.door-form-from": "{name} のフォームです — ここでは変更できません",
   "text.draft": "ドラフト保存",
   "text.due-just-passed": "過ぎたところ",
   "text.due-left-in": "残り{span}",
@@ -283,6 +288,10 @@
   "text.task_is_saved_successfully": "業務が正常に保存されました。",
   "text.task_is_started_successfully": "業務が正常に開始されました。",
   "text.timeline-count": "{count}件",
+  "text.work-doors-lead": "承認・割当の各段階で承認者と受取人が決まっているかを表示します。決めていないと、承認は申請と同時に承認され、割当は誰にも届きません。",
+  "text.work-doors-next-line": "業務様式 {count}件に承認ラインを指定してください —",
+  "text.work-doors-next-seats": "ロール {offered}件中 {standing}件が設定されています。承認ラインに使うロールを先に設定してください —",
+  "text.work-doors-read-failed": "承認様式の状況を読み込めませんでした。",
   "text.write-your-comment-as-reference": "ご意見をご記入ください。",
   "title.activity": "業務",
   "title.activity application": "業務申込書作成",
@@ -324,5 +333,7 @@
   "title.my workspace": "私の仕事の空間",
   "title.pick activity": "担当する業務を選択",
   "title.todo list": "やること",
+  "title.work-doors": "この工場の承認・割当様式",
+  "title.work-doors-next": "次にすること",
   "title.worklist dashboard": "ワークリストダッシュボード"
-}
+}

package/translations/ko.json

@@ -41,6 +41,8 @@
   "error.approval line names a person who cannot be found": "{seats} 단계에 지정한 사람을 찾을 수 없습니다. 결재자를 다시 지정하십시오.",
   "error.approval line names a role that nobody holds": "{seats} 단계에 지정한 역할에 사람이 없습니다. 그 역할에 사람을 추가하십시오.",
   "error.not authorized to handle this task": "이 작업을 수행할 권한이 없습니다.",
+  "error.work-door-not-used-reason-missing": "쓰지 않는 이유를 입력하십시오.",
+  "error.work-door-unknown": "\"{name}\" 은(는) 알 수 없는 업무입니다. 현황 화면의 업무 이름을 쓰십시오.",
   "field.activity-type": "업무 타입",
   "field.approval-changed-at": "최근 변경",
   "field.approval-drafter": "기안자",
@@ -202,6 +204,7 @@
   "label.what-changes": "승인하면 달라지는 것",
   "label.what-it-was-judged-from": "판단 근거",
   "label.yes": "예",
+  "menu.work-doors": "결재·배정 양식 현황",
   "text.activity-activated": "{name} 을 이 도메인에서 쓰도록 켰습니다.",
   "text.activity-change-failed": "{name} 을 바꾸지 못했습니다: {why}",
   "text.activity-change-not-allowed": "{name} 을 바꿀 권한이 없습니다. 관리자에게 업무 활동 권한을 요청하십시오.",
@@ -228,6 +231,8 @@
   "text.copy-failed": "복사할 수 없습니다",
   "text.copy-payload": "이 값을 원문(JSON)으로 복사합니다",
   "text.decision-keys-count": "판단 항목 {n}개",
+  "text.door-filled-from": "{name} 에서 정했습니다",
+  "text.door-form-from": "{name} 의 양식입니다 — 여기서는 못 고칩니다",
   "text.draft": "초안저장",
   "text.due-just-passed": "방금 지남",
   "text.due-left-in": "{span} 남음",
@@ -283,6 +288,10 @@
   "text.task_is_saved_successfully": "업무가 성공적으로 저장되었습니다.",
   "text.task_is_started_successfully": "업무가 성공적으로 시작되었습니다.",
   "text.timeline-count": "{count}건",
+  "text.work-doors-lead": "승인·배정 단계마다 결재자와 받는 사람이 정해졌는지 보여 줍니다. 정하지 않으면 결재는 올리는 즉시 승인되고, 배정은 아무에게도 가지 않습니다.",
+  "text.work-doors-next-line": "업무 양식 {count}개에 결재선을 지정하십시오 —",
+  "text.work-doors-next-seats": "역할 {offered}개 중 {standing}개가 설정되어 있습니다. 결재선에 쓸 역할을 먼저 설정하십시오 —",
+  "text.work-doors-read-failed": "결재 양식 현황을 읽지 못했습니다.",
   "text.write-your-comment-as-reference": "의견을 적어 주십시오.",
   "title.activity": "업무",
   "title.activity application": "업무 신청서 작성",
@@ -324,5 +333,7 @@
   "title.my workspace": "나의 업무 공간",
   "title.pick activity": "담당할 업무 선택",
   "title.todo list": "할 일",
+  "title.work-doors": "이 공장의 결재·배정 양식",
+  "title.work-doors-next": "다음에 할 일",
   "title.worklist dashboard": "업무실적 대시보드"
-}
+}

package/translations/ms.json

@@ -41,6 +41,8 @@
   "error.approval line names a person who cannot be found": "{seats}: orang yang dinamakan untuk langkah itu tidak ditemui. namakan pelulus lain.",
   "error.approval line names a role that nobody holds": "{seats}: tiada sesiapa memegang peranan untuk langkah itu. tambah seseorang pada peranan itu.",
   "error.not authorized to handle this task": "Anda tidak mempunyai kebenaran untuk melaksanakan tugas ini.",
+  "error.work-door-not-used-reason-missing": "masukkan sebab tugas ini tidak digunakan.",
+  "error.work-door-unknown": "tugas \"{name}\" tidak diketahui. gunakan nama tugas daripada skrin status.",
   "field.activity-type": "jenis aktiviti",
   "field.approval-changed-at": "perubahan terakhir",
   "field.approval-drafter": "dihantar oleh",
@@ -202,6 +204,7 @@
   "label.what-changes": "apa yang berubah selepas kelulusan",
   "label.what-it-was-judged-from": "dasar penilaian",
   "label.yes": "ya",
+  "menu.work-doors": "borang kelulusan dan tugasan",
   "text.activity-activated": "{name} kini dihidupkan untuk domain ini.",
   "text.activity-change-failed": "{name} tidak diubah: {why}",
   "text.activity-change-not-allowed": "anda tiada keizinan untuk mengubah {name}. minta keizinan aktiviti daripada pentadbir.",
@@ -228,6 +231,8 @@
   "text.copy-failed": "tidak dapat menyalin",
   "text.copy-payload": "salin nilai ini sebagai json asal",
   "text.decision-keys-count": "{n} kunci keputusan",
+  "text.door-filled-from": "ditetapkan di {name}",
+  "text.door-form-from": "Borang {name} — tidak boleh diubah dari sini",
   "text.draft": "draf",
   "text.due-just-passed": "baru lewat",
   "text.due-left-in": "tinggal {span}",
@@ -283,6 +288,10 @@
   "text.task_is_saved_successfully": "tugas berjaya disimpan",
   "text.task_is_started_successfully": "tugas berjaya bermula.",
   "text.timeline-count": "{count} rekod",
+  "text.work-doors-lead": "menunjukkan sama ada setiap langkah kelulusan dan tugasan mempunyai pelulus atau penerima. tanpanya, kelulusan selesai sebaik dihantar dan tugasan tidak sampai kepada sesiapa.",
+  "text.work-doors-next-line": "tetapkan laluan kelulusan pada {count} borang kerja —",
+  "text.work-doors-next-seats": "{standing} daripada {offered} peranan telah ditetapkan. tetapkan peranan dahulu untuk digunakan dalam laluan kelulusan —",
+  "text.work-doors-read-failed": "tidak dapat membaca borang kelulusan.",
   "text.write-your-comment-as-reference": "tuliskan komen anda.",
   "title.activity": "perniagaan",
   "title.activity application": "permohonan aktiviti",
@@ -324,5 +333,7 @@
   "title.my workspace": "ruang kerja saya",
   "title.pick activity": "pilih aktiviti untuk dikendalikan",
   "title.todo list": "untuk dibuat",
+  "title.work-doors": "borang kelulusan dan tugasan di kilang ini",
+  "title.work-doors-next": "Apa yang perlu dilakukan",
   "title.worklist dashboard": "papan pemantauan senarai kerja"
-}
+}

package/translations/zh.json

@@ -41,6 +41,8 @@
   "error.approval line names a person who cannot be found": "找不到 {seats} 步骤指定的人员。请重新指定审批人。",
   "error.approval line names a role that nobody holds": "{seats} 步骤指定的角色中没有人员。请为该角色添加人员。",
   "error.not authorized to handle this task": "您无权执行此任务。",
+  "error.work-door-not-used-reason-missing": "请填写不使用此业务的原因。",
+  "error.work-door-unknown": "\"{name}\"是未知的业务。请使用状况画面中的业务名称。",
   "field.activity-type": "业务类型",
   "field.approval-changed-at": "最近变更",
   "field.approval-drafter": "起草人",
@@ -202,6 +204,7 @@
   "label.what-changes": "批准后将发生的变化",
   "label.what-it-was-judged-from": "判断依据",
   "label.yes": "是",
+  "menu.work-doors": "审批与分配表单状态",
   "text.activity-activated": "已在此域中启用 {name}。",
   "text.activity-change-failed": "无法更改 {name}：{why}",
   "text.activity-change-not-allowed": "您无权更改 {name}。请向管理员申请业务活动权限。",
@@ -228,6 +231,8 @@
   "text.copy-failed": "无法复制",
   "text.copy-payload": "以原始 JSON 复制此值",
   "text.decision-keys-count": "判断项 {n} 个",
+  "text.door-filled-from": "在 {name} 中设定",
+  "text.door-form-from": "{name} 的表单 — 此处无法修改",
   "text.draft": "草稿",
   "text.due-just-passed": "刚刚超期",
   "text.due-left-in": "剩余{span}",
@@ -283,6 +288,10 @@
   "text.task_is_saved_successfully": "任务已成功保存。",
   "text.task_is_started_successfully": "任务已成功开始。",
   "text.timeline-count": "{count}条",
+  "text.work-doors-lead": "显示每个审批与分配环节是否已指定审批人和接收人。未指定时，审批在提交时即完成，分配不会送达任何人。",
+  "text.work-doors-next-line": "请为 {count} 个业务表单指定审批线 —",
+  "text.work-doors-next-seats": "{offered} 个角色中已设置 {standing} 个。请先设置用于审批线的角色 —",
+  "text.work-doors-read-failed": "无法读取审批表单状态。",
   "text.write-your-comment-as-reference": "请填写您的意见。",
   "title.activity": "业务",
   "title.activity application": "业务申请",
@@ -324,5 +333,7 @@
   "title.my workspace": "我的工作空间",
   "title.pick activity": "选择要负责的任务",
   "title.todo list": "待办",
+  "title.work-doors": "本工厂的审批与分配表单",
+  "title.work-doors-next": "接下来要做的",
   "title.worklist dashboard": "工作清单仪表板"
-}
+}