@things-factory/shell 10.1.106 → 10.1.122

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@things-factory/shell",
-  "version": "10.1.106",
+  "version": "10.1.122",
   "description": "Core module for framework",
   "bin": {
     "things-factory": "bin/things-factory",
@@ -56,7 +56,7 @@
     "@things-factory/ejs-remote": "^10.1.20",
     "@things-factory/env": "^10.1.20",
     "@things-factory/operato-license-checker": "^4.0.4",
-    "@things-factory/styles": "^10.1.20",
+    "@things-factory/styles": "^10.1.122",
     "@things-factory/utils": "^10.1.20",
     "@types/koa": "^3.0.1",
     "@types/koa-bodyparser": "^4.3.13",
@@ -126,5 +126,5 @@
     "pg": "^8.7.3",
     "sqlite3": "^5.0.8"
   },
-  "gitHead": "8d78c14708420773ec32d18b8dd44c300771c44d"
+  "gitHead": "a66715e94ef6064cade05229de57d0fe5798d1fb"
 }

package/tests/styles-sources-load.test.ts

@@ -0,0 +1,75 @@
+import { spawnSync } from 'child_process'
+import { readdirSync, readFileSync, statSync } from 'fs'
+import path from 'path'
+import ts from 'typescript'
+
+/*
+ * @things-factory/styles is published as source: no build, no compiler. A backtick in a comment inside a
+ * css`` template ends the template early, and nothing catches it until an app bundles the file -
+ * 10.1.121 shipped that way (surface-styles.js, a path written in backticks in a comment), and every
+ * app that loads the package failed to bundle (2026-10-05, ADR-0117).
+ *
+ * Each style file is loaded by node on its own. index.js is left out: it imports without extensions,
+ * which the bundler resolves and node does not.
+ */
+const SRC = path.resolve(__dirname, '../../styles/src')
+
+const styleFiles = () => readdirSync(SRC).filter(name => name.endsWith('.js') && name !== 'index.js')
+
+describe('@things-factory/styles sources', () => {
+  it('has style files to load - an empty list would make the check below pass on nothing', () => {
+    expect(styleFiles().length).toBeGreaterThan(3)
+  })
+
+  it.each(styleFiles())('%s loads as a module', name => {
+    const file = path.join(SRC, name)
+    const run = spawnSync(process.execPath, ['--input-type=module', '-e', `await import(${JSON.stringify(file)})`], {
+      cwd: SRC,
+      encoding: 'utf8'
+    })
+    expect(run.stderr.split('\n').filter(line => /Error|Unexpected/.test(line))).toEqual([])
+    expect(run.status).toBe(0)
+  })
+})
+
+/*
+ * The same hole elsewhere (counted 2026-10-05): files that go out with no compiler reading them before
+ * publish - component-ui has no build script at all (its .ts is compiled only inside each app's bundle),
+ * and two .js entries that the packages' tsc does not read. They are parsed here for syntax; a template
+ * cut short by a backtick is a syntax error to the parser.
+ */
+const PACKAGES = path.resolve(__dirname, '../..')
+
+function filesUnder(dir: string): string[] {
+  const out: string[] = []
+  for (const name of readdirSync(dir)) {
+    if (name === 'node_modules' || name.startsWith('dist')) continue
+    const full = path.join(dir, name)
+    if (statSync(full).isDirectory()) out.push(...filesUnder(full))
+    else if (/\.(ts|js)$/.test(name) && !name.endsWith('.d.ts')) out.push(full)
+  }
+  return out
+}
+
+const UNCOMPILED = [
+  ...filesUnder(path.join(PACKAGES, 'component-ui/client')),
+  path.join(PACKAGES, 'board-service/client/entries/headless-scene-components.js'),
+  path.join(PACKAGES, 'shell/client/entries/public/home.js')
+]
+
+describe('client files no compiler reads before publish', () => {
+  it('found the files - an empty list would pass on nothing', () => {
+    expect(UNCOMPILED.length).toBeGreaterThan(5)
+  })
+
+  it.each(UNCOMPILED.map(file => path.relative(PACKAGES, file)))('%s parses', relative => {
+    const file = path.join(PACKAGES, relative)
+    const result = ts.transpileModule(readFileSync(file, 'utf8'), {
+      fileName: file,
+      reportDiagnostics: true,
+      compilerOptions: { target: ts.ScriptTarget.ES2022, module: ts.ModuleKind.ESNext, experimentalDecorators: true, allowJs: true }
+    })
+    const syntax = (result.diagnostics ?? []).map(d => ts.flattenDiagnosticMessageText(d.messageText, '\n'))
+    expect(syntax).toEqual([])
+  })
+})