@things-factory/sales-base 4.3.108 → 4.3.109

package/server/service/others/other-types.ts

@@ -1,5 +1,5 @@
 import { Field, Float, Int, ObjectType } from 'type-graphql'
-import { Product, ProductDetail } from '@things-factory/product-base'
+import { Product } from '@things-factory/product-base'
 import { ScalarDate } from '@things-factory/shell'
 
 @ObjectType()
@@ -19,9 +19,6 @@ export class InventoryProductGroup {
   @Field({ nullable: true })
   productId: string
 
-  @Field({ nullable: true })
-  productDetailId: string
-
   @Field({ nullable: true })
   batchId: string
 
@@ -105,7 +102,4 @@ export class InventoryProductGroup {
 
   @Field(type => Product, { nullable: true })
   product: Product
-
-  @Field(type => ProductDetail, { nullable: true })
-  productDetail: ProductDetail
 }

package/server/service/purchase-order/purchase-order-mutation.ts

@@ -69,14 +69,7 @@ export class PurchaseOrderMutation {
 
     const findPurchaseOrder: PurchaseOrder = await getRepository(PurchaseOrder).findOne({
       where: { domain, id },
-      relations: [
-        'orderProducts',
-        'orderProducts.product',
-        'orderProducts.productDetail',
-        'bufferLocation',
-        'bizplace',
-        'domain'
-      ]
+      relations: ['orderProducts', 'orderProducts.product', 'bufferLocation', 'bizplace', 'domain']
     })
 
     // const findPurchaseOrder: PurchaseOrder = await tx.getRepository(PurchaseOrder).findOne({id}, { relations:['bizplace']})
@@ -425,7 +418,6 @@ export async function upsertPurchaseOrderProducts(
     const bizplaceRepo: Repository<Product> = tx?.getRepository(Bizplace) || getRepository(Bizplace)
     const orderProductRepo: Repository<OrderProduct> = tx?.getRepository(OrderProduct) || getRepository(OrderProduct)
     const productRepo: Repository<Product> = tx?.getRepository(Product) || getRepository(Product)
-    const productDetailRepo: Repository<Product> = tx?.getRepository(ProductDetail) || getRepository(ProductDetail)
 
     // // Remove all existing order products that do not exist in current input
     let removeOP = purchaseOrder.orderProducts.filter(
@@ -451,7 +443,6 @@ export async function upsertPurchaseOrderProducts(
           bizplace: bizplace,
           name: op?.id ? op.name : OrderNoGenerator.orderProduct(),
           product: await productRepo.findOne(op.product.id),
-          productDetail: await productDetailRepo.findOne(op.productDetail.id),
           packingSize: foundProductDetail?.packingSize || 1,
           purchaseOrder: purchaseOrder,
           status: purchaseOrder.status,

package/server/service/purchase-order/purchase-order-query.ts

@@ -62,7 +62,6 @@ export async function getPurchaseOrderFunction(_: any, name: any, context: any,
       'supplier',
       'orderProducts',
       'orderProducts.product',
-      'orderProducts.productDetail',
       'otherCharges',
       'bufferLocation',
       'bizplace',

package/server/service/release-good/release-good-mutation.ts

@@ -17,7 +17,7 @@ import { MarketplaceStore } from '@things-factory/integration-marketplace'
 import { Sellercraft, SellercraftStatus } from '@things-factory/integration-sellercraft'
 import { MarketplaceOrder, MarketplaceProductVariation } from '@things-factory/marketplace-base'
 // import { sendNotification } from '@things-factory/notification'
-import { Product, ProductBundleSetting, ProductDetail } from '@things-factory/product-base'
+import { Product, ProductBundleSetting } from '@things-factory/product-base'
 import { PartnerSetting, Setting } from '@things-factory/setting-base'
 import { Domain } from '@things-factory/shell'
 import { Inventory } from '@things-factory/warehouse-base'
@@ -676,7 +676,7 @@ export async function generateReleaseGoodFunction(
 
           const pbSettings: ProductBundleSetting[] = await tx.getRepository(ProductBundleSetting).find({
             where: { productBundle: oi.product.id },
-            relations: ['product', 'productBundle', 'productDetail']
+            relations: ['product', 'productBundle']
           })
 
           pbSettings.forEach(pbs => {
@@ -690,9 +690,6 @@ export async function generateReleaseGoodFunction(
                 id: pbs.product.id,
                 name: pbs.product.name,
                 groupType: PRODUCT_GROUP_TYPE.SINGLE
-              },
-              productDetail: {
-                id: pbs.productDetail.id
               }
             }
             splitBundleOIs.push(splitOI)
@@ -707,10 +704,6 @@ export async function generateReleaseGoodFunction(
     newReleaseGood = await tx.getRepository(ReleaseGood).save(newReleaseGood)
 
     for (let oi of orderInventories) {
-      let productDetail: any = await tx
-        .getRepository(ProductDetail)
-        .findOne(oi.productDetail.id, { relations: ['product'] })
-
       let newOrderInv: OrderInventory = Object.assign({}, oi)
       newOrderInv = {
         ...newOrderInv,
@@ -719,8 +712,7 @@ export async function generateReleaseGoodFunction(
         status: ORDER_INVENTORY_STATUS.PENDING,
         name: OrderNoGenerator.orderInventory(),
         releaseGood: newReleaseGood,
-        product: productDetail.product,
-        productDetail,
+        product: await tx.getRepository(Product).findOne(oi.product.id),
         creator: user,
         updater: user
       }
@@ -758,9 +750,9 @@ export async function generateReleaseGoodFunction(
         }
 
         let assignedOrderInventories: OrderInventory[] = await InventoryUtil.autoAssignInventoryForRelease(
+          newOrderInv.product,
           oi,
-          productDetail.product,
-          productDetail,
+          oi.packingType,
           locationSortingRules,
           bizplace,
           warehouseDomain,
@@ -1387,17 +1379,12 @@ export async function bulkGenerateReleaseGood(
         }
       }
 
-      let productDetail = oi.orderProduct?.productDetail
-      let product = oi.orderProduct?.product
-      if (!productDetail) {
-        productDetail = await tx.getRepository(ProductDetail).findOne(oi.productDetailId, { relations: ['product'] })
-        product = productDetail.product
-      }
+      const product: Product = await tx.getRepository(Product).findOne(oi.productId)
 
       let assignedResult = await InventoryUtil.autoAssignInventoryForRelease(
-        oi,
         product,
-        productDetail,
+        oi,
+        oi.packingType,
         locationSortingRules,
         bizplace,
         warehouseDomain,

package/server/service/release-good/release-good-query.ts

@@ -133,6 +133,7 @@ export class ReleaseGoodQuery {
           'orderInventories.product',
           'orderInventories.inventory',
           'orderInventories.inventory.product',
+          'orderInventories.inventory.product.productDetails',
           'orderVass',
           'orderVass.vas',
           'creator',
@@ -196,7 +197,6 @@ export class ReleaseGoodQuery {
           .createQueryBuilder('oi')
           .leftJoinAndSelect('oi.inventory', 'inventory')
           .leftJoinAndSelect('oi.product', 'product')
-          .leftJoinAndSelect('oi.productDetail', 'productDetail')
           .leftJoinAndSelect('inventory.location', 'location')
           .where('oi.domain_id = :domainId', { domainId: domain.id })
           .andWhere('oi.release_good_id = :releaseGoodId', { releaseGoodId: releaseGood.id })
@@ -227,7 +227,6 @@ export class ReleaseGoodQuery {
                 batchIdRef: inventory.batchIdRef,
                 palletId: inventory.palletId,
                 product: orderInv.product,
-                productDetail: orderInv.productDetail,
                 productIdRef: orderInv.product.id,
                 productName: `${orderInv.product.name} (${orderInv.product.description})`,
                 packingType: orderInv.packingType,
@@ -935,7 +934,7 @@ function _extractData(rawData, validatedData) {
       errorMsg:
         !raw.productId || !raw.productDetailId
           ? 'inventory or product not found'
-          : raw.releaseQty <= 0 || raw.releaseQty % 1 != 0
+          : raw.releaseQty <= 0
           ? 'invalid release qty'
           : raw.assignedQty < raw.releaseQty
           ? 'insufficient stock'

package/server/service/release-good/release-good-types.ts

@@ -1,6 +1,6 @@
 import { Field, Float, InputType, Int, ObjectType } from 'type-graphql'
 
-import { Product, ProductDetail } from '@things-factory/product-base'
+import { Product } from '@things-factory/product-base'
 import { ObjectRef } from '@things-factory/shell'
 import { Location } from '@things-factory/warehouse-base'
 
@@ -77,9 +77,6 @@ export class InventoryInfos {
   @Field(type => Product, { nullable: true })
   product?: Product
 
-  @Field(type => ProductDetail, { nullable: true })
-  productDetail?: ProductDetail
-
   @Field({ nullable: true })
   packingType?: string
 
@@ -188,6 +185,8 @@ export class NewReleaseGood {
   @Field({ nullable: true })
   orderMethod: string
 
+
+
   @Field({ nullable: true })
   collectionOrderNo: string
 

package/server/service/return-order/return-order-mutation.ts

@@ -6,7 +6,7 @@ import { Attachment, createAttachments } from '@things-factory/attachment-base'
 import { Role, User } from '@things-factory/auth-base'
 import { Bizplace, getDomainUsers } from '@things-factory/biz-base'
 import { sendNotification } from '@things-factory/notification'
-import { Product, ProductDetail } from '@things-factory/product-base'
+import { Product } from '@things-factory/product-base'
 import { Domain } from '@things-factory/shell'
 import { Inventory } from '@things-factory/warehouse-base'
 
@@ -59,7 +59,6 @@ export class ReturnOrderMutation {
         itm =>
           itm.product.id === curr.product.id &&
           itm.packingType === curr.packingType &&
-          itm.productDetailId === curr.product.productDetailId &&
           itm.batchId === curr.batchId &&
           itm.packingSize === curr.packingSize
       )
@@ -69,7 +68,6 @@ export class ReturnOrderMutation {
       } else {
         existingItem.returnQty = existingItem.returnQty + curr.returnQty
         existingItem.returnUomValue = existingItem.returnUomValue + curr.returnUomValue
-        existingItem.remark = `${existingItem.remark} | ${curr.remark}`
       }
 
       return acc
@@ -101,7 +99,6 @@ export class ReturnOrderMutation {
       newOrderInv.name = OrderNoGenerator.orderInventory()
       newOrderInv.returnOrder = createdReturnOrder
       newOrderInv.product = await tx.getRepository(Product).findOne(moi.product.id)
-      newOrderInv.productDetail = await tx.getRepository(ProductDetail).findOne(moi.productDetail.id)
       newOrderInv.creator = user
       newOrderInv.updater = user
 

package/server/service/return-order/return-order-types.ts

@@ -115,7 +115,6 @@ export class NewReturnOrder {
   @Field({ nullable: true })
   truckNo: string
 
-
   @Field({ nullable: true })
   deliveryOrderNo: string
 

package/server/service/reverse-kitting-order-inventory/reverse-kitting-order-inventory.ts

@@ -12,7 +12,7 @@ import {
 
 import { User } from '@things-factory/auth-base'
 import { Bizplace } from '@things-factory/biz-base'
-import { Product, ProductDetail } from '@things-factory/product-base'
+import { Product } from '@things-factory/product-base'
 import { Domain } from '@things-factory/shell'
 import { Inventory } from '@things-factory/warehouse-base'
 
@@ -127,10 +127,6 @@ export class ReverseKittingOrderInventory {
   @Field({ nullable: true })
   updatedAt?: Date
 
-  @ManyToOne(type => ProductDetail, { nullable: true })
-  @Field({ nullable: true })
-  productDetail: ProductDetail
-
   @ManyToOne(type => User, { nullable: true })
   @Field({ nullable: true })
   creator?: User